146009 2015-06-16 00:01:36 -0700 [iOS] Crash long pressing on <input type=file> 2015-06-16 14:40:36 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 jhoneycutt jhoneycutt commit-queue esprehn+autocc kangil.han rniwa oldest_to_newest 1102189 0 jhoneycutt 2015-06-16 00:01:36 -0700 The web process crashes when trying to long press on an <input type=file> control. <rdar://problem/21234453> 1102190 1 254941 jhoneycutt 2015-06-16 00:07:01 -0700 Created attachment 254941 Patch 1102206 2 254941 rniwa 2015-06-16 02:10:32 -0700 Comment on attachment 254941 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254941&action=review > Source/WebCore/ChangeLog:5 > + > + <https://bugs.webkit.org/show_bug.cgi?id=146009> We don't usually place a blank line between the bug title and the bugzilla URL. Also, we don't normally warp a bugzilla URL with < & > unlike a rdar URL. > ChangeLog:5 > + > + <https://bugs.webkit.org/show_bug.cgi?id=146009> Ditto. > ChangeLog:10 > + * ManualTests/ios/long-press-input-type-file-crash.html: Added. It's sad we can't automate this :( > ManualTests/ios/long-press-input-type-file-crash.html:1 > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> Why don't we use <!DOCTYPE html> instead? 1102271 3 254941 darin 2015-06-16 10:50:05 -0700 Comment on attachment 254941 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254941&action=review > Source/WebCore/ChangeLog:13 > + * dom/Position.cpp: > + (WebCore::Position::atStartOfTree): > + (WebCore::Position::atEndOfTree): > + Null check the container node before passing it to findParent(). If findParent doesn’t work on null, it should take a reference rather than a pointer. Or we could put the check for null inside findParent. 1102348 4 jhoneycutt 2015-06-16 14:34:05 -0700 (In reply to comment #2) > Comment on attachment 254941 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254941&action=review > > > Source/WebCore/ChangeLog:5 > > + > > + <https://bugs.webkit.org/show_bug.cgi?id=146009> > > We don't usually place a blank line between the bug title and the bugzilla > URL. > Also, we don't normally warp a bugzilla URL with < & > unlike a rdar URL. > > > ChangeLog:5 > > + > > + <https://bugs.webkit.org/show_bug.cgi?id=146009> > > Ditto. Fixed. > > > ChangeLog:10 > > + * ManualTests/ios/long-press-input-type-file-crash.html: Added. > > It's sad we can't automate this :( > > > ManualTests/ios/long-press-input-type-file-crash.html:1 > > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> > > Why don't we use <!DOCTYPE html> instead? Fixed. Thanks for the review! 1102349 5 jhoneycutt 2015-06-16 14:35:18 -0700 (In reply to comment #3) > Comment on attachment 254941 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254941&action=review > > > Source/WebCore/ChangeLog:13 > > + * dom/Position.cpp: > > + (WebCore::Position::atStartOfTree): > > + (WebCore::Position::atEndOfTree): > > + Null check the container node before passing it to findParent(). > > If findParent doesn’t work on null, it should take a reference rather than a > pointer. Or we could put the check for null inside findParent. I’m going to land this as-is and make a follow-up patch that does one of the two. 1102350 6 jhoneycutt 2015-06-16 14:40:36 -0700 Committed r185613: <http://trac.webkit.org/changeset/185613> 254941 2015-06-16 00:07:01 -0700 2015-06-16 02:10:32 -0700 Patch bug-146009-20150616000626.patch text/plain 3930 jhoneycutt U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQ2NmYzZWMyYzk0OTIx YTYxN2Y5NTQzZjZmZmNlODIzZGU2MDNmMS4uY2JiZDZhMzMxMDJlMzUyMDA0NzcxMGZkMGY5MjI3 Mzk5NzdlYjk5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA2LTE1ICBKb24g SG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQ3Jhc2gg bG9uZyBwcmVzc2luZyBvbiA8aW5wdXQgdHlwZT1maWxlPgorCisgICAgICAgIDxodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MDA5PgorICAgICAgICA8cmRhcjovL3By b2JsZW0vMjEyMzQ0NTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBkb20vUG9zaXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9zaXRpb246 OmF0U3RhcnRPZlRyZWUpOgorICAgICAgICAoV2ViQ29yZTo6UG9zaXRpb246OmF0RW5kT2ZUcmVl KToKKyAgICAgICAgTnVsbCBjaGVjayB0aGUgY29udGFpbmVyIG5vZGUgYmVmb3JlIHBhc3Npbmcg aXQgdG8gZmluZFBhcmVudCgpLgorCiAyMDE1LTA2LTE1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFw cGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTgyMjE1KTogUmVwcm9kdWNpYmxlIGNy YXNoIGF0IGRyYXdzdmcub3JnIGR1ZSB0byByZWVudHJhbnQgbGF5b3V0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1Bvc2l0 aW9uLmNwcAppbmRleCBkMmIxMTA1ZTExYmJhZjU5MzZlMzEwOTZjNWVlMDY3ZDY4MzBhZDliLi5l ZDllMjQ4MGE2ZjM3MWYxNzE3NWI4NGM3YjQ2Y2NhYzRlMDlhOTBhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3Np dGlvbi5jcHAKQEAgLTQ3Niw3ICs0NzYsOSBAQCBib29sIFBvc2l0aW9uOjphdFN0YXJ0T2ZUcmVl KCkgY29uc3QKIHsKICAgICBpZiAoaXNOdWxsKCkpCiAgICAgICAgIHJldHVybiB0cnVlOwotICAg IGlmIChmaW5kUGFyZW50KGNvbnRhaW5lck5vZGUoKSkpCisKKyAgICBOb2RlKiBjb250YWluZXIg PSBjb250YWluZXJOb2RlKCk7CisgICAgaWYgKGNvbnRhaW5lciAmJiBmaW5kUGFyZW50KGNvbnRh aW5lcikpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIHN3aXRjaCAobV9hbmNob3JUeXBl KSB7CkBAIC00OTksNyArNTAxLDkgQEAgYm9vbCBQb3NpdGlvbjo6YXRFbmRPZlRyZWUoKSBjb25z dAogewogICAgIGlmIChpc051bGwoKSkKICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgaWYgKGZp bmRQYXJlbnQoY29udGFpbmVyTm9kZSgpKSkKKworICAgIE5vZGUqIGNvbnRhaW5lciA9IGNvbnRh aW5lck5vZGUoKTsKKyAgICBpZiAoY29udGFpbmVyICYmIGZpbmRQYXJlbnQoY29udGFpbmVyKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgc3dpdGNoIChtX2FuY2hvclR5cGUpIHsKZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1YTJjYWFjYzA2MjYzN2M0NjAz ZDQ3MTFlNDZlODU1OTBkYTQxMjhiLi4wOTE2YzVjNzIxODg2MGJkNmExYjQwMWQwMzdkMmZhOGRj YTgxNWMyIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTQgQEAKKzIwMTUtMDYtMTUgIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K KworICAgICAgICBbaU9TXSBDcmFzaCBsb25nIHByZXNzaW5nIG9uIDxpbnB1dCB0eXBlPWZpbGU+ CisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYw MDk+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMTIzNDQ1Mz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1hbnVhbFRlc3RzL2lvcy9sb25nLXBy ZXNzLWlucHV0LXR5cGUtZmlsZS1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxNS0wNi0xMiAgR3l1 eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gQnVt cCBFV2ViS2l0IHZlcnNpb24gZnJvbSAxLjExLjAgdG8gMS4xNC4wCmRpZmYgLS1naXQgYS9NYW51 YWxUZXN0cy9pb3MvbG9uZy1wcmVzcy1pbnB1dC10eXBlLWZpbGUtY3Jhc2guaHRtbCBiL01hbnVh bFRlc3RzL2lvcy9sb25nLXByZXNzLWlucHV0LXR5cGUtZmlsZS1jcmFzaC5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjI1NjQxOGRjYTAwZTgyZTNmMjkzOTZlN2M0MWQ5MjkzNzgzM2Q5MjEKLS0tIC9kZXYvbnVs bAorKysgYi9NYW51YWxUZXN0cy9pb3MvbG9uZy1wcmVzcy1pbnB1dC10eXBlLWZpbGUtY3Jhc2gu aHRtbApAQCAtMCwwICsxLDM3IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RU RCBIVE1MLy9FTiI+Cis8aHRtbD4KKyAgICA8Ym9keSBvbmxvYWQ9InRlc3QoKSI+CisgICAgICAg IDxwPgorICAgICAgICAgICAgVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGEgbG9uZyBwcmVzcyBnZXN0 dXJlIG9uIGFuIGZpbGUgaW5wdXQgYnV0dG9uIGRvZXMgbm90IGNyYXNoIG9uIGlPUy4KKyAgICAg ICAgICAgIFByZXNzIGFuZCBob2xkIG9uIHRoZSBmaWxlIGlucHV0IGJ1dHRvbiBiZWxvdyB1bnRp bCB5b3Ugc2VlIHRoZSB3b3JkICJQQVNTIi4KKyAgICAgICAgPC9wPgorICAgICAgICA8cCBpZD0i cmVzdWx0Ij5UZXN0IG5vdCBydW5uaW5nPC9wPgorICAgICAgICA8cD4KKyAgICAgICAgICAgIDxp bnB1dCB0eXBlPSJmaWxlIiBpZD0iZmlsZWNvbnRyb2wiPgorICAgICAgICA8L3A+CisgICAgICAg IDxzY3JpcHQ+CisgICAgICAgICAgICB2YXIgdGltZXI7CisgICAgICAgICAgICB2YXIgcGFzczsK KyAgICAgICAgICAgIGZ1bmN0aW9uIHNldFRleHQocykKKyAgICAgICAgICAgIHsKKyAgICAgICAg ICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MID0gczsK KyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gdGVzdCgpIHsKKyAgICAgICAg ICAgICAgICB2YXIgaW5wdXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZmlsZWNvbnRyb2wi KTsKKyAgICAgICAgICAgICAgICBpbnB1dC5vbmNsaWNrID0gZnVuY3Rpb24oZSkgeyBlLnByZXZl bnREZWZhdWx0KCk7IH0KKyAgICAgICAgICAgICAgICBpbnB1dC5vbnRvdWNoc3RhcnQgPSBmdW5j dGlvbigpIHsKKyAgICAgICAgICAgICAgICAgICAgc2V0VGV4dCgiV2FpdC4uLiIpOworICAgICAg ICAgICAgICAgICAgICBwYXNzZWQgPSBmYWxzZTsKKyAgICAgICAgICAgICAgICAgICAgdGltZXIg PSB3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsgc2V0VGV4dCgiUEFTUyIpOyBwYXNzZWQg PSB0cnVlOyB9LCAxMDAwKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgaW5w dXQub250b3VjaGVuZCA9IGlucHV0Lm9udG91Y2htb3ZlID0gZnVuY3Rpb24oKSB7CisgICAgICAg ICAgICAgICAgICAgIGlmIChwYXNzZWQpCisgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47 CisgICAgICAgICAgICAgICAgICAgIHNldFRleHQoIlRyeSBhZ2FpbiIpOworICAgICAgICAgICAg ICAgICAgICB3aW5kb3cuY2xlYXJUaW1lb3V0KHRpbWVyKTsKKyAgICAgICAgICAgICAgICB9Cisg ICAgICAgICAgICB9CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvYm9keT4KKzwvaHRtbD4K