146007 2015-06-15 23:16:39 -0700 Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn 2015-06-23 03:46:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tanay.c webkit-unassigned commit-queue darin gyuyoung.kim ossy oldest_to_newest 1102172 0 tanay.c 2015-06-15 23:16:39 -0700 ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:68:108: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] messageLength += vsnprintf(message + messageLength, messageBufferSize - 1 - messageLength, format, args); ^ ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:68:108: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] 1102173 1 254937 tanay.c 2015-06-15 23:20:38 -0700 Created attachment 254937 Patch 1102273 2 254937 darin 2015-06-16 10:51:03 -0700 Comment on attachment 254937 Patch I am pretty sure you could use attribute rather than __attribute__. In macros it makes sense to use the form less likely to conflict, but in code like this it doesn’t seem necessary. 1102275 3 254937 darin 2015-06-16 10:52:12 -0700 Comment on attachment 254937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254937&action=review For best compatibility across platforms would be much better to use WTF_ATTRIBUTE_PRINTF. Please do that. > Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:63 > +void __attribute__((format(printf, 2, 0))) pluginLogWithArguments(NPP instance, const char* format, va_list args) Oops, no this is wrong. Needs to use WTF_ATTRIBUTE_PRINTF 1102483 4 254937 gyuyoung.kim 2015-06-16 22:41:58 -0700 Comment on attachment 254937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254937&action=review > Tools/ChangeLog:3 > + [EFL] Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn I think this patch isn't only for EFL port. Please remove [EFL] prefix or add other ports too. 1102499 5 tanay.c 2015-06-16 23:54:32 -0700 I am getting compilation errors if this macro is used. It seems like the 'WTF_ATTRIBUTE_PRINTF' macro is not available in this directory. This is conditionally compiled for ENABLE_X11_TARGET flag. if (ENABLE_X11_TARGET) add_subdirectory(DumpRenderTree/TestNetscapePlugIn) Please advice. 1102594 6 darin 2015-06-17 11:00:08 -0700 (In reply to comment #5) > I am getting compilation errors if this macro is used. > > It seems like the 'WTF_ATTRIBUTE_PRINTF' macro is not available in this > directory. I don’t think it’s the directory, but rather the includes. You’ll have to include an appropriate WTF header file to use WTF_ATTRIBUTE_PRINTF. It doesn’t compile because it’s not including the header file. I think it’s <wtf/Assertions.h>. > This is conditionally compiled for ENABLE_X11_TARGET flag. > if (ENABLE_X11_TARGET) > add_subdirectory(DumpRenderTree/TestNetscapePlugIn) That’s in the make file used for the EFL port. This same plug-in is built, just built with other build systems, for other ports that don’t necessarily share that make file. 1102879 7 tanay.c 2015-06-18 04:41:34 -0700 After including the <wtf/Assertions.h> header and I get the following error ../../Source/WTF/wtf/Assertions.h:130:1: error: ‘WTF_EXPORT_PRIVATE’ does not name a type 1103196 8 tanay.c 2015-06-19 00:02:51 -0700 Are there some additional dependencies that I am missing? I have tried linking with the WTF library but it does not resolve. 1103219 9 ossy 2015-06-19 02:15:53 -0700 (In reply to comment #8) > Are there some additional dependencies that I am missing? > I have tried linking with the WTF library but it does not resolve. Assertions.h needs WTF_EXPORT_PRIVATE, which is defined in wtf/ExportMacros.h. And wtf/ExportMacros.h needs OS/USE/COMPILER macros which are defined in Platform.h. Adding these includes in exactly this order + adding WTF to include path in cmake build system solves this issue ... But it is very ugly and style checker will warn because of unordered includes ... #include <wtf/Platform.h> #include <wtf/ExportMacros.h> #include <wtf/Assertions.h> 1103229 10 255187 tanay.c 2015-06-19 05:04:25 -0700 Created attachment 255187 Patch 1103230 11 tanay.c 2015-06-19 05:05:36 -0700 Thanks for the clarifications. Uploaded a patch with the changes. 1103294 12 darin 2015-06-19 10:51:22 -0700 I’m surprised that Assertions.h does not itself include those other headers. I think maybe it’s because we expect those other headers to be included universally as part of config.h or precompiled headers. 1103775 13 255187 commit-queue 2015-06-22 00:26:13 -0700 Comment on attachment 255187 Patch Rejecting attachment 255187 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 255187, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: zz 3. patching file Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt Hunk #1 FAILED at 33. 1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt.rej patching file Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp patching file Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/4736415837454336 1103809 14 255342 tanay.c 2015-06-22 05:07:34 -0700 Created attachment 255342 Patch 1103812 15 tanay.c 2015-06-22 05:08:48 -0700 Re-based and uploaded the patch. 1104074 16 255342 commit-queue 2015-06-23 03:46:16 -0700 Comment on attachment 255342 Patch Clearing flags on attachment: 255342 Committed r185871: <http://trac.webkit.org/changeset/185871> 1104075 17 commit-queue 2015-06-23 03:46:20 -0700 All reviewed patches have been landed. Closing bug. 254937 2015-06-15 23:20:38 -0700 2015-06-19 05:04:15 -0700 Patch bug-146007-20150616115010.patch text/plain 2423 tanay.c SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTU4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE1LTA2LTE1ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXSBSZW1vdmUgYnVpbGQgd2FybmluZ3MgaW4gVG9vbHMvRHVtcFJlbmRlclRy ZWUvVGVzdE5ldHNjYXBlUGx1Z0luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDYwMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5P YmplY3QuY3BwOiBBZGQgYXR0cmlidXRlIHRvIGZ1bmN0aW9ucy4KKyAgICAgICAgKHBsdWdpbkxv Z1dpdGhXaW5kb3dPYmplY3QpOgorICAgICAgICAocGx1Z2luTG9nV2l0aEFyZ3VtZW50cyk6Cisg ICAgICAgIChwbHVnaW5Mb2cpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2Fw ZVBsdWdJbi9QbHVnaW5UZXN0LmNwcDogQWRkIGF0dHJpYnV0ZSB0byBmdW5jdGlvbnMuCisgICAg ICAgIChQbHVnaW5UZXN0OjpleGVjdXRlU2NyaXB0KToKKyAgICAgICAgKFBsdWdpblRlc3Q6Omxv Zyk6CisKIDIwMTUtMDYtMTUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIHRlc3QgZXhwZWN0YXRpb25zIGZvciBFbCBDYXBpdGFuCkluZGV4OiBUb29s cy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2JqZWN0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2lu T2JqZWN0LmNwcAkocmV2aXNpb24gMTg1NTQ3KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVz dE5ldHNjYXBlUGx1Z0luL1BsdWdpbk9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwLDcg KzYwLDcgQEAgc3RhdGljIHZvaWQgcGx1Z2luTG9nV2l0aFdpbmRvd09iamVjdChOUAogICAgIGJy b3dzZXItPnJlbGVhc2VvYmplY3QoY29uc29sZU9iamVjdCk7CiB9CiAKLXZvaWQgcGx1Z2luTG9n V2l0aEFyZ3VtZW50cyhOUFAgaW5zdGFuY2UsIGNvbnN0IGNoYXIqIGZvcm1hdCwgdmFfbGlzdCBh cmdzKQordm9pZCBfX2F0dHJpYnV0ZV9fKChmb3JtYXQocHJpbnRmLCAyLCAwKSkpIHBsdWdpbkxv Z1dpdGhBcmd1bWVudHMoTlBQIGluc3RhbmNlLCBjb25zdCBjaGFyKiBmb3JtYXQsIHZhX2xpc3Qg YXJncykKIHsKICAgICBjb25zdCBzaXplX3QgbWVzc2FnZUJ1ZmZlclNpemUgPSAyMDQ4OwogICAg IGNoYXIgbWVzc2FnZVttZXNzYWdlQnVmZmVyU2l6ZV0gPSAiUExVR0lOOiAiOwpAQCAtODAsNyAr ODAsNyBAQCB2b2lkIHBsdWdpbkxvZ1dpdGhBcmd1bWVudHMoTlBQIGluc3RhbmNlCiB9CiAKIC8v IEhlbHBlciBmdW5jdGlvbiB0byBsb2cgdG8gdGhlIGNvbnNvbGUgb2JqZWN0Lgotdm9pZCBwbHVn aW5Mb2coTlBQIGluc3RhbmNlLCBjb25zdCBjaGFyKiBmb3JtYXQsIC4uLikKK3ZvaWQgX19hdHRy aWJ1dGVfXygoZm9ybWF0KHByaW50ZiwgMiwgMykpKSBwbHVnaW5Mb2coTlBQIGluc3RhbmNlLCBj b25zdCBjaGFyKiBmb3JtYXQsIC4uLikKIHsKICAgICB2YV9saXN0IGFyZ3M7CiAgICAgdmFfc3Rh cnQoYXJncywgZm9ybWF0KTsKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2Fw ZVBsdWdJbi9QbHVnaW5UZXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJl ZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVzdC5jcHAJKHJldmlzaW9uIDE4NTU0NykKKysr IFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5UZXN0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjU0LDcgKzI1NCw3IEBAIHZvaWQgUGx1Z2luVGVzdDo6ZXhlY3V0 ZVNjcmlwdChjb25zdCBjaGEKICAgICBicm93c2VyLT5yZWxlYXNldmFyaWFudHZhbHVlKCZicm93 c2VyUmVzdWx0KTsKIH0KIAotdm9pZCBQbHVnaW5UZXN0Ojpsb2coY29uc3QgY2hhciogZm9ybWF0 LCAuLi4pCit2b2lkIF9fYXR0cmlidXRlX18oKGZvcm1hdChwcmludGYsIDIsIDMpKSkgUGx1Z2lu VGVzdDo6bG9nKGNvbnN0IGNoYXIqIGZvcm1hdCwgLi4uKQogewogICAgIHZhX2xpc3QgYXJnczsK ICAgICB2YV9zdGFydChhcmdzLCBmb3JtYXQpOwo= 255187 2015-06-19 05:04:25 -0700 2015-06-22 05:07:23 -0700 Patch bug-146007-20150619173353.patch text/plain 3269 tanay.c SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTc0NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE1LTA2LTE5ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKwor ICAgICAgICBSZW1vdmUgYnVpbGQgd2FybmluZ3MgaW4gVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVz dE5ldHNjYXBlUGx1Z0luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDYwMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4 dDoKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2Jq ZWN0LmNwcDogQWRkIGF0dHJpYnV0ZSB0byBmdW5jdGlvbnMuCisgICAgICAgIChwbHVnaW5Mb2dX aXRoV2luZG93T2JqZWN0KToKKyAgICAgICAgKHBsdWdpbkxvZ1dpdGhBcmd1bWVudHMpOgorICAg ICAgICAocGx1Z2luTG9nKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQ bHVnSW4vUGx1Z2luVGVzdC5jcHA6IEFkZCBhdHRyaWJ1dGUgdG8gZnVuY3Rpb25zLgorICAgICAg ICAoUGx1Z2luVGVzdDo6ZXhlY3V0ZVNjcmlwdCk6CisgICAgICAgIChQbHVnaW5UZXN0Ojpsb2cp OgorCiAyMDE1LTA2LTE5ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZC4gQWRkIG15c2VsZiBhcyBhIGNvbW1pdHRlci4KSW5kZXg6IFRv b2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VM aXN0cy50eHQJKHJldmlzaW9uIDE4NTczNykKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3RO ZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMzMsNiArMzMs NyBAQCBzZXQoV2ViS2l0VGVzdE5ldHNjYXBlUGx1Z2luX0lOQ0xVREVfRElSCiAgICAgJHtXRUJL SVRfVEVTVE5FVFNDQVBFUExVR0lOX0RJUn0KICAgICAke1dFQktJVF9URVNUTkVUU0NBUEVQTFVH SU5fRElSfS91bml4L0ZvcndhcmRpbmdIZWFkZXJzCiAgICAgJHtXRUJDT1JFX0RJUn0KKyAgICAk e1dURl9ESVJ9CiAgICAgJHtYMTFfSU5DTFVERV9ESVJ9CiApCiAKSW5kZXg6IFRvb2xzL0R1bXBS ZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5PYmplY3QuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5PYmplY3Qu Y3BwCShyZXZpc2lvbiAxODU3MzcpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2Nh cGVQbHVnSW4vUGx1Z2luT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQsNiArMzQsOSBA QAogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8c3Ry aW5nLmg+CisjaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CisjaW5jbHVkZSA8d3RmL0V4cG9ydE1h Y3Jvcy5oPgorI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAKIC8vIEhlbHBlciBmdW5jdGlv biB3aGljaCB0YWtlcyBpbiB0aGUgcGx1Z2luIHdpbmRvdyBvYmplY3QgZm9yIGxvZ2dpbmcgdG8g dGhlIGNvbnNvbGUgb2JqZWN0Lgogc3RhdGljIHZvaWQgcGx1Z2luTG9nV2l0aFdpbmRvd09iamVj dChOUE9iamVjdCogd2luZG93T2JqZWN0LCBOUFAgaW5zdGFuY2UsIGNvbnN0IGNoYXIqIG1lc3Nh Z2UpCkBAIC02MCw2ICs2Myw3IEBAIHN0YXRpYyB2b2lkIHBsdWdpbkxvZ1dpdGhXaW5kb3dPYmpl Y3QoTlAKICAgICBicm93c2VyLT5yZWxlYXNlb2JqZWN0KGNvbnNvbGVPYmplY3QpOwogfQogCitX VEZfQVRUUklCVVRFX1BSSU5URigyLCAwKQogdm9pZCBwbHVnaW5Mb2dXaXRoQXJndW1lbnRzKE5Q UCBpbnN0YW5jZSwgY29uc3QgY2hhciogZm9ybWF0LCB2YV9saXN0IGFyZ3MpCiB7CiAgICAgY29u c3Qgc2l6ZV90IG1lc3NhZ2VCdWZmZXJTaXplID0gMjA0ODsKQEAgLTgwLDYgKzg0LDcgQEAgdm9p ZCBwbHVnaW5Mb2dXaXRoQXJndW1lbnRzKE5QUCBpbnN0YW5jZQogfQogCiAvLyBIZWxwZXIgZnVu Y3Rpb24gdG8gbG9nIHRvIHRoZSBjb25zb2xlIG9iamVjdC4KK1dURl9BVFRSSUJVVEVfUFJJTlRG KDIsIDMpCiB2b2lkIHBsdWdpbkxvZyhOUFAgaW5zdGFuY2UsIGNvbnN0IGNoYXIqIGZvcm1hdCwg Li4uKQogewogICAgIHZhX2xpc3QgYXJnczsKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rl c3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5UZXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1w UmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVzdC5jcHAJKHJldmlzaW9uIDE4 NTczNykKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5U ZXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsOSBAQAogI2luY2x1ZGUgIlBsdWdp bk9iamVjdC5oIgogI2luY2x1ZGUgPGFzc2VydC5oPgogI2luY2x1ZGUgPHN0cmluZy5oPgorI2lu Y2x1ZGUgPHd0Zi9QbGF0Zm9ybS5oPgorI2luY2x1ZGUgPHd0Zi9FeHBvcnRNYWNyb3MuaD4KKyNp bmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogCiAjaWYgZGVmaW5lZChYUF9VTklYKSB8fCBkZWZp bmVkKEFORFJPSUQpCiAjaW5jbHVkZSA8dW5pc3RkLmg+CkBAIC0yNTQsNiArMjU3LDcgQEAgdm9p ZCBQbHVnaW5UZXN0OjpleGVjdXRlU2NyaXB0KGNvbnN0IGNoYQogICAgIGJyb3dzZXItPnJlbGVh c2V2YXJpYW50dmFsdWUoJmJyb3dzZXJSZXN1bHQpOwogfQogCitXVEZfQVRUUklCVVRFX1BSSU5U RigyLCAzKQogdm9pZCBQbHVnaW5UZXN0Ojpsb2coY29uc3QgY2hhciogZm9ybWF0LCAuLi4pCiB7 CiAgICAgdmFfbGlzdCBhcmdzOwo= 255342 2015-06-22 05:07:34 -0700 2015-06-23 03:46:16 -0700 Patch bug-146007-20150622173657.patch text/plain 3354 tanay.c SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTgyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE1LTA2LTIyICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKwor ICAgICAgICBSZW1vdmUgYnVpbGQgd2FybmluZ3MgaW4gVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVz dE5ldHNjYXBlUGx1Z0luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDYwMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4 dDoKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2Jq ZWN0LmNwcDogQWRkIGF0dHJpYnV0ZSB0byBmdW5jdGlvbnMuCisgICAgICAgIChwbHVnaW5Mb2dX aXRoV2luZG93T2JqZWN0KToKKyAgICAgICAgKHBsdWdpbkxvZ1dpdGhBcmd1bWVudHMpOgorICAg ICAgICAocGx1Z2luTG9nKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQ bHVnSW4vUGx1Z2luVGVzdC5jcHA6IEFkZCBhdHRyaWJ1dGUgdG8gZnVuY3Rpb25zLgorICAgICAg ICAoUGx1Z2luVGVzdDo6ZXhlY3V0ZVNjcmlwdCk6CisgICAgICAgIChQbHVnaW5UZXN0Ojpsb2cp OgorCiAyMDE1LTA2LTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04gKHIxNzI5NzUpOiBuYXZpZ2F0b3IubGFuZ3VhZ2UgdW5hYmxlIHRv IHRlbGwgcmVnaW9uIGZvciBUcmFkaXRpb25hbCBDaGluZXNlIHVzZXJzCkluZGV4OiBUb29scy9E dW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL0NNYWtlTGlzdHMu dHh0CShyZXZpc2lvbiAxODU4MjEpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2Nh cGVQbHVnSW4vQ01ha2VMaXN0cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTMzLDYgKzMzLDcgQEAg c2V0KFdlYktpdFRlc3ROZXRzY2FwZVBsdWdpbl9JTkNMVURFX0RJUgogICAgICR7V0VCS0lUX1RF U1RORVRTQ0FQRVBMVUdJTl9ESVJ9CiAgICAgJHtXRUJLSVRfVEVTVE5FVFNDQVBFUExVR0lOX0RJ Un0vdW5peC9Gb3J3YXJkaW5nSGVhZGVycwogICAgICR7V0VCQ09SRV9ESVJ9CisgICAgJHtXVEZf RElSfQogKQogCiBzZXQoV2ViS2l0VGVzdE5ldHNjYXBlUGx1Z2luX1NZU1RFTV9JTkNMVURFX0RJ UkVDVE9SSUVTCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4v UGx1Z2luT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0 TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2JqZWN0LmNwcAkocmV2aXNpb24gMTg1ODIxKQorKysgVG9v bHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpbk9iamVjdC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM0LDYgKzM0LDkgQEAKICNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1 ZGUgPHN0ZGxpYi5oPgogI2luY2x1ZGUgPHN0cmluZy5oPgorI2luY2x1ZGUgPHd0Zi9QbGF0Zm9y bS5oPgorI2luY2x1ZGUgPHd0Zi9FeHBvcnRNYWNyb3MuaD4KKyNpbmNsdWRlIDx3dGYvQXNzZXJ0 aW9ucy5oPgogCiAvLyBIZWxwZXIgZnVuY3Rpb24gd2hpY2ggdGFrZXMgaW4gdGhlIHBsdWdpbiB3 aW5kb3cgb2JqZWN0IGZvciBsb2dnaW5nIHRvIHRoZSBjb25zb2xlIG9iamVjdC4KIHN0YXRpYyB2 b2lkIHBsdWdpbkxvZ1dpdGhXaW5kb3dPYmplY3QoTlBPYmplY3QqIHdpbmRvd09iamVjdCwgTlBQ IGluc3RhbmNlLCBjb25zdCBjaGFyKiBtZXNzYWdlKQpAQCAtNjAsNiArNjMsNyBAQCBzdGF0aWMg dm9pZCBwbHVnaW5Mb2dXaXRoV2luZG93T2JqZWN0KE5QCiAgICAgYnJvd3Nlci0+cmVsZWFzZW9i amVjdChjb25zb2xlT2JqZWN0KTsKIH0KIAorV1RGX0FUVFJJQlVURV9QUklOVEYoMiwgMCkKIHZv aWQgcGx1Z2luTG9nV2l0aEFyZ3VtZW50cyhOUFAgaW5zdGFuY2UsIGNvbnN0IGNoYXIqIGZvcm1h dCwgdmFfbGlzdCBhcmdzKQogewogICAgIGNvbnN0IHNpemVfdCBtZXNzYWdlQnVmZmVyU2l6ZSA9 IDIwNDg7CkBAIC04MCw2ICs4NCw3IEBAIHZvaWQgcGx1Z2luTG9nV2l0aEFyZ3VtZW50cyhOUFAg aW5zdGFuY2UKIH0KIAogLy8gSGVscGVyIGZ1bmN0aW9uIHRvIGxvZyB0byB0aGUgY29uc29sZSBv YmplY3QuCitXVEZfQVRUUklCVVRFX1BSSU5URigyLCAzKQogdm9pZCBwbHVnaW5Mb2coTlBQIGlu c3RhbmNlLCBjb25zdCBjaGFyKiBmb3JtYXQsIC4uLikKIHsKICAgICB2YV9saXN0IGFyZ3M7Cklu ZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVzdC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0lu L1BsdWdpblRlc3QuY3BwCShyZXZpc2lvbiAxODU4MjEpCisrKyBUb29scy9EdW1wUmVuZGVyVHJl ZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4 LDYgKzI4LDkgQEAKICNpbmNsdWRlICJQbHVnaW5PYmplY3QuaCIKICNpbmNsdWRlIDxhc3NlcnQu aD4KICNpbmNsdWRlIDxzdHJpbmcuaD4KKyNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KKyNpbmNs dWRlIDx3dGYvRXhwb3J0TWFjcm9zLmg+CisjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KIAog I2lmIGRlZmluZWQoWFBfVU5JWCkgfHwgZGVmaW5lZChBTkRST0lEKQogI2luY2x1ZGUgPHVuaXN0 ZC5oPgpAQCAtMjU0LDYgKzI1Nyw3IEBAIHZvaWQgUGx1Z2luVGVzdDo6ZXhlY3V0ZVNjcmlwdChj b25zdCBjaGEKICAgICBicm93c2VyLT5yZWxlYXNldmFyaWFudHZhbHVlKCZicm93c2VyUmVzdWx0 KTsKIH0KIAorV1RGX0FUVFJJQlVURV9QUklOVEYoMiwgMykKIHZvaWQgUGx1Z2luVGVzdDo6bG9n KGNvbnN0IGNoYXIqIGZvcm1hdCwgLi4uKQogewogICAgIHZhX2xpc3QgYXJnczsK