146002 2015-06-15 20:27:05 -0700 FTL boolify() UntypedUse is wrong in the masquerades-as-undefined case 2015-06-16 12:18:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo barraclough basile_clement benjamin ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam webkit-bug-importer oldest_to_newest 1102144 0 fpizlo 2015-06-15 20:27:05 -0700 It makes non-masquerading objects boolify to False instead of True. 1102145 1 254927 fpizlo 2015-06-15 20:29:20 -0700 Created attachment 254927 the patch 1102263 2 254927 darin 2015-06-16 10:41:11 -0700 Comment on attachment 254927 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=254927&action=review > Source/JavaScriptCore/ChangeLog:8 > + * ftl/FTLLowerDFGToLLVM.cpp: Put this in an anonymous namespace. We should have done that all along. It makes it easier to add debug code. Should we be using anonymous namespaces throughout WebKit instead of “static” to make things local to a file? A while back this made debugging harder, which I think is why we didn’t do that at the time. 1102291 3 mark.lam 2015-06-16 11:32:06 -0700 <rdar://problem/21393673> 1102303 4 fpizlo 2015-06-16 12:07:14 -0700 (In reply to comment #2) > Comment on attachment 254927 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254927&action=review > > > Source/JavaScriptCore/ChangeLog:8 > > + * ftl/FTLLowerDFGToLLVM.cpp: Put this in an anonymous namespace. We should have done that all along. It makes it easier to add debug code. > > Should we be using anonymous namespaces throughout WebKit instead of > “static” to make things local to a file? A while back this made debugging > harder, which I think is why we didn’t do that at the time. I didn't know about the debugging issue. Compiler debugging usually involves glorified printf()'s. My preference is to use anonymous namespaces instead of static, because it allows us to create one block in a module that contains all of the module-local stuff - functions, classes, variables, enums, etc. It's very liberating - you can use short names. We've been steadily converting the DFG/FTL to use anonymous namespaces for the module-local classes. Each compiler phase usually involves at least one module-local class. That's really all I'm doing here. 1102307 5 fpizlo 2015-06-16 12:18:35 -0700 Landed in http://trac.webkit.org/changeset/185600 254927 2015-06-15 20:29:20 -0700 2015-06-16 10:41:11 -0700 the patch blah.patch text/plain 3070 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1NTc3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE1LTA2LTE1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIGJvb2xpZnkoKSBVbnR5cGVkVXNlIGlzIHdyb25nIGluIHRoZSBtYXNxdWVyYWRlcy1hcy11 bmRlZmluZWQgY2FzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ2MDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwOiBQdXQgdGhpcyBpbiBhbiBhbm9ueW1v dXMgbmFtZXNwYWNlLiBXZSBzaG91bGQgaGF2ZSBkb25lIHRoYXQgYWxsIGFsb25nLiBJdCBtYWtl cyBpdCBlYXNpZXIgdG8gYWRkIGRlYnVnIGNvZGUuCisgICAgICAgIChKU0M6OkZUTDo6REZHOjpM b3dlckRGR1RvTExWTTo6Ym9vbGlmeSk6IEZpeCB0aGUgYnVnLgorICAgICAgICAqIHRlc3RzL3N0 cmVzcy9sb2dpY2FsLW5vdC1tYXNxdWVyYWRlcy5qczogQWRkZWQuIFRoaXMgdGVzdCBjcmVhdGVz IGEgbWFzcXVlcmFkZXIgc28gdGhhdCB0aGUgd2F0Y2hwb2ludCBpcyBpbnZhbGlkLiBQcmV2aW91 c2x5IHRoaXMgd291bGQgZmFpbCBmb3IgdGhlIG5vcm1hbCBvYmplY3QgY2FzZXMuCisgICAgICAg IChmb28pOgorCiAyMDE1LTA2LTE0ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwu Y29tPgogCiAgICAgICAgIFtFUzZdIEludHJvZHVjZSAlSXRlcmF0b3JQcm90b3R5cGUlIGFuZCBk cm9wIGFsbCBYWFhJdGVyYXRvckNvbnN0cnVjdG9yCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTg1NTY1KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTYzLDcgKzYzLDkgQEAgbmFtZXNwYWNlIEpTQyB7IG5hbWVzcGFjZSBGVEwgewog CiB1c2luZyBuYW1lc3BhY2UgREZHOwogCi1zdGF0aWMgc3RkOjphdG9taWM8aW50PiBjb21waWxl Q291bnRlcjsKK25hbWVzcGFjZSB7CisKK3N0ZDo6YXRvbWljPGludD4gY29tcGlsZUNvdW50ZXI7 CiAKICNpZiBBU1NFUlRfRElTQUJMRUQKIE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0ggc3RhdGljIHZv aWQgZnRsVW5yZWFjaGFibGUoKQpAQCAtNjMwMSw3ICs2MzAzLDcgQEAgcHJpdmF0ZToKICAgICAg ICAgICAgIGVsc2UgewogICAgICAgICAgICAgICAgIExCYXNpY0Jsb2NrIG1hc3F1ZXJhZGVzQ2Fz ZSA9IEZUTF9ORVdfQkxPQ0sobV9vdXQsICgiQm9vbGlmeSB1bnR5cGVkIG1hc3F1ZXJhZGVzIGNh c2UiKSk7CiAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgcmVzdWx0cy5hcHBlbmQo bV9vdXQuYW5jaG9yKG1fb3V0LmJvb2xlYW5GYWxzZSkpOworICAgICAgICAgICAgICAgIHJlc3Vs dHMuYXBwZW5kKG1fb3V0LmFuY2hvcihtX291dC5ib29sZWFuVHJ1ZSkpOwogICAgICAgICAgICAg ICAgIAogICAgICAgICAgICAgICAgIG1fb3V0LmJyYW5jaCgKICAgICAgICAgICAgICAgICAgICAg bV9vdXQudGVzdElzWmVybzgoCkBAIC04NjYwLDYgKzg2NjIsOCBAQCBwcml2YXRlOgogICAgIHVu c2lnbmVkIG1fdGJhYVN0cnVjdEtpbmQ7CiB9OwogCit9IC8vIGFub255bW91cyBuYW1lc3BhY2UK Kwogdm9pZCBsb3dlckRGR1RvTExWTShTdGF0ZSYgc3RhdGUpCiB7CiAgICAgTG93ZXJERkdUb0xM Vk0gbG93ZXJpbmcoc3RhdGUpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0 cmVzcy9sb2dpY2FsLW5vdC1tYXNxdWVyYWRlcy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2xvZ2ljYWwtbm90LW1hc3F1ZXJhZGVzLmpzCShyZXZp c2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9sb2dpY2FsLW5v dC1tYXNxdWVyYWRlcy5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDMzIEBACitmdW5jdGlv biBmb28odmFsdWUpIHsKKyAgICByZXR1cm4gISF2YWx1ZTsKK30KKworbm9JbmxpbmUoZm9vKTsK KwordmFyIHRlc3RzID0gWworICAgIFswLCBmYWxzZV0sCisgICAgWzEsIHRydWVdLAorICAgIFsw LzAsIGZhbHNlXSwKKyAgICBbMC8tMSwgZmFsc2VdLAorICAgIFswLjAsIGZhbHNlXSwKKyAgICBb IiIsIGZhbHNlXSwKKyAgICBbImYiLCB0cnVlXSwKKyAgICBbImhlbGxvIiwgdHJ1ZV0sCisgICAg W3t9LCB0cnVlXSwKKyAgICBbW10sIHRydWVdLAorICAgIFtudWxsLCBmYWxzZV0sCisgICAgW3Zv aWQgMCwgZmFsc2VdLAorICAgIFtmYWxzZSwgZmFsc2VdLAorICAgIFt0cnVlLCB0cnVlXSwKKyAg ICBbbWFrZU1hc3F1ZXJhZGVyKCksIGZhbHNlXQorXTsKKworZm9yICh2YXIgaSA9IDA7IGkgPCAx MDAwMDsgKytpKSB7CisgICAgZm9yICh2YXIgaiA9IDA7IGogPCB0ZXN0cy5sZW5ndGg7ICsraikg eworICAgICAgICB2YXIgaW5wdXQgPSB0ZXN0c1tqXVswXTsKKyAgICAgICAgdmFyIGV4cGVjdGVk ID0gdGVzdHNbal1bMV07CisgICAgICAgIHZhciByZXN1bHQgPSBmb28oaW5wdXQpOworICAgICAg ICBpZiAocmVzdWx0ICE9PSBleHBlY3RlZCkKKyAgICAgICAgICAgIHRocm93ICJFcnJvcjogYmFk IHJlc3VsdCBmb3IgIiArIGlucHV0ICsgIjogIiArIHJlc3VsdDsKKyAgICB9Cit9Cg==