145977 2015-06-15 09:53:19 -0700 [WK2] BrowsingContextController.loadData API is leaking Navigation objects 2015-06-15 12:29:51 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=145948 InRadar P2 Normal --- 1 cdumez cdumez andersca barraclough commit-queue darin kling sam oldest_to_newest 1101944 0 cdumez 2015-06-15 09:53:19 -0700 BrowsingContextController.loadData API is leaking Navigation objects. The issue seems to be that WebPageProxy::loadData() creates a Navigation object but does not pass the navigationID to the WebProcess when sending the essages::WebPage::LoadData IPC. As a result, the WebProcess is using 0 as navigationID and we end up creating a new Navigation object later on for the same navigation. Radar: <rdar://problem/21305706> 1101978 1 254885 cdumez 2015-06-15 11:25:17 -0700 Created attachment 254885 Patch 1102001 2 254885 commit-queue 2015-06-15 12:29:45 -0700 Comment on attachment 254885 Patch Clearing flags on attachment: 254885 Committed r185563: <http://trac.webkit.org/changeset/185563> 1102002 3 commit-queue 2015-06-15 12:29:51 -0700 All reviewed patches have been landed. Closing bug. 254885 2015-06-15 11:25:17 -0700 2015-06-15 12:29:45 -0700 Patch bug-145977-20150615112443.patch text/plain 6052 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzQ2ZTM0YjZiMmYzZDJi ZDUzZDY3YmIzNjFlMjEyMTBhODdkMjE2MS4uM2Y3MzE3YWJhYzc4YmZkNjhiZWY5ODc0MzI0N2Ey N2M3ZTM5ZTNjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA2LTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gQnJvd3NpbmdDb250 ZXh0Q29udHJvbGxlci5sb2FkRGF0YSBBUEkgaXMgbGVha2luZyBOYXZpZ2F0aW9uIG9iamVjdHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTk3Nwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjEzMDU3MDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlci5sb2Fk RGF0YSBBUEkgd2FzIGxlYWtpbmcgTmF2aWdhdGlvbiBvYmplY3RzLgorICAgICAgICBUaGUgaXNz dWUgd2FzIGR1ZSB0byBXZWJQYWdlUHJveHk6OmxvYWREYXRhKCkgY3JlYXRpbmcgYSBOYXZpZ2F0 aW9uCisgICAgICAgIG9iamVjdCBidXQgbm90IHBhc3NpbmcgYWxvbmcgdGhlIG5hdmlnYXRpb25J RCB0byB0aGUgV2ViUHJvY2VzcyB3aGVuCisgICAgICAgIHNlbmRpbmcgdGhlIE1lc3NhZ2VzOjpX ZWJQYWdlOjpMb2FkRGF0YSBJUEMuIEFzIGEgcmVzdWx0LCB0aGUKKyAgICAgICAgV2ViUHJvY2Vz cyB3b3VsZCB1c2UgMCBhcyBuYXZpZ2F0aW9uSUQgYW5kIHdlIHdvdWxkIGVuZCB1cCBjcmVhdGlu ZyBhCisgICAgICAgIG5ldyBOYXZpZ2F0aW9uIG9iamVjdCBsYXRlciBvbiBmb3IgdGhlIHNhbWUg bmF2aWdhdGlvbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmxvYWREYXRhKToKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmxvYWRE YXRhKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oOgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluOgorCiAyMDE1LTA2LTE1ICBI eXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgogCiAgICAgICAgIFtF RkxdIE1ha2Ugc2VuZC9yZWNlaXZlIG1lc3NhZ2VzIHRvIGNvbW11bmljYXRlIHRoZSBXZWIgYW5k IFVJIFByb2Nlc3NlcyB1c2luZyBJbmplY3RlZCBCdW5kbGUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDIzMjY0MmI4Yjc0MWZhYjc2ZmIyMzZlNWRmZjYz YmVmNzViYjQ2ODguLjM5ZTlkOWU1OGY2NjhkMjk5YmQwODY5MTQxYzM2MGQzNjdiNTU2OWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC05MTgsNyArOTE4 LDcgQEAgUmVmUHRyPEFQSTo6TmF2aWdhdGlvbj4gV2ViUGFnZVByb3h5Ojpsb2FkRGF0YShBUEk6 OkRhdGEqIGRhdGEsIGNvbnN0IFN0cmluZyYgTUkKICAgICAgICAgcmVhdHRhY2hUb1dlYlByb2Nl c3MoKTsKIAogICAgIG1fcHJvY2Vzcy0+YXNzdW1lUmVhZEFjY2Vzc1RvQmFzZVVSTChiYXNlVVJM KTsKLSAgICBtX3Byb2Nlc3MtPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OkxvYWREYXRhKGRhdGEt PmRhdGFSZWZlcmVuY2UoKSwgTUlNRVR5cGUsIGVuY29kaW5nLCBiYXNlVVJMLCBVc2VyRGF0YShw cm9jZXNzKCkudHJhbnNmb3JtT2JqZWN0c1RvSGFuZGxlcyh1c2VyRGF0YSkuZ2V0KCkpKSwgbV9w YWdlSUQpOworICAgIG1fcHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6TG9hZERhdGEo bmF2aWdhdGlvbi0+bmF2aWdhdGlvbklEKCksIGRhdGEtPmRhdGFSZWZlcmVuY2UoKSwgTUlNRVR5 cGUsIGVuY29kaW5nLCBiYXNlVVJMLCBVc2VyRGF0YShwcm9jZXNzKCkudHJhbnNmb3JtT2JqZWN0 c1RvSGFuZGxlcyh1c2VyRGF0YSkuZ2V0KCkpKSwgbV9wYWdlSUQpOwogICAgIG1fcHJvY2Vzcy0+ cmVzcG9uc2l2ZW5lc3NUaW1lcigpLT5zdGFydCgpOwogCiAgICAgcmV0dXJuIFdURjo6bW92ZShu YXZpZ2F0aW9uKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcAppbmRleCAzNThlMWMwOGIxZWExYzEwYTg5YjM0NjFiY2JkMzdjYzg5MGZhZWQ0Li5hY2I1 YTIwOWMzZjY5YjcyZmQ2NzQ0N2RjY2Y2MTEzYjg1Y2U4ZjAyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0xMDY3LDExICsxMDY3LDExIEBA IHZvaWQgV2ViUGFnZTo6bG9hZFN0cmluZyh1aW50NjRfdCBuYXZpZ2F0aW9uSUQsIGNvbnN0IFN0 cmluZyYgaHRtbFN0cmluZywgY29uc3QKICAgICB9CiB9CiAKLXZvaWQgV2ViUGFnZTo6bG9hZERh dGEoY29uc3QgSVBDOjpEYXRhUmVmZXJlbmNlJiBkYXRhLCBjb25zdCBTdHJpbmcmIE1JTUVUeXBl LCBjb25zdCBTdHJpbmcmIGVuY29kaW5nTmFtZSwgY29uc3QgU3RyaW5nJiBiYXNlVVJMU3RyaW5n LCBjb25zdCBVc2VyRGF0YSYgdXNlckRhdGEpCit2b2lkIFdlYlBhZ2U6OmxvYWREYXRhKHVpbnQ2 NF90IG5hdmlnYXRpb25JRCwgY29uc3QgSVBDOjpEYXRhUmVmZXJlbmNlJiBkYXRhLCBjb25zdCBT dHJpbmcmIE1JTUVUeXBlLCBjb25zdCBTdHJpbmcmIGVuY29kaW5nTmFtZSwgY29uc3QgU3RyaW5n JiBiYXNlVVJMU3RyaW5nLCBjb25zdCBVc2VyRGF0YSYgdXNlckRhdGEpCiB7CiAgICAgUmVmUHRy PFNoYXJlZEJ1ZmZlcj4gc2hhcmVkQnVmZmVyID0gU2hhcmVkQnVmZmVyOjpjcmVhdGUocmVpbnRl cnByZXRfY2FzdDxjb25zdCBjaGFyKj4oZGF0YS5kYXRhKCkpLCBkYXRhLnNpemUoKSk7CiAgICAg VVJMIGJhc2VVUkwgPSBiYXNlVVJMU3RyaW5nLmlzRW1wdHkoKSA/IGJsYW5rVVJMKCkgOiBVUkwo VVJMKCksIGJhc2VVUkxTdHJpbmcpOwotICAgIGxvYWREYXRhSW1wbCgwLCBzaGFyZWRCdWZmZXIs IE1JTUVUeXBlLCBlbmNvZGluZ05hbWUsIGJhc2VVUkwsIFVSTCgpLCB1c2VyRGF0YSk7CisgICAg bG9hZERhdGFJbXBsKG5hdmlnYXRpb25JRCwgc2hhcmVkQnVmZmVyLCBNSU1FVHlwZSwgZW5jb2Rp bmdOYW1lLCBiYXNlVVJMLCBVUkwoKSwgdXNlckRhdGEpOwogfQogCiB2b2lkIFdlYlBhZ2U6Omxv YWRIVE1MU3RyaW5nKHVpbnQ2NF90IG5hdmlnYXRpb25JRCwgY29uc3QgU3RyaW5nJiBodG1sU3Ry aW5nLCBjb25zdCBTdHJpbmcmIGJhc2VVUkxTdHJpbmcsIGNvbnN0IFVzZXJEYXRhJiB1c2VyRGF0 YSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCmluZGV4IGY5 ZTYxMzY4MGE2YTFkNzZlYWVmNWQwMmQ3ODMyZGQwOTBhMjk1MTguLjNiYTg1MzIwNjQyZjFjZWU1 MzlhNDg5Yjc3NWNlYzA3ODg4YTAwYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuaApAQCAtOTQ5LDcgKzk0OSw3IEBAIHByaXZhdGU6CiAgICAgLy8gQWN0 aW9ucwogICAgIHZvaWQgdHJ5Q2xvc2UoKTsKICAgICB2b2lkIGxvYWRSZXF1ZXN0KHVpbnQ2NF90 IG5hdmlnYXRpb25JRCwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgU2Fu ZGJveEV4dGVuc2lvbjo6SGFuZGxlJiwgdWludDY0X3Qgc2hvdWxkT3BlbkV4dGVybmFsVVJMc1Bv bGljeSwgY29uc3QgVXNlckRhdGEmKTsKLSAgICB2b2lkIGxvYWREYXRhKGNvbnN0IElQQzo6RGF0 YVJlZmVyZW5jZSYsIGNvbnN0IFN0cmluZyYgTUlNRVR5cGUsIGNvbnN0IFN0cmluZyYgZW5jb2Rp bmdOYW1lLCBjb25zdCBTdHJpbmcmIGJhc2VVUkwsIGNvbnN0IFVzZXJEYXRhJik7CisgICAgdm9p ZCBsb2FkRGF0YSh1aW50NjRfdCBuYXZpZ2F0aW9uSUQsIGNvbnN0IElQQzo6RGF0YVJlZmVyZW5j ZSYsIGNvbnN0IFN0cmluZyYgTUlNRVR5cGUsIGNvbnN0IFN0cmluZyYgZW5jb2RpbmdOYW1lLCBj b25zdCBTdHJpbmcmIGJhc2VVUkwsIGNvbnN0IFVzZXJEYXRhJik7CiAgICAgdm9pZCBsb2FkSFRN TFN0cmluZyh1aW50NjRfdCBuYXZpZ2F0aW9uSUQsIGNvbnN0IFN0cmluZyYgaHRtbFN0cmluZywg Y29uc3QgU3RyaW5nJiBiYXNlVVJMLCBjb25zdCBVc2VyRGF0YSYpOwogICAgIHZvaWQgbG9hZEFs dGVybmF0ZUhUTUxTdHJpbmcoY29uc3QgU3RyaW5nJiBodG1sU3RyaW5nLCBjb25zdCBTdHJpbmcm IGJhc2VVUkwsIGNvbnN0IFN0cmluZyYgdW5yZWFjaGFibGVVUkwsIGNvbnN0IFN0cmluZyYgcHJv dmlzaW9uYWxMb2FkRXJyb3JVUkwsIGNvbnN0IFVzZXJEYXRhJik7CiAgICAgdm9pZCBsb2FkUGxh aW5UZXh0U3RyaW5nKGNvbnN0IFN0cmluZyYsIGNvbnN0IFVzZXJEYXRhJik7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbiBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluCmlu ZGV4IDgwODJjMDAxMjBkMTdlNjhkODA2OWU1MDJiMTBkZjZjZjM2ZWU3NjMuLmE3NDllYTRkOTVh ODNiNDE1YjcyMjM5MDIxMGQ2ZmIzNGE0ZWQxNWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluCkBAIC0xMjcsNyArMTI3 LDcgQEAgbWVzc2FnZXMgLT4gV2ViUGFnZSBMZWdhY3lSZWNlaXZlciB7CiAKICAgICBMb2FkVVJM SW5GcmFtZShTdHJpbmcgdXJsLCB1aW50NjRfdCBmcmFtZUlEKQogICAgIExvYWRSZXF1ZXN0KHVp bnQ2NF90IG5hdmlnYXRpb25JRCwgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0IHJlcXVlc3QsIFdl YktpdDo6U2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlIHNhbmRib3hFeHRlbnNpb25IYW5kbGUsIHVp bnQ2NF90IHNob3VsZE9wZW5FeHRlcm5hbFVSTHNQb2xpY3ksIFdlYktpdDo6VXNlckRhdGEgdXNl ckRhdGEpCi0gICAgTG9hZERhdGEoSVBDOjpEYXRhUmVmZXJlbmNlIGRhdGEsIFN0cmluZyBNSU1F VHlwZSwgU3RyaW5nIGVuY29kaW5nLCBTdHJpbmcgYmFzZVVSTCwgV2ViS2l0OjpVc2VyRGF0YSB1 c2VyRGF0YSkKKyAgICBMb2FkRGF0YSh1aW50NjRfdCBuYXZpZ2F0aW9uSUQsIElQQzo6RGF0YVJl ZmVyZW5jZSBkYXRhLCBTdHJpbmcgTUlNRVR5cGUsIFN0cmluZyBlbmNvZGluZywgU3RyaW5nIGJh c2VVUkwsIFdlYktpdDo6VXNlckRhdGEgdXNlckRhdGEpCiAgICAgTG9hZEhUTUxTdHJpbmcodWlu dDY0X3QgbmF2aWdhdGlvbklELCBTdHJpbmcgaHRtbFN0cmluZywgU3RyaW5nIGJhc2VVUkwsIFdl YktpdDo6VXNlckRhdGEgdXNlckRhdGEpCiAgICAgTG9hZEFsdGVybmF0ZUhUTUxTdHJpbmcoU3Ry aW5nIGh0bWxTdHJpbmcsIFN0cmluZyBiYXNlVVJMLCBTdHJpbmcgdW5yZWFjaGFibGVVUkwsIFN0 cmluZyBwcm92aXNpb25hbExvYWRFcnJvclVSTCwgV2ViS2l0OjpVc2VyRGF0YSB1c2VyRGF0YSkK ICAgICBMb2FkUGxhaW5UZXh0U3RyaW5nKFN0cmluZyBzdHJpbmcsIFdlYktpdDo6VXNlckRhdGEg dXNlckRhdGEpCg==