145957 2015-06-13 12:37:26 -0700 [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate 2015-07-06 16:50:02 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca commit-queue sam stefan oldest_to_newest 1101828 0 mitz 2015-06-13 12:37:26 -0700 UIClient::close is currently exposed only view WKUIDelegatePrivate. Expose it via the public WKUIDelegate. 1101831 1 254856 mitz 2015-06-13 14:02:33 -0700 Created attachment 254856 Add -[id <WKUIDelegate> webViewDidClose:] 1101846 2 254856 ap 2015-06-13 21:59:17 -0700 Comment on attachment 254856 Add -[id <WKUIDelegate> webViewDidClose:] View in context: https://bugs.webkit.org/attachment.cgi?id=254856&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:65 > +- (void)webViewDidClose:(WKWebView *)webView; I was told that we always - always! - add availability macros to new APIs. 1101847 3 mitz 2015-06-13 22:02:54 -0700 (In reply to comment #2) > Comment on attachment 254856 [details] > Add -[id <WKUIDelegate> webViewDidClose:] > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254856&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:65 > > +- (void)webViewDidClose:(WKWebView *)webView; > > I was told that we always - always! - add availability macros to new APIs. You were lied to. There have been a couple of exceptions, but we normally don’t add availability macros in protocols. 1101880 4 ap 2015-06-14 22:38:50 -0700 There isn't so much difference between this case and adding another error value to an enum. It would be nice to make decisions on some principle other than who bluffs more convincingly. 1102560 5 mitz 2015-06-17 09:15:43 -0700 While not part of this patch, we are going to formalize the rules and apply them to all API. 1102562 6 254856 commit-queue 2015-06-17 09:18:47 -0700 Comment on attachment 254856 Add -[id <WKUIDelegate> webViewDidClose:] Clearing flags on attachment: 254856 Committed r185653: <http://trac.webkit.org/changeset/185653> 1102563 7 commit-queue 2015-06-17 09:18:53 -0700 All reviewed patches have been landed. Closing bug. 1103624 8 mitz 2015-06-20 08:58:13 -0700 (In reply to comment #5) > While not part of this patch, we are going to formalize the rules and apply > them to all API. Added availability for this delegate method in r185794. 1107282 9 andersca 2015-07-06 16:50:02 -0700 *** Bug 146638 has been marked as a duplicate of this bug. *** 254856 2015-06-13 14:02:33 -0700 2015-06-17 09:18:47 -0700 Add -[id <WKUIDelegate> webViewDidClose:] bug-145957-20150613140201.patch text/plain 6344 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTU0MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA2LTEzICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBFeHBvc2UgVUlEZWxl Z2F0ZTo6VUlDbGllbnQ6OmNsb3NlIHZpYSBXS1VJRGVsZWdhdGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTk1NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJ RGVsZWdhdGUuaDogQWRkZWQgLXdlYlZpZXdEaWRDbG9zZTogdG8gdGhlIHByb3RvY29sLgorICAg ICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRlLmg6IEFkZGVkIGEgd2ViVmlld0RpZENs b3NlIGJvb2xlYW4gdG8gdGhlIGRlbGVnYXRlIG1ldGhvZHMgc3RydWN0LgorICAgICAgICAqIFVJ UHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRlLm1tOgorICAgICAgICAoV2ViS2l0OjpVSURlbGVnYXRl OjpzZXREZWxlZ2F0ZSk6IEluaXRpYWxpemUgdGhlIHdlYlZpZXdEaWRDbG9zZSBib29sZWFuLgor ICAgICAgICAoV2ViS2l0OjpVSURlbGVnYXRlOjpVSUNsaWVudDo6Y2xvc2UpOiBDaGFuZ2VkIHRv IGNhbGwgdGhlIG5ldyBkZWxlZ2F0ZSBtZXRob2QuIExlZnQgYmVoaW5kCisgICAgICAgIGNvZGUg dGhhdCBjYWxscyB0aGUgb2xkIHByaXZhdGUgbWV0aG9kIGlmIGl04oCZcyBpbXBsZW1lbnRlZC4K KwogMjAxNS0wNi0xMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlaW1wbGVtZW50IFdLUmVzb3VyY2VDYWNoZU1hbmFnZXJSZWYgb24gdG9wIG9mIFdL V2Vic2l0ZURhdGFTdG9yZVJlZgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1VJRGVsZWdhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZS5oCShyZXZpc2lvbiAxODU1MzkpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZS5oCSh3b3JraW5nIGNvcHkp CkBAIC01Nyw2ICs1NywxMyBAQCBXS19BU1NVTUVfTk9OTlVMTF9CRUdJTgogICovCiAtIChXS19O VUxMQUJMRSBXS1dlYlZpZXcgKil3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGNyZWF0ZVdl YlZpZXdXaXRoQ29uZmlndXJhdGlvbjooV0tXZWJWaWV3Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3Vy YXRpb24gZm9yTmF2aWdhdGlvbkFjdGlvbjooV0tOYXZpZ2F0aW9uQWN0aW9uICopbmF2aWdhdGlv bkFjdGlvbiB3aW5kb3dGZWF0dXJlczooV0tXaW5kb3dGZWF0dXJlcyAqKXdpbmRvd0ZlYXR1cmVz OwogCisvKiEgQGFic3RyYWN0IE5vdGlmaWVzIHlvdXIgYXBwIHRoYXQgdGhlIERPTSB3aW5kb3cg b2JqZWN0J3MgY2xvc2UoKSBtZXRob2QgY29tcGxldGVkIHN1Y2Nlc3NmdWxseS4KKyAgQHBhcmFt IHdlYlZpZXcgVGhlIHdlYiB2aWV3IGludm9raW5nIHRoZSBkZWxlZ2F0ZSBtZXRob2QuCisgIEBk aXNjdXNzaW9uIFlvdXIgYXBwIHNob3VsZCByZW1vdmUgdGhlIHdlYiB2aWV3IGZyb20gdGhlIHZp ZXcgaGllcmFyY2h5IGFuZCB1cGRhdGUKKyAgdGhlIFVJIGFzIG5lZWRlZCwgc3VjaCBhcyBieSBj bG9zaW5nIHRoZSBjb250YWluaW5nIGJyb3dzZXIgdGFiIG9yIHdpbmRvdy4KKyAgKi8KKy0gKHZv aWQpd2ViVmlld0RpZENsb3NlOihXS1dlYlZpZXcgKil3ZWJWaWV3OworCiAvKiEgQGFic3RyYWN0 IERpc3BsYXlzIGEgSmF2YVNjcmlwdCBhbGVydCBwYW5lbC4KICBAcGFyYW0gd2ViVmlldyBUaGUg d2ViIHZpZXcgaW52b2tpbmcgdGhlIGRlbGVnYXRlIG1ldGhvZC4KICBAcGFyYW0gbWVzc2FnZSBU aGUgbWVzc2FnZSB0byBkaXNwbGF5LgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nv Y29hL1VJRGVsZWdhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Q29jb2EvVUlEZWxlZ2F0ZS5oCShyZXZpc2lvbiAxODU1MzkpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQ29jb2EvVUlEZWxlZ2F0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC04OCw2ICs4OCw3 IEBAIHByaXZhdGU6CiAgICAgICAgIGJvb2wgd2ViVmlld0RlY2lkZURhdGFiYXNlUXVvdGFGb3JT ZWN1cml0eU9yaWdpbkN1cnJlbnRRdW90YUN1cnJlbnRPcmlnaW5Vc2FnZUN1cnJlbnREYXRhYmFz ZVVzYWdlRXhwZWN0ZWRVc2FnZURlY2lzaW9uSGFuZGxlciA6IDE7CiAgICAgICAgIGJvb2wgd2Vi Vmlld0RlY2lkZVdlYkFwcGxpY2F0aW9uQ2FjaGVRdW90YUZvclNlY3VyaXR5T3JpZ2luQ3VycmVu dFF1b3RhVG90YWxCeXRlc05lZWRlZCA6IDE7CiAgICAgICAgIGJvb2wgd2ViVmlld1ByaW50RnJh bWUgOiAxOworICAgICAgICBib29sIHdlYlZpZXdEaWRDbG9zZSA6IDE7CiAgICAgICAgIGJvb2wg d2ViVmlld0Nsb3NlIDogMTsKICAgICAgICAgYm9vbCB3ZWJWaWV3RnVsbHNjcmVlbk1heVJldHVy blRvSW5saW5lIDogMTsKICAgICAgICAgYm9vbCB3ZWJWaWV3RGlkRW50ZXJGdWxsc2NyZWVuIDog MTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRlLm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRlLm1t CShyZXZpc2lvbiAxODU1MzkpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvVUlE ZWxlZ2F0ZS5tbQkod29ya2luZyBjb3B5KQpAQCAtNzEsNiArNzEsNyBAQCB2b2lkIFVJRGVsZWdh dGU6OnNldERlbGVnYXRlKGlkIDxXS1VJRGVsCiAgICAgbV9kZWxlZ2F0ZU1ldGhvZHMud2ViVmll d0RlY2lkZURhdGFiYXNlUXVvdGFGb3JTZWN1cml0eU9yaWdpbkN1cnJlbnRRdW90YUN1cnJlbnRP cmlnaW5Vc2FnZUN1cnJlbnREYXRhYmFzZVVzYWdlRXhwZWN0ZWRVc2FnZURlY2lzaW9uSGFuZGxl ciA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3OmRlY2lk ZURhdGFiYXNlUXVvdGFGb3JTZWN1cml0eU9yaWdpbjpjdXJyZW50UXVvdGE6Y3VycmVudE9yaWdp blVzYWdlOmN1cnJlbnREYXRhYmFzZVVzYWdlOmV4cGVjdGVkVXNhZ2U6ZGVjaXNpb25IYW5kbGVy OildOwogICAgIG1fZGVsZWdhdGVNZXRob2RzLndlYlZpZXdEZWNpZGVXZWJBcHBsaWNhdGlvbkNh Y2hlUXVvdGFGb3JTZWN1cml0eU9yaWdpbkN1cnJlbnRRdW90YVRvdGFsQnl0ZXNOZWVkZWQgPSBb ZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihfd2ViVmlldzpkZWNpZGVXZWJB cHBsaWNhdGlvbkNhY2hlUXVvdGFGb3JTZWN1cml0eU9yaWdpbjpjdXJyZW50UXVvdGE6dG90YWxC eXRlc05lZWRlZDpkZWNpc2lvbkhhbmRsZXI6KV07CiAgICAgbV9kZWxlZ2F0ZU1ldGhvZHMud2Vi Vmlld1ByaW50RnJhbWUgPSBbZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihf d2ViVmlldzpwcmludEZyYW1lOildOworICAgIG1fZGVsZWdhdGVNZXRob2RzLndlYlZpZXdEaWRD bG9zZSA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKHdlYlZpZXdEaWRD bG9zZTopXTsKICAgICBtX2RlbGVnYXRlTWV0aG9kcy53ZWJWaWV3Q2xvc2UgPSBbZGVsZWdhdGUg cmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihfd2ViVmlld0Nsb3NlOildOwogICAgIG1fZGVs ZWdhdGVNZXRob2RzLndlYlZpZXdGdWxsc2NyZWVuTWF5UmV0dXJuVG9JbmxpbmUgPSBbZGVsZWdh dGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihfd2ViVmlld0Z1bGxzY3JlZW5NYXlSZXR1 cm5Ub0lubGluZTopXTsKICAgICBtX2RlbGVnYXRlTWV0aG9kcy53ZWJWaWV3RGlkRW50ZXJGdWxs c2NyZWVuID0gW2RlbGVnYXRlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXdE aWRFbnRlckZ1bGxzY3JlZW46KV07CkBAIC0yMzIsMTQgKzIzMywyMyBAQCB2b2lkIFVJRGVsZWdh dGU6OlVJQ2xpZW50OjpwcmludEZyYW1lKFdlCiAKIHZvaWQgVUlEZWxlZ2F0ZTo6VUlDbGllbnQ6 OmNsb3NlKFdlYktpdDo6V2ViUGFnZVByb3h5KikKIHsKLSAgICBpZiAoIW1fdWlEZWxlZ2F0ZS5t X2RlbGVnYXRlTWV0aG9kcy53ZWJWaWV3Q2xvc2UpCisgICAgaWYgKG1fdWlEZWxlZ2F0ZS5tX2Rl bGVnYXRlTWV0aG9kcy53ZWJWaWV3Q2xvc2UpIHsKKyAgICAgICAgYXV0byBkZWxlZ2F0ZSA9IG1f dWlEZWxlZ2F0ZS5tX2RlbGVnYXRlLmdldCgpOworICAgICAgICBpZiAoIWRlbGVnYXRlKQorICAg ICAgICAgICAgcmV0dXJuOworCisgICAgICAgIFsoaWQgPFdLVUlEZWxlZ2F0ZVByaXZhdGU+KWRl bGVnYXRlIF93ZWJWaWV3Q2xvc2U6bV91aURlbGVnYXRlLm1fd2ViVmlld107CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKKyAgICBpZiAoIW1fdWlEZWxlZ2F0ZS5tX2RlbGVnYXRlTWV0aG9kcy53 ZWJWaWV3RGlkQ2xvc2UpCiAgICAgICAgIHJldHVybjsKIAogICAgIGF1dG8gZGVsZWdhdGUgPSBt X3VpRGVsZWdhdGUubV9kZWxlZ2F0ZS5nZXQoKTsKICAgICBpZiAoIWRlbGVnYXRlKQogICAgICAg ICByZXR1cm47CiAKLSAgICBbKGlkIDxXS1VJRGVsZWdhdGVQcml2YXRlPilkZWxlZ2F0ZSBfd2Vi Vmlld0Nsb3NlOm1fdWlEZWxlZ2F0ZS5tX3dlYlZpZXddOworICAgIFtkZWxlZ2F0ZSB3ZWJWaWV3 RGlkQ2xvc2U6bV91aURlbGVnYXRlLm1fd2ViVmlld107CiB9CiAKIHZvaWQgVUlEZWxlZ2F0ZTo6 VUlDbGllbnQ6OmZ1bGxzY3JlZW5NYXlSZXR1cm5Ub0lubGluZShXZWJLaXQ6OldlYlBhZ2VQcm94 eSopCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAxODU1NDApCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxMyBAQAorMjAxNS0wNi0xMyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29t PgorCisgICAgICAgIFtDb2NvYV0gRXhwb3NlIFVJRGVsZWdhdGU6OlVJQ2xpZW50OjpjbG9zZSB2 aWEgV0tVSURlbGVnYXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDU5NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL09wZW5BbmRDbG9zZVdp bmRvdy5tbToKKyAgICAgICAgKC1bT3BlbkFuZENsb3NlV2luZG93VUlEZWxlZ2F0ZSB3ZWJWaWV3 RGlkQ2xvc2U6XSk6IFJlbmFtZWQgZnJvbSAtX3dlYlZpZXdDbG9zZTouCisKIDIwMTUtMDYtMTIg IEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIHNw cmluZ0xvYWRpbmdIaWdobGlnaHQgdHlwZQpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyQ29jb2EvT3BlbkFuZENsb3NlV2luZG93Lm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL09wZW5BbmRDbG9zZVdpbmRvdy5tbQko cmV2aXNpb24gMTg1NTM5KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29j b2EvT3BlbkFuZENsb3NlV2luZG93Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC00NSw3ICs0NSw3IEBA IEBpbnRlcmZhY2UgT3BlbkFuZENsb3NlV2luZG93VUlEZWxlZ2F0ZSAKIAogQGltcGxlbWVudGF0 aW9uIE9wZW5BbmRDbG9zZVdpbmRvd1VJRGVsZWdhdGUKIAotLSAodm9pZClfd2ViVmlld0Nsb3Nl OihXS1dlYlZpZXcgKil3ZWJWaWV3CistICh2b2lkKXdlYlZpZXdEaWRDbG9zZTooV0tXZWJWaWV3 ICopd2ViVmlldwogewogICAgIEVYUEVDVF9FUShvcGVuZWRXZWJWaWV3LCB3ZWJWaWV3KTsKICAg ICBpc0RvbmUgPSB0cnVlOwo=