145940 2015-06-12 14:43:25 -0700 Perf dashboard's v2 UI shouldn't hide auto-detected outliers 2016-02-16 13:52:47 -0800 1 1 1 Unclassified WebKit Perf Dashboard 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141237 1 rniwa rniwa barraclough cdumez commit-queue kling rniwa slewis oldest_to_newest 1101701 0 rniwa 2015-06-12 14:43:25 -0700 Right now, v2 UI automatically "detects" outliers and hides them. Now that we can explicitly mark outliers, this "feature" is nothing but an annoyance. 1101703 1 254821 rniwa 2015-06-12 14:46:32 -0700 Created attachment 254821 Removes the feature 1101808 2 254821 commit-queue 2015-06-13 01:17:01 -0700 Comment on attachment 254821 Removes the feature Clearing flags on attachment: 254821 Committed r185535: <http://trac.webkit.org/changeset/185535> 1101809 3 commit-queue 2015-06-13 01:17:12 -0700 All reviewed patches have been landed. Closing bug. 254821 2015-06-12 14:46:32 -0700 2015-06-13 01:17:01 -0700 Removes the feature bug-145940-20150612144602.patch text/plain 4625 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1NTIwKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE1LTA2LTEyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFBlcmYgZGFzaGJvYXJkJ3MgdjIgVUkgc2hvdWxkbid0IGhpZGUgYXV0by1kZXRl Y3RlZCBvdXRsaWVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ1OTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRG9uJ3QgZmFsbGJhY2sgdG8gdGhlIGRlZmF1bHQgc3RyYXRlZ2llcyBmb3IgbW92aW5n IGF2ZXJhZ2VzIGFuZCBlbnZlbG9wZSB3aGVuIG9uZSBpcyBub3Qgc3BlY2lmaWVkLgorICAgICAg ICBBbHNvIGRlbGV0ZWQgdGhlIGNvZGUgdG8gbWFyayBwb2ludHMgb3V0c2lkZSB0aGUgZW52ZWxv cCBhcyBvdXRsaWVycy4KKworICAgICAgICAqIHB1YmxpYy92Mi9hcHAuanM6CisKIDIwMTUtMDYt MDkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZCBidWlsZCBmaXguIFNvbWUgYnVpbGRlciBuYW1lcyBhcmUgcmVhbGx5IGxvbmcuCkluZGV4OiBX ZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2FwcC5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2FwcC5qcwkocmV2aXNpb24gMTg1MzQ2 KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9hcHAuanMJKHdvcmtpbmcg Y29weSkKQEAgLTU4Niw4ICs1ODYsMTAgQEAgQXBwLlBhbmUgPSBFbWJlci5PYmplY3QuZXh0ZW5k KHsKIAogICAgICAgICB2YXIgcmF3VmFsdWVzID0gY2hhcnREYXRhLmN1cnJlbnQucmF3VmFsdWVz KCk7CiAgICAgICAgIHZhciBtb3ZpbmdBdmVyYWdlSXNTZXRCeVVzZXIgPSBtb3ZpbmdBdmVyYWdl U3RyYXRlZ3kgJiYgbW92aW5nQXZlcmFnZVN0cmF0ZWd5LmV4ZWN1dGU7Ci0gICAgICAgIHZhciBt b3ZpbmdBdmVyYWdlVmFsdWVzID0gU3RhdGlzdGljcy5leGVjdXRlU3RyYXRlZ3koCi0gICAgICAg ICAgICBtb3ZpbmdBdmVyYWdlSXNTZXRCeVVzZXIgPyBtb3ZpbmdBdmVyYWdlU3RyYXRlZ3kgOiBT dGF0aXN0aWNzLk1vdmluZ0F2ZXJhZ2VTdHJhdGVnaWVzWzBdLCByYXdWYWx1ZXMpOworICAgICAg ICBpZiAoIW1vdmluZ0F2ZXJhZ2VJc1NldEJ5VXNlcikKKyAgICAgICAgICAgIHJldHVybiBudWxs OworCisgICAgICAgIHZhciBtb3ZpbmdBdmVyYWdlVmFsdWVzID0gU3RhdGlzdGljcy5leGVjdXRl U3RyYXRlZ3kobW92aW5nQXZlcmFnZVN0cmF0ZWd5LCByYXdWYWx1ZXMpOwogICAgICAgICBpZiAo IW1vdmluZ0F2ZXJhZ2VWYWx1ZXMpCiAgICAgICAgICAgICByZXR1cm4gbnVsbDsKIApAQCAtNTk1 LDMzICs1OTcsMjMgQEAgQXBwLlBhbmUgPSBFbWJlci5PYmplY3QuZXh0ZW5kKHsKICAgICAgICAg aWYgKG1vdmluZ0F2ZXJhZ2VTdHJhdGVneSAmJiBtb3ZpbmdBdmVyYWdlU3RyYXRlZ3kuaXNTZWdt ZW50YXRpb24gJiYgdGVzdFJhbmdlU2VsZWN0aW9uU3RyYXRlZ3kgJiYgdGVzdFJhbmdlU2VsZWN0 aW9uU3RyYXRlZ3kuZXhlY3V0ZSkKICAgICAgICAgICAgIHRlc3RSYW5nZUNhbmRpZGF0ZXMgPSBT dGF0aXN0aWNzLmV4ZWN1dGVTdHJhdGVneSh0ZXN0UmFuZ2VTZWxlY3Rpb25TdHJhdGVneSwgcmF3 VmFsdWVzLCBbbW92aW5nQXZlcmFnZVZhbHVlc10pOwogCi0gICAgICAgIHZhciBlbnZlbG9wZUlz U2V0QnlVc2VyID0gZW52ZWxvcGluZ1N0cmF0ZWd5ICYmIGVudmVsb3BpbmdTdHJhdGVneS5leGVj dXRlOwotICAgICAgICB2YXIgZW52ZWxvcGVEZWx0YSA9IFN0YXRpc3RpY3MuZXhlY3V0ZVN0cmF0 ZWd5KGVudmVsb3BlSXNTZXRCeVVzZXIgPyBlbnZlbG9waW5nU3RyYXRlZ3kgOiBTdGF0aXN0aWNz LkVudmVsb3BpbmdTdHJhdGVnaWVzWzBdLAotICAgICAgICAgICAgcmF3VmFsdWVzLCBbbW92aW5n QXZlcmFnZVZhbHVlc10pOwotCi0gICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgY3VycmVudFRp bWVTZXJpZXNEYXRhLmxlbmd0aDsgaSsrKSB7Ci0gICAgICAgICAgICB2YXIgY3VycmVudFZhbHVl ID0gY3VycmVudFRpbWVTZXJpZXNEYXRhW2ldLnZhbHVlOwotICAgICAgICAgICAgdmFyIG1vdmlu Z0F2ZXJhZ2VWYWx1ZSA9IG1vdmluZ0F2ZXJhZ2VWYWx1ZXNbaV07Ci0gICAgICAgICAgICBpZiAo Y3VycmVudFZhbHVlIDwgbW92aW5nQXZlcmFnZVZhbHVlIC0gZW52ZWxvcGVEZWx0YSB8fCBtb3Zp bmdBdmVyYWdlVmFsdWUgKyBlbnZlbG9wZURlbHRhIDwgY3VycmVudFZhbHVlKQotICAgICAgICAg ICAgICAgIGN1cnJlbnRUaW1lU2VyaWVzRGF0YVtpXS5pc091dGxpZXIgPSB0cnVlOwotICAgICAg ICB9Ci0gICAgICAgIGlmICghZW52ZWxvcGVJc1NldEJ5VXNlcikKLSAgICAgICAgICAgIGVudmVs b3BlRGVsdGEgPSBudWxsOwotCi0gICAgICAgIHZhciBhbm9tYWxpZXMgPSB7fTsKLSAgICAgICAg aWYgKGFub21hbHlEZXRlY3Rpb25TdHJhdGVnaWVzLmxlbmd0aCkgewotICAgICAgICAgICAgdmFy IGlzQW5vbWFseUFycmF5ID0gbmV3IEFycmF5KGN1cnJlbnRUaW1lU2VyaWVzRGF0YS5sZW5ndGgp OwotICAgICAgICAgICAgZm9yICh2YXIgc3RyYXRlZ3kgb2YgYW5vbWFseURldGVjdGlvblN0cmF0 ZWdpZXMpIHsKLSAgICAgICAgICAgICAgICB2YXIgYW5vbWFseUxlbmd0aHMgPSBTdGF0aXN0aWNz LmV4ZWN1dGVTdHJhdGVneShzdHJhdGVneSwgcmF3VmFsdWVzLCBbbW92aW5nQXZlcmFnZVZhbHVl cywgZW52ZWxvcGVEZWx0YV0pOwotICAgICAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwg Y3VycmVudFRpbWVTZXJpZXNEYXRhLmxlbmd0aDsgaSsrKQotICAgICAgICAgICAgICAgICAgICBp c0Fub21hbHlBcnJheVtpXSA9IGlzQW5vbWFseUFycmF5W2ldIHx8IGFub21hbHlMZW5ndGhzW2ld OwotICAgICAgICAgICAgfQotICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBpc0Fub21h bHlBcnJheS5sZW5ndGg7IGkrKykgewotICAgICAgICAgICAgICAgIGlmICghaXNBbm9tYWx5QXJy YXlbaV0pCi0gICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICAgICAgICAgIGFu b21hbGllc1tjdXJyZW50VGltZVNlcmllc0RhdGFbaV0ubWVhc3VyZW1lbnQuaWQoKV0gPSB0cnVl OwotICAgICAgICAgICAgICAgIHdoaWxlIChpc0Fub21hbHlBcnJheVtpXSAmJiBpIDwgaXNBbm9t YWx5QXJyYXkubGVuZ3RoKQotICAgICAgICAgICAgICAgICAgICArK2k7CisgICAgICAgIGlmIChl bnZlbG9waW5nU3RyYXRlZ3kgJiYgZW52ZWxvcGluZ1N0cmF0ZWd5LmV4ZWN1dGUpIHsKKyAgICAg ICAgICAgIHZhciBlbnZlbG9wZURlbHRhID0gU3RhdGlzdGljcy5leGVjdXRlU3RyYXRlZ3koZW52 ZWxvcGluZ1N0cmF0ZWd5LCByYXdWYWx1ZXMsIFttb3ZpbmdBdmVyYWdlVmFsdWVzXSk7CisgICAg ICAgICAgICB2YXIgYW5vbWFsaWVzID0ge307CisgICAgICAgICAgICBpZiAoYW5vbWFseURldGVj dGlvblN0cmF0ZWdpZXMubGVuZ3RoKSB7CisgICAgICAgICAgICAgICAgdmFyIGlzQW5vbWFseUFy cmF5ID0gbmV3IEFycmF5KGN1cnJlbnRUaW1lU2VyaWVzRGF0YS5sZW5ndGgpOworICAgICAgICAg ICAgICAgIGZvciAodmFyIHN0cmF0ZWd5IG9mIGFub21hbHlEZXRlY3Rpb25TdHJhdGVnaWVzKSB7 CisgICAgICAgICAgICAgICAgICAgIHZhciBhbm9tYWx5TGVuZ3RocyA9IFN0YXRpc3RpY3MuZXhl Y3V0ZVN0cmF0ZWd5KHN0cmF0ZWd5LCByYXdWYWx1ZXMsIFttb3ZpbmdBdmVyYWdlVmFsdWVzLCBl bnZlbG9wZURlbHRhXSk7CisgICAgICAgICAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwg Y3VycmVudFRpbWVTZXJpZXNEYXRhLmxlbmd0aDsgaSsrKQorICAgICAgICAgICAgICAgICAgICAg ICAgaXNBbm9tYWx5QXJyYXlbaV0gPSBpc0Fub21hbHlBcnJheVtpXSB8fCBhbm9tYWx5TGVuZ3Ro c1tpXTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7 IGkgPCBpc0Fub21hbHlBcnJheS5sZW5ndGg7IGkrKykgeworICAgICAgICAgICAgICAgICAgICBp ZiAoIWlzQW5vbWFseUFycmF5W2ldKQorICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWU7 CisgICAgICAgICAgICAgICAgICAgIGFub21hbGllc1tjdXJyZW50VGltZVNlcmllc0RhdGFbaV0u bWVhc3VyZW1lbnQuaWQoKV0gPSB0cnVlOworICAgICAgICAgICAgICAgICAgICB3aGlsZSAoaXNB bm9tYWx5QXJyYXlbaV0gJiYgaSA8IGlzQW5vbWFseUFycmF5Lmxlbmd0aCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICsraTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KIAo=