145938 2015-06-12 14:24:19 -0700 Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https 2015-06-12 15:09:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham oldest_to_newest 1101695 0 bfulgham 2015-06-12 14:24:19 -0700 Content on the 'developer.apple.com' site recently moved. The LWP::Simple methods being used did not properly respect the redirect status, and started failing. This patch corrects this problem. 1101696 1 254819 bfulgham 2015-06-12 14:28:18 -0700 Created attachment 254819 Patch 1101705 2 254823 bfulgham 2015-06-12 14:50:40 -0700 Created attachment 254823 Patch 1101706 3 254819 ap 2015-06-12 14:57:16 -0700 Comment on attachment 254819 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254819&action=review > Tools/ChangeLog:3 > + Correct update-webkit-dependency to handle redirects I don't see any redirect when trying with curl. Maybe something else is wrong. > Tools/Scripts/update-webkit-dependency:90 > +my $content_type = $response->header('Content-Type'); > +my $document_length = $response->header('Content-Length'); > +my $modified_time = $response->header('Last-Modified'); > +my $expires; > +my $server = $response->header('Server'); Are these needed? > Tools/Scripts/update-webkit-dependency:110 > + if ($result == 300) { 300 is Multiple Choice. Brent says that this is debugging code that needs to be removed. 1101707 4 254823 ap 2015-06-12 14:57:42 -0700 Comment on attachment 254823 Patch Carrying over r+ from the previous patch. 1101712 5 bfulgham 2015-06-12 15:09:18 -0700 Committed r185522: <http://trac.webkit.org/changeset/185522> 254819 2015-06-12 14:28:18 -0700 2015-06-12 14:57:16 -0700 Patch bug-145938-20150612144045.patch text/plain 2568 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTUyMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTA2LTEyICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIENvcnJlY3QgdXBkYXRlLXdlYmtpdC1kZXBlbmRlbmN5IHRvIGhhbmRsZSBy ZWRpcmVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0NTkzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy91cGRhdGUtd2Via2l0LWRlcGVuZGVuY3k6IFN3aXRjaCBmcm9tIExXUDo6U2lt cGxlIHRvCisgICAgICAgIExXUDo6VXNlckFnZW50IHRvIGdldCBhY2Nlc3MgdG8gcmVkaXJlY3Qg ZmVhdHVyZXMuCisKIDIwMTUtMDYtMTIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0 Lm9yZz4KIAogICAgICAgICBbR1RLXSBGaXggcmV0dXJuIHR5cGUgd2FybmluZyBpbiBXZWJWaWV3 VGVzdC5jcHAKSW5kZXg6IFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1kZXBlbmRlbmN5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1kZXBlbmRlbmN5CShyZXZp c2lvbiAxODU1MTgpCisrKyBUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtZGVwZW5kZW5jeQko d29ya2luZyBjb3B5KQpAQCAtMzksNyArMzksOSBAQCB1c2UgRmlsZTo6U3BlYzsKIHVzZSBGaWxl OjpUZW1wICgpOwogdXNlIEZpbmRCaW47CiB1c2UgSFRUUDo6RGF0ZSBxdyhzdHIydGltZSB0aW1l MnN0cik7Cit1c2UgSFRUUDo6UmVxdWVzdDsKIHVzZSBMV1A6OlNpbXBsZTsKK3VzZSBMV1A6OlVz ZXJBZ2VudDsKIHVzZSBQT1NJWDsKIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsKIHVzZSB3ZWJraXRk aXJzOwpAQCAtNzMsMTAgKzc1LDE5IEBAIG15ICR6aXBGaWxlID0gIiRmaWxlLnppcCI7CiBteSAk d2Via2l0TGlicmFyaWVzRGlyID0gJEVOVnsnV0VCS0lUX0xJQlJBUklFUyd9IHx8IEZpbGU6OlNw ZWMtPmNhdGRpcigkc291cmNlRGlyLCAiV2ViS2l0TGlicmFyaWVzIiwgIndpbiIpOwogbXkgJHRt cFJlbGF0aXZlRGlyID0gRmlsZTo6VGVtcDo6dGVtcGRpcigid2Via2l0bGlic1hYWFhYWFgiLCBU TVBESVIgPT4gMSwgQ0xFQU5VUCA9PiAxKTsKIG15ICR0bXBBYnNEaXIgPSBGaWxlOjpTcGVjLT5y ZWwyYWJzKCR0bXBSZWxhdGl2ZURpcik7CitteSAkdWEgPSBMV1A6OlVzZXJBZ2VudC0+bmV3KCk7 CiAKIHByaW50ICJDaGVja2luZyBMYXN0LU1vZGlmaWVkIGRhdGUgb2YgJHppcEZpbGUuLi5cbiI7 CiAKLW15ICgkY29udGVudF90eXBlLCAkZG9jdW1lbnRfbGVuZ3RoLCAkbW9kaWZpZWRfdGltZSwg JGV4cGlyZXMsICRzZXJ2ZXIpID0gaGVhZCgkbGlic1VSTCk7CitteSAkcmVzcG9uc2UgPSAkdWEt PmdldCgkbGlic1VSTCk7CisKK2RpZSAiQ291bGQgbm90IGFjY2VzcyAkbGlic1VSTDpcbiIgLiAk cmVzcG9uc2UtPmhlYWRlcnNfYXNfc3RyaW5nIC4gIlxuIiB1bmxlc3MgKCRyZXNwb25zZS0+aXNf c3VjY2Vzcyk7CisKK215ICRjb250ZW50X3R5cGUgPSAkcmVzcG9uc2UtPmhlYWRlcignQ29udGVu dC1UeXBlJyk7CitteSAkZG9jdW1lbnRfbGVuZ3RoID0gJHJlc3BvbnNlLT5oZWFkZXIoJ0NvbnRl bnQtTGVuZ3RoJyk7CitteSAkbW9kaWZpZWRfdGltZSA9ICRyZXNwb25zZS0+aGVhZGVyKCdMYXN0 LU1vZGlmaWVkJyk7IAorbXkgJGV4cGlyZXM7CitteSAkc2VydmVyID0gJHJlc3BvbnNlLT5oZWFk ZXIoJ1NlcnZlcicpOyAKIAogaWYgKGRlZmluZWQgJG1vZGlmaWVkX3RpbWUpIHsKIApAQCAtOTUs NiArMTA2LDEzIEBAIGlmIChkZWZpbmVkICRtb2RpZmllZF90aW1lKSB7CiAKICAgICBpZiAoIWlz X3N1Y2Nlc3MoJHJlc3VsdCkpIHsKICAgICAgICAgcHJpbnQgU1RERVJSICJDb3VsZG4ndCBjaGVj ayBMYXN0LU1vZGlmaWVkIGRhdGUgb2YgbmV3ICR6aXBGaWxlLlxuIjsKKworICAgICAgICBpZiAo JHJlc3VsdCA9PSAzMDApIHsKKyAgICAgICAgICAgIHByaW50IFNUREVSUiAiUmVzb3VyY2Ugd2Fz IG1vdmVkOlxuIjsKKyAgICAgICAgICAgIHByaW50IFNUREVSUiAiU2VlICR0bXBBYnNEaXJcLiRm aWxlXC5oZWFkZXJzXG4iOyAKKyAgICAgICAgfQorCisgICAgICAgIHByaW50IFNUREVSUiAiUmVz cG9uc2Ugd2FzOiAkcmVzdWx0LlxuIjsKICAgICAgICAgcHJpbnQgU1RERVJSICJQbGVhc2UgZW5z dXJlIHRoYXQgUGVybCBjYW4gdXNlIExXUDo6U2ltcGxlIHRvIGNvbm5lY3QgdG8gSFRUUFMgdXJs cywgYW5kIHRoYXQgJGxpYnNVUkwgaXMgcmVhY2hhYmxlLlxuIjsKICAgICAgICAgcHJpbnQgU1RE RVJSICJZb3UgbWF5IGhhdmUgdG8gcnVuIFwkIGNwYW4gTFdQOjpQcm90b2NvbDo6aHR0cHNcbiI7 CiAK 254823 2015-06-12 14:50:40 -0700 2015-06-12 14:57:42 -0700 Patch bug-145938-20150612150308.patch text/plain 2407 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTUyMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTA2LTEyICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIENvcnJlY3QgdXBkYXRlLXdlYmtpdC1kZXBlbmRlbmN5IHRvIGhhbmRsZSBy ZWRpcmVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0NTkzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy91cGRhdGUtd2Via2l0LWRlcGVuZGVuY3k6IFN3aXRjaCBmcm9tIExXUDo6U2lt cGxlIHRvCisgICAgICAgIExXUDo6VXNlckFnZW50IHRvIGdldCBhY2Nlc3MgdG8gcmVkaXJlY3Qg ZmVhdHVyZXMuCisKIDIwMTUtMDYtMTIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0 Lm9yZz4KIAogICAgICAgICBbR1RLXSBGaXggcmV0dXJuIHR5cGUgd2FybmluZyBpbiBXZWJWaWV3 VGVzdC5jcHAKSW5kZXg6IFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1kZXBlbmRlbmN5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1kZXBlbmRlbmN5CShyZXZp c2lvbiAxODU1MTgpCisrKyBUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtZGVwZW5kZW5jeQko d29ya2luZyBjb3B5KQpAQCAtMzksNyArMzksOSBAQCB1c2UgRmlsZTo6U3BlYzsKIHVzZSBGaWxl OjpUZW1wICgpOwogdXNlIEZpbmRCaW47CiB1c2UgSFRUUDo6RGF0ZSBxdyhzdHIydGltZSB0aW1l MnN0cik7Cit1c2UgSFRUUDo6UmVxdWVzdDsKIHVzZSBMV1A6OlNpbXBsZTsKK3VzZSBMV1A6OlVz ZXJBZ2VudDsKIHVzZSBQT1NJWDsKIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsKIHVzZSB3ZWJraXRk aXJzOwpAQCAtNzMsMTAgKzc1LDE5IEBAIG15ICR6aXBGaWxlID0gIiRmaWxlLnppcCI7CiBteSAk d2Via2l0TGlicmFyaWVzRGlyID0gJEVOVnsnV0VCS0lUX0xJQlJBUklFUyd9IHx8IEZpbGU6OlNw ZWMtPmNhdGRpcigkc291cmNlRGlyLCAiV2ViS2l0TGlicmFyaWVzIiwgIndpbiIpOwogbXkgJHRt cFJlbGF0aXZlRGlyID0gRmlsZTo6VGVtcDo6dGVtcGRpcigid2Via2l0bGlic1hYWFhYWFgiLCBU TVBESVIgPT4gMSwgQ0xFQU5VUCA9PiAxKTsKIG15ICR0bXBBYnNEaXIgPSBGaWxlOjpTcGVjLT5y ZWwyYWJzKCR0bXBSZWxhdGl2ZURpcik7CitteSAkdWEgPSBMV1A6OlVzZXJBZ2VudC0+bmV3KCk7 CiAKIHByaW50ICJDaGVja2luZyBMYXN0LU1vZGlmaWVkIGRhdGUgb2YgJHppcEZpbGUuLi5cbiI7 CiAKLW15ICgkY29udGVudF90eXBlLCAkZG9jdW1lbnRfbGVuZ3RoLCAkbW9kaWZpZWRfdGltZSwg JGV4cGlyZXMsICRzZXJ2ZXIpID0gaGVhZCgkbGlic1VSTCk7CitteSAkcmVzcG9uc2UgPSAkdWEt PmdldCgkbGlic1VSTCk7CisKK2RpZSAiQ291bGQgbm90IGFjY2VzcyAkbGlic1VSTDpcbiIgLiAk cmVzcG9uc2UtPmhlYWRlcnNfYXNfc3RyaW5nIC4gIlxuIiB1bmxlc3MgKCRyZXNwb25zZS0+aXNf c3VjY2Vzcyk7CisKK215ICRjb250ZW50X3R5cGUgPSAkcmVzcG9uc2UtPmhlYWRlcignQ29udGVu dC1UeXBlJyk7CitteSAkZG9jdW1lbnRfbGVuZ3RoID0gJHJlc3BvbnNlLT5oZWFkZXIoJ0NvbnRl bnQtTGVuZ3RoJyk7CitteSAkbW9kaWZpZWRfdGltZSA9ICRyZXNwb25zZS0+aGVhZGVyKCdMYXN0 LU1vZGlmaWVkJyk7IAorbXkgJGV4cGlyZXM7CitteSAkc2VydmVyID0gJHJlc3BvbnNlLT5oZWFk ZXIoJ1NlcnZlcicpOyAKIAogaWYgKGRlZmluZWQgJG1vZGlmaWVkX3RpbWUpIHsKIApAQCAtOTUs NiArMTA2LDcgQEAgaWYgKGRlZmluZWQgJG1vZGlmaWVkX3RpbWUpIHsKIAogICAgIGlmICghaXNf c3VjY2VzcygkcmVzdWx0KSkgewogICAgICAgICBwcmludCBTVERFUlIgIkNvdWxkbid0IGNoZWNr IExhc3QtTW9kaWZpZWQgZGF0ZSBvZiBuZXcgJHppcEZpbGUuXG4iOworICAgICAgICBwcmludCBT VERFUlIgIlJlc3BvbnNlIHdhczogJHJlc3VsdC5cbiI7CiAgICAgICAgIHByaW50IFNUREVSUiAi UGxlYXNlIGVuc3VyZSB0aGF0IFBlcmwgY2FuIHVzZSBMV1A6OlNpbXBsZSB0byBjb25uZWN0IHRv IEhUVFBTIHVybHMsIGFuZCB0aGF0ICRsaWJzVVJMIGlzIHJlYWNoYWJsZS5cbiI7CiAgICAgICAg IHByaW50IFNUREVSUiAiWW91IG1heSBoYXZlIHRvIHJ1biBcJCBjcGFuIExXUDo6UHJvdG9jb2w6 Omh0dHBzXG4iOwogCg==