145936 2015-06-12 13:07:17 -0700 [Mac] AirPlay menu button doesn't always show on page load 2015-06-25 14:11:27 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer oldest_to_newest 1101678 0 eric.carlson 2015-06-12 13:07:17 -0700 The AirPlay menu button isn't always visible when the first page with <video> loads. 1101679 1 eric.carlson 2015-06-12 13:07:49 -0700 <rdar://problem/21330128> 1101680 2 254816 eric.carlson 2015-06-12 13:26:44 -0700 Created attachment 254816 Proposed patch. 1101681 3 commit-queue 2015-06-12 13:27:52 -0700 Attachment 254816 did not pass style-queue: ERROR: Source/WebCore/Modules/mediasession/WebMediaSessionManager.h:78: The parameter name "tasks" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1101682 4 254816 bfulgham 2015-06-12 13:31:18 -0700 Comment on attachment 254816 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=254816&action=review r=me. I noticed a couple of typos, but nothing that needs to be re-reviewed. > Source/WebCore/ChangeLog:9 > + (WebCore::mediaProducerStateString): New, return a stream representing MediaStateFlags. return a *string* (not stream)? > Source/WebCore/ChangeLog:11 > + (WebCore::WebMediaSessionManager::toString): New, return a stream representing ConfigurationTasks. return a *string* (not stream)? > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:178 > + virtual bool wirelessVideoPlaybackDisabled() const override { return false; } We don't need to write 'virtual' when we also write 'override'. We've been changing this style elsewhere. But I don't care if you do so in this patch. 1101683 5 eric.carlson 2015-06-12 13:42:57 -0700 Committed r185519: https://trac.webkit.org/r185519 254816 2015-06-12 13:26:44 -0700 2015-06-25 14:11:27 -0700 Proposed patch. mirroring_mode_patch_2.txt text/plain 6869 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTUxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA2LTEyICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIEFpclBsYXkg bWVudSBidXR0b24gZG9lc24ndCBhbHdheXMgc2hvdyBvbiBwYWdlIGxvYWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTkzNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXNlc3Np b24vV2ViTWVkaWFTZXNzaW9uTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjptZWRpYVBy b2R1Y2VyU3RhdGVTdHJpbmcpOiBOZXcsIHJldHVybiBhIHN0cmVhbSByZXByZXNlbnRpbmcgTWVk aWFTdGF0ZUZsYWdzLgorICAgICAgICAoV2ViQ29yZTo6V2ViTWVkaWFTZXNzaW9uTWFuYWdlcjo6 Y2xpZW50U3RhdGVEaWRDaGFuZ2UpOiBMb2cgdGhlIHN0YXRlcyBhcyBzdHJpbmdzLgorICAgICAg ICAoV2ViQ29yZTo6V2ViTWVkaWFTZXNzaW9uTWFuYWdlcjo6dG9TdHJpbmcpOiBOZXcsIHJldHVy biBhIHN0cmVhbSByZXByZXNlbnRpbmcgQ29uZmlndXJhdGlvblRhc2tzLgorICAgICAgICAoV2Vi Q29yZTo6V2ViTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2NoZWR1bGVEZWxheWVkVGFzayk6IEFkZCBs b2dnaW5nLgorICAgICAgICAoV2ViQ29yZTo6V2ViTWVkaWFTZXNzaW9uTWFuYWdlcjo6dGFza1Rp bWVyRmlyZWQpOiBBZGQgbG9nZ2luZy4KKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc2Vzc2lvbi9X ZWJNZWRpYVNlc3Npb25NYW5hZ2VyLmg6CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMuaDog T3ZlcnJpZGUgd2lyZWxlc3NWaWRlb1BsYXliYWNrRGlzYWJsZWQKKyAgICAgICAgICBzbyBpdCBp cyBwb3NzaWJsZSB0byBhY3RpdmF0ZSByb3V0ZSBtb25pdG9yaW5nIGZvciBhIG1vdmllIGxvYWRl ZCB3aXRoIHRoaXMgZW5naW5lLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRp YVBsYXllclByaXZhdGVRVEtpdC5oOiBEaXR0by4KKwogMjAxNS0wNi0xMiAgWmFuIERvYmVyc2Vr ICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgQWRkIHRoZSByZW1haW5pbmcgbWlz c2luZyBvdmVycmlkZSBzcGVjaWZpZXJzIHVuZGVyIFNvdXJjZS9XZWJDb3JlLwpJbmRleDogU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vV2ViTWVkaWFTZXNzaW9uTWFuYWdlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vV2Vi TWVkaWFTZXNzaW9uTWFuYWdlci5jcHAJKHJldmlzaW9uIDE4NTUxOCkKKysrIFNvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL1dlYk1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zMiw2ICszMiw3IEBACiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1 ZGUgIk1lZGlhUGxheWJhY2tUYXJnZXRQaWNrZXJNYWMuaCIKICNpbmNsdWRlICJXZWJNZWRpYVNl c3Npb25NYW5hZ2VyQ2xpZW50LmgiCisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nQnVpbGRlci5o PgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTYxLDYgKzYyLDI5IEBAIHN0YXRpYyBib29s IGZsYWdzQXJlU2V0KE1lZGlhUHJvZHVjZXI6Ok0KICAgICByZXR1cm4gdmFsdWUgJiBmbGFnczsK IH0KIAorI2lmICFMT0dfRElTQUJMRUQKK3N0YXRpYyBTdHJpbmcgbWVkaWFQcm9kdWNlclN0YXRl U3RyaW5nKE1lZGlhUHJvZHVjZXI6Ok1lZGlhU3RhdGVGbGFncyBmbGFncykKK3sKKyAgICBTdHJp bmdCdWlsZGVyIHN0cmluZzsKKyAgICBpZiAoZmxhZ3MgJiBNZWRpYVByb2R1Y2VyOjpJc1BsYXlp bmdBdWRpbykKKyAgICAgICAgc3RyaW5nLmFwcGVuZCgiSXNQbGF5aW5nQXVkaW8gKyAiKTsKKyAg ICBpZiAoZmxhZ3MgJiBNZWRpYVByb2R1Y2VyOjpJc1BsYXlpbmdWaWRlbykKKyAgICAgICAgc3Ry aW5nLmFwcGVuZCgiSXNQbGF5aW5nVmlkZW8gKyAiKTsKKyAgICBpZiAoZmxhZ3MgJiBNZWRpYVBy b2R1Y2VyOjpJc1BsYXlpbmdUb0V4dGVybmFsRGV2aWNlKQorICAgICAgICBzdHJpbmcuYXBwZW5k KCJJc1BsYXlpbmdUb0V4dGVybmFsRGV2aWNlICsgIik7CisgICAgaWYgKGZsYWdzICYgTWVkaWFQ cm9kdWNlcjo6UmVxdWlyZXNQbGF5YmFja1RhcmdldE1vbml0b3JpbmcpCisgICAgICAgIHN0cmlu Zy5hcHBlbmQoIlJlcXVpcmVzUGxheWJhY2tUYXJnZXRNb25pdG9yaW5nICsgIik7CisgICAgaWYg KGZsYWdzICYgTWVkaWFQcm9kdWNlcjo6RXh0ZXJuYWxEZXZpY2VBdXRvUGxheUNhbmRpZGF0ZSkK KyAgICAgICAgc3RyaW5nLmFwcGVuZCgiRXh0ZXJuYWxEZXZpY2VBdXRvUGxheUNhbmRpZGF0ZSAr ICIpOworICAgIGlmIChzdHJpbmcuaXNFbXB0eSgpKQorICAgICAgICBzdHJpbmcuYXBwZW5kKCJJ c05vdFBsYXlpbmciKTsKKyAgICBlbHNlCisgICAgICAgIHN0cmluZy5yZXNpemUoc3RyaW5nLmxl bmd0aCgpIC0gMik7CisKKyAgICByZXR1cm4gc3RyaW5nLnRvU3RyaW5nKCk7Cit9CisjZW5kaWYK KwogV2ViTWVkaWFTZXNzaW9uTWFuYWdlcjo6V2ViTWVkaWFTZXNzaW9uTWFuYWdlcigpCiAgICAg OiBtX3Rhc2tUaW1lcihSdW5Mb29wOjpjdXJyZW50KCksIHRoaXMsICZXZWJNZWRpYVNlc3Npb25N YW5hZ2VyOjp0YXNrVGltZXJGaXJlZCkKIHsKQEAgLTEzNiw3ICsxNjAsNyBAQCB2b2lkIFdlYk1l ZGlhU2Vzc2lvbk1hbmFnZXI6OmNsaWVudFN0YXRlCiAKICAgICBhdXRvJiBjaGFuZ2VkQ2xpZW50 U3RhdGUgPSBtX2NsaWVudFN0YXRlW2luZGV4XTsKICAgICBNZWRpYVByb2R1Y2VyOjpNZWRpYVN0 YXRlRmxhZ3Mgb2xkRmxhZ3MgPSBjaGFuZ2VkQ2xpZW50U3RhdGUtPmZsYWdzOwotICAgIExPRyhN ZWRpYSwgIldlYk1lZGlhU2Vzc2lvbk1hbmFnZXI6OmNsaWVudFN0YXRlRGlkQ2hhbmdlKCVwICsg JWxsdSkgLSBuZXcgZmxhZ3MgPSAweCV4LCBvbGQgZmxhZ3MgPSAweCV4IiwgJmNsaWVudCwgY29u dGV4dElkLCBuZXdGbGFncywgb2xkRmxhZ3MpOworICAgIExPRyhNZWRpYSwgIldlYk1lZGlhU2Vz c2lvbk1hbmFnZXI6OmNsaWVudFN0YXRlRGlkQ2hhbmdlKCVwICsgJWxsdSkgLSBuZXcgZmxhZ3Mg PSAlcywgb2xkIGZsYWdzID0gJXMiLCAmY2xpZW50LCBjb250ZXh0SWQsIG1lZGlhUHJvZHVjZXJT dGF0ZVN0cmluZyhuZXdGbGFncykudXRmOCgpLmRhdGEoKSwgbWVkaWFQcm9kdWNlclN0YXRlU3Ry aW5nKG9sZEZsYWdzKS51dGY4KCkuZGF0YSgpKTsKICAgICBpZiAobmV3RmxhZ3MgPT0gb2xkRmxh Z3MpCiAgICAgICAgIHJldHVybjsKIApAQCAtMjY1LDE0ICsyODksMzcgQEAgdm9pZCBXZWJNZWRp YVNlc3Npb25NYW5hZ2VyOjpjb25maWd1cmVQbAogICAgICAgICB0YXJnZXRQaWNrZXIoKS5zdG9w TW9uaXRvcmluZ1BsYXliYWNrVGFyZ2V0cygpOwogfQogCisjaWYgIUxPR19ESVNBQkxFRAorU3Ry aW5nIFdlYk1lZGlhU2Vzc2lvbk1hbmFnZXI6OnRvU3RyaW5nKENvbmZpZ3VyYXRpb25UYXNrcyB0 YXNrcykKK3sKKyAgICBTdHJpbmdCdWlsZGVyIHN0cmluZzsKKyAgICBpZiAodGFza3MgJiBJbml0 aWFsQ29uZmlndXJhdGlvblRhc2spCisgICAgICAgIHN0cmluZy5hcHBlbmQoIkluaXRpYWxDb25m aWd1cmF0aW9uVGFzayArICIpOworICAgIGlmICh0YXNrcyAmIFRhcmdldENsaWVudHNDb25maWd1 cmF0aW9uVGFzaykKKyAgICAgICAgc3RyaW5nLmFwcGVuZCgiVGFyZ2V0Q2xpZW50c0NvbmZpZ3Vy YXRpb25UYXNrICsgIik7CisgICAgaWYgKHRhc2tzICYgVGFyZ2V0TW9uaXRvcmluZ0NvbmZpZ3Vy YXRpb25UYXNrKQorICAgICAgICBzdHJpbmcuYXBwZW5kKCJUYXJnZXRNb25pdG9yaW5nQ29uZmln dXJhdGlvblRhc2sgKyAiKTsKKyAgICBpZiAoc3RyaW5nLmlzRW1wdHkoKSkKKyAgICAgICAgc3Ry aW5nLmFwcGVuZCgiTm9UYXNrIik7CisgICAgZWxzZQorICAgICAgICBzdHJpbmcucmVzaXplKHN0 cmluZy5sZW5ndGgoKSAtIDIpOworICAgIAorICAgIHJldHVybiBzdHJpbmcudG9TdHJpbmcoKTsK K30KKyNlbmRpZgorCiB2b2lkIFdlYk1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNjaGVkdWxlRGVsYXll ZFRhc2soQ29uZmlndXJhdGlvblRhc2tzIHRhc2tzKQogeworICAgIExPRyhNZWRpYSwgIldlYk1l ZGlhU2Vzc2lvbk1hbmFnZXI6OnNjaGVkdWxlRGVsYXllZFRhc2sgLSB0YXNrcyA9ICVzIiwgdG9T dHJpbmcodGFza3MpLnV0ZjgoKS5kYXRhKCkpOworCiAgICAgbV90YXNrRmxhZ3MgfD0gdGFza3M7 CiAgICAgbV90YXNrVGltZXIuc3RhcnRPbmVTaG90KHRhc2tEZWxheUludGVydmFsKTsKIH0KIAog dm9pZCBXZWJNZWRpYVNlc3Npb25NYW5hZ2VyOjp0YXNrVGltZXJGaXJlZCgpCiB7CisgICAgTE9H KE1lZGlhLCAiV2ViTWVkaWFTZXNzaW9uTWFuYWdlcjo6dGFza1RpbWVyRmlyZWQgLSB0YXNrcyA9 ICVzIiwgdG9TdHJpbmcobV90YXNrRmxhZ3MpLnV0ZjgoKS5kYXRhKCkpOworCiAgICAgaWYgKG1f dGFza0ZsYWdzICYgSW5pdGlhbENvbmZpZ3VyYXRpb25UYXNrKQogICAgICAgICBjb25maWd1cmVO ZXdDbGllbnRzKCk7CiAgICAgaWYgKG1fdGFza0ZsYWdzICYgVGFyZ2V0Q2xpZW50c0NvbmZpZ3Vy YXRpb25UYXNrKQpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vV2Vi TWVkaWFTZXNzaW9uTWFuYWdlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzZXNzaW9uL1dlYk1lZGlhU2Vzc2lvbk1hbmFnZXIuaAkocmV2aXNpb24gMTg1NTE4 KQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vV2ViTWVkaWFTZXNzaW9u TWFuYWdlci5oCSh3b3JraW5nIGNvcHkpCkBAIC03NSw2ICs3NSw3IEBAIHByaXZhdGU6CiAgICAg ICAgIFRhcmdldE1vbml0b3JpbmdDb25maWd1cmF0aW9uVGFzayA9IDEgPDwgMiwKICAgICB9Owog ICAgIHR5cGVkZWYgdW5zaWduZWQgQ29uZmlndXJhdGlvblRhc2tzOworICAgIFN0cmluZyB0b1N0 cmluZyhDb25maWd1cmF0aW9uVGFza3MgdGFza3MpOwogCiAgICAgdm9pZCBzY2hlZHVsZURlbGF5 ZWRUYXNrKENvbmZpZ3VyYXRpb25UYXNrcyk7CiAgICAgdm9pZCB0YXNrVGltZXJGaXJlZCgpOwpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMv TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5 ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLmgJKHJldmlzaW9uIDE4NTUxOCkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVy UHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNzUsNiArMTc1 LDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgaXNDdXJyZW50UGxheWJhY2tUYXJnZXRX aXJlbGVzcygpIGNvbnN0IG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBzZXRXaXJlbGVzc1Bs YXliYWNrVGFyZ2V0KFJlZjxNZWRpYVBsYXliYWNrVGFyZ2V0PiYmKTsKICAgICB2aXJ0dWFsIHZv aWQgc2V0U2hvdWxkUGxheVRvUGxheWJhY2tUYXJnZXQoYm9vbCkgb3ZlcnJpZGU7CisgICAgdmly dHVhbCBib29sIHdpcmVsZXNzVmlkZW9QbGF5YmFja0Rpc2FibGVkKCkgY29uc3Qgb3ZlcnJpZGUg eyByZXR1cm4gZmFsc2U7IH0KICNlbmRpZgogCiAgICAgdm9pZCBlbnN1cmVMYXllcigpOwpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0 ZVFUS2l0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv bWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0LmgJKHJldmlzaW9uIDE4NTUxOCkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5o CSh3b3JraW5nIGNvcHkpCkBAIC0xODMsNiArMTgzLDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFs IGJvb2wgaXNDdXJyZW50UGxheWJhY2tUYXJnZXRXaXJlbGVzcygpIGNvbnN0IG92ZXJyaWRlOwog ICAgIHZpcnR1YWwgdm9pZCBzZXRXaXJlbGVzc1BsYXliYWNrVGFyZ2V0KFJlZjxNZWRpYVBsYXli YWNrVGFyZ2V0PiYmKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2hvdWxkUGxheVRvUGxheWJhY2tU YXJnZXQoYm9vbCkgb3ZlcnJpZGU7CisgICAgdmlydHVhbCBib29sIHdpcmVsZXNzVmlkZW9QbGF5 YmFja0Rpc2FibGVkKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gZmFsc2U7IH0KICNlbmRpZgog CiAgICAgTWVkaWFQbGF5ZXIqIG1fcGxheWVyOwo=