145925 2015-06-12 05:09:39 -0700 Fix unused private field warning in PageBanner.h 2015-06-15 04:21:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy commit-queue darin ossy oldest_to_newest 1101557 0 ossy 2015-06-12 05:09:39 -0700 In file included from ../../Source/WebKit2/WebProcess/WebPage/PageBanner.cpp:27: ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:86:10: warning: private field 'm_type' is not used [-Wunused-private-field] Type m_type; ^ ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:88:14: warning: private field 'm_webPage' is not used [-Wunused-private-field] WebPage* m_webPage; ^ ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:90:10: warning: private field 'm_mouseDownInBanner' is not used [-Wunused-private-field] bool m_mouseDownInBanner; ^ ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:91:10: warning: private field 'm_isHidden' is not used [-Wunused-private-field] bool m_isHidden; ^ 4 warnings generated. 1101561 1 254795 ossy 2015-06-12 05:15:07 -0700 Created attachment 254795 Patch 1101610 2 254795 darin 2015-06-12 09:41:52 -0700 Comment on attachment 254795 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254795&action=review > Source/WebKit2/WebProcess/WebPage/PageBanner.h:90 > + Type m_type; > + WebPage* m_webPage; Source/WebKit2/WebProcess/WebPage/mac/PageBannerMac.mm:45:7: error: field 'm_type' will be initialized after field 'm_client' [-Werror,-Wreorder] Need to fix this before landing. 1101611 3 254795 darin 2015-06-12 09:42:36 -0700 Comment on attachment 254795 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254795&action=review >> Source/WebKit2/WebProcess/WebPage/PageBanner.h:90 >> + WebPage* m_webPage; > > Source/WebKit2/WebProcess/WebPage/mac/PageBannerMac.mm:45:7: error: field 'm_type' will be initialized after field 'm_client' [-Werror,-Wreorder] > > Need to fix this before landing. Best way to fix it is probably to initialize m_type, m_webPage, m_mouseDownInBanner, and m_isHidden in the header rather than in the constructor. 1101890 4 254867 ossy 2015-06-15 02:41:40 -0700 Created attachment 254867 Patch Good point, I fixed it. 1101905 5 254867 commit-queue 2015-06-15 04:21:12 -0700 Comment on attachment 254867 Patch Clearing flags on attachment: 254867 Committed r185549: <http://trac.webkit.org/changeset/185549> 1101906 6 commit-queue 2015-06-15 04:21:15 -0700 All reviewed patches have been landed. Closing bug. 254795 2015-06-12 05:15:07 -0700 2015-06-15 02:41:35 -0700 Patch bug-145925-20150612051436.patch text/plain 2715 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjQ1ZTE3Yjk3ZGZlYjNh YjA2ZTNjNjBmZTgyNjY4OTQ3YWE3ZGZkMS4uOGRmN2VhMGRiNjJiNGM2NDRlODA2Y2VkZjk1OGI0 YzRlNDA1ZWI3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTEyICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHVudXNlZCBw cml2YXRlIGZpZWxkIHdhcm5pbmcgaW4gUGFnZUJhbm5lci5oCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU5MjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9QYWdlQmFu bmVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGFnZUJhbm5lcjo6flBhZ2VCYW5uZXIpOgorICAg ICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9QYWdlQmFubmVyLmg6CisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQYWdlL21hYy9QYWdlQmFubmVyTWFjLm1tOiBVc2UgUExBVEZPUk0oTUFDKSBpbnN0 ZWFkIG9mICFQTEFURk9STShJT1MpLCB0aGV5IGFyZSBzYW1lIGluIG9iamMgZmlsZXMuCisKIDIw MTUtMDYtMTIgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFVz ZSBTSEExIGZvciBjYWNoZSBjb2RlciBjaGVja3N1bXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9QYWdlQmFubmVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9QYWdlQmFubmVyLmNwcAppbmRleCBkMzUyZGU1NDA1Y2VjMjViZWU5 M2IyOGQ4YTEyMjEyZTg4Y2FiYjI1Li42YjJmZWNhYzdmYzE2NDQ2M2JlMGFmMTFkZTk0NWQ0OWNm M2IwMTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFn ZUJhbm5lci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VC YW5uZXIuY3BwCkBAIC0zMywxMSArMzMsMTMgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKIFBhZ2VC YW5uZXI6On5QYWdlQmFubmVyKCkKIHsKKyNpZiBQTEFURk9STShNQUMpCiAgICAgQVNTRVJUKCFt X3dlYlBhZ2UpOworI2VuZGlmCiAgICAgbV9jbGllbnQtPnBhZ2VCYW5uZXJEZXN0cm95ZWQodGhp cyk7CiB9CiAKLSNpZiAhUExBVEZPUk0oQ09DT0EpCisjaWYgIVBMQVRGT1JNKE1BQykKIHZvaWQg UGFnZUJhbm5lcjo6YWRkVG9QYWdlKFR5cGUsIFdlYlBhZ2UqKQogewogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VCYW5uZXIuaCBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9QYWdlQmFubmVyLmgKaW5kZXggOGQ5MTgxNDkzZjI2 Nzk2Y2QzOGI0NjA3MDYyY2IzMmMxMzUxMzAzMC4uN2YzNWNlMTQ5YjU4NDYxYTBhZjk3NDk4YjA5 ZGExN2I4N2M4ZmExYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1BhZ2VCYW5uZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv UGFnZUJhbm5lci5oCkBAIC04MywxNCArODMsMTQgQEAgcHJpdmF0ZToKICAgICBleHBsaWNpdCBQ YWdlQmFubmVyKENBTGF5ZXIgKiwgaW50IGhlaWdodCwgQ2xpZW50Kik7CiAjZW5kaWYKIAotICAg IFR5cGUgbV90eXBlOwogICAgIENsaWVudCogbV9jbGllbnQ7Ci0gICAgV2ViUGFnZSogbV93ZWJQ YWdlOwogCisjaWYgUExBVEZPUk0oTUFDKQorICAgIFR5cGUgbV90eXBlOworICAgIFdlYlBhZ2Uq IG1fd2ViUGFnZTsKICAgICBib29sIG1fbW91c2VEb3duSW5CYW5uZXI7CiAgICAgYm9vbCBtX2lz SGlkZGVuOwogCi0jaWYgUExBVEZPUk0oTUFDKQogICAgIFJldGFpblB0cjxDQUxheWVyPiBtX2xh eWVyOwogICAgIGludCBtX2hlaWdodDsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QYWdlQmFubmVyTWFjLm1tIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QYWdlQmFubmVyTWFjLm1tCmluZGV4IGIxMDlkOTI0 YWFjNDJiMmIyMTg1N2JlZjYxNWZjYmMyNDNmYTQyZGMuLmJlYzVmYTA3OWUwNDRmN2U4OTY2MWM2 ZmM0MTAyNzBhM2VjNTNmOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvUGFnZUJhbm5lck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1BhZ2VCYW5uZXJNYWMubW0KQEAgLTI2LDcgKzI2LDcgQEAKICNpbmNs dWRlICJjb25maWcuaCIKICNpbmNsdWRlICJQYWdlQmFubmVyLmgiCiAKLSNpZiAhUExBVEZPUk0o SU9TKQorI2lmIFBMQVRGT1JNKE1BQykKIAogI2luY2x1ZGUgIldlYlBhZ2UuaCIKICNpbmNsdWRl IDxXZWJDb3JlL0ZyYW1lVmlldy5oPgpAQCAtMTcwLDQgKzE3MCw0IEBAIENBTGF5ZXIgKlBhZ2VC YW5uZXI6OmxheWVyKCkKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKLSNlbmRpZiAvLyAhUExB VEZPUk0oSU9TKQorI2VuZGlmIC8vIFBMQVRGT1JNKE1BQykK 254867 2015-06-15 02:41:40 -0700 2015-06-15 04:21:12 -0700 Patch bug-145925-20150615024107.patch text/plain 3230 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGZjN2EyOTJjYzcwODU2 M2FjZmM3MjVlMGM2NzdkZGZiNjk3Yzk2NS4uMDE0ZGQ3NzY1NzBjOWM2YmM0MzQ3MmQyYzJkMzU5 ODIzZDU5MDcyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTE1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHVudXNlZCBw cml2YXRlIGZpZWxkIHdhcm5pbmcgaW4gUGFnZUJhbm5lci5oCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU5MjUKKworICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9QYWdlQmFubmVy LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGFnZUJhbm5lcjo6flBhZ2VCYW5uZXIpOgorICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9QYWdlQmFubmVyLmg6IEluaXRpYWxpemUgbV90eXBlLCBt X3dlYlBhZ2UsIG1fbW91c2VEb3duSW5CYW5uZXIsIGFuZCBtX2lzSGlkZGVuIGhlcmUgaW5zdGVh ZCBvZiBpbiB0aGUgY29uc3RydWN0b3IuCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21h Yy9QYWdlQmFubmVyTWFjLm1tOiBVc2UgUExBVEZPUk0oTUFDKSBpbnN0ZWFkIG9mICFQTEFURk9S TShJT1MpLCB0aGV5IGFyZSBzYW1lIGluIG9iamMgZmlsZXMuCisKIDIwMTUtMDYtMTQgIERhbiBC ZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXhlZCB0aGUgYnVpbGQuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFnZUJhbm5lci5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFnZUJhbm5lci5jcHAKaW5k ZXggZDM1MmRlNTQwNWNlYzI1YmVlOTNiMjhkOGExMjIxMmU4OGNhYmIyNS4uNmIyZmVjYWM3ZmMx NjQ0NjNiZTBhZjExZGU5NDVkNDljZjNiMDE2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VCYW5uZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9QYWdlQmFubmVyLmNwcApAQCAtMzMsMTEgKzMzLDEzIEBAIG5hbWVz cGFjZSBXZWJLaXQgewogCiBQYWdlQmFubmVyOjp+UGFnZUJhbm5lcigpCiB7CisjaWYgUExBVEZP Uk0oTUFDKQogICAgIEFTU0VSVCghbV93ZWJQYWdlKTsKKyNlbmRpZgogICAgIG1fY2xpZW50LT5w YWdlQmFubmVyRGVzdHJveWVkKHRoaXMpOwogfQogCi0jaWYgIVBMQVRGT1JNKENPQ09BKQorI2lm ICFQTEFURk9STShNQUMpCiB2b2lkIFBhZ2VCYW5uZXI6OmFkZFRvUGFnZShUeXBlLCBXZWJQYWdl KikKIHsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Q YWdlQmFubmVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFnZUJhbm5l ci5oCmluZGV4IDhkOTE4MTQ5M2YyNjc5NmNkMzhiNDYwNzA2MmNiMzJjMTM1MTMwMzAuLjMzZGY0 MjVhOTUyNmQ0ZTg3OThkNGMxY2VlMDcxNTU0NWEzMzdlYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9QYWdlQmFubmVyLmgKKysrIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VCYW5uZXIuaApAQCAtODMsMTQgKzgzLDE0IEBAIHBy aXZhdGU6CiAgICAgZXhwbGljaXQgUGFnZUJhbm5lcihDQUxheWVyICosIGludCBoZWlnaHQsIENs aWVudCopOwogI2VuZGlmCiAKLSAgICBUeXBlIG1fdHlwZTsKICAgICBDbGllbnQqIG1fY2xpZW50 OwotICAgIFdlYlBhZ2UqIG1fd2ViUGFnZTsKLQotICAgIGJvb2wgbV9tb3VzZURvd25JbkJhbm5l cjsKLSAgICBib29sIG1faXNIaWRkZW47CiAKICNpZiBQTEFURk9STShNQUMpCisgICAgVHlwZSBt X3R5cGUgPSBOb3RTZXQ7CisgICAgV2ViUGFnZSogbV93ZWJQYWdlID0gMDsKKyAgICBib29sIG1f bW91c2VEb3duSW5CYW5uZXIgPSBmYWxzZTsKKyAgICBib29sIG1faXNIaWRkZW4gPSBmYWxzZTsK KwogICAgIFJldGFpblB0cjxDQUxheWVyPiBtX2xheWVyOwogICAgIGludCBtX2hlaWdodDsKICNl bmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9Q YWdlQmFubmVyTWFjLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9Q YWdlQmFubmVyTWFjLm1tCmluZGV4IGIxMDlkOTI0YWFjNDJiMmIyMTg1N2JlZjYxNWZjYmMyNDNm YTQyZGMuLjM4YjkyNDc0OWFlYzEyNDgzNjk3NDI5MzQ1ODBlODY0MTFlYzkyMzMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGFnZUJhbm5lck1hYy5t bQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BhZ2VCYW5uZXJN YWMubW0KQEAgLTI2LDcgKzI2LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJQ YWdlQmFubmVyLmgiCiAKLSNpZiAhUExBVEZPUk0oSU9TKQorI2lmIFBMQVRGT1JNKE1BQykKIAog I2luY2x1ZGUgIldlYlBhZ2UuaCIKICNpbmNsdWRlIDxXZWJDb3JlL0ZyYW1lVmlldy5oPgpAQCAt NDIsMTEgKzQyLDcgQEAgUGFzc1JlZlB0cjxQYWdlQmFubmVyPiBQYWdlQmFubmVyOjpjcmVhdGUo Q0FMYXllciAqbGF5ZXIsIGludCBoZWlnaHQsIENsaWVudCogY2wKIH0KIAogUGFnZUJhbm5lcjo6 UGFnZUJhbm5lcihDQUxheWVyICpsYXllciwgaW50IGhlaWdodCwgQ2xpZW50KiBjbGllbnQpCi0g ICAgOiBtX3R5cGUoTm90U2V0KQotICAgICwgbV9jbGllbnQoY2xpZW50KQotICAgICwgbV93ZWJQ YWdlKDApCi0gICAgLCBtX21vdXNlRG93bkluQmFubmVyKGZhbHNlKQotICAgICwgbV9pc0hpZGRl bihmYWxzZSkKKyAgICA6IG1fY2xpZW50KGNsaWVudCkKICAgICAsIG1fbGF5ZXIobGF5ZXIpCiAg ICAgLCBtX2hlaWdodChoZWlnaHQpCiB7CkBAIC0xNzAsNCArMTY2LDQgQEAgQ0FMYXllciAqUGFn ZUJhbm5lcjo6bGF5ZXIoKQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAotI2VuZGlmIC8vICFQ TEFURk9STShJT1MpCisjZW5kaWYgLy8gUExBVEZPUk0oTUFDKQo=