145922 2015-06-12 04:26:11 -0700 [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp 2015-06-15 06:10:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugzilla.gnome.org/show_bug.cgi?id=750918 P2 Normal --- 145121 1 ossy ossy cgarcia commit-queue mcatanzaro mrobinson ossy zan oldest_to_newest 1101549 0 ossy 2015-06-12 04:26:11 -0700 DerivedSources/webkit2gtk/webkit2/WebKitMarshal.cpp:65:3: warning: 'register' storage class specifier is deprecated [-Wdeprecated-register] register GMarshalFunc_BOOLEAN__BOXED callback; ^~~~~~~~~ DerivedSources/webkit2gtk/webkit2/WebKitMarshal.cpp:66:3: warning: 'register' storage class specifier is deprecated [-Wdeprecated-register] register GCClosure *cc = (GCClosure*) closure; ^~~~~~~~~ ... The problem is that WebKitMarshal.cpp is generated by glib-genmarshal. To fix it properly, we should fix it in upstream or patch the glib jhbuild module. Or we should simply disable this warning for this file only. 1101857 1 mcatanzaro 2015-06-14 09:59:52 -0700 (In reply to comment #0) > To fix it properly, we should fix it in upstream Done. I usually build inside GNOME jhbuild, so the problem is gone for me :) > or patch the glib jhbuild module. Or we should simply disable this warning for this file only. ^ But to fix the issue with WebKit jhbuild, we still need to do one of the above. 1101907 2 254872 ossy 2015-06-15 04:22:02 -0700 Created attachment 254872 Patch Thanks for the quick fix. I prefer adding your upstream patch to the WebKit's jhbuild 1101914 3 254872 commit-queue 2015-06-15 06:10:18 -0700 Comment on attachment 254872 Patch Clearing flags on attachment: 254872 Committed r185550: <http://trac.webkit.org/changeset/185550> 1101915 4 commit-queue 2015-06-15 06:10:22 -0700 All reviewed patches have been landed. Closing bug. 254872 2015-06-15 04:22:02 -0700 2015-06-15 06:10:18 -0700 Patch bug-145922-20150615042127.patch text/plain 3122 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NTQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjFlODkzY2NhNGJlZmRjYzgwYjY1ZWE5ZDQ4YTA3ZGY4 NjdkNTgzOS4uOWYyM2IyMjUzODFmZDI3MGM5ZmJlN2YwYTY0MGNlODE0YTk0NjZjNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTA2LTE1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0dUS10gRml4IGRlcHJlY2F0ZWQtcmVnaXN0ZXIgd2FybmluZyBpbiB0aGUgZ2Vu ZXJhdGVkIFdlYktpdE1hcnNoYWwuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDU5MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGd0ay9qaGJ1aWxkLm1vZHVsZXM6CisgICAgICAgICogZ3RrL3Bh dGNoZXMvZ2xpYi13YXJuaW5nLWZpeC5wYXRjaDogQWRkZWQuCisKIDIwMTUtMDYtMTIgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIHNwcmluZ0xv YWRpbmdIaWdobGlnaHQgdHlwZQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxl cyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggMmU2YmU5ODJkMjcxOTA2YTAzYWNm NjRiY2MyY2I2NmU1NDE1OWI4Ny4uNjEyMTI4ZTBhYjI4ZjdmYmM3YjgxNGY2MmM5YTAwNDc2ZTcw NDFjMCAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9n dGsvamhidWlsZC5tb2R1bGVzCkBAIC0xNzIsNyArMTcyLDkgQEAKICAgICA8YnJhbmNoIG1vZHVs ZT0iL3B1Yi9HTk9NRS9zb3VyY2VzL2dsaWIvMi40MS9nbGliLTIuNDEuMi50YXIueHoiIHZlcnNp b249IjIuNDEuMiIKICAgICAgICAgICAgIHJlcG89ImZ0cC5nbm9tZS5vcmciCiAgICAgICAgICAg ICBoYXNoPSJzaGEyNTY6ZGExZjcyNTg2NTVmMGUxOTZiOTMwNGNiOTUxNTc4NDYzNGYzNzk3NDM3 OTIzZTIzNmJiMzQ2NjM0ODgxMWM5NiIKLSAgICAgICAgICAgIG1kNXN1bT0iOTYzNmY2MGU5OWI5 OGZkMGZkYjUyMzlmOTA1YWMwMDgiLz4KKyAgICAgICAgICAgIG1kNXN1bT0iOTYzNmY2MGU5OWI5 OGZkMGZkYjUyMzlmOTA1YWMwMDgiPgorICAgICAgPHBhdGNoIGZpbGU9ImdsaWItd2FybmluZy1m aXgucGF0Y2giIHN0cmlwPSIxIi8+CisgICAgPC9icmFuY2g+CiAgIDwvYXV0b3Rvb2xzPgogCiAg IDxhdXRvdG9vbHMgaWQ9ImdsaWItbmV0d29ya2luZyI+CmRpZmYgLS1naXQgYS9Ub29scy9ndGsv cGF0Y2hlcy9nbGliLXdhcm5pbmctZml4LnBhdGNoIGIvVG9vbHMvZ3RrL3BhdGNoZXMvZ2xpYi13 YXJuaW5nLWZpeC5wYXRjaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44ZmFmNGQxMWYyY2M1NWE0NDJiMzhjZGQyY2M0 NWZkMzI4OTZlMjNjCi0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvZ3RrL3BhdGNoZXMvZ2xpYi13 YXJuaW5nLWZpeC5wYXRjaApAQCAtMCwwICsxLDM0IEBACitGcm9tIDlmOTBlZTVlZWNjZDQ3ZjM5 YzdhMDNkY2Q3ODZiMTI1YTE5YzE5NWQgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCitGcm9tOiBN aWNoYWVsIENhdGFuemFybyA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CitEYXRlOiBTYXQsIDEzIEp1 biAyMDE1IDIyOjUyOjMzIC0wNTAwCitTdWJqZWN0OiBbUEFUQ0hdIGdlbm1hcnNoYWw6IHNpbGVu Y2UgcmVnaXN0ZXIgc3RvcmFnZSBjbGFzcyB3YXJuaW5ncworCitVc2luZyB0aGUgcmVnaXN0ZXIg a2V5d29yZCB0cmlnZ2VycyB3YXJuaW5ncyBvbiBub3Rld29ydGh5IGNvbXBpbGVycworKGNsYW5n KSwgc2luY2UgaXQncyBkZXByZWNhdGVkIGluIEMrKyBhbmQgYXQgZGFuZ2VyIG9mIGJlaW5nIHJl bW92ZWQKK2Zyb20gdGhlIGxhbmd1YWdlLiBUaGVyZSBpcyBubyByZWFzb24gdG8gdXNlIGl0IHNp bmNlIGl0IGlzbid0IDE5ODAKK2FueW1vcmUuCisKK2h0dHBzOi8vYnVnemlsbGEuZ25vbWUub3Jn L3Nob3dfYnVnLmNnaT9pZD03NTA5MTgKKy0tLQorIGdvYmplY3QvZ2xpYi1nZW5tYXJzaGFsLmMg fCA2ICsrKy0tLQorIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pCisKK2RpZmYgLS1naXQgYS9nb2JqZWN0L2dsaWItZ2VubWFyc2hhbC5jIGIvZ29iamVjdC9n bGliLWdlbm1hcnNoYWwuYworaW5kZXggYmU0MTUxYS4uY2E3OGE2ZiAxMDA2NDQKKy0tLSBhL2dv YmplY3QvZ2xpYi1nZW5tYXJzaGFsLmMKKysrKyBiL2dvYmplY3QvZ2xpYi1nZW5tYXJzaGFsLmMK K0BAIC00MTIsOSArNDEyLDkgQEAgZ2VuZXJhdGVfbWFyc2hhbCAoY29uc3QgZ2NoYXIgKnNpZ25h bWUsCisgICAgICAgZ19mcHJpbnRmIChmb3V0LCAiJXMlcyBkYXRhMik7XG4iLCBpbmRlbnQgKGlu ZCksIHBhZCAoImdwb2ludGVyIikpOworIAorICAgICAgIC8qIGNmaWxlIG1hcnNoYWwgdmFyaWFi bGVzICovCistICAgICAgZ19mcHJpbnRmIChmb3V0LCAiICByZWdpc3RlciBHTWFyc2hhbEZ1bmNf JXMgY2FsbGJhY2s7XG4iLCBzaWduYW1lKTsKKy0gICAgICBnX2ZwcmludGYgKGZvdXQsICIgIHJl Z2lzdGVyIEdDQ2xvc3VyZSAqY2MgPSAoR0NDbG9zdXJlKikgY2xvc3VyZTtcbiIpOworLSAgICAg IGdfZnByaW50ZiAoZm91dCwgIiAgcmVnaXN0ZXIgZ3BvaW50ZXIgZGF0YTEsIGRhdGEyO1xuIik7 CisrICAgICAgZ19mcHJpbnRmIChmb3V0LCAiICBHTWFyc2hhbEZ1bmNfJXMgY2FsbGJhY2s7XG4i LCBzaWduYW1lKTsKKysgICAgICBnX2ZwcmludGYgKGZvdXQsICIgIEdDQ2xvc3VyZSAqY2MgPSAo R0NDbG9zdXJlKikgY2xvc3VyZTtcbiIpOworKyAgICAgIGdfZnByaW50ZiAoZm91dCwgIiAgZ3Bv aW50ZXIgZGF0YTEsIGRhdGEyO1xuIik7CisgICAgICAgaWYgKHNpZy0+cmFyZy0+c2V0dGVyKQor IAlnX2ZwcmludGYgKGZvdXQsICIgICVzIHZfcmV0dXJuO1xuIiwgc2lnLT5yYXJnLT5jdHlwZSk7 CisgCistLSAKKzIuNC4yClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=