145921 2015-06-12 04:22:33 -0700 Fix missing braces and deprecated declarations warnings in WebKitNotificationProvider.cpp 2015-06-18 07:31:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy berto cgarcia commit-queue gustavo mcatanzaro mrobinson ossy oldest_to_newest 1101546 0 ossy 2015-06-12 04:22:33 -0700 ../../Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.cpp:75:9: warning: suggest braces around initialization of subobject [-Wmissing-braces] kWKNotificationProviderCurrentVersion, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.cpp:75:9: warning: 'kWKNotificationProviderCurrentVersion' is deprecated: Use an explicit version number instead [-Wdeprecated-declarations] ../../Source/WebKit2/UIProcess/API/C/WKNotificationProvider.h:61:8: note: 'kWKNotificationProviderCurrentVersion' has been explicitly marked deprecated here enum { kWKNotificationProviderCurrentVersion __attribute__((deprecated("Use an explicit version number instead"))) = 0, }; ^ 2 warnings generated. 1102897 1 255111 ossy 2015-06-18 06:20:00 -0700 Created attachment 255111 Patch 1102898 2 commit-queue 2015-06-18 06:22:53 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1102904 3 255111 commit-queue 2015-06-18 07:14:40 -0700 Comment on attachment 255111 Patch Clearing flags on attachment: 255111 Committed r185700: <http://trac.webkit.org/changeset/185700> 1102905 4 commit-queue 2015-06-18 07:14:45 -0700 All reviewed patches have been landed. Closing bug. 1102913 5 mcatanzaro 2015-06-18 07:31:42 -0700 Got to say, I'm amazed that code was legal.... 255111 2015-06-18 06:20:00 -0700 2015-06-18 07:14:40 -0700 Patch bug-145921-20150618061922.patch text/plain 1593 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1Njk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTAxNzVjMDI1YTc0NTU4 Nzk5YjNhNTM5ZjBkMmY1YzUyNzZiMmFmZS4uM2I5MmJlYWY3YzM4MTcwZTMyOGRlZGQzZDBjNzEz NjE5MWNlZTcxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA2LTE4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IG1pc3Npbmcg YnJhY2VzIGFuZCBkZXByZWNhdGVkIGRlY2xhcmF0aW9ucyB3YXJuaW5ncyBpbiBXZWJLaXROb3Rp ZmljYXRpb25Qcm92aWRlci5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NTkyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0Tm90aWZpY2F0aW9uUHJvdmlk ZXIuY3BwOgorICAgICAgICAoV2ViS2l0Tm90aWZpY2F0aW9uUHJvdmlkZXI6OldlYktpdE5vdGlm aWNhdGlvblByb3ZpZGVyKToKKwogMjAxNS0wNi0xOCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcu a2ltQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gdGVzdF9ld2syX2NvbnRleHQgaGFzIGJl ZW4gZmFpbGVkIHNpbmNlIHIxODU1MjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdE5vdGlmaWNhdGlvblByb3ZpZGVyLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdE5vdGlmaWNhdGlvblByb3ZpZGVyLmNwcAppbmRl eCA3NTc1ZGZlODk0MmEyMmE4MTBkOGEyZDY1MTM0ZWU4YmQwNDRmMzM1Li4wMWRjMjk3ZTFhZGFl NGYzNmFlMGY4NDY1ZjhiMWViYzZlZjg1YTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXROb3RpZmljYXRpb25Qcm92aWRlci5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0Tm90aWZpY2F0aW9uUHJvdmlkZXIu Y3BwCkBAIC03Miw4ICs3MiwxMCBAQCBXZWJLaXROb3RpZmljYXRpb25Qcm92aWRlcjo6V2ViS2l0 Tm90aWZpY2F0aW9uUHJvdmlkZXIoV2ViTm90aWZpY2F0aW9uTWFuYWdlclBybwogICAgIEFTU0VS VChub3RpZmljYXRpb25NYW5hZ2VyKTsKIAogICAgIFdLTm90aWZpY2F0aW9uUHJvdmlkZXJWMCB3 a05vdGlmaWNhdGlvblByb3ZpZGVyID0gewotICAgICAgICBrV0tOb3RpZmljYXRpb25Qcm92aWRl ckN1cnJlbnRWZXJzaW9uLAotICAgICAgICB0aGlzLCAvLyBjbGllbnRJbmZvLAorICAgICAgICB7 CisgICAgICAgICAgICAwLCAvLyB2ZXJzaW9uCisgICAgICAgICAgICB0aGlzLCAvLyBjbGllbnRJ bmZvCisgICAgICAgIH0sCiAgICAgICAgIHNob3dDYWxsYmFjaywKICAgICAgICAgY2FuY2VsQ2Fs bGJhY2ssCiAgICAgICAgIDAsIC8vIGRpZERlc3Ryb3lOb3RpZmljYXRpb25DYWxsYmFjaywK