145920 2015-06-12 04:16:15 -0700 Fix overloaded virtual function warning in ScrollbarThemeGtk.h 2015-07-10 10:39:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy cgarcia clopez commit-queue ossy zan oldest_to_newest 1101542 0 ossy 2015-06-12 04:16:15 -0700 In file included from ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:27: ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:48:13: warning: 'WebCore::ScrollbarThemeGtk::thumbRect' hides overloaded virtual function [-Woverloaded-virtual] IntRect thumbRect(ScrollbarThemeClient*, const IntRect& unconstrainedTrackRect); ^ ../../Source/WebCore/platform/ScrollbarThemeComposite.h:58:21: note: hidden overloaded virtual function 'WebCore::ScrollbarThemeComposite::thumbRect' declared here: different number of parameters (1 vs 2) virtual IntRect thumbRect(ScrollbarThemeClient*); ^ 1 warning generated. 1108610 1 256580 ossy 2015-07-10 07:43:52 -0700 Created attachment 256580 Patch Now the thumbRect of the baseclass isn't used (it would be compile error), but the easiest way to fix this warning is to unhide it for the compiler with an explicit using. 1108660 2 256580 commit-queue 2015-07-10 10:39:24 -0700 Comment on attachment 256580 Patch Clearing flags on attachment: 256580 Committed r186680: <http://trac.webkit.org/changeset/186680> 1108661 3 commit-queue 2015-07-10 10:39:28 -0700 All reviewed patches have been landed. Closing bug. 256580 2015-07-10 07:43:52 -0700 2015-07-10 10:39:24 -0700 Patch bug-145920-20150710074249.patch text/plain 1301 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQ2ZTMxMjRkN2FiNzhm Y2YwYTU4OWRkNGU2MzZkNTU2NzNmNjRhMS4uNTIxMTUzNzNiZTMyNDQyM2RhNjMzZmYzZWM1MTI0 ZWZkYjM0ZThhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA3LTEwICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IG92ZXJsb2Fk ZWQgdmlydHVhbCBmdW5jdGlvbiB3YXJuaW5nIGluIFNjcm9sbGJhclRoZW1lR3RrLmgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTkyMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1Njcm9sbGJhclRoZW1lR3RrLmg6CisKIDIwMTUtMDctMDkgIFphbGFuIEJ1anRhcyAgPHphbGFu QGFwcGxlLmNvbT4KIAogICAgICAgICBQbHVnaW4gY3JlYXRlIGNhbiBlbmQgdXAgZGVzdHJveWlu ZyBpdHMgcmVuZGVyZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv U2Nyb2xsYmFyVGhlbWVHdGsuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxi YXJUaGVtZUd0ay5oCmluZGV4IDVlOWI0YzdmMGNhMTE3OGE3ZTcwZGY1MTc0ODBjYTYzMDQ4NTcz NmUuLjdlODJjYTcxNTdhZjZlOTI4OGRkZTZmYWI1Y2I0NzkyNWRiMjJmZDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5oCkBAIC00NSw2ICs0 NSw3IEBAIHB1YmxpYzoKICNpZm5kZWYgR1RLX0FQSV9WRVJTSU9OXzIKICAgICBTY3JvbGxiYXJU aGVtZUd0aygpOwogCisgICAgdXNpbmcgU2Nyb2xsYmFyVGhlbWVDb21wb3NpdGU6OnRodW1iUmVj dDsKICAgICBJbnRSZWN0IHRodW1iUmVjdChTY3JvbGxiYXImLCBjb25zdCBJbnRSZWN0JiB1bmNv bnN0cmFpbmVkVHJhY2tSZWN0KTsKICAgICBib29sIHBhaW50KFNjcm9sbGJhciYsIEdyYXBoaWNz Q29udGV4dCYsIGNvbnN0IEludFJlY3QmIGRhbWFnZVJlY3QpOwogICAgIHZvaWQgcGFpbnRTY3Jv bGxiYXJCYWNrZ3JvdW5kKEdyYXBoaWNzQ29udGV4dCYsIFNjcm9sbGJhciYpOwo=