145904 2015-06-11 18:25:49 -0700 DFG Object Allocation Sinking should not consider GetClosureVar as escapes 2015-06-12 09:34:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 basile_clement basile_clement commit-queue fpizlo ggaren mark.lam msaboff oldest_to_newest 1101467 0 basile_clement 2015-06-11 18:25:49 -0700 DFG Object Allocation Sinking should not consider GetClosureVar as escapes 1101470 1 254774 basile_clement 2015-06-11 18:39:06 -0700 Created attachment 254774 Patch 1101591 2 254803 basile_clement 2015-06-12 08:39:49 -0700 Created attachment 254803 Patch for landing 1101605 3 254803 commit-queue 2015-06-12 09:34:13 -0700 Comment on attachment 254803 Patch for landing Clearing flags on attachment: 254803 Committed r185505: <http://trac.webkit.org/changeset/185505> 1101606 4 commit-queue 2015-06-12 09:34:18 -0700 All reviewed patches have been landed. Closing bug. 254774 2015-06-11 18:39:06 -0700 2015-06-12 08:39:45 -0700 Patch bug-145904-20150611183837.patch text/plain 2787 basile_clement U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ODU1YTE3YmJkNzg4MzY1NTE0ZDhiYTg1NTVjZmY0MWNkOWE1NmFhLi45MjJiYjg2NjZlOTY5NDhm YWYzZDFkMjk0ZTM4MWJhYTI3NzdkODFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNS0wNi0xMSAgQmFzaWxlIENsZW1lbnQgIDxiYXNpbGVfY2xlbWVudEBh cHBsZS5jb20+CisKKyAgICAgICAgREZHIE9iamVjdCBBbGxvY2F0aW9uIFNpbmtpbmcgc2hvdWxk IG5vdCBjb25zaWRlciBHZXRDbG9zdXJlVmFyIGFzIGVzY2FwZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTkwNAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBvYmplY3QgYWxsb2NhdGlvbiBzaW5r aW5nIHBoYXNlIGlzIGN1cnJlbnRseSBhYmxlIHRvIHNpbmsKKyAgICAgICAgQ3JlYXRlQWN0aXZh dGlvbiBub2RlcywgYnV0IHdpbGwgY29uc2lkZXIgYW55IEdldENsb3N1cmVWYXIgbm9kZSBhcwor ICAgICAgICBlc2NhcGluZy4KKworICAgICAgICBUaGlzIGlzIG5vdCBwcm9ibGVtYXRpYyBpbiBn ZW5lcmFsIGFzIG1vc3Qgb2YgdGhlIEdldENsb3N1cmVWYXIgbm9kZXMKKyAgICAgICAgd2Ugd291 bGQgaGF2ZSBiZWVuIGFibGUgdG8gc2luayBvdmVyIHdpbGwgaGF2ZSBiZWVuIGVsaW1pbmF0ZWQg YnkgQ1NFCisgICAgICAgIGFueXdheS4gU3RpbGwsIHRoaXMgaXMgYW4gb3ZlcnNpZ2h0IHRoYXQg d2Ugc2hvdWxkIGZpeCBzaW5jZSB0aGUKKyAgICAgICAgbWFjaGluZXJ5IGlzIGFscmVhZHkgaW4g cGxhY2UuCisKKyAgICAgICAgKiBkZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5j cHA6CisgICAgICAgIChKU0M6OkRGRzo6T2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZTo6aGFu ZGxlTm9kZSk6CisgICAgICAgICogZGZnL0RGR1Byb21vdGVIZWFwQWNjZXNzLmg6CisgICAgICAg IChKU0M6OkRGRzo6cHJvbW90ZUhlYXBBY2Nlc3MpOgorCiAyMDE1LTA2LTExICBDb21taXQgUXVl dWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByMTg1NDY1LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHAKaW5kZXggNTg0ZTE2MDY1 MDQ2YmRlNTYwNDk1ODNlOGE3N2I0YTBhYmVjM2FhOC4uMDQwZDU3ODFkZTI1MmNlMWVhY2YxN2Nk ZDk3MTk4ZjRhZmI1MDU5MiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCkBAIC05MDAsNiAr OTAwLDEzIEBAIHByaXZhdGU6CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCisgICAg ICAgIGNhc2UgR2V0Q2xvc3VyZVZhcjogeworICAgICAgICAgICAgTm9kZSogdGFyZ2V0ID0gbm9k ZS0+Y2hpbGQxKCkubm9kZSgpOworICAgICAgICAgICAgaWYgKCF0YXJnZXQtPmlzQWN0aXZhdGlv bkFsbG9jYXRpb24oKSkKKyAgICAgICAgICAgICAgICBlc2NhcGUodGFyZ2V0KTsKKyAgICAgICAg ICAgIGJyZWFrOworICAgICAgICB9CisKICAgICAgICAgY2FzZSBQdXRDbG9zdXJlVmFyOiB7CiAg ICAgICAgICAgICBOb2RlKiB0YXJnZXQgPSBub2RlLT5jaGlsZDEoKS5ub2RlKCk7CiAgICAgICAg ICAgICBpZiAoIXRhcmdldC0+aXNBY3RpdmF0aW9uQWxsb2NhdGlvbigpKQpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQcm9tb3RlSGVhcEFjY2Vzcy5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQcm9tb3RlSGVhcEFjY2Vzcy5oCmluZGV4IDY0NTc4NGUw YzllZTc1MTgzNGU1YWY5NmYwYzliMjg5NjA5Mzk3NDguLjAxOGMzYjE3NDk3N2Y3N2U3MmFmNGRl ZTE5OWRlMDZmNWRiMGNlMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHUHJvbW90ZUhlYXBBY2Nlc3MuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1Byb21vdGVIZWFwQWNjZXNzLmgKQEAgLTU5LDYgKzU5LDExIEBAIHZvaWQgcHJvbW90ZUhlYXBB Y2Nlc3MoTm9kZSogbm9kZSwgY29uc3QgV3JpdGVGdW5jdG9yJiB3cml0ZSwgY29uc3QgUmVhZEZ1 bmN0b3ImCiAgICAgICAgIH0KICAgICAgICAgYnJlYWs7CiAgICAgfQorCisgICAgY2FzZSBHZXRD bG9zdXJlVmFyOgorICAgICAgICBpZiAobm9kZS0+Y2hpbGQxKCktPmlzUGhhbnRvbUFjdGl2YXRp b25BbGxvY2F0aW9uKCkpCisgICAgICAgICAgICByZWFkKFByb21vdGVkSGVhcExvY2F0aW9uKENs b3N1cmVWYXJQTG9jLCBub2RlLT5jaGlsZDEoKSwgbm9kZS0+c2NvcGVPZmZzZXQoKS5vZmZzZXQo KSkpOworICAgICAgICBicmVhazsKICAgICAgICAgCiAgICAgY2FzZSBQdXRIaW50OiB7CiAgICAg ICAgIEFTU0VSVChub2RlLT5jaGlsZDEoKS0+aXNQaGFudG9tQWxsb2NhdGlvbigpKTsK 254803 2015-06-12 08:39:49 -0700 2015-06-12 09:34:13 -0700 Patch for landing bug-145904-20150612083918.patch text/plain 2849 basile_clement U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw NzA1YmMxZDVhMTY0MjU0MzdiNDQyMWI1ODYwYTFhZjk0YTk4ZTY0Li5jNDgwYTIxZjdjM2Y2Njk4 MDY5OTAzYmVjYzlmMTY1YzY5OTNhY2ZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNS0wNi0xMiAgQmFzaWxlIENsZW1lbnQgIDxiYXNpbGVfY2xlbWVudEBh cHBsZS5jb20+CisKKyAgICAgICAgREZHIE9iamVjdCBBbGxvY2F0aW9uIFNpbmtpbmcgc2hvdWxk IG5vdCBjb25zaWRlciBHZXRDbG9zdXJlVmFyIGFzIGVzY2FwZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTkwNAorCisgICAgICAgIFJldmlld2Vk IGJ5IEZpbGlwIFBpemxvLgorCisgICAgICAgIFRoZSBvYmplY3QgYWxsb2NhdGlvbiBzaW5raW5n IHBoYXNlIGlzIGN1cnJlbnRseSBhYmxlIHRvIHNpbmsKKyAgICAgICAgQ3JlYXRlQWN0aXZhdGlv biBub2RlcywgYnV0IHdpbGwgY29uc2lkZXIgYW55IEdldENsb3N1cmVWYXIgbm9kZSBhcworICAg ICAgICBlc2NhcGluZy4KKworICAgICAgICBUaGlzIGlzIG5vdCBwcm9ibGVtYXRpYyBpbiBnZW5l cmFsIGFzIG1vc3Qgb2YgdGhlIEdldENsb3N1cmVWYXIgbm9kZXMKKyAgICAgICAgd2Ugd291bGQg aGF2ZSBiZWVuIGFibGUgdG8gc2luayBvdmVyIHdpbGwgaGF2ZSBiZWVuIGVsaW1pbmF0ZWQgYnkg Q1NFCisgICAgICAgIGFueXdheS4gU3RpbGwsIHRoaXMgaXMgYW4gb3ZlcnNpZ2h0IHRoYXQgd2Ug c2hvdWxkIGZpeCBzaW5jZSB0aGUKKyAgICAgICAgbWFjaGluZXJ5IGlzIGFscmVhZHkgaW4gcGxh Y2UuCisKKyAgICAgICAgKiBkZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHA6 CisgICAgICAgIChKU0M6OkRGRzo6T2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZTo6aGFuZGxl Tm9kZSk6CisgICAgICAgICogZGZnL0RGR1Byb21vdGVIZWFwQWNjZXNzLmg6CisgICAgICAgIChK U0M6OkRGRzo6cHJvbW90ZUhlYXBBY2Nlc3MpOgorCiAyMDE1LTA2LTExICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJDb3JlOjpyZXBvcnRFeGNlcHRpb24oKSBu ZWVkcyB0byBiZSBhYmxlIHRvIGFjY2VwdCBhIHJhdyB0aHJvd24gdmFsdWUgaW4gYWRkaXRpb24g dG8gRXhjZXB0aW9uIG9iamVjdHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcAppbmRleCA1ODRl MTYwNjUwNDZiZGU1NjA0OTU4M2U4YTc3YjRhMGFiZWMzYWE4Li4wNDBkNTc4MWRlMjUyY2UxZWFj ZjE3Y2RkOTcxOThmNGFmYjUwNTkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHAKQEAgLTkw MCw2ICs5MDAsMTMgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAK KyAgICAgICAgY2FzZSBHZXRDbG9zdXJlVmFyOiB7CisgICAgICAgICAgICBOb2RlKiB0YXJnZXQg PSBub2RlLT5jaGlsZDEoKS5ub2RlKCk7CisgICAgICAgICAgICBpZiAoIXRhcmdldC0+aXNBY3Rp dmF0aW9uQWxsb2NhdGlvbigpKQorICAgICAgICAgICAgICAgIGVzY2FwZSh0YXJnZXQpOworICAg ICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKwogICAgICAgICBjYXNlIFB1dENsb3N1cmVWYXI6 IHsKICAgICAgICAgICAgIE5vZGUqIHRhcmdldCA9IG5vZGUtPmNoaWxkMSgpLm5vZGUoKTsKICAg ICAgICAgICAgIGlmICghdGFyZ2V0LT5pc0FjdGl2YXRpb25BbGxvY2F0aW9uKCkpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Byb21vdGVIZWFwQWNjZXNzLmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Byb21vdGVIZWFwQWNjZXNzLmgKaW5kZXggNjQ1 Nzg0ZTBjOWVlNzUxODM0ZTVhZjk2ZjBjOWIyODk2MDkzOTc0OC4uMDE4YzNiMTc0OTc3Zjc3ZTcy YWY0ZGVlMTk5ZGUwNmY1ZGIwY2UyYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdQcm9tb3RlSGVhcEFjY2Vzcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHUHJvbW90ZUhlYXBBY2Nlc3MuaApAQCAtNTksNiArNTksMTEgQEAgdm9pZCBwcm9tb3Rl SGVhcEFjY2VzcyhOb2RlKiBub2RlLCBjb25zdCBXcml0ZUZ1bmN0b3ImIHdyaXRlLCBjb25zdCBS ZWFkRnVuY3RvciYKICAgICAgICAgfQogICAgICAgICBicmVhazsKICAgICB9CisKKyAgICBjYXNl IEdldENsb3N1cmVWYXI6CisgICAgICAgIGlmIChub2RlLT5jaGlsZDEoKS0+aXNQaGFudG9tQWN0 aXZhdGlvbkFsbG9jYXRpb24oKSkKKyAgICAgICAgICAgIHJlYWQoUHJvbW90ZWRIZWFwTG9jYXRp b24oQ2xvc3VyZVZhclBMb2MsIG5vZGUtPmNoaWxkMSgpLCBub2RlLT5zY29wZU9mZnNldCgpLm9m ZnNldCgpKSk7CisgICAgICAgIGJyZWFrOwogICAgICAgICAKICAgICBjYXNlIFB1dEhpbnQ6IHsK ICAgICAgICAgQVNTRVJUKG5vZGUtPmNoaWxkMSgpLT5pc1BoYW50b21BbGxvY2F0aW9uKCkpOwo=