145901 2015-06-11 16:43:02 -0700 [WK2] Add allowsPictureInPictureMediaPlayback 2015-06-15 11:07:41 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 145825 1 jonlee jonlee andersca eric.carlson jeremyj-wk webkit-bug-importer oldest_to_newest 1101445 0 jonlee 2015-06-11 16:43:02 -0700 Add allowsPictureInPictureMediaPlayback 1101446 1 webkit-bug-importer 2015-06-11 16:43:24 -0700 <rdar://problem/21349851> 1101449 2 254769 jonlee 2015-06-11 16:57:35 -0700 Created attachment 254769 Patch 1101642 3 254769 andersca 2015-06-12 10:41:47 -0700 Comment on attachment 254769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254769&action=review This needs to go through internal API review (unless it already has). > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-327 > -#if PLATFORM(IOS) > -- (BOOL)_allowsAlternateFullscreen > -{ > - return _allowsAlternateFullscreen; > -} > - > -- (void)_setAllowsAlternateFullscreen:(BOOL)allowed > -{ > - _allowsAlternateFullscreen = allowed; > -} > -#endif > - We probably need to keep these for now (and just have them call the SPI methods) so we won't break iOS Safari. 1101713 4 254769 jonlee 2015-06-12 15:19:05 -0700 Comment on attachment 254769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254769&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-327 >> - > > We probably need to keep these for now (and just have them call the SPI methods) so we won't break iOS Safari. As far as I can tell, no client calls this SPI, including iOS Safari. So I plan on removing it. 1101715 5 jonlee 2015-06-12 15:19:30 -0700 (In reply to comment #3) > Comment on attachment 254769 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254769&action=review > > This needs to go through internal API review (unless it already has). It already has. No objections :) 1101973 6 jonlee 2015-06-15 11:07:41 -0700 Committed r185556: <http://trac.webkit.org/changeset/185556> 254769 2015-06-11 16:57:35 -0700 2015-06-12 10:41:47 -0700 Patch bug-145901-20150611165705.patch text/plain 6001 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTdmZmQ0Yjk3YmI5OGRj MjZjZjdlZTE4YWM5ZTc2NmFhYmQwYzgzNS4uNWJlNjQ2MDMyNWExZTZiMjJjYTk4ZGM0NTFhYTYx OTg3Yjk0ZDgxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE1LTA2LTExICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAorICAgICAgICBbV0syXSBBZGQgYWxsb3dzUGljdHVy ZUluUGljdHVyZU1lZGlhUGxheWJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NTkwMQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMTM0OTg1MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2Ug X2FsbG93c0FsdGVybmF0ZUZ1bGxzY3JlZW4gd2l0aCBhbGxvd3NQaWN0dXJlSW5QaWN0dXJlTWVk aWFQbGF5YmFjay4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29u ZmlndXJhdGlvbi5oOiBBZGQgYWxsb3dzUGljdHVyZUluUGljdHVyZU1lZGlhUGxheWJhY2suCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9uLm1tOgor ICAgICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIGluaXRdKTogUmVtb3ZlIF9hbGxvd3NB bHRlcm5hdGVGdWxsc2NyZWVuLgorICAgICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIGNv cHlXaXRoWm9uZTpdKTogUmVwbGFjZSB0aGUgdmFyaWFibGUuCisgICAgICAgICgtW1dLV2ViVmll d0NvbmZpZ3VyYXRpb24gX2FsbG93c0FsdGVybmF0ZUZ1bGxzY3JlZW5dKTogRGVsZXRlZC4KKyAg ICAgICAgKC1bV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBfc2V0QWxsb3dzQWx0ZXJuYXRlRnVsbHNj cmVlbjpdKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll d0NvbmZpZ3VyYXRpb25Qcml2YXRlLmg6IFJlbW92ZSB0aGUgU1BJLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBpbml0 V2l0aEZyYW1lOmNvbmZpZ3VyYXRpb246XSk6IFVwZGF0ZSB0byB1c2UgdGhlIG5ldyBBUEkuCisK KzIwMTUtMDYtMTEgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgorCiAgICAgICAgIFVwZGF0 ZSBtZWRpYSBjb250cm9scyBKUyBhbmQgQ1NTIHRvIHVzZSBwaWN0dXJlLWluLXBpY3R1cmUKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTgyNwogICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjEzMTE1NzY+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IDljYzc5MjgzMDI5MGM2ZGQyMDFjMTgz ZDQ2ZTYzZDVhYjM0NzkzOTIuLjRjMTAyYmVhNDljOTk1ZDhiODU3ZDIzY2E3NjE4ZGRmMzg0MjQ1 NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Lm1tCkBAIC0zMjEsNyArMzIxLDcgQEAgc3RhdGljIGJvb2wgc2hvdWxkQWxsb3dBbHRlcm5hdGVG dWxsc2NyZWVuKCkKIAogI2lmIFBMQVRGT1JNKElPUykKICAgICB3ZWJQYWdlQ29uZmlndXJhdGlv bi5wcmVmZXJlbmNlVmFsdWVzLnNldChXZWJLaXQ6OldlYlByZWZlcmVuY2VzS2V5OjphbGxvd3NJ bmxpbmVNZWRpYVBsYXliYWNrS2V5KCksIFdlYktpdDo6V2ViUHJlZmVyZW5jZXNTdG9yZTo6VmFs dWUoISFbX2NvbmZpZ3VyYXRpb24gYWxsb3dzSW5saW5lTWVkaWFQbGF5YmFja10pKTsKLSAgICB3 ZWJQYWdlQ29uZmlndXJhdGlvbi5wcmVmZXJlbmNlVmFsdWVzLnNldChXZWJLaXQ6OldlYlByZWZl cmVuY2VzS2V5OjphbGxvd3NBbHRlcm5hdGVGdWxsc2NyZWVuS2V5KCksIFdlYktpdDo6V2ViUHJl ZmVyZW5jZXNTdG9yZTo6VmFsdWUoISFbX2NvbmZpZ3VyYXRpb24gX2FsbG93c0FsdGVybmF0ZUZ1 bGxzY3JlZW5dICYmIHNob3VsZEFsbG93QWx0ZXJuYXRlRnVsbHNjcmVlbigpKSk7CisgICAgd2Vi UGFnZUNvbmZpZ3VyYXRpb24ucHJlZmVyZW5jZVZhbHVlcy5zZXQoV2ViS2l0OjpXZWJQcmVmZXJl bmNlc0tleTo6YWxsb3dzQWx0ZXJuYXRlRnVsbHNjcmVlbktleSgpLCBXZWJLaXQ6OldlYlByZWZl cmVuY2VzU3RvcmU6OlZhbHVlKCEhW19jb25maWd1cmF0aW9uIGFsbG93c1BpY3R1cmVJblBpY3R1 cmVNZWRpYVBsYXliYWNrXSAmJiBzaG91bGRBbGxvd0FsdGVybmF0ZUZ1bGxzY3JlZW4oKSkpOwog ICAgIHdlYlBhZ2VDb25maWd1cmF0aW9uLnByZWZlcmVuY2VWYWx1ZXMuc2V0KFdlYktpdDo6V2Vi UHJlZmVyZW5jZXNLZXk6OnJlcXVpcmVzVXNlckdlc3R1cmVGb3JNZWRpYVBsYXliYWNrS2V5KCks IFdlYktpdDo6V2ViUHJlZmVyZW5jZXNTdG9yZTo6VmFsdWUoISFbX2NvbmZpZ3VyYXRpb24gcmVx dWlyZXNVc2VyQWN0aW9uRm9yTWVkaWFQbGF5YmFja10pKTsKICNlbmRpZgogI2lmIEVOQUJMRShX SVJFTEVTU19QTEFZQkFDS19UQVJHRVQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24uaCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5oCmluZGV4IDJjNDE0 ZmFjNDA0NDU3MTg3NGIwOTllYzI1NGJiYzg3N2RhOTA1ZjguLmY1MWZlYWE4ZGY3NGUyYmY3YTg4 OTI5ZTE1ZTFiY2MzZWQ1NGQ2ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5oCkBAIC0xMTMsNiAr MTEzLDEyIEBAIFdLX0NMQVNTX0FWQUlMQUJMRSgxMF8xMCwgOF8wKQogICovCiBAcHJvcGVydHkg KG5vbmF0b21pYykgV0tTZWxlY3Rpb25HcmFudWxhcml0eSBzZWxlY3Rpb25HcmFudWxhcml0eTsK IAorLyohIEBhYnN0cmFjdCBBIEJvb2xlYW4gdmFsdWUgaW5kaWNhdGluZyB3aGV0aGVyIEhUTUw1 IHZpZGVvcyBtYXkgcGxheQorIHBpY3R1cmUtaW4tcGljdHVyZS4KKyBAZGlzY3Vzc2lvbiBUaGUg ZGVmYXVsdCB2YWx1ZSBpcyBZRVMuCisgKi8KK0Bwcm9wZXJ0eSAobm9uYXRvbWljKSBCT09MIGFs bG93c1BpY3R1cmVJblBpY3R1cmVNZWRpYVBsYXliYWNrIFdLX0FWQUlMQUJMRShOQSwgV0tfSU9T X1RCQSk7CisKICNlbmRpZgogCiBAZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW0gYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW0KaW5kZXggYjU3 NzJhMzI3YTdhNjJlNDUwZWE2MGEwNjNmN2JlMWUwNWVlYTg0Yi4uNDc2NWNkMjk3MmYwZmJjZDdk ZmM1YjliMTQ1Yjk4MDU0NTg3YTM0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQpAQCAtOTMs NyArOTMsNiBAQCBwcml2YXRlOgogCiAjaWYgUExBVEZPUk0oSU9TKQogICAgIExhenlJbml0aWFs aXplZDxSZXRhaW5QdHI8V0tXZWJWaWV3Q29udGVudFByb3ZpZGVyUmVnaXN0cnk+PiBfY29udGVu dFByb3ZpZGVyUmVnaXN0cnk7Ci0gICAgQk9PTCBfYWxsb3dzQWx0ZXJuYXRlRnVsbHNjcmVlbjsK ICNlbmRpZgogfQogCkBAIC0xMDQsOCArMTAzLDkgQEAgcHJpdmF0ZToKICAgICAKICNpZiBQTEFU Rk9STShJT1MpCiAgICAgX3JlcXVpcmVzVXNlckFjdGlvbkZvck1lZGlhUGxheWJhY2sgPSBZRVM7 Ci0gICAgX2FsbG93c0FsdGVybmF0ZUZ1bGxzY3JlZW4gPSBZRVM7CisgICAgX2FsbG93c1BpY3R1 cmVJblBpY3R1cmVNZWRpYVBsYXliYWNrID0gWUVTOwogI2VuZGlmCisKICNpZiBFTkFCTEUoV0lS RUxFU1NfVEFSR0VUX1BMQVlCQUNLKQogICAgIF9hbGxvd3NBaXJQbGF5Rm9yTWVkaWFQbGF5YmFj ayA9IFlFUzsKICNlbmRpZgpAQCAtMTM5LDcgKzEzOSw3IEBAIHByaXZhdGU6CiAKICNpZiBQTEFU Rk9STShJT1MpCiAgICAgY29uZmlndXJhdGlvbi0+X2FsbG93c0lubGluZU1lZGlhUGxheWJhY2sg PSBzZWxmLT5fYWxsb3dzSW5saW5lTWVkaWFQbGF5YmFjazsKLSAgICBjb25maWd1cmF0aW9uLT5f YWxsb3dzQWx0ZXJuYXRlRnVsbHNjcmVlbiA9IHNlbGYtPl9hbGxvd3NBbHRlcm5hdGVGdWxsc2Ny ZWVuOworICAgIGNvbmZpZ3VyYXRpb24tPl9hbGxvd3NQaWN0dXJlSW5QaWN0dXJlTWVkaWFQbGF5 YmFjayA9IHNlbGYtPl9hbGxvd3NQaWN0dXJlSW5QaWN0dXJlTWVkaWFQbGF5YmFjazsKICAgICBj b25maWd1cmF0aW9uLT5fcmVxdWlyZXNVc2VyQWN0aW9uRm9yTWVkaWFQbGF5YmFjayA9IHNlbGYt Pl9yZXF1aXJlc1VzZXJBY3Rpb25Gb3JNZWRpYVBsYXliYWNrOwogICAgIGNvbmZpZ3VyYXRpb24t Pl9zZWxlY3Rpb25HcmFudWxhcml0eSA9IHNlbGYtPl9zZWxlY3Rpb25HcmFudWxhcml0eTsKICNl bmRpZgpAQCAtMzEzLDE4ICszMTMsNiBAQCBzdGF0aWMgTlNTdHJpbmcgKmRlZmF1bHRBcHBsaWNh dGlvbk5hbWVGb3JVc2VyQWdlbnQoKQogICAgIF90cmVhdHNTSEExU2lnbmVkQ2VydGlmaWNhdGVz QXNJbnNlY3VyZSA9IGluc2VjdXJlOwogfQogCi0jaWYgUExBVEZPUk0oSU9TKQotLSAoQk9PTClf YWxsb3dzQWx0ZXJuYXRlRnVsbHNjcmVlbgotewotICAgIHJldHVybiBfYWxsb3dzQWx0ZXJuYXRl RnVsbHNjcmVlbjsKLX0KLQotLSAodm9pZClfc2V0QWxsb3dzQWx0ZXJuYXRlRnVsbHNjcmVlbjoo Qk9PTClhbGxvd2VkCi17Ci0gICAgX2FsbG93c0FsdGVybmF0ZUZ1bGxzY3JlZW4gPSBhbGxvd2Vk OwotfQotI2VuZGlmCi0KIEBlbmQKIAogQGltcGxlbWVudGF0aW9uIFdLV2ViVmlld0NvbmZpZ3Vy YXRpb24gKFdLRGVwcmVjYXRlZCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvblByaXZhdGUuaCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvblByaXZhdGUuaApp bmRleCA0NTFlZTE4ODZiZmQyZWFlOTE3Y2VjMmQ4YThmMmNlYzZmYzAzNDdmLi5mZTM0ZmQwNWY4 OGE1YWIyM2JiZGMxMjRjZjlmZGQ4ODk5MjU5N2ExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb25Qcml2YXRlLmgKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0 aW9uUHJpdmF0ZS5oCkBAIC00NCwxMCArNDQsNiBAQAogCiBAcHJvcGVydHkgKG5vbmF0b21pYywg c2V0dGVyPV9zZXRUcmVhdHNTSEExU2lnbmVkQ2VydGlmaWNhdGVzQXNJbnNlY3VyZTopIEJPT0wg X3RyZWF0c1NIQTFTaWduZWRDZXJ0aWZpY2F0ZXNBc0luc2VjdXJlIFdLX0FWQUlMQUJMRShOQSwg V0tfSU9TX1RCQSk7CiAKLSNpZiBUQVJHRVRfT1NfSVBIT05FCi1AcHJvcGVydHkgKG5vbmF0b21p Yywgc2V0dGVyPV9zZXRBbGxvd3NBbHRlcm5hdGVGdWxsc2NyZWVuOikgQk9PTCBfYWxsb3dzQWx0 ZXJuYXRlRnVsbHNjcmVlbiBXS19BVkFJTEFCTEUoTkEsIFdLX0lPU19UQkEpOwotI2VuZGlmCi0K IEBlbmQKIAogI2VuZGlmCg==