145898 2015-06-11 14:25:56 -0700 Web Inspector: CRASH trying to inspect text that was removed/replaced 2015-06-12 09:49:39 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1101415 0 joepeck 2015-06-11 14:25:56 -0700 * SUMMARY Trying to inspect an element via the Context Menu but that element is removed causes a crash. * TEST <body> <script> var i = 0; var box = document.body.appendChild(document.createElement("p")); var span = box.appendChild(document.createElement("span")); setInterval(function() { span.textContent = (i++) + " seconds"; }, 500); </script> * STEPS TO REPRODUCE 1. Load test 2. Right click the "N seconds" text and wait a second for it to change 3. Select "Inspect Element" => CRASH * NOTES - We assume the focus node is in the document, but it may not be by the time Inspect Element is triggered. 1101416 1 joepeck 2015-06-11 14:26:25 -0700 <rdar://problem/18921081> 1101417 2 254758 joepeck 2015-06-11 14:28:46 -0700 Created attachment 254758 [PATCH] Proposed Fix 1101615 3 254758 commit-queue 2015-06-12 09:49:34 -0700 Comment on attachment 254758 [PATCH] Proposed Fix Clearing flags on attachment: 254758 Committed r185507: <http://trac.webkit.org/changeset/185507> 1101616 4 commit-queue 2015-06-12 09:49:39 -0700 All reviewed patches have been landed. Closing bug. 254758 2015-06-11 14:28:46 -0700 2015-06-12 09:49:34 -0700 [PATCH] Proposed Fix fix-crash.patch text/plain 1883 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlN2Y2ZGE3Li41MTYzNTU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTUtMDYtMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBDUkFTSCB0cnlpbmcgdG8gaW5zcGVjdCB0ZXh0IHRoYXQg d2FzIHJlbW92ZWQvcmVwbGFjZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NTg5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Okluc3BlY3RvckRPTUFnZW50OjppbnNwZWN0KToKKyAgICAgICAgKFdlYkNvcmU6 Okluc3BlY3RvckRPTUFnZW50Ojpmb2N1c05vZGUpOgorICAgICAgICBFbnN1cmUgd2Ugb25seSBj YXVzZSBmb2N1c05vZGUgd2l0aCBhIG5vZGUgdG8gZm9jdXMuIElmIHRoZSBvcmlnaW5hbAorICAg ICAgICBub2RlIHRoYXQgd2FzIHByb3ZpZGVkIGlzIG5vIGxvbmdlciBpbiB0aGUgZG9jdW1lbnQs IHRoZW4gd2Ugd29uJ3QKKyAgICAgICAgYWN0dWFsbHkgZmluZCBhIG5vZGUgdG8gaW5zcGVjdC4K KwogMjAxNS0wNi0wNSAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEu Y29tPiBhbmQgWW91ZW5uIEZhYmxldCA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAg ICAgICAgW1N0cmVhbXMgQVBJXSBSZWFkYWJsZVN0cmVhbSBzaG91bGQgc3RvcmUgY2FsbGJhY2tz IGFzIGEgRGVxdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdl bnQuY3BwCmluZGV4IGNjNGQ3NzYuLjI1ZTllYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApAQCAtOTY2LDEyICs5NjYsMTUgQEAgdm9pZCBJ bnNwZWN0b3JET01BZ2VudDo6aW5zcGVjdChOb2RlKiBpbnNwZWN0ZWROb2RlKQogewogICAgIEVy cm9yU3RyaW5nIHVudXNlZDsKICAgICBSZWZQdHI8Tm9kZT4gbm9kZSA9IGluc3BlY3RlZE5vZGU7 Ci0gICAgc2V0U2VhcmNoaW5nRm9yTm9kZSh1bnVzZWQsIGZhbHNlLCAwKTsKKyAgICBzZXRTZWFy Y2hpbmdGb3JOb2RlKHVudXNlZCwgZmFsc2UsIG51bGxwdHIpOwogCiAgICAgaWYgKG5vZGUtPm5v ZGVUeXBlKCkgIT0gTm9kZTo6RUxFTUVOVF9OT0RFICYmIG5vZGUtPm5vZGVUeXBlKCkgIT0gTm9k ZTo6RE9DVU1FTlRfTk9ERSkKICAgICAgICAgbm9kZSA9IG5vZGUtPnBhcmVudE5vZGUoKTsKICAg ICBtX25vZGVUb0ZvY3VzID0gbm9kZTsKIAorICAgIGlmICghbV9ub2RlVG9Gb2N1cykKKyAgICAg ICAgcmV0dXJuOworCiAgICAgZm9jdXNOb2RlKCk7CiB9CiAKQEAgLTk4Myw3ICs5ODYsNyBAQCB2 b2lkIEluc3BlY3RvckRPTUFnZW50Ojpmb2N1c05vZGUoKQogICAgIEFTU0VSVChtX25vZGVUb0Zv Y3VzKTsKIAogICAgIFJlZlB0cjxOb2RlPiBub2RlID0gbV9ub2RlVG9Gb2N1cy5nZXQoKTsKLSAg ICBtX25vZGVUb0ZvY3VzID0gMDsKKyAgICBtX25vZGVUb0ZvY3VzID0gbnVsbHB0cjsKIAogICAg IEZyYW1lKiBmcmFtZSA9IG5vZGUtPmRvY3VtZW50KCkuZnJhbWUoKTsKICAgICBpZiAoIWZyYW1l KQo=