145895 2015-06-11 13:23:12 -0700 Full screen video space can be resized to 1pt wide 2015-08-27 18:39:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham eric.carlson simon.fraser thorton webkit-bug-importer oldest_to_newest 1101388 0 bfulgham 2015-06-11 13:23:12 -0700 In tiled mode, you can resize the full-screen video WebView to 1pt wide. This should not be possible. 1101389 1 bfulgham 2015-06-11 13:23:34 -0700 <rdar://problem/20907914> 1101392 2 254753 bfulgham 2015-06-11 13:28:24 -0700 Created attachment 254753 Patch 1101393 3 bfulgham 2015-06-11 13:29:48 -0700 Related: <rdar://problem/21150721> 1101411 4 bfulgham 2015-06-11 14:06:54 -0700 Committed r185473: <http://trac.webkit.org/changeset/185473> 1118068 5 thorton 2015-08-16 17:59:58 -0700 Whaaa. This should not be using kWKLayoutModeDynamicSizeWithMinimumViewSize (nothing should! I just got here because I was about to delete it). Probably wanted the default, kWKLayoutModeViewSize. But also, you always reset to kWKLayoutModeViewSize, ignoring whatever it was before! I bet there's a lot of brokenness going into/out of fullscreen with a page that is scaled-down in Split View. 1118069 6 thorton 2015-08-16 18:01:10 -0700 It's nontrivial to internally swap to a different layout mode and still come back to the right thing (respecting changes that come in from API clients, etc.), but I just implemented this for PDF, so we can probably reuse that. 1118070 7 thorton 2015-08-16 18:01:10 -0700 It's nontrivial to internally swap to a different layout mode and still come back to the right thing (respecting changes that come in from API clients, etc.), but I just implemented this for PDF, so we can probably reuse that. 1121527 8 thorton 2015-08-27 18:39:06 -0700 Patch to move to the better thing: https://bugs.webkit.org/show_bug.cgi?id=148553 254753 2015-06-11 13:28:24 -0700 2015-06-11 13:35:51 -0700 Patch bug-145895-20150611132755.patch text/plain 2926 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTQ2OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA2LTExICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEZ1bGwgc2NyZWVuIHZpZGVv IHNwYWNlIGNhbiBiZSByZXNpemVkIHRvIDFwdCB3aWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU4OTUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzIwOTA3OTE0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFByaW9yIHRvIHRoZSB1cGNvbWluZyBPUyBYLCBmdWxsIHNjcmVlbiBtb2RlIHdhcyBub3Qg cmVzaXphYmxlLiBOb3cgdGhhdCBpdCBpcywKKyAgICAgICAgd2UgbmVlZCB0byBzZXQgYSBtaW5p bXVtIHdpbmRvdyB3aWR0aCB0aGF0IGlzIGxhcmdlIGVub3VnaCB0byBob2xkIHRoZSBtZWRpYQor ICAgICAgICBjb250cm9scy4gVGhpcyBtYWtlcyBvdXIgZnVsbC1zY3JlZW4gdmlkZW8gYmVoYXZl IHRoZSBzYW1lIGFzIHRoZSBRdWlja1RpbWVYIHBsYXllci4KKworICAgICAgICAqIFVJUHJvY2Vz cy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tGdWxs U2NyZWVuV2luZG93Q29udHJvbGxlciBmaW5pc2hlZEVudGVyRnVsbFNjcmVlbkFuaW1hdGlvbjpd KTogQWN0aXZlIHRoYXQgbmV3CisgICAgICAgIGtXS0xheW91dE1vZGVEeW5hbWljU2l6ZVdpdGhN aW5pbXVtVmlld1NpemUgc3R5bGUsIGFuZCBzZXQgdGhlIG1pbmltdW0gdmlldyBzaXplIHRvCisg ICAgICAgIGJlIHRoZSB3aWR0aCBvZiBvdXIgbWVkaWEgY29udHJvbHMsIHdpdGggMjAgcGl4ZWxz IG9mIHBhZGRpbmcgb24gZWl0aGVyIHNpZGUuCisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRv d0NvbnRyb2xsZXIgZmluaXNoZWRFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbjpdKTogU2V0IHRoZSBs YXlvdXQKKyAgICAgICAgbW9kZSBiYWNrIHRvIHRoZSBkZWZhdWx0IHN0eWxlLgorCiAyMDE1LTA2 LTExICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgU3BlY3VsYXRpdmUgYnVpbGQgZml4IGZvciBHVEsgYWZ0ZXIgcjE4NTQ2My4KSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVl bldpbmRvd0NvbnRyb2xsZXIubW0JKHJldmlzaW9uIDE4NTQ2MCkKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQkod29ya2luZyBj b3B5KQpAQCAtMjc4LDYgKzI3OCw4IEBAIC0gKHZvaWQpYmVnYW5FbnRlckZ1bGxTY3JlZW5XaXRo SW5pdGlhbEYKICAgICBbW3NlbGYgd2luZG93XSBlbnRlckZ1bGxTY3JlZW5Nb2RlOnNlbGZdOwog fQogCitzdGF0aWMgY29uc3QgZmxvYXQgbWluVmlkZW9XaWR0aCA9IDQ4MCArIDIwICsgMjA7IC8v IE5vdGU6IEtlZXAgaW4gc3luYyB3aXRoIG1lZGlhQ29udHJvbHNBcHBsZS5jc3MgKHZpZGVvOi13 ZWJraXQtZnVsbC1zY3JlZW46Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwpCisKIC0gKHZv aWQpZmluaXNoZWRFbnRlckZ1bGxTY3JlZW5BbmltYXRpb246KGJvb2wpY29tcGxldGVkCiB7CiAg ICAgaWYgKF9mdWxsU2NyZWVuU3RhdGUgIT0gRW50ZXJpbmdGdWxsU2NyZWVuKQpAQCAtMjk4LDYg KzMwMCwxMiBAQCAtICh2b2lkKWZpbmlzaGVkRW50ZXJGdWxsU2NyZWVuQW5pbWF0aW9uCiAKICAg ICAgICAgW193ZWJWaWV3UGxhY2Vob2xkZXIgc2V0RXhpdFdhcm5pbmdWaXNpYmxlOllFU107CiAg ICAgICAgIFtfd2ViVmlld1BsYWNlaG9sZGVyIHNldFRhcmdldDpzZWxmXTsKKworICAgICAgICBb X3dlYlZpZXcgX3NldExheW91dE1vZGU6a1dLTGF5b3V0TW9kZUR5bmFtaWNTaXplV2l0aE1pbmlt dW1WaWV3U2l6ZV07CisgICAgICAgIAorICAgICAgICBOU1NpemUgbWluQ29udGVudFNpemUgPSBz ZWxmLndpbmRvdy5jb250ZW50TWluU2l6ZTsKKyAgICAgICAgbWluQ29udGVudFNpemUud2lkdGgg PSBtaW5WaWRlb1dpZHRoOworICAgICAgICBzZWxmLndpbmRvdy5jb250ZW50TWluU2l6ZSA9IG1p bkNvbnRlbnRTaXplOwogICAgIH0gZWxzZSB7CiAgICAgICAgIC8vIFRyYW5zaXRpb24gdG8gZnVs bHNjcmVlbiBmYWlsZWQuIENsZWFuIHVwLgogICAgICAgICBfZnVsbFNjcmVlblN0YXRlID0gTm90 SW5GdWxsU2NyZWVuOwpAQCAtMzg0LDYgKzM5Miw3IEBAIC0gKHZvaWQpZmluaXNoZWRFeGl0RnVs bFNjcmVlbkFuaW1hdGlvbjoKICAgICBtYWtlUmVzcG9uZGVyRmlyc3RSZXNwb25kZXJJZkRlc2Nl bmRhbnRPZlZpZXcoX3dlYlZpZXcud2luZG93LCBmaXJzdFJlc3BvbmRlciwgX3dlYlZpZXcpOwog CiAgICAgW1tfd2ViVmlldyB3aW5kb3ddIG1ha2VLZXlBbmRPcmRlckZyb250OnNlbGZdOworICAg IFtfd2ViVmlldyBfc2V0TGF5b3V0TW9kZTprV0tMYXlvdXRNb2RlVmlld1NpemVdOwogCiAgICAg Ly8gVGhlc2UgbWVzc2FnZXMgbXVzdCBiZSBzZW50IGFmdGVyIHRoZSBzd2FwIG9yIGZsYXNoaW5n IHdpbGwgb2NjdXIgZHVyaW5nIGZvcmNlUmVwYWludDoKICAgICBbc2VsZiBfbWFuYWdlcl0tPmRp ZEV4aXRGdWxsU2NyZWVuKCk7Cg==