145869 2015-06-10 20:11:40 -0700 Select validation does not correctly work when handling change event 2022-10-25 13:34:35 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mh35jp webkit-unassigned ahmad.saleem792 simon.fraser wenson_hsieh oldest_to_newest 1101209 0 254703 mh35jp 2015-06-10 20:11:40 -0700 Created attachment 254703 Test case Expected behavior Select a value->1 ... Should be changed to true, but remains false 1->Select a value ... Should be changed to false, but true 1119118 1 259434 wenson_hsieh 2015-08-19 17:35:32 -0700 Created attachment 259434 Patch 1119123 2 259434 dino 2015-08-19 17:39:52 -0700 Comment on attachment 259434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259434&action=review > Source/WebCore/ChangeLog:14 > + Test: fast/forms/onchange-select-check-validity.html > + > + When selecting an option in a <select> with validation that also has an onchange listener, calling > + checkValidity() for the select within the onchange handler would produce incorrect results and (on > + a debug build) crash at an assertion. This is because the change events were being dispatched before > + form validity was updated. Making the validation step come before the change event dispatch fixes > + this issue. Normally the Test line comes last. > LayoutTests/fast/forms/onchange-select-check-validity.html:17 > + select.onchange = showFormValidity; > + select.addEventListener("change", showFormValidity); I think these two lines do the same thing. You only need one of them. 1119124 3 259434 wenson_hsieh 2015-08-19 17:43:07 -0700 Comment on attachment 259434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259434&action=review >> Source/WebCore/ChangeLog:14 >> + this issue. > > Normally the Test line comes last. got it. >> LayoutTests/fast/forms/onchange-select-check-validity.html:17 >> + select.addEventListener("change", showFormValidity); > > I think these two lines do the same thing. You only need one of them. good catch. fixed! 1908212 4 ahmad.saleem792 2022-10-25 13:34:35 -0700 Landed and didn't backed out - https://github.com/WebKit/WebKit/commit/dfc4f77e61d39a165b4d9c8edd877282bde90e84 Marking this as "RESOLVED FIXED". 254703 2015-06-10 20:11:40 -0700 2015-06-10 20:11:40 -0700 Test case index.html text/html 594 mh35jp PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CjxtZXRhIGNoYXJzZXQ9IlVU Ri04IiAvPgo8dGl0bGU+U2VsZWN0IGJlaGF2aW9yIGJ1ZzwvdGl0bGU+CjwvaGVhZD4KPGJvZHk+ Cjxmb3JtIG1ldGhvZD0icG9zdCI+CjxzZWxlY3QgbmFtZT0iYSIgcmVxdWlyZWQ9InJlcXVpcmVk IiBpZD0iYSI+CjxvcHRpb24gdmFsdWU9IiIgc2VsZWN0ZWQ9InNlbGVjdGVkIj5TZWxlY3QgYSB2 YWx1ZTwvb3B0aW9uPgo8b3B0aW9uIHZhbHVlPSIxIj4xPC9vcHRpb24+CjxvcHRpb24gdmFsdWU9 IjIiPjI8L29wdGlvbj4KPG9wdGlvbiB2YWx1ZT0iMyI+Mzwvb3B0aW9uPgo8L3NlbGVjdD4KPC9m b3JtPgo8ZGl2IGlkPSJiIj48L2Rpdj4KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgpm dW5jdGlvbiBmKCkgewoJZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2InKS5pbm5lckhUTUwgPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYScpLmNoZWNrVmFsaWRpdHkoKTsKfQpmKCk7CmRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdhJykuYWRkRXZlbnRMaXN0ZW5lcignY2hhbmdlJywgZik7Cjwv c2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 259434 2015-08-19 17:35:32 -0700 2015-08-19 17:39:52 -0700 Patch bug-145869-20150819173528.patch text/plain 4944 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjhmZmFjNGQwNTNiNDYy ZTQxZGViZTFkNWViNjk0MzkzZDZhZmU3ZS4uODhkZGI4ZDE3MmIyNGRiMzhjOTExODA5NTI2Yjlm MjZlMTlhYmNjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA4LTE5ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFNlbGVjdCB2YWxp ZGF0aW9uIGRvZXMgbm90IGNvcnJlY3RseSB3b3JrIHdoZW4gaGFuZGxpbmcgY2hhbmdlIGV2ZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU4NjkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBm YXN0L2Zvcm1zL29uY2hhbmdlLXNlbGVjdC1jaGVjay12YWxpZGl0eS5odG1sCisKKyAgICAgICAg V2hlbiBzZWxlY3RpbmcgYW4gb3B0aW9uIGluIGEgPHNlbGVjdD4gd2l0aCB2YWxpZGF0aW9uIHRo YXQgYWxzbyBoYXMgYW4gb25jaGFuZ2UgbGlzdGVuZXIsIGNhbGxpbmcKKyAgICAgICAgY2hlY2tW YWxpZGl0eSgpIGZvciB0aGUgc2VsZWN0IHdpdGhpbiB0aGUgb25jaGFuZ2UgaGFuZGxlciB3b3Vs ZCBwcm9kdWNlIGluY29ycmVjdCByZXN1bHRzIGFuZCAob24KKyAgICAgICAgYSBkZWJ1ZyBidWls ZCkgY3Jhc2ggYXQgYW4gYXNzZXJ0aW9uLiBUaGlzIGlzIGJlY2F1c2UgdGhlIGNoYW5nZSBldmVu dHMgd2VyZSBiZWluZyBkaXNwYXRjaGVkIGJlZm9yZQorICAgICAgICBmb3JtIHZhbGlkaXR5IHdh cyB1cGRhdGVkLiBNYWtpbmcgdGhlIHZhbGlkYXRpb24gc3RlcCBjb21lIGJlZm9yZSB0aGUgY2hh bmdlIGV2ZW50IGRpc3BhdGNoIGZpeGVzCisgICAgICAgIHRoaXMgaXNzdWUuCisKKyAgICAgICAg KiBodG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTZWxl Y3RFbGVtZW50OjpzZWxlY3RPcHRpb24pOiBVcGRhdGUgdmFsaWRpdHkgYmVmb3JlIGRpc3BhdGNo aW5nIGNoYW5nZSBldmVudHMuCisKIDIwMTUtMDgtMTggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9o c2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgU2Nyb2xsIHNuYXBwaW5nIHNob3VsZCB0cmlnZ2Vy IHdoZW4gcmVjZWl2aW5nIGEgbW9tZW50dW0gZW5kIHdoZWVsIGV2ZW50CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCmluZGV4IGM4YjQyNjMyMzM5NzA0NmQ4YjRlMzkx MmJlZjdmNDM5OWU1MDNjODIuLmQ5ZTM3YTM5MTExODdlOGVlZWQ5N2QwMzQwY2Q5NzJhNTBmOGI4 NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCkBAIC05MDEs NiArOTAxLDcgQEAgdm9pZCBIVE1MU2VsZWN0RWxlbWVudDo6c2VsZWN0T3B0aW9uKGludCBvcHRp b25JbmRleCwgU2VsZWN0T3B0aW9uRmxhZ3MgZmxhZ3MpCiAKICAgICBzY3JvbGxUb1NlbGVjdGlv bigpOwogCisgICAgdXBkYXRlVmFsaWRpdHkoKTsKICAgICBpZiAodXNlc01lbnVMaXN0KCkpIHsK ICAgICAgICAgbV9pc1Byb2Nlc3NpbmdVc2VyRHJpdmVuQ2hhbmdlID0gZmxhZ3MgJiBVc2VyRHJp dmVuOwogICAgICAgICBpZiAoZmxhZ3MgJiBEaXNwYXRjaENoYW5nZUV2ZW50KQpAQCAtOTEyLDgg KzkxMyw2IEBAIHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6OnNlbGVjdE9wdGlvbihpbnQgb3B0aW9u SW5kZXgsIFNlbGVjdE9wdGlvbkZsYWdzIGZsYWdzKQogICAgICAgICAgICAgICAgIGRvd25jYXN0 PFJlbmRlckxpc3RCb3g+KCpyZW5kZXJlcikuc2VsZWN0aW9uQ2hhbmdlZCgpOwogICAgICAgICB9 CiAgICAgfQotCi0gICAgdXBkYXRlVmFsaWRpdHkoKTsKIH0KIAogaW50IEhUTUxTZWxlY3RFbGVt ZW50OjpvcHRpb25Ub0xpc3RJbmRleChpbnQgb3B0aW9uSW5kZXgpIGNvbnN0CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2Rh ZmQxMTU0NGRjNDAwNTM1Nzk3ZGMwYWNhYmRjNmQyMmM5OGYzYS4uNWYzMzg0M2YyOTUxYzM4ZWQ3 NzFiY2Q1M2VmMzBlNWZkZmY1ZGE2MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA4LTE5 ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFNlbGVj dCB2YWxpZGF0aW9uIGRvZXMgbm90IGNvcnJlY3RseSB3b3JrIHdoZW4gaGFuZGxpbmcgY2hhbmdl IGV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDU4NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU ZXN0cyB0aGF0IGNoZWNrVmFsaWRpdHkoKSByZXR1cm5zIGNvcnJlY3QgcmVzdWx0cyBmcm9tIHdp dGhpbiB0aGUgb25jaGFuZ2UgaGFuZGxlciBvZiBhCisgICAgICAgIDxzZWxlY3Q+IHdoZW4gdGhl IHZhbGlkaXR5IG9mIHRoZSBzZWxlY3RlZCBvcHRpb24gY2hhbmdlcy4KKworICAgICAgICAqIGZh c3QvZm9ybXMvb25jaGFuZ2Utc2VsZWN0LWNoZWNrLXZhbGlkaXR5LWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9vbmNoYW5nZS1zZWxlY3QtY2hlY2stdmFsaWRpdHku aHRtbDogQWRkZWQuCisKIDIwMTUtMDgtMTkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBXZWJLaXQgbWF5IGtlZXAgb3V0ZGF0ZWQgZW50cnkgaW4gdGhlIGRpc2sg Y2FjaGUgYWZ0ZXIgYSByZWxvYWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv b25jaGFuZ2Utc2VsZWN0LWNoZWNrLXZhbGlkaXR5LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvb25jaGFuZ2Utc2VsZWN0LWNoZWNrLXZhbGlkaXR5LWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi44ZmM3MWEwOWQ4OTMzN2YxYzEyMTg2ZWMzZjEyYTk4Yjg3OGVjMGE4Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9vbmNoYW5nZS1zZWxlY3QtY2hl Y2stdmFsaWRpdHktZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorCitUaGUgc2VsZWN0J3Mg dmFsaWRpdHkgd2FzIGluaXRpYWxseSBmYWxzZQorVGhlIHNlbGVjdCdzIHZhbGlkaXR5IHdhcyBj aGFuZ2VkIHRvIHRydWUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9vbmNo YW5nZS1zZWxlY3QtY2hlY2stdmFsaWRpdHkuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv b25jaGFuZ2Utc2VsZWN0LWNoZWNrLXZhbGlkaXR5Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDI0Yjg4YmIw ODU2ODZlZWM3ODBmYjU0NzZhYzdkZTg4ODYzYjlmZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvb25jaGFuZ2Utc2VsZWN0LWNoZWNrLXZhbGlkaXR5Lmh0bWwKQEAg LTAsMCArMSwzOCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CisgICAgZnVuY3Rpb24gbG9n KG1lc3NhZ2UpIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5h cHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShtZXNzYWdlICsgIlxuIikpOworICAg IH0KKworICAgIGZ1bmN0aW9uIHNldHVwVGVzdCgpIHsKKyAgICAgICAgdmFyIGlzVmFsaWQgPSBu dWxsOworICAgICAgICB2YXIgc2VsZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInZhbGlk YXRlZC1zZWxlY3QiKTsKKyAgICAgICAgc2VsZWN0LmZvY3VzKCk7CisgICAgICAgIGZ1bmN0aW9u IHNob3dGb3JtVmFsaWRpdHkoKSB7CisgICAgICAgICAgICBpc1ZhbGlkID0gc2VsZWN0LmNoZWNr VmFsaWRpdHkoKTsKKyAgICAgICAgfQorICAgICAgICBzaG93Rm9ybVZhbGlkaXR5KCk7CisgICAg ICAgIHNlbGVjdC5vbmNoYW5nZSA9IHNob3dGb3JtVmFsaWRpdHk7CisgICAgICAgIHNlbGVjdC5h ZGRFdmVudExpc3RlbmVyKCJjaGFuZ2UiLCBzaG93Rm9ybVZhbGlkaXR5KTsKKworICAgICAgICBp ZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4 dCgpOworICAgICAgICAgICAgbG9nKCJUaGUgc2VsZWN0J3MgdmFsaWRpdHkgd2FzIGluaXRpYWxs eSAiICsgaXNWYWxpZCk7CisgICAgICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCIxIik7Cisg ICAgICAgICAgICBsb2coIlRoZSBzZWxlY3QncyB2YWxpZGl0eSB3YXMgY2hhbmdlZCB0byAiICsg aXNWYWxpZCk7CisgICAgICAgIH0KKyAgICB9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkg b25sb2FkPSJzZXR1cFRlc3QoKSI+Cis8Zm9ybT4KKzxzZWxlY3QgbmFtZT0idmFsaWRhdGVkLXNl bGVjdCIgcmVxdWlyZWQ9InJlcXVpcmVkIiBpZD0idmFsaWRhdGVkLXNlbGVjdCI+CisgICAgPG9w dGlvbiB2YWx1ZT0iIiBzZWxlY3RlZD0ic2VsZWN0ZWQiPlNlbGVjdCBhIHZhbHVlPC9vcHRpb24+ CisgICAgPG9wdGlvbiB2YWx1ZT0iMSI+MTwvb3B0aW9uPgorPC9zZWxlY3Q+Cis8L2Zvcm0+Cis8 cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KKzwvYm9keT4KKzwvaHRtbD4K