145868 2015-06-10 20:09:41 -0700 Rewrite WKPluginSiteDataManager using WebsiteDataStore functions 2015-06-11 10:02:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1101207 0 andersca 2015-06-10 20:09:41 -0700 Rewrite WKPluginSiteDataManager using WebsiteDataStore functions 1101208 1 254702 andersca 2015-06-10 20:11:11 -0700 Created attachment 254702 Patch 1101302 2 254702 koivisto 2015-06-11 09:45:17 -0700 Comment on attachment 254702 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254702&action=review > Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.h:53 > + WebProcessPool& processPool() { return *m_processPool; } > + > void invalidate(); > void clearProcessPool() { m_processPool = nullptr; } Looks like m_processPool could be null? 1101303 3 andersca 2015-06-11 10:02:18 -0700 Committed r185457: <http://trac.webkit.org/changeset/185457> 254702 2015-06-10 20:11:11 -0700 2015-06-11 09:45:17 -0700 Patch bug-145868-20150610201042.patch text/plain 6656 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDBiYjRiN2ZjYTQ0ZmM5 MmU1NWNiYzIxMzIwOThlZTY1MmZhZmQ3Mi4uNjhkMGQyYzAxOGRkN2M5YjViNTgxNTYyMWIwMTdj Y2U4OWFhNTc5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTA2LTEwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV3cml0ZSBXS1Bs dWdpblNpdGVEYXRhTWFuYWdlciB1c2luZyBXZWJzaXRlRGF0YVN0b3JlIGZ1bmN0aW9ucworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1ODY4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0MvV0tQbHVnaW5TaXRlRGF0YU1hbmFnZXIuY3BwOgorICAgICAgICAoV0tQbHVnaW5TaXRl RGF0YU1hbmFnZXJHZXRTaXRlc1dpdGhEYXRhKToKKyAgICAgICAgKFdLUGx1Z2luU2l0ZURhdGFN YW5hZ2VyQ2xlYXJTaXRlRGF0YSk6CisgICAgICAgIChXS1BsdWdpblNpdGVEYXRhTWFuYWdlckNs ZWFyQWxsU2l0ZURhdGEpOgorICAgICAgICAodG9OUENsZWFyU2l0ZURhdGFGbGFncyk6IERlbGV0 ZWQuCisgICAgICAgICogVUlQcm9jZXNzL1BsdWdpbnMvV2ViUGx1Z2luU2l0ZURhdGFNYW5hZ2Vy Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYlBsdWdpblNpdGVEYXRhTWFuYWdlcjo6cHJvY2Vzc1Bv b2wpOgorCisyMDE1LTA2LTEwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+ CisKICAgICAgICAgV0tXZWJzaXRlRGF0YVN0b3JlIHNob3VsZCBoYW5kbGUgcmVtb3ZpbmcgcGx1 Zy1pbiBkYXRhIGZvciBpbmRpdmlkdWFsIHJlY29yZHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTg2NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQbHVnaW5TaXRlRGF0YU1hbmFnZXIuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGx1Z2luU2l0ZURhdGFNYW5hZ2VyLmNwcAppbmRl eCAyMjgyOTk2ZmJjOTAzZTkzMDZhMDhhMDE4MTQyZjVhZGZjY2JjMmRlLi5kOTg1YWI3YjdlOTFj ZDdmNjQ0ZDA2NGE1MDhjY2NjNTAzZDlmZGMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0MvV0tQbHVnaW5TaXRlRGF0YU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BsdWdpblNpdGVEYXRhTWFuYWdlci5jcHAKQEAgLTI5 LDEzICsyOSw4IEBACiAjaW5jbHVkZSAiQVBJT2JqZWN0LmgiCiAjaW5jbHVkZSAiV0tBUElDYXN0 LmgiCiAjaW5jbHVkZSAiV2ViUGx1Z2luU2l0ZURhdGFNYW5hZ2VyLmgiCi0KLSNpZiBFTkFCTEUo TkVUU0NBUEVfUExVR0lOX0FQSSkKLSNpbmNsdWRlIDxXZWJDb3JlL25wYXBpLmg+Ci0jaWYgZGVm aW5lZChNT1pfWDExKQotI3VuZGVmIE5vbmUKLSNlbmRpZgotI2VuZGlmCisjaW5jbHVkZSAiV2Vi UHJvY2Vzc1Bvb2wuaCIKKyNpbmNsdWRlICJXZWJzaXRlRGF0YVJlY29yZC5oIgogCiB1c2luZyBu YW1lc3BhY2UgV2ViS2l0OwogCkBAIC00OCw1NSArNDMsNjEgQEAgV0tUeXBlSUQgV0tQbHVnaW5T aXRlRGF0YU1hbmFnZXJHZXRUeXBlSUQoKQogI2VuZGlmCiB9CiAKLXZvaWQgV0tQbHVnaW5TaXRl RGF0YU1hbmFnZXJHZXRTaXRlc1dpdGhEYXRhKFdLUGx1Z2luU2l0ZURhdGFNYW5hZ2VyUmVmIG1h bmFnZXJSZWYsIHZvaWQqIGNvbnRleHQsIFdLUGx1Z2luU2l0ZURhdGFNYW5hZ2VyR2V0U2l0ZXNX aXRoRGF0YUZ1bmN0aW9uIGNhbGxiYWNrKQordm9pZCBXS1BsdWdpblNpdGVEYXRhTWFuYWdlckdl dFNpdGVzV2l0aERhdGEoV0tQbHVnaW5TaXRlRGF0YU1hbmFnZXJSZWYgbWFuYWdlciwgdm9pZCog Y29udGV4dCwgV0tQbHVnaW5TaXRlRGF0YU1hbmFnZXJHZXRTaXRlc1dpdGhEYXRhRnVuY3Rpb24g Y2FsbGJhY2spCiB7CiAjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCi0gICAgdG9JbXBs KG1hbmFnZXJSZWYpLT5nZXRTaXRlc1dpdGhEYXRhKHRvR2VuZXJpY0NhbGxiYWNrRnVuY3Rpb24o Y29udGV4dCwgY2FsbGJhY2spKTsKKyAgICBhdXRvJiB3ZWJzaXRlRGF0YVN0b3JlID0gdG9JbXBs KG1hbmFnZXIpLT5wcm9jZXNzUG9vbCgpLndlYnNpdGVEYXRhU3RvcmUoKS0+d2Vic2l0ZURhdGFT dG9yZSgpOworICAgIHdlYnNpdGVEYXRhU3RvcmUuZmV0Y2hEYXRhKFdlYnNpdGVEYXRhVHlwZXM6 OldlYnNpdGVEYXRhVHlwZVBsdWdJbkRhdGEsIFtjb250ZXh0LCBjYWxsYmFja10oVmVjdG9yPFdl YnNpdGVEYXRhUmVjb3JkPiBkYXRhUmVjb3JkcykgeworICAgICAgICBWZWN0b3I8U3RyaW5nPiBo b3N0TmFtZXM7CisgICAgICAgIGZvciAoY29uc3QgYXV0byYgZGF0YVJlY29yZCA6IGRhdGFSZWNv cmRzKSB7CisgICAgICAgICAgICBmb3IgKGNvbnN0IGF1dG8mIGhvc3ROYW1lIDogZGF0YVJlY29y ZC5wbHVnaW5EYXRhSG9zdE5hbWVzKQorICAgICAgICAgICAgICAgIGhvc3ROYW1lcy5hcHBlbmQo aG9zdE5hbWUpOworICAgICAgICB9CisKKyAgICAgICAgY2FsbGJhY2sodG9BUEkoQVBJOjpBcnJh eTo6Y3JlYXRlU3RyaW5nQXJyYXkoaG9zdE5hbWVzKS5wdHIoKSksIG51bGxwdHIsIGNvbnRleHQp OworICAgIH0pOwogI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0obWFuYWdlclJlZik7CisgICAgVU5V U0VEX1BBUkFNKG1hbmFnZXIpOwogICAgIFVOVVNFRF9QQVJBTShjb250ZXh0KTsKICAgICBVTlVT RURfUEFSQU0oY2FsbGJhY2spOwogI2VuZGlmCiB9CiAKLSNpZiBFTkFCTEUoTkVUU0NBUEVfUExV R0lOX0FQSSkKLXN0YXRpYyB1aW50NjRfdCB0b05QQ2xlYXJTaXRlRGF0YUZsYWdzKFdLQ2xlYXJT aXRlRGF0YUZsYWdzIGZsYWdzKQordm9pZCBXS1BsdWdpblNpdGVEYXRhTWFuYWdlckNsZWFyU2l0 ZURhdGEoV0tQbHVnaW5TaXRlRGF0YU1hbmFnZXJSZWYgbWFuYWdlciwgV0tBcnJheVJlZiBzaXRl cywgV0tDbGVhclNpdGVEYXRhRmxhZ3MgZmxhZ3MsIHVpbnQ2NF90IG1heEFnZUluU2Vjb25kcywg dm9pZCogY29udGV4dCwgV0tQbHVnaW5TaXRlRGF0YU1hbmFnZXJDbGVhclNpdGVEYXRhRnVuY3Rp b24gY2FsbGJhY2spCiB7Ci0gICAgaWYgKGZsYWdzID09IGtXS0NsZWFyU2l0ZURhdGFGbGFnc0Ns ZWFyQWxsKQotICAgICAgICByZXR1cm4gTlBfQ0xFQVJfQUxMOworICAgIC8vIFRoZXNlIGFyZSB0 aGUgb25seSBwYXJhbWV0ZXJzIHN1cHBvcnRlZC4KKyAgICBBU1NFUlRfVU5VU0VEKGZsYWdzLCBm bGFncyA9PSBrV0tDbGVhclNpdGVEYXRhRmxhZ3NDbGVhckFsbCk7CisgICAgQVNTRVJUX1VOVVNF RChtYXhBZ2VJblNlY29uZHMsIG1heEFnZUluU2Vjb25kcyA9PSBzdGQ6Om51bWVyaWNfbGltaXRz PHVpbnQ2NF90Pjo6bWF4KCkpOwogCi0gICAgdWludDY0X3QgcmVzdWx0ID0gMDsKLSAgICBpZiAo ZmxhZ3MgJiBrV0tDbGVhclNpdGVEYXRhRmxhZ3NDbGVhckNhY2hlKQotICAgICAgICByZXN1bHQg fD0gTlBfQ0xFQVJfQ0FDSEU7Ci0gICAgcmV0dXJuIHJlc3VsdDsKLX0KLSNlbmRpZgotCi12b2lk IFdLUGx1Z2luU2l0ZURhdGFNYW5hZ2VyQ2xlYXJTaXRlRGF0YShXS1BsdWdpblNpdGVEYXRhTWFu YWdlclJlZiBtYW5hZ2VyUmVmLCBXS0FycmF5UmVmIHNpdGVzUmVmLCBXS0NsZWFyU2l0ZURhdGFG bGFncyBmbGFncywgdWludDY0X3QgbWF4QWdlSW5TZWNvbmRzLCB2b2lkKiBjb250ZXh0LCBXS1Bs dWdpblNpdGVEYXRhTWFuYWdlckNsZWFyU2l0ZURhdGFGdW5jdGlvbiBmdW5jdGlvbikKLXsKICNp ZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKLSAgICB0b0ltcGwobWFuYWdlclJlZiktPmNs ZWFyU2l0ZURhdGEodG9JbXBsKHNpdGVzUmVmKSwgdG9OUENsZWFyU2l0ZURhdGFGbGFncyhmbGFn cyksIG1heEFnZUluU2Vjb25kcywgW2NvbnRleHQsIGZ1bmN0aW9uXShDYWxsYmFja0Jhc2U6OkVy cm9yIGVycm9yKSB7Ci0gICAgICAgIGZ1bmN0aW9uKGVycm9yID09IENhbGxiYWNrQmFzZTo6RXJy b3I6Ok5vbmUgPyBudWxscHRyIDogdG9BUEkoQVBJOjpFcnJvcjo6Y3JlYXRlKCkucHRyKCkpLCBj b250ZXh0KTsKKyAgICBXZWJzaXRlRGF0YVJlY29yZCBkYXRhUmVjb3JkOworICAgIGZvciAoY29u c3QgYXV0byYgc3RyaW5nIDogdG9JbXBsKHNpdGVzKS0+ZWxlbWVudHNPZlR5cGU8QVBJOjpTdHJp bmc+KCkpCisgICAgICAgIGRhdGFSZWNvcmQucGx1Z2luRGF0YUhvc3ROYW1lcy5hZGQoc3RyaW5n LT5zdHJpbmcoKSk7CisKKyAgICBhdXRvJiB3ZWJzaXRlRGF0YVN0b3JlID0gdG9JbXBsKG1hbmFn ZXIpLT5wcm9jZXNzUG9vbCgpLndlYnNpdGVEYXRhU3RvcmUoKS0+d2Vic2l0ZURhdGFTdG9yZSgp OworICAgIHdlYnNpdGVEYXRhU3RvcmUucmVtb3ZlRGF0YShXZWJzaXRlRGF0YVR5cGVzOjpXZWJz aXRlRGF0YVR5cGVQbHVnSW5EYXRhLCB7IGRhdGFSZWNvcmQgfSwgW2NvbnRleHQsIGNhbGxiYWNr XSB7CisgICAgICAgIGNhbGxiYWNrKG51bGxwdHIsIGNvbnRleHQpOwogICAgIH0pOwogI2Vsc2UK LSAgICBVTlVTRURfUEFSQU0obWFuYWdlclJlZik7Ci0gICAgVU5VU0VEX1BBUkFNKHNpdGVzUmVm KTsKKyAgICBVTlVTRURfUEFSQU0obWFuYWdlcik7CisgICAgVU5VU0VEX1BBUkFNKHNpdGVzKTsK ICAgICBVTlVTRURfUEFSQU0oZmxhZ3MpOwogICAgIFVOVVNFRF9QQVJBTShtYXhBZ2VJblNlY29u ZHMpOwogICAgIFVOVVNFRF9QQVJBTShjb250ZXh0KTsKLSAgICBVTlVTRURfUEFSQU0oZnVuY3Rp b24pOworICAgIFVOVVNFRF9QQVJBTShjYWxsYmFjayk7CiAjZW5kaWYKIH0KIAotdm9pZCBXS1Bs dWdpblNpdGVEYXRhTWFuYWdlckNsZWFyQWxsU2l0ZURhdGEoV0tQbHVnaW5TaXRlRGF0YU1hbmFn ZXJSZWYgbWFuYWdlclJlZiwgdm9pZCogY29udGV4dCwgV0tQbHVnaW5TaXRlRGF0YU1hbmFnZXJD bGVhclNpdGVEYXRhRnVuY3Rpb24gZnVuY3Rpb24pCit2b2lkIFdLUGx1Z2luU2l0ZURhdGFNYW5h Z2VyQ2xlYXJBbGxTaXRlRGF0YShXS1BsdWdpblNpdGVEYXRhTWFuYWdlclJlZiBtYW5hZ2VyLCB2 b2lkKiBjb250ZXh0LCBXS1BsdWdpblNpdGVEYXRhTWFuYWdlckNsZWFyU2l0ZURhdGFGdW5jdGlv biBjYWxsYmFjaykKIHsKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKLSAgICB0b0lt cGwobWFuYWdlclJlZiktPmNsZWFyU2l0ZURhdGEoMCwgTlBfQ0xFQVJfQUxMLCBzdGQ6Om51bWVy aWNfbGltaXRzPHVpbnQ2NF90Pjo6bWF4KCksIFtjb250ZXh0LCBmdW5jdGlvbl0oQ2FsbGJhY2tC YXNlOjpFcnJvciBlcnJvcikgewotICAgICAgICBmdW5jdGlvbihlcnJvciA9PSBDYWxsYmFja0Jh c2U6OkVycm9yOjpOb25lID8gbnVsbHB0ciA6IHRvQVBJKEFQSTo6RXJyb3I6OmNyZWF0ZSgpLnB0 cigpKSwgY29udGV4dCk7CisgICAgYXV0byYgd2Vic2l0ZURhdGFTdG9yZSA9IHRvSW1wbChtYW5h Z2VyKS0+cHJvY2Vzc1Bvb2woKS53ZWJzaXRlRGF0YVN0b3JlKCktPndlYnNpdGVEYXRhU3RvcmUo KTsKKyAgICB3ZWJzaXRlRGF0YVN0b3JlLnJlbW92ZURhdGEoV2Vic2l0ZURhdGFUeXBlczo6V2Vi c2l0ZURhdGFUeXBlUGx1Z0luRGF0YSwgc3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6dGltZV9w b2ludDo6bWluKCksIFtjb250ZXh0LCBjYWxsYmFja10geworICAgICAgICBjYWxsYmFjayhudWxs cHRyLCBjb250ZXh0KTsKICAgICB9KTsKICNlbHNlCi0gICAgVU5VU0VEX1BBUkFNKG1hbmFnZXJS ZWYpOworICAgIFVOVVNFRF9QQVJBTShtYW5hZ2VyKTsKICAgICBVTlVTRURfUEFSQU0oY29udGV4 dCk7Ci0gICAgVU5VU0VEX1BBUkFNKGZ1bmN0aW9uKTsKKyAgICBVTlVTRURfUEFSQU0oY2FsbGJh Y2spOwogI2VuZGlmCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1 Z2lucy9XZWJQbHVnaW5TaXRlRGF0YU1hbmFnZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QbHVnaW5zL1dlYlBsdWdpblNpdGVEYXRhTWFuYWdlci5oCmluZGV4IGYwMGJlOTY0NjA1Y2Vh YjlmYmRlYTg1ZmZkZTI2ODIzMDEyYjk2MTkuLjEzZmQ3ZGYyOTYyYmE2NGNlYmI2NGI5ODU4MDU2 OTMwMjVmZWFiYjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5z L1dlYlBsdWdpblNpdGVEYXRhTWFuYWdlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QbHVnaW5zL1dlYlBsdWdpblNpdGVEYXRhTWFuYWdlci5oCkBAIC00Nyw2ICs0Nyw4IEBAIHB1 YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxXZWJQbHVnaW5TaXRlRGF0YU1hbmFnZXI+IGNy ZWF0ZShXZWJQcm9jZXNzUG9vbCopOwogICAgIHZpcnR1YWwgfldlYlBsdWdpblNpdGVEYXRhTWFu YWdlcigpOwogCisgICAgV2ViUHJvY2Vzc1Bvb2wmIHByb2Nlc3NQb29sKCkgeyByZXR1cm4gKm1f cHJvY2Vzc1Bvb2w7IH0KKwogICAgIHZvaWQgaW52YWxpZGF0ZSgpOwogICAgIHZvaWQgY2xlYXJQ cm9jZXNzUG9vbCgpIHsgbV9wcm9jZXNzUG9vbCA9IG51bGxwdHI7IH0KIAo=