145855 2015-06-10 14:22:26 -0700 Overriding the overlay scrollbar style on WKView doesn't take effect immediately 2015-06-10 14:54:57 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin sam simon.fraser oldest_to_newest 1101109 0 bdakin 2015-06-10 14:22:26 -0700 If the scrollbar style is changed dynamically after the WKView is loaded, then the new style won't actually change until rubber-banding. rdar://problem/20948706 1101116 1 254677 bdakin 2015-06-10 14:42:59 -0700 Created attachment 254677 Patch 1101117 2 254677 simon.fraser 2015-06-10 14:44:19 -0700 Comment on attachment 254677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254677&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1020 > + if (!painter) > + return; > + [painter setNeedsDisplay:YES]; It would be OK removing the null check, since messaging nil is OK. 1101122 3 bdakin 2015-06-10 14:54:57 -0700 (In reply to comment #2) > Comment on attachment 254677 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254677&action=review > > > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1020 > > + if (!painter) > > + return; > > + [painter setNeedsDisplay:YES]; > > It would be OK removing the null check, since messaging nil is OK. Good point. Removed! Thanks, Simon! http://trac.webkit.org/changeset/185431 254677 2015-06-10 14:42:59 -0700 2015-06-10 14:44:19 -0700 Patch for-review.txt text/plain 5112 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTQyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDE1LTA2LTEwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBPdmVycmlkaW5nIHRoZSBvdmVybGF5 IHNjcm9sbGJhciBzdHlsZSBvbiBXS1ZpZXcgZG9lc24ndCB0YWtlIGVmZmVjdCBpbW1lZGlhdGVs eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1ODU1 CisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjA5 NDg3MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT aW5jZSB3ZSBvcHQgaW50byBsYXllci1wZXItcGFydCBzY3JvbGxiYXJzIGluIG9yZGVyIHRvIG1v dmUgdGhlIGtub2Igb24gdGhlIAorICAgICAgICBzZWNvbmRhcnkgdGhyZWFkLCBBcHBLaXQgaXMg Y3JlYXRpbmcgaXRzIG93biBsYXllcnMgZm9yIHRoZSBrbm9iIGFuZCB0cmFjay4gVG8gCisgICAg ICAgIGludmFsaWRhdGUgdGhlbSwgd2UgbmVlZCB0byBjYWxsIGludG8gdGhlIFNjcm9sbGJhclBh aW50ZXLigJlzIHNldE5lZWRzRGlzcGxheS4KKworICAgICAgICBOZXcgdmlydHVhbCBmdW5jdGlv biBvbiBTY3JvbGxBbmltYXRvciB0byBjYWxsIGludG8gU2Nyb2xsYmFyUGFpbnRlcuKAmXMgCisg ICAgICAgIHNldE5lZWRzRGlzcGF5LgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbEFuaW1hdG9y Lmg6CisKKyAgICAgICAgQ2FsbCB0aGUgbmV3IGZ1bmN0aW9uIHdoZW4gc2V0dGluZyB0aGUgb3Zl cmxheSBzdHlsZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTY3JvbGxhYmxlQXJlYTo6c2V0U2Nyb2xsYmFyT3ZlcmxheVN0eWxlKToK KworICAgICAgICBBZGQgc2V0TmVlZHNEaXNwbGF5IHRvIHRoZSBsaXN0IG9mIFNjcm9sbGJhclBh aW50ZXIgbWV0aG9kcy4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvTlNTY3JvbGxlckltcERldGFp bHMuaDoKKworICAgICAgICBJbXBsZW1lbnQgaW52YWxpZGF0ZVNjcm9sbGJhclBhcnRMYXllcnMu CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLmg6CisgICAgICAgICog cGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Ny b2xsQW5pbWF0b3JNYWM6OmludmFsaWRhdGVTY3JvbGxiYXJQYXJ0TGF5ZXJzKToKKwogMjAxNS0w Ni0xMCAgTWF0dCBSYWpjYSAgPG1yYWpjYUBhcHBsZS5jb20+CiAKICAgICAgICAgTWVkaWFSZW1v dGVDb250cm9scyBzaG91bGQgYmUgbWFya2VkIEpTR2VuZXJhdGVUb0pTT2JqZWN0LgpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3IuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvci5oCShyZXZpc2lvbiAxODUzNjYp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvci5oCSh3b3JraW5nIGNv cHkpCkBAIC0xMTAsNiArMTEwLDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRBZGRI b3Jpem9udGFsU2Nyb2xsYmFyKFNjcm9sbGJhciopIHsgfQogICAgIHZpcnR1YWwgdm9pZCB3aWxs UmVtb3ZlSG9yaXpvbnRhbFNjcm9sbGJhcihTY3JvbGxiYXIqKSB7IH0KIAorICAgIHZpcnR1YWwg dm9pZCBpbnZhbGlkYXRlU2Nyb2xsYmFyUGFydExheWVycyhTY3JvbGxiYXIqKSB7IH0KKwogICAg IHZpcnR1YWwgdm9pZCB2ZXJ0aWNhbFNjcm9sbGJhckxheWVyRGlkQ2hhbmdlKCkgeyB9CiAgICAg dmlydHVhbCB2b2lkIGhvcml6b250YWxTY3JvbGxiYXJMYXllckRpZENoYW5nZSgpIHsgfQogCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuY3BwCShyZXZpc2lv biAxODUzNjYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTM0MSwxMSArMzQxLDE1IEBAIHZvaWQgU2Nyb2xsYWJsZUFyZWE6 OnNldFNjcm9sbGJhck92ZXJsYXkKICAgICBpZiAoaG9yaXpvbnRhbFNjcm9sbGJhcigpKSB7CiAg ICAgICAgIFNjcm9sbGJhclRoZW1lOjp0aGVtZSgpLT51cGRhdGVTY3JvbGxiYXJPdmVybGF5U3R5 bGUoaG9yaXpvbnRhbFNjcm9sbGJhcigpKTsKICAgICAgICAgaG9yaXpvbnRhbFNjcm9sbGJhcigp LT5pbnZhbGlkYXRlKCk7CisgICAgICAgIGlmIChTY3JvbGxBbmltYXRvciogc2Nyb2xsQW5pbWF0 b3IgPSBleGlzdGluZ1Njcm9sbEFuaW1hdG9yKCkpCisgICAgICAgICAgICBzY3JvbGxBbmltYXRv ci0+aW52YWxpZGF0ZVNjcm9sbGJhclBhcnRMYXllcnMoaG9yaXpvbnRhbFNjcm9sbGJhcigpKTsK ICAgICB9CiAgICAgCiAgICAgaWYgKHZlcnRpY2FsU2Nyb2xsYmFyKCkpIHsKICAgICAgICAgU2Ny b2xsYmFyVGhlbWU6OnRoZW1lKCktPnVwZGF0ZVNjcm9sbGJhck92ZXJsYXlTdHlsZSh2ZXJ0aWNh bFNjcm9sbGJhcigpKTsKICAgICAgICAgdmVydGljYWxTY3JvbGxiYXIoKS0+aW52YWxpZGF0ZSgp OworICAgICAgICBpZiAoU2Nyb2xsQW5pbWF0b3IqIHNjcm9sbEFuaW1hdG9yID0gZXhpc3RpbmdT Y3JvbGxBbmltYXRvcigpKQorICAgICAgICAgICAgc2Nyb2xsQW5pbWF0b3ItPmludmFsaWRhdGVT Y3JvbGxiYXJQYXJ0TGF5ZXJzKHZlcnRpY2FsU2Nyb2xsYmFyKCkpOwogICAgIH0KIH0KIApJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL05TU2Nyb2xsZXJJbXBEZXRhaWxzLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL05TU2Nyb2xsZXJJbXBEZXRh aWxzLmgJKHJldmlzaW9uIDE4NTM2NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9O U1Njcm9sbGVySW1wRGV0YWlscy5oCSh3b3JraW5nIGNvcHkpCkBAIC02Miw2ICs2Miw5IEBAIEBp bnRlcmZhY2UgTlNPYmplY3QgKFNjcm9sbGJhclBhaW50ZXIpCiAtICh2b2lkKWRyYXdLbm9iOwog LSAodm9pZCltb3VzZUVudGVyZWRTY3JvbGxlcjsKIC0gKHZvaWQpbW91c2VFeGl0ZWRTY3JvbGxl cjsKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTAwMAorLSAodm9p ZClzZXROZWVkc0Rpc3BsYXk6KEJPT0wpZmxhZzsKKyNlbmRpZgogQGVuZAogCiBAaW50ZXJmYWNl IE5TT2JqZWN0IChTY3JvbGxiYXJQYWludGVyQ29udHJvbGxlcikKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5oCShyZXZpc2lvbiAxODUz NjYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMuaAko d29ya2luZyBjb3B5KQpAQCAtMTE1LDYgKzExNSw4IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2 b2lkIGRpZEFkZEhvcml6b250YWxTY3JvbGxiYXIoU2Nyb2xsYmFyKik7CiAgICAgdmlydHVhbCB2 b2lkIHdpbGxSZW1vdmVIb3Jpem9udGFsU2Nyb2xsYmFyKFNjcm9sbGJhciopOwogCisgICAgdm9p ZCBpbnZhbGlkYXRlU2Nyb2xsYmFyUGFydExheWVycyhTY3JvbGxiYXIqKSBvdmVycmlkZTsKKwog ICAgIHZpcnR1YWwgdm9pZCB2ZXJ0aWNhbFNjcm9sbGJhckxheWVyRGlkQ2hhbmdlKCk7CiAgICAg dmlydHVhbCB2b2lkIGhvcml6b250YWxTY3JvbGxiYXJMYXllckRpZENoYW5nZSgpOwogCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1t CShyZXZpc2lvbiAxODUzNjYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xs QW5pbWF0b3JNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTEwMTEsNiArMTAxMSwyMCBAQCB2b2lk IFNjcm9sbEFuaW1hdG9yTWFjOjp3aWxsUmVtb3ZlSG9yaXpvCiAgICAgW21fc2Nyb2xsYmFyUGFp bnRlckNvbnRyb2xsZXIgc2V0SG9yaXpvbnRhbFNjcm9sbGVySW1wOm5pbF07CiB9CiAKKyNpZiBf X01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTAwMAordm9pZCBTY3JvbGxBbmlt YXRvck1hYzo6aW52YWxpZGF0ZVNjcm9sbGJhclBhcnRMYXllcnMoU2Nyb2xsYmFyKiBzY3JvbGxi YXIpCit7CisgICAgU2Nyb2xsYmFyUGFpbnRlciBwYWludGVyID0gc2Nyb2xsYmFyUGFpbnRlckZv clNjcm9sbGJhcihzY3JvbGxiYXIpOworICAgIGlmICghcGFpbnRlcikKKyAgICAgICAgcmV0dXJu OworICAgIFtwYWludGVyIHNldE5lZWRzRGlzcGxheTpZRVNdOworfQorI2Vsc2UKK3ZvaWQgU2Ny b2xsQW5pbWF0b3JNYWM6OmludmFsaWRhdGVTY3JvbGxiYXJQYXJ0TGF5ZXJzKFNjcm9sbGJhciop Cit7Cit9CisjZW5kaWYKKwogdm9pZCBTY3JvbGxBbmltYXRvck1hYzo6dmVydGljYWxTY3JvbGxi YXJMYXllckRpZENoYW5nZSgpCiB7CiAgICAgR3JhcGhpY3NMYXllciogbGF5ZXIgPSBtX3Njcm9s bGFibGVBcmVhLmxheWVyRm9yVmVydGljYWxTY3JvbGxiYXIoKTsK