145854 2015-06-10 14:09:39 -0700 Move all content extension tests to same directory to fix flakiness 2015-06-10 14:37:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1101105 0 achristensen 2015-06-10 14:09:39 -0700 Right now there are two directories with content extension tests, which causes them to be run with two WebKitTestRunners at the same time, and sometimes they delete each other's content extension when resetting the state between tests. I'm pretty sure this is what is causing flakiness like http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcontentextensions&revision=185388 1101106 1 254675 achristensen 2015-06-10 14:12:16 -0700 Created attachment 254675 Patch 1101108 2 254675 ap 2015-06-10 14:17:11 -0700 Comment on attachment 254675 Patch This is ok as a short term fix, however the requirement to have all these tests in one directory is not something that we should remember forever, and also we should have tests work with -f. How can we make parallel testing processes independent? 1101114 3 achristensen 2015-06-10 14:36:57 -0700 http://trac.webkit.org/changeset/185430 The problem is related to the call to _removeAllContentExtensions in TestControllerMac.mm but I'm not sure how to safely make it work with different directories. And I'm only about 90% sure this moving-all-tests-to-the-same-directory will work. 254675 2015-06-10 14:12:16 -0700 2015-06-10 14:17:11 -0700 Patch bug-145854-20150610141148.patch text/plain 6267 achristensen SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4NTQyOSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA2LTEwICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW92ZSBhbGwgY29udGVudCBl eHRlbnNpb24gdGVzdHMgdG8gc2FtZSBkaXJlY3RvcnkgdG8gZml4IGZsYWtpbmVzcy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTg1NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHR0cC90ZXN0cy9j b250ZW50ZXh0ZW5zaW9ucy9sb2FkaW5nL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC1l eHBlY3RlZC50eHQ6IFJlbW92ZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5z aW9ucy9sb2FkaW5nL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC5waHA6IFJlbW92ZWQu CisgICAgICAgICogaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy9sb2FkaW5nL21haW4tcmVz b3VyY2UtcmVkaXJlY3QtYmxvY2tlZC5waHAuanNvbjogUmVtb3ZlZC4KKyAgICAgICAgKiBodHRw L3Rlc3RzL2NvbnRlbnRleHRlbnNpb25zL2xvYWRpbmcvcmVzb3VyY2VzL21haW4tcmVzb3VyY2Ut cmVkaXJlY3QtYmxvY2tlZC10YXJnZXQuaHRtbDogUmVtb3ZlZC4KKyAgICAgICAgKiBodHRwL3Rl c3RzL2NvbnRlbnRleHRlbnNpb25zL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC1leHBl Y3RlZC50eHQ6IENvcGllZCBmcm9tIGh0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvbG9hZGlu Zy9tYWluLXJlc291cmNlLXJlZGlyZWN0LWJsb2NrZWQtZXhwZWN0ZWQudHh0LgorICAgICAgICAq IGh0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC1ibG9j a2VkLnBocDogQ29waWVkIGZyb20gaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy9sb2FkaW5n L21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC5waHAuCisgICAgICAgICogaHR0cC90ZXN0 cy9jb250ZW50ZXh0ZW5zaW9ucy9tYWluLXJlc291cmNlLXJlZGlyZWN0LWJsb2NrZWQucGhwLmpz b246IENvcGllZCBmcm9tIGh0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvbG9hZGluZy9tYWlu LXJlc291cmNlLXJlZGlyZWN0LWJsb2NrZWQucGhwLmpzb24uCisgICAgICAgICogaHR0cC90ZXN0 cy9jb250ZW50ZXh0ZW5zaW9ucy9yZXNvdXJjZXMvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC1ibG9j a2VkLXRhcmdldC5odG1sOiBDb3BpZWQgZnJvbSBodHRwL3Rlc3RzL2NvbnRlbnRleHRlbnNpb25z L2xvYWRpbmcvcmVzb3VyY2VzL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC10YXJnZXQu aHRtbC4KKwogMjAxNS0wNi0xMCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtpdC5v cmc+CiAKICAgICAgICAgW0VGTF0gVW5yZXZpZXdlZCwgRUZMIGdhcmRlbmluZyBvbiBKdW4gMTB0 aApJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy9tYWluLXJl c291cmNlLXJlZGlyZWN0LWJsb2NrZWQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvbWFpbi1yZXNvdXJjZS1yZWRpcmVj dC1ibG9ja2VkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTg1NDI1KQkoZnJvbSBMYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL2NvbnRlbnRleHRlbnNpb25zL2xvYWRpbmcvbWFpbi1yZXNvdXJjZS1yZWRp cmVjdC1ibG9ja2VkLWV4cGVjdGVkLnR4dDoxODU0MjUpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2NvbnRlbnRleHRlbnNpb25zL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC1leHBl Y3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzIEBACittYWluIGZyYW1lIC0gZGlk U3RhcnRQcm92aXNpb25hbExvYWRGb3JGcmFtZQorbWFpbiBmcmFtZSAtIGRpZEZhaWxQcm92aXNp b25hbExvYWRXaXRoRXJyb3IKK21haW4gZnJhbWUgLSAoa1dLRXJyb3JDb2RlQ2Fubm90U2hvd1VS TCkKSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvbWFpbi1y ZXNvdXJjZS1yZWRpcmVjdC1ibG9ja2VkLnBocAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL2NvbnRlbnRleHRlbnNpb25zL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tl ZC5waHAJKHJldmlzaW9uIDE4NTQyNSkJKGZyb20gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb250 ZW50ZXh0ZW5zaW9ucy9sb2FkaW5nL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC5waHA6 MTg1NDI1KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy9tYWlu LXJlc291cmNlLXJlZGlyZWN0LWJsb2NrZWQucGhwCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs NCBAQAorPD9waHAKKyAgaGVhZGVyKCdMb2NhdGlvbjogcmVzb3VyY2VzL21haW4tcmVzb3VyY2Ut cmVkaXJlY3QtYmxvY2tlZC10YXJnZXQuaHRtbCcpOworICBoZWFkZXIoJ0hUVFAvMS4wIDMwMiBG b3VuZCcpOworPz4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lv bnMvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC1ibG9ja2VkLnBocC5qc29uCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvbWFpbi1yZXNvdXJjZS1y ZWRpcmVjdC1ibG9ja2VkLnBocC5qc29uCShyZXZpc2lvbiAxODU0MjUpCShmcm9tIExheW91dFRl c3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvbG9hZGluZy9tYWluLXJlc291cmNlLXJl ZGlyZWN0LWJsb2NrZWQucGhwLmpzb246MTg1NDI1KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9jb250ZW50ZXh0ZW5zaW9ucy9tYWluLXJlc291cmNlLXJlZGlyZWN0LWJsb2NrZWQucGhwLmpz b24JKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorWworICAgIHsKKyAgICAgICAgImFj dGlvbiI6IHsKKyAgICAgICAgICAgICJ0eXBlIjogImJsb2NrIgorICAgICAgICB9LAorICAgICAg ICAidHJpZ2dlciI6IHsKKyAgICAgICAgICAgICJ1cmwtZmlsdGVyIjogIi4qbWFpbi1yZXNvdXJj ZS1yZWRpcmVjdC1ibG9ja2VkLXRhcmdldC5odG1sIgorICAgICAgICB9CisgICAgfQorXQpJbmRl eDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy9sb2FkaW5nL21haW4t cmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy9sb2FkaW5nL21haW4tcmVzb3Vy Y2UtcmVkaXJlY3QtYmxvY2tlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDE4NTQyNSkKKysrIExh eW91dFRlc3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvbG9hZGluZy9tYWluLXJlc291 cmNlLXJlZGlyZWN0LWJsb2NrZWQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzAsMCBAQAotbWFpbiBmcmFtZSAtIGRpZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUKLW1h aW4gZnJhbWUgLSBkaWRGYWlsUHJvdmlzaW9uYWxMb2FkV2l0aEVycm9yCi1tYWluIGZyYW1lIC0g KGtXS0Vycm9yQ29kZUNhbm5vdFNob3dVUkwpCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L2NvbnRlbnRleHRlbnNpb25zL2xvYWRpbmcvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC1ibG9ja2Vk LnBocAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NvbnRlbnRleHRlbnNp b25zL2xvYWRpbmcvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC1ibG9ja2VkLnBocAkocmV2aXNpb24g MTg1NDI1KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy9sb2Fk aW5nL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC5waHAJKHdvcmtpbmcgY29weSkKQEAg LTEsNCArMCwwIEBACi08P3BocAotICBoZWFkZXIoJ0xvY2F0aW9uOiByZXNvdXJjZXMvbWFpbi1y ZXNvdXJjZS1yZWRpcmVjdC1ibG9ja2VkLXRhcmdldC5odG1sJyk7Ci0gIGhlYWRlcignSFRUUC8x LjAgMzAyIEZvdW5kJyk7Ci0/PgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb250ZW50 ZXh0ZW5zaW9ucy9sb2FkaW5nL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC5waHAuanNv bgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NvbnRlbnRleHRlbnNpb25z L2xvYWRpbmcvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC1ibG9ja2VkLnBocC5qc29uCShyZXZpc2lv biAxODU0MjUpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NvbnRlbnRleHRlbnNpb25zL2xv YWRpbmcvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC1ibG9ja2VkLnBocC5qc29uCSh3b3JraW5nIGNv cHkpCkBAIC0xLDEwICswLDAgQEAKLVsKLSAgICB7Ci0gICAgICAgICJhY3Rpb24iOiB7Ci0gICAg ICAgICAgICAidHlwZSI6ICJibG9jayIKLSAgICAgICAgfSwKLSAgICAgICAgInRyaWdnZXIiOiB7 Ci0gICAgICAgICAgICAidXJsLWZpbHRlciI6ICIuKm1haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxv Y2tlZC10YXJnZXQuaHRtbCIKLSAgICAgICAgfQotICAgIH0KLV0KSW5kZXg6IExheW91dFRlc3Rz L2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvbG9hZGluZy9yZXNvdXJjZXMvbWFpbi1yZXNv dXJjZS1yZWRpcmVjdC1ibG9ja2VkLXRhcmdldC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvbG9hZGluZy9yZXNvdXJjZXMvbWFpbi1y ZXNvdXJjZS1yZWRpcmVjdC1ibG9ja2VkLXRhcmdldC5odG1sCShyZXZpc2lvbiAxODU0MjUpCisr KyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NvbnRlbnRleHRlbnNpb25zL2xvYWRpbmcvcmVzb3Vy Y2VzL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC10YXJnZXQuaHRtbAkod29ya2luZyBj b3B5KQpAQCAtMSArMCwwIEBACi1UaGlzIHBhZ2Ugc2hvdWxkIG5ldmVyIGFjdHVhbGx5IGxvYWQu ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9jb250ZW50ZXh0ZW5zaW9ucy9yZXNvdXJjZXMvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC1ibG9j a2VkLXRhcmdldC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvY29u dGVudGV4dGVuc2lvbnMvcmVzb3VyY2VzL21haW4tcmVzb3VyY2UtcmVkaXJlY3QtYmxvY2tlZC10 YXJnZXQuaHRtbAkocmV2aXNpb24gMTg1NDI1KQkoZnJvbSBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L2NvbnRlbnRleHRlbnNpb25zL2xvYWRpbmcvcmVzb3VyY2VzL21haW4tcmVzb3VyY2UtcmVkaXJl Y3QtYmxvY2tlZC10YXJnZXQuaHRtbDoxODU0MjUpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L2NvbnRlbnRleHRlbnNpb25zL3Jlc291cmNlcy9tYWluLXJlc291cmNlLXJlZGlyZWN0LWJsb2Nr ZWQtdGFyZ2V0Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSBAQAorVGhpcyBwYWdlIHNo b3VsZCBuZXZlciBhY3R1YWxseSBsb2FkLgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK