145838 2015-06-10 04:50:42 -0700 [EFL] Implement minibrowser:version Web UI using custom scheme. 2015-09-14 10:55:32 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 hyungwook.lee hyungwook.lee gyuyoung.kim lucas.de.marchi ryuan.choi oldest_to_newest 1100989 0 hyungwook.lee 2015-06-10 04:50:42 -0700 Implement about:version Web UI using custom scheme. 1101016 1 254649 hyungwook.lee 2015-06-10 07:28:52 -0700 Created attachment 254649 Patch 1101871 2 254649 gyuyoung.kim 2015-06-14 21:08:31 -0700 Comment on attachment 254649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254649&action=review > Tools/MiniBrowser/efl/main.c:1041 > + if (has_scheme(arg) || eina_str_has_prefix(arg, "javascript:") || eina_str_has_prefix(arg, "minibrowser:") || !strcasecmp(arg, "about:blank")) Hmm... to be honest, MiniBrowser is a just simple application. In GTK MiniBrowser case, they didn't add new feature because minibrowser is just test application for own WebKit port. I don't know we need to add this feature to EFL MiniBrowser. 1101873 3 ryuan.choi 2015-06-14 21:35:11 -0700 (In reply to comment #2) > Comment on attachment 254649 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254649&action=review > > > Tools/MiniBrowser/efl/main.c:1041 > > + if (has_scheme(arg) || eina_str_has_prefix(arg, "javascript:") || eina_str_has_prefix(arg, "minibrowser:") || !strcasecmp(arg, "about:blank")) > > Hmm... to be honest, MiniBrowser is a just simple application. In GTK > MiniBrowser case, they didn't add new feature because minibrowser is just > test application for own WebKit port. I don't know we need to add this > feature to EFL MiniBrowser. I also don't think that it is usefull for MiniBrowser to have this. MiniBrowser is just simple browser to test basic functionality. 1101884 4 254649 hyungwook.lee 2015-06-14 23:25:26 -0700 Comment on attachment 254649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254649&action=review >>> Tools/MiniBrowser/efl/main.c:1041 >>> + if (has_scheme(arg) || eina_str_has_prefix(arg, "javascript:") || eina_str_has_prefix(arg, "minibrowser:") || !strcasecmp(arg, "about:blank")) >> >> Hmm... to be honest, MiniBrowser is a just simple application. In GTK MiniBrowser case, they didn't add new feature because minibrowser is just test application for own WebKit port. I don't know we need to add this feature to EFL MiniBrowser. > > I also don't think that it is usefull for MiniBrowser to have this. > > MiniBrowser is just simple browser to test basic functionality. I referenced GTK Mini Browser that supports 'about:minibrowser' scheme to show current version using Web UI. I think Web UI is very useful function for Mini Browser to provide many functions easily. ex) Settings, History, Cache Status, WebKit Debugging UI, etc... Actually I want to implement WebKit Debugging UI and WebKit Setting UI using Web UI for developer who want to enable / disable some features in runtime. 1125631 5 254649 ossy 2015-09-14 10:55:32 -0700 Comment on attachment 254649 Patch Cleared review? from attachment 254649 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 254649 2015-06-10 07:28:52 -0700 2015-09-14 10:55:32 -0700 Patch bug-145838-20150610232823.patch text/plain 2930 hyungwook.lee SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTQxNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE1LTA2LTEwICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZl cmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIEltcGxlbWVudCBtaW5pYnJvd3Nlcjp2ZXJzaW9u IFdlYiBVSSB1c2luZyBjdXN0b20gc2NoZW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1ODM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU3VwcG9ydCAnbWluaWJyb3dzZXI6dmVyc2lvbicgc2NoZW1l IHRvIHNob3cgY3VycmVudCBXZWJLaXQgRUZMIHZlcnNpb24gYnkgV2ViIFVJLgorCisgICAgICAg ICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKHVybF9mcm9tX3VzZXJfaW5wdXQp OgorICAgICAgICAob25fbWluaWJyb3dzZXJfc2NoZW1lKToKKyAgICAgICAgKGVsbV9tYWluKToK KwogMjAxNS0wNi0xMCAgSHl1bmd3b29rIExlZSAgPGh5dW5nd29vay5sZWVAbmF2ZXJjb3JwLmNv bT4KIAogICAgICAgICBbRUZMXSBFeGVjdXRlIEphdmFzY3JpcHQgbWV0aG9kIGluIG1pbmkgYnJv d3NlciBhZGRyZXNzIGJhci4KSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwkocmV2aXNpb24gMTg1NDA4 KQorKysgVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtMTAz OCw3ICsxMDM4LDcgQEAgc3RhdGljIGNoYXIgKgogdXJsX2Zyb21fdXNlcl9pbnB1dChjb25zdCBj aGFyICphcmcpCiB7CiAgICAgLyogSWYgaXQgaXMgYWxyZWFkeSBhIFVSTCwgcmV0dXJuIHRoZSBh cmd1bWVudCBhcyBpcy4gKi8KLSAgICBpZiAoaGFzX3NjaGVtZShhcmcpIHx8IGVpbmFfc3RyX2hh c19wcmVmaXgoYXJnLCAiamF2YXNjcmlwdDoiKSB8fCAhc3RyY2FzZWNtcChhcmcsICJhYm91dDpi bGFuayIpKQorICAgIGlmIChoYXNfc2NoZW1lKGFyZykgfHwgZWluYV9zdHJfaGFzX3ByZWZpeChh cmcsICJqYXZhc2NyaXB0OiIpIHx8IGVpbmFfc3RyX2hhc19wcmVmaXgoYXJnLCAibWluaWJyb3dz ZXI6IikgfHwgIXN0cmNhc2VjbXAoYXJnLCAiYWJvdXQ6YmxhbmsiKSkKICAgICAgICAgcmV0dXJu IHN0cmR1cChhcmcpOwogCiAgICAgRWluYV9TdHJidWYgKmJ1ZiA9IGVpbmFfc3RyYnVmX21hbmFn ZV9uZXcoZWluYV9maWxlX3BhdGhfc2FuaXRpemUoYXJnKSk7CkBAIC0yMDMwLDYgKzIwMzAsMjIg QEAgb25fd2luZG93X2RlbGV0aW9uKHZvaWQgKnVzZXJfZGF0YSwgRXZhcwogICAgIHdpbmRvd19j bG9zZSh3aW5kb3dfZmluZF93aXRoX2VsbV93aW5kb3coZWxtX3dpbmRvdykpOwogfQogCitzdGF0 aWMgdm9pZAorb25fbWluaWJyb3dzZXJfc2NoZW1lKEV3a19VcmxfU2NoZW1lX1JlcXVlc3QgKnJl cXVlc3QsIHZvaWQgKnVzZXJfZGF0YSkKK3sKKyAgICBjb25zdCBjaGFyICpwYXRoID0gZXdrX3Vy bF9zY2hlbWVfcmVxdWVzdF9wYXRoX2dldChyZXF1ZXN0KTsKKworICAgIEVpbmFfU3RyYnVmICpo dG1sID0gZWluYV9zdHJidWZfbmV3KCk7CisKKyAgICBpZiAoIXN0cmNtcChwYXRoLCAidmVyc2lv biIpKQorICAgICAgICBlaW5hX3N0cmJ1Zl9hcHBlbmRfcHJpbnRmKGh0bWwsICI8aHRtbD48Ym9k eT48aDE+V2ViS2l0RUZMIE1pbmlCcm93c2VyPC9oMT48cD5UaGUgV2ViS2l0MiB0ZXN0IGJyb3dz ZXIgb2YgdGhlIEVGTCBwb3J0LjwvcD48cD5WZXJzaW9uOiAlZC4lZC4lZDwvcD48L2JvZHk+PC9o dG1sPiIsIEVXS19WRVJTSU9OX01BSk9SLCBFV0tfVkVSU0lPTl9NSU5PUiwgRVdLX1ZFUlNJT05f TUlDUk8pOworICAgIGVsc2UKKyAgICAgICAgZWluYV9zdHJidWZfYXBwZW5kX3ByaW50ZihodG1s LCAiPGh0bWw8Ym9keT5JbnZhbGlkIG1pbmlicm93c2VyOiVzIHBhZ2UuPC9ib2R5PC9odG1sPiIs IHBhdGgpOworCisgICAgZXdrX3VybF9zY2hlbWVfcmVxdWVzdF9maW5pc2gocmVxdWVzdCwgZWlu YV9zdHJidWZfc3RyaW5nX2dldChodG1sKSwgZWluYV9zdHJidWZfbGVuZ3RoX2dldChodG1sKSwg InRleHQvaHRtbCIpOworICAgIGVpbmFfc3RyYnVmX2ZyZWUoaHRtbCk7Cit9CisKIHN0YXRpYyBF dmFzX09iamVjdCAqCiBjcmVhdGVfdG9vbGJhcl9idXR0b24oRXZhc19PYmplY3QgKmVsbV93aW5k b3csIGNvbnN0IGNoYXIgKmljb25fbmFtZSkKIHsKQEAgLTI0NzEsNiArMjQ4Nyw5IEBAIGVsbV9t YWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAgICAgLy8gU2V0IGNhbGxiYWNrcyBmb3IgZG93 bmxvYWQgZXZlbnRzLgogICAgIGV3a19jb250ZXh0X2Rvd25sb2FkX2NhbGxiYWNrc19zZXQoY29u dGV4dCwgb25fZG93bmxvYWRfcmVxdWVzdCwgb25fZG93bmxvYWRfZmFpbGVkLCAwLCBvbl9kb3du bG9hZF9maW5pc2hlZCwgd2luZG93KTsKIAorICAgIC8vIFJlZ2lzdGVyIG1pbmlicm93c2VyOiBz Y2hlbWUgZm9yIFdlYiBVSS4KKyAgICBld2tfY29udGV4dF91cmxfc2NoZW1lX3JlZ2lzdGVyKGNv bnRleHQsICJtaW5pYnJvd3NlciIsIG9uX21pbmlicm93c2VyX3NjaGVtZSwgTlVMTCk7CisgICAg CiAgICAgaWYgKGFyZ3MgPCBhcmdjKSB7CiAgICAgICAgIGNoYXIgKnVybCA9IHVybF9mcm9tX3Vz ZXJfaW5wdXQoYXJndlthcmdzXSk7CiAgICAgICAgIHVybF9sb2FkX2Zyb21fdXNlcl9pbnB1dCh3 aW5kb3ctPmV3a192aWV3LCB1cmwpOwo=