145837 2015-06-10 03:22:12 -0700 [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang 2015-10-01 08:39:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy cgarcia commit-queue gyuyoung.kim kumar.rohit ossy pnormand oldest_to_newest 1100971 0 ossy 2015-06-10 03:22:12 -0700 Building openwebrtc jhbuild module with clang fails: ----------------------------------------------------- /home/webkit/WebKit/WebKitBuild/DependenciesEFL/Root/include/gstreamer-1.0/gst/gstcompat.h:54:38: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if (((((GstPad*)(pad))->direction) == GST_PAD_SRC)) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ /home/webkit/WebKit/WebKitBuild/DependenciesEFL/Root/include/gstreamer-1.0/gst/gstcompat.h:54:38: note: remove extraneous parentheses around the comparison to silence this warning if (((((GstPad*)(pad))->direction) == GST_PAD_SRC)) ~ ^ ~ /home/webkit/WebKit/WebKitBuild/DependenciesEFL/Root/include/gstreamer-1.0/gst/gstcompat.h:54:38: note: use '=' to turn this equality comparison into an assignment if (((((GstPad*)(pad))->direction) == GST_PAD_SRC)) ^~ = 1 warning generated. ----- gstcompat.h:54 --> if (GST_PAD_IS_SRC (pad)) Removing the extra parentheses would be very ugly here, we should simply disable parentheses-equality warning. 1100972 1 ossy 2015-06-10 03:23:10 -0700 We have same error in gst-plugins-openwebrtc module. 1100975 2 ossy 2015-06-10 03:28:38 -0700 It can be fixed easily on EFL, because we download tarballs, which can be patched by jhbuild. But unfortunately GTK download git repositories, which can't be patched by jhbuild. 1100981 3 254643 ossy 2015-06-10 03:48:52 -0700 Created attachment 254643 Patch 1100982 4 254643 ossy 2015-06-10 03:51:47 -0700 Comment on attachment 254643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254643&action=review > Tools/efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch:10 > +-libgstvideorepair_la_CFLAGS = $(GST_CFLAGS) $(GST_PLUGINS_BASE_CFLAGS) -Wall -Wextra -Werror > ++libgstvideorepair_la_CFLAGS = $(GST_CFLAGS) $(GST_PLUGINS_BASE_CFLAGS) -Wall -Wextra Adding -Wno-parentheses-equality here doesn't work, because the parent Makefile adds -Wall to CFLAGS which comes after libgstvideorepair_la_CFLAGS and overrides the -Wno option. 1101000 5 kumar.rohit 2015-06-10 06:04:02 -0700 I have been facing this issue on GTK port for some time now. Is there any workaround to build WebKit for GTK port? 1101004 6 ossy 2015-06-10 06:16:10 -0700 (In reply to comment #5) > I have been facing this issue on GTK port for some time now. Is there any > workaround to build WebKit for GTK port? You can build the dependencies with GCC without any problem. And then you can build WebKit with GCC or Clang too. 1101532 7 ossy 2015-06-12 03:37:46 -0700 cc-ing Philip, maybe you are interested in fixing it for GTK and/or fixing it in upstream openwebrtc / gst-plugins-openwebrtc. 1101573 8 pnormand 2015-06-12 06:08:40 -0700 Would you like to submit the patch upstream? It's yours after all :) 1104930 9 ossy 2015-06-26 07:41:29 -0700 (In reply to comment #8) > Would you like to submit the patch upstream? It's yours after all :) upstream issues: https://github.com/EricssonResearch/openwebrtc-gst-plugins/issues/44 https://github.com/EricssonResearch/openwebrtc/issues/420 1113449 10 ossy 2015-07-30 11:45:44 -0700 I reported the bug upstream. Can we push this patch to WebKit to be able to build dependencies with clang? 1113640 11 254643 gyuyoung.kim 2015-07-30 21:12:29 -0700 Comment on attachment 254643 Patch rs=me. 1113695 12 254643 pnormand 2015-07-31 02:01:52 -0700 Comment on attachment 254643 Patch Please bump the version now that your patch was merged upstream :) 1128463 13 ossy 2015-09-24 03:46:55 -0700 (In reply to comment #12) > Comment on attachment 254643 [details] > Patch > > Please bump the version now that your patch was merged upstream :) Only the openwebrtc patch was merged, but bumping isn't as trivial as you think. Not at all. The openwebrtc-gst-plugin fix was rejected. Bumping to trunk openwebrtc is impossible, because https://github.com/EricssonResearch/openwebrtc/commit/49635a9eba2d3e081cab7ba631bc32a5521975dd needs newer gst-plugins-base - https://github.com/gstreamer-mirror/gst-plugins-base/commit/bfc13c8e51862662804dcc9d14bf3a7f9f0027bd . Or bumping to the exact openwebrtc revision which merged my fix isn't as easy, because we would need many unrelated fixes too: - https://github.com/EricssonResearch/openwebrtc/commit 605fbcdc734444a936dde73ddc19b300f59c7503 commit in openwebrtc uses a feature added to libnice by https://github.com/libnice/libnice/commit/4e4af4be3890f12e300fe71104564171091b7a17 , so we will need to bump libnice too. This commit is already included in 0.1.11. - Additionally we would have to fix FindOpenWebRTC.cmake too, because the package version was bumped by https://github.com/EricssonResearch/openwebrtc/commit/437679ffb777265f6bcfdea2be0d0aec8bc6a474 - We would need to add -Wno-parentheses-equality to the brand new tests/Makefile.am ---- I don't think if we should fix the whole world and bump absouletely unrelated modules to unstable revisions (with possible new bugs, etc.) just to suppress some compiler warnings. 1128464 14 254643 ossy 2015-09-24 03:55:17 -0700 Comment on attachment 254643 Patch r? again, I still think it is the easieast fix for this issue. 1128466 15 pnormand 2015-09-24 04:13:35 -0700 Bumping openwebrtc* only makes sense after we migrated to GStreamer 1.6.x. OpenWebRTC barely works anyway with older versions of GStreamer. 1128997 16 ossy 2015-09-28 04:28:09 -0700 So can we land this patch as is? 1129890 17 ossy 2015-10-01 03:00:05 -0700 ping? 1129924 18 254643 commit-queue 2015-10-01 08:39:29 -0700 Comment on attachment 254643 Patch Clearing flags on attachment: 254643 Committed r190409: <http://trac.webkit.org/changeset/190409> 1129925 19 commit-queue 2015-10-01 08:39:34 -0700 All reviewed patches have been landed. Closing bug. 254643 2015-06-10 03:48:52 -0700 2015-10-01 08:39:29 -0700 Patch bug-145837-20150610034823.patch text/plain 4636 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NDA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmIzMWU4MjY4YWRkMWM5YzQ3OTM1YTUxMzljOTExZDEz NWJiYjg5Ny4uNjM4MGYyNjE1NmFmODMxYTIwMzRkNjEzMmEwZWJiNDcwNDE3OWZhZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTA2LTEwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0VGTF0gRml4IHRoZSBvcGVud2VicnRjIGFuZCBnc3QtcGx1Z2lucy1vcGVud2Vi cnRjIGJ1aWxkIHdpdGggY2xhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NTgzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogZWZsL2poYnVpbGQubW9kdWxlczoKKyAgICAgICAgKiBlZmwvcGF0Y2hl cy9vcGVud2VicnRjLWNsYW5nLXdhcm5pbmctZml4LnBhdGNoOiBBZGRlZC4KKyAgICAgICAgKiBl ZmwvcGF0Y2hlcy9vcGVud2VicnRjLWdzdC1wbHVnaW5zLWNsYW5nLXdhcm5pbmctZml4LnBhdGNo OiBBZGRlZC4KKwogMjAxNS0wNi0wOSAgSHl1bmd3b29rIExlZSAgPGh5dW5nd29vay5sZWVAbmF2 ZXJjb3JwLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgZHVtcFByb2dyZXNzRmluaXNoZWRDYWxs YmFjaygpIGZvciBXaW4gbGF5b3V0VGVzdENvbnRyb2xsZXIuCmRpZmYgLS1naXQgYS9Ub29scy9l ZmwvamhidWlsZC5tb2R1bGVzIGIvVG9vbHMvZWZsL2poYnVpbGQubW9kdWxlcwppbmRleCAyMTYy NDY3OWQwZGIzMTI0ZmFiZjlhZDc4M2ExZWFhY2I0ZDQ2NGM2Li44MjVlNDUwZWQ4NTc5OGQwOWRh ZGVlOTJiYmM4ZDIyZTJiYmMwNjI0IDEwMDY0NAotLS0gYS9Ub29scy9lZmwvamhidWlsZC5tb2R1 bGVzCisrKyBiL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMKQEAgLTMyNyw2ICszMjcsNyBAQAog ICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1bGU9IkVyaWNzc29uUmVzZWFyY2gvb3Bl bndlYnJ0Yy1nc3QtcGx1Z2lucy9hcmNoaXZlL2UzNTliNjc0ODRhZjkwZjQxNmVhMzVlMzAxMjA1 ZDJiNTNjNzdhMTQudGFyLmd6IiBjaGVja291dGRpcj0iZ3N0LXBsdWdpbnMtb3BlbndlYnJ0YyIg dmVyc2lvbj0iZ3N0LXBsdWdpbnMtb3BlbndlYnJ0Yy0yMDE1MDMxNyIKICAgICAgICAgICAgaGFz aD0ic2hhMjU2OmE0NTY0MjVlZmI4OGRlMzljMTZhNGY4YWM0MjE0YWFmNTMxNTdmOWRmMTMyM2Yw OGRlMzc1Yzc3ZjIyN2I2YjciCiAgICAgICAgICAgIG1kNXN1bT0iODI3ZjEzNjM0ZmZhODNjY2Nm MWE2MzEyZWZmYmNlYWEiIHNpemU9IjkyODgzIj4KKyAgICAgIDxwYXRjaCBmaWxlPSJvcGVud2Vi cnRjLWdzdC1wbHVnaW5zLWNsYW5nLXdhcm5pbmctZml4LnBhdGNoIiBzdHJpcD0iMSIvPgogICAg PC9icmFuY2g+CiAgIDwvYXV0b3Rvb2xzPgogCkBAIC0zNDgsNiArMzQ5LDcgQEAKICAgICA8YnJh bmNoIHJlcG89ImdpdGh1Yi5jb20iIG1vZHVsZT0iRXJpY3Nzb25SZXNlYXJjaC9vcGVud2VicnRj L2FyY2hpdmUvMTM1MTZjN2Y3OWEwYzQ4YmI0MTE0NjRmNzYxM2Q0YjQyNmM3MGY1Yi50YXIuZ3oi IGNoZWNrb3V0ZGlyPSJvcGVud2VicnRjIiB2ZXJzaW9uPSIxMzUxNmM3Zjc5YTBjNDhiYjQxMTQ2 NGY3NjEzZDRiNDI2YzcwZjViIgogICAgICAgICAgICAgaGFzaD0ic2hhMjU2OmM4NDlkMzZkOTdj MTdhMTk4YTVkOWMxODBmMTNmMTRjNzg5N2M5MjM2ZTIzODRlYTExMDI5ZTIzYjA5YjU5YWMiCiAg ICAgICAgICAgICBtZDVzdW09IjEzNTE2YzdmNzlhMGM0OGJiNDExNDY0Zjc2MTNkNGI0MjZjNzBm NWIudGFyLmd6IiBzaXplPSIyNTg5MzYiPgorICAgICAgPHBhdGNoIGZpbGU9Im9wZW53ZWJydGMt Y2xhbmctd2FybmluZy1maXgucGF0Y2giIHN0cmlwPSIxIi8+CiAgICAgPC9icmFuY2g+CiAgIDwv YXV0b3Rvb2xzPgogCmRpZmYgLS1naXQgYS9Ub29scy9lZmwvcGF0Y2hlcy9vcGVud2VicnRjLWNs YW5nLXdhcm5pbmctZml4LnBhdGNoIGIvVG9vbHMvZWZsL3BhdGNoZXMvb3BlbndlYnJ0Yy1jbGFu Zy13YXJuaW5nLWZpeC5wYXRjaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43ZGZiNDM1NmVmZjJlMzg2OWViYmIxNzE2 NDY4MDMyN2EzZDRlYTMxCi0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvZWZsL3BhdGNoZXMvb3Bl bndlYnJ0Yy1jbGFuZy13YXJuaW5nLWZpeC5wYXRjaApAQCAtMCwwICsxLDQ4IEBACitkaWZmIC0t Z2l0IGEvZ3N0L01ha2VmaWxlLmFtIGIvZ3N0L01ha2VmaWxlLmFtCitpbmRleCBkMGUwMDYyLi5k NGJjY2VhIDEwMDY0NAorLS0tIGEvZ3N0L01ha2VmaWxlLmFtCisrKysgYi9nc3QvTWFrZWZpbGUu YW0KK0BAIC0xMyw2ICsxMyw3IEBAIEFNX0NGTEFHUyA9IFwKKyAgICAgLVdhbGwgXAorICAgICAt V2V4dHJhIFwKKyAgICAgLVdlcnJvciBcCisrICAgIC1Xbm8tcGFyZW50aGVzZXMtZXF1YWxpdHkg XAorICAgICAkKERFQlVHX0NGTEFHUykKKyAKKyBsaWJfTFRMSUJSQVJJRVMgPSBsaWJvcGVud2Vi cnRjX2dzdC5sYQorZGlmZiAtLWdpdCBhL2xvY2FsL01ha2VmaWxlLmFtIGIvbG9jYWwvTWFrZWZp bGUuYW0KK2luZGV4IGUyZTc4NzYuLmM2ZGMyZjcgMTAwNjQ0CistLS0gYS9sb2NhbC9NYWtlZmls ZS5hbQorKysrIGIvbG9jYWwvTWFrZWZpbGUuYW0KK0BAIC0xMyw2ICsxMyw3IEBAIEFNX0NGTEFH UyA9IFwKKyAgICAgLVdhbGwgXAorICAgICAtV2V4dHJhIFwKKyAgICAgLVdlcnJvciBcCisrICAg IC1Xbm8tcGFyZW50aGVzZXMtZXF1YWxpdHkgXAorICAgICAkKERFQlVHX0NGTEFHUykKKyAKKyBu b2luc3RfTFRMSUJSQVJJRVMgPSBsaWJvcGVud2VicnRjX2xvY2FsLmxhCitkaWZmIC0tZ2l0IGEv b3dyL01ha2VmaWxlLmFtIGIvb3dyL01ha2VmaWxlLmFtCitpbmRleCAyYWY0NzM1Li5kYzNmMWYy IDEwMDY0NAorLS0tIGEvb3dyL01ha2VmaWxlLmFtCisrKysgYi9vd3IvTWFrZWZpbGUuYW0KK0BA IC0xNCw2ICsxNCw3IEBAIEFNX0NGTEFHUyA9IFwKKyAgICAgLVdhbGwgXAorICAgICAtV2V4dHJh IFwKKyAgICAgLVdlcnJvciBcCisrICAgIC1Xbm8tcGFyZW50aGVzZXMtZXF1YWxpdHkgXAorICAg ICAkKERFQlVHX0NGTEFHUykKKyAKKyBsaWJfTFRMSUJSQVJJRVMgPSBsaWJvcGVud2VicnRjLmxh CitkaWZmIC0tZ2l0IGEvdHJhbnNwb3J0L01ha2VmaWxlLmFtIGIvdHJhbnNwb3J0L01ha2VmaWxl LmFtCitpbmRleCAzMTRlYTUzLi41YjVjNzQ5IDEwMDY0NAorLS0tIGEvdHJhbnNwb3J0L01ha2Vm aWxlLmFtCisrKysgYi90cmFuc3BvcnQvTWFrZWZpbGUuYW0KK0BAIC0xNSw2ICsxNSw3IEBAIEFN X0NGTEFHUyA9IFwKKyAgICAgLVdhbGwgXAorICAgICAtV2V4dHJhIFwKKyAgICAgLVdlcnJvciBc CisrICAgIC1Xbm8tcGFyZW50aGVzZXMtZXF1YWxpdHkgXAorICAgICAkKERFQlVHX0NGTEFHUykK KyAKKyBub2luc3RfTFRMSUJSQVJJRVMgPSBsaWJvcGVud2VicnRjX3RyYW5zcG9ydC5sYQpkaWZm IC0tZ2l0IGEvVG9vbHMvZWZsL3BhdGNoZXMvb3BlbndlYnJ0Yy1nc3QtcGx1Z2lucy1jbGFuZy13 YXJuaW5nLWZpeC5wYXRjaCBiL1Rvb2xzL2VmbC9wYXRjaGVzL29wZW53ZWJydGMtZ3N0LXBsdWdp bnMtY2xhbmctd2FybmluZy1maXgucGF0Y2gKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTI2YmE3ZTk5MjA1Y2NkMzg3 Y2IxMGY3MDcyM2U2NTI5MWUzZmFkNQotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL2VmbC9wYXRj aGVzL29wZW53ZWJydGMtZ3N0LXBsdWdpbnMtY2xhbmctd2FybmluZy1maXgucGF0Y2gKQEAgLTAs MCArMSwxMyBAQAorZGlmZiAtLWdpdCBhL2dzdC92aWRlb3JlcGFpci9NYWtlZmlsZS5hbSBiL2dz dC92aWRlb3JlcGFpci9NYWtlZmlsZS5hbQoraW5kZXggMzQ0ODdiNS4uMzRjMzg4NyAxMDA2NDQK Ky0tLSBhL2dzdC92aWRlb3JlcGFpci9NYWtlZmlsZS5hbQorKysrIGIvZ3N0L3ZpZGVvcmVwYWly L01ha2VmaWxlLmFtCitAQCAtMTcsNyArMTcsNyBAQCBwbHVnaW5fTFRMSUJSQVJJRVMgPSBsaWJn c3R2aWRlb3JlcGFpci5sYQorIGxpYmdzdHZpZGVvcmVwYWlyX2xhX1NPVVJDRVMgPSBnc3R2aWRl b3JlcGFpci5jCisgCisgIyBjb21waWxlciBhbmQgbGlua2VyIGZsYWdzIHVzZWQgdG8gY29tcGls ZSB0aGlzIHBsdWdpbiwgc2V0IGluIGNvbmZpZ3VyZS5hYworLWxpYmdzdHZpZGVvcmVwYWlyX2xh X0NGTEFHUyA9ICQoR1NUX0NGTEFHUykgJChHU1RfUExVR0lOU19CQVNFX0NGTEFHUykgLVdhbGwg LVdleHRyYSAtV2Vycm9yCisrbGliZ3N0dmlkZW9yZXBhaXJfbGFfQ0ZMQUdTID0gJChHU1RfQ0ZM QUdTKSAkKEdTVF9QTFVHSU5TX0JBU0VfQ0ZMQUdTKSAtV2FsbCAtV2V4dHJhCisgbGliZ3N0dmlk ZW9yZXBhaXJfbGFfTElCQUREID0gJChHU1RfTElCUykgLWxnc3R2aWRlby0xLjAKKyBsaWJnc3R2 aWRlb3JlcGFpcl9sYV9MREZMQUdTID0gJChHU1RfUExVR0lOX0xERkxBR1MpCisgaWYgIUdTVF9Q TFVHSU5fQlVJTERfU1RBVElDCg==