145832 2015-06-10 00:05:24 -0700 [WinCairo] Crash on exit when terminating egl 2016-06-01 05:19:36 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=157973 P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham cgarcia mcatanzaro oldest_to_newest 1100931 0 peavo 2015-06-10 00:05:24 -0700 I'm getting a crash on exit when egl is being terminated. atidxx32.dll!5aa314c8() [Frames below may be incorrect and/or missing, no symbols loaded for atidxx32.dll] atiuxpag.dll!73fb29f7() d3d11.dll!5814e03c() d3d11.dll!5814b4dd() d3d11.dll!5814d979() d3d11.dll!5814bb03() d3d11.dll!5816cbe8() d3d11.dll!5816c59d() d3d11.dll!5816cb06() d3d11.dll!5816c8c0() d3d11.dll!5816c75e() d3d11.dll!58149241() > libGLESv2.dll!rx::SwapChain11::release() Line 57 + 0xd bytes C++ libGLESv2.dll!rx::SwapChain11::`scalar deleting destructor'() + 0x11 bytes C++ libEGL.dll!egl::Surface::`scalar deleting destructor'() + 0x1e bytes C++ libEGL.dll!egl::Display::terminate() Line 125 + 0x15 bytes C++ libEGL.dll!eglTerminate(void * dpy) Line 157 C++ WebKit.dll!WebCore::PlatformDisplayWin::`scalar deleting destructor'() + 0x1a bytes C++ WebKit.dll!`WebCore::PlatformDisplay::sharedDisplay'::`2'::`dynamic atexit destructor for 'display''() + 0x10 bytes C++ WebKit.dll!_CRT_INIT(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 416 C WebKit.dll!__DllMainCRTStartup(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 522 + 0xc bytes C WebKit.dll!_DllMainCRTStartup(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 472 + 0xe bytes C ntdll.dll!77668d44() 1100932 1 254631 peavo 2015-06-10 00:09:51 -0700 Created attachment 254631 Patch 1100938 2 254631 cgarcia 2015-06-10 00:47:08 -0700 Comment on attachment 254631 Patch I don't think this is correct, I didn't use NeverDestroyed on purpose, since both X11 and wayland display implementation have cleanup in their destructors. I think the point here is why it crashes on windows when terminating EGL, and if it's a windows specific bug, I would add an ifdef to the destructor for windows platform to avoid the EGL termination 1100951 3 254637 peavo 2015-06-10 01:52:32 -0700 Created attachment 254637 Patch 1100952 4 peavo 2015-06-10 01:53:12 -0700 (In reply to comment #2) > Comment on attachment 254631 [details] > Patch > > I don't think this is correct, I didn't use NeverDestroyed on purpose, since > both X11 and wayland display implementation have cleanup in their > destructors. I think the point here is why it crashes on windows when > terminating EGL, and if it's a windows specific bug, I would add an ifdef to > the destructor for windows platform to avoid the EGL termination Thanks for reviewing :) Updated patch. 1100955 5 254637 cgarcia 2015-06-10 02:04:21 -0700 Comment on attachment 254637 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254637&action=review Ok, I think it would be interesting to know why it crashes, though, you might be hiding an actual bug rather than fixing it. > Source/WebCore/platform/graphics/PlatformDisplay.cpp:112 > +#if USE(EGL) && !PLATFORM(WIN) // WinCairo crashes when terminating EGL on exit I would move the comment to the previous line, finishing with a period, and adding a link to this bug. And if this is not supposed to crash on termination, it should be a FIXME comment to make it clear this is a workaround, not the proper fix. 1100974 6 peavo 2015-06-10 03:27:11 -0700 I believe it crashes because libEGL.dll is unloaded before eglTerminate is called. 1100984 7 254644 peavo 2015-06-10 04:07:18 -0700 Created attachment 254644 Patch 1100988 8 peavo 2015-06-10 04:35:43 -0700 Committed r185411: <http://trac.webkit.org/changeset/185411> 1198123 9 mcatanzaro 2016-06-01 05:19:36 -0700 Could this be bug #157973? 254631 2015-06-10 00:09:51 -0700 2015-06-10 01:52:23 -0700 Patch bug-145832-20150610090854.patch text/plain 1584 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTQwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTEwICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIENyYXNo IG9uIGV4aXQgd2hlbiB0ZXJtaW5hdGluZyBlZ2wKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTgzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkIHRlcm1pbmF0aW5nIGVnbCBvbiBleGl0IGJ5IHVz aW5nIE5ldmVyRGVzdHJveWVkIHRlbXBsYXRlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvUGxhdGZvcm1EaXNwbGF5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxh eTo6c2hhcmVkRGlzcGxheSk6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6OlBs YXRmb3JtRGlzcGxheSk6CisKIDIwMTUtMDYtMDkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFi bGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBEZWZlcnJlZFdyYXBwZXIgc2hvdWxkIGNsZWFy IGl0cyBKUyBzdHJvbmcgcmVmZXJlbmNlcyBvbmNlIGl0cyBwcm9taXNlIGlzIHJlc29sdmVkL3Jl amVjdGVkCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURp c3BsYXkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L1BsYXRmb3JtRGlzcGxheS5jcHAJKHJldmlzaW9uIDE4NTQwNCkKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTkzLDExICs5MywxMSBAQCBzdGQ6OnVuaXF1ZV9wdHI8UGxhdGZvcm1EaXNwbGF5PiBQbGF0Zm9y CiBQbGF0Zm9ybURpc3BsYXkmIFBsYXRmb3JtRGlzcGxheTo6c2hhcmVkRGlzcGxheSgpCiB7CiAg ICAgc3RhdGljIHN0ZDo6b25jZV9mbGFnIG9uY2VGbGFnOwotICAgIHN0YXRpYyBzdGQ6OnVuaXF1 ZV9wdHI8UGxhdGZvcm1EaXNwbGF5PiBkaXNwbGF5OworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3ll ZDxzdGQ6OnVuaXF1ZV9wdHI8UGxhdGZvcm1EaXNwbGF5Pj4gZGlzcGxheTsKICAgICBzdGQ6OmNh bGxfb25jZShvbmNlRmxhZywgW117Ci0gICAgICAgIGRpc3BsYXkgPSBjcmVhdGVQbGF0Zm9ybURp c3BsYXkoKTsKKyAgICAgICAgZGlzcGxheS5nZXQoKSA9IGNyZWF0ZVBsYXRmb3JtRGlzcGxheSgp OwogICAgIH0pOwotICAgIHJldHVybiAqZGlzcGxheTsKKyAgICByZXR1cm4gKmRpc3BsYXkuZ2V0 KCk7CiB9CiAKIFBsYXRmb3JtRGlzcGxheTo6UGxhdGZvcm1EaXNwbGF5KCkK 254637 2015-06-10 01:52:32 -0700 2015-06-10 04:07:10 -0700 Patch bug-145832-20150610105135.patch text/plain 1249 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTQwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTEwICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIENyYXNo IG9uIGV4aXQgd2hlbiB0ZXJtaW5hdGluZyBlZ2wKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTgzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkIHRlcm1pbmF0aW5nIGVnbCBvbiBleGl0IGZvciBX aW5DYWlyby4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6On5QbGF0Zm9ybURpc3BsYXkp OgorCiAyMDE1LTA2LTEwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CiAKICAgICAgICAgUmVmYWN0b3IgQXVkaW9Db250ZXh0IGltcGxlbWVudGF0aW9uIHRvIGVu YWJsZSBhdXRvbWF0aWMgYmluZGluZyBnZW5lcmF0aW9uIG9mIHByb21pc2UtYmFzZWQgbWV0aG9k cwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QbGF0 Zm9ybURpc3BsYXkuY3BwCShyZXZpc2lvbiAxODU0MDQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDks NyArMTA5LDcgQEAgUGxhdGZvcm1EaXNwbGF5OjpQbGF0Zm9ybURpc3BsYXkoKQogCiBQbGF0Zm9y bURpc3BsYXk6On5QbGF0Zm9ybURpc3BsYXkoKQogewotI2lmIFVTRShFR0wpCisjaWYgVVNFKEVH TCkgJiYgIVBMQVRGT1JNKFdJTikgLy8gV2luQ2Fpcm8gY3Jhc2hlcyB3aGVuIHRlcm1pbmF0aW5n IEVHTCBvbiBleGl0CiAgICAgdGVybWluYXRlRUdMRGlzcGxheSgpOwogI2VuZGlmCiB9Cg== 254644 2015-06-10 04:07:18 -0700 2015-06-10 04:17:56 -0700 Patch bug-145832-20150610130621.patch text/plain 1310 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTQxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTEwICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIENyYXNo IG9uIGV4aXQgd2hlbiB0ZXJtaW5hdGluZyBlZ2wKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTgzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkIHRlcm1pbmF0aW5nIGVnbCBvbiBleGl0IGZvciBX aW5DYWlyby4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6On5QbGF0Zm9ybURpc3BsYXkp OgorCiAyMDE1LTA2LTEwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CiAKICAgICAgICAgUmVmYWN0b3IgQXVkaW9Db250ZXh0IGltcGxlbWVudGF0aW9uIHRvIGVu YWJsZSBhdXRvbWF0aWMgYmluZGluZyBnZW5lcmF0aW9uIG9mIHByb21pc2UtYmFzZWQgbWV0aG9k cwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QbGF0 Zm9ybURpc3BsYXkuY3BwCShyZXZpc2lvbiAxODU0MTApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDks NyArMTA5LDkgQEAgUGxhdGZvcm1EaXNwbGF5OjpQbGF0Zm9ybURpc3BsYXkoKQogCiBQbGF0Zm9y bURpc3BsYXk6On5QbGF0Zm9ybURpc3BsYXkoKQogewotI2lmIFVTRShFR0wpCisgICAgLy8gV2lu Q2Fpcm8gY3Jhc2hlcyB3aGVuIHRlcm1pbmF0aW5nIEVHTCBvbiBleGl0LgorICAgIC8vIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU4MzIKKyNpZiBVU0UoRUdMKSAm JiAhUExBVEZPUk0oV0lOKQogICAgIHRlcm1pbmF0ZUVHTERpc3BsYXkoKTsKICNlbmRpZgogfQo=