145826 2015-06-09 16:37:31 -0700 Update presentation mode JS API to using 'picture-in-picture' 2015-06-10 19:57:45 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 145825 1 jonlee jonlee commit-queue webkit-bug-importer oldest_to_newest 1100857 0 jonlee 2015-06-09 16:37:31 -0700 Update presentation mode JS API to using 'picture-in-picture' 1100858 1 webkit-bug-importer 2015-06-09 16:37:45 -0700 <rdar://problem/21311535> 1101184 2 254695 jonlee 2015-06-10 17:52:33 -0700 Created attachment 254695 Patch 1101202 3 254695 commit-queue 2015-06-10 19:57:42 -0700 Comment on attachment 254695 Patch Clearing flags on attachment: 254695 Committed r185446: <http://trac.webkit.org/changeset/185446> 1101203 4 commit-queue 2015-06-10 19:57:45 -0700 All reviewed patches have been landed. Closing bug. 254695 2015-06-10 17:52:33 -0700 2015-06-10 19:57:42 -0700 Patch bug-145826-20150610175205.patch text/plain 7182 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQyNzcyYzQyYmZkM2E5 NzRmOTAxNTdiYWU1NzFkYjk2NjIwNWIwYi4uMjg3MWM1NGVkNDljZDZlMDVhMTBlNzY1YzIwYTYz N2JhY2IwMTAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTA2LTEwICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBVcGRhdGUgcHJlc2VudGF0aW9uIG1v ZGUgSlMgQVBJIHRvIHVzaW5nICdwaWN0dXJlLWluLXBpY3R1cmUnCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU4MjYKKyAgICAgICAgcmRhcjovL3By b2JsZW0vMjEzMTE1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFVwZGF0ZSBwcmVzZW50YXRpb24gbW9kZXMgdG8gdXNlICdwaWN0dXJlLWluLXBpY3R1 cmUnIGluIGxpZXUgb2YgJ29wdGltaXplZCcuCisKKyAgICAgICAgKiBodG1sL0hUTUxWaWRlb0Vs ZW1lbnQuaWRsOiBVcGRhdGUgdG8gInBpY3R1cmUtaW4tcGljdHVyZSIuCisgICAgICAgICogaHRt bC9IVE1MVmlkZW9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnByZXNlbnRhdGlvbk1v ZGVQaWN0dXJlSW5QaWN0dXJlKTogUmVuYW1lIHN0YXRpYyBmdW5jdGlvbiByZXR1cm5pbmcgc3Ry aW5nLgorICAgICAgICAoV2ViQ29yZTo6cHJlc2VudGF0aW9uTW9kZU9wdGltaXplZCk6IERlbGV0 ZWQuCisgICAgICAgIChXZWJDb3JlOjpIVE1MVmlkZW9FbGVtZW50Ojp3ZWJraXRTdXBwb3J0c1By ZXNlbnRhdGlvbk1vZGUpOiBVc2UgdGhlIG5ldyBzdGF0aWMgZnVuY3Rpb24gbmFtZS4KKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxWaWRlb0VsZW1lbnQ6OndlYmtpdFNldFByZXNlbnRhdGlvbk1vZGUp OiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxWaWRlb0VsZW1lbnQ6OndlYmtpdFByZXNl bnRhdGlvbk1vZGUpOiBEaXR0by4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9t ZWRpYUNvbnRyb2xzaU9TLmpzOiBVcGRhdGUgdG8gJ3BpY3R1cmUtaW4tcGljdHVyZScuCisgICAg ICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5jb25maWd1cmVJbmxpbmVDb250cm9scyk6IAor ICAgICAgICAoQ29udHJvbGxlcklPUy5wcm90b3R5cGUuaXNGdWxsU2NyZWVuKToKKyAgICAgICAg KENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZU9wdGltaXplZEZ1bGxzY3JlZW5CdXR0b25D bGlja2VkKToKKyAgICAgICAgKENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZVByZXNlbnRh dGlvbk1vZGVDaGFuZ2UpOgorICAgICAgICAoQ29udHJvbGxlcklPUy5wcm90b3R5cGUuY29udHJv bHNBbHdheXNWaXNpYmxlKToKKwogMjAxNS0wNi0wOSAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJv dWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIGZlQ29tcG9zaXRlIGZpbHRlciBkb2VzIG5v dCBjbGlwIHRoZSBwYWludCByZWN0IHRvIGl0cyBlZmZlY3QgcmVjdCB3aGVuIHRoZSBvcGVyYXRv ciBpcyAnaW4nIG9yICdhdG9wJwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwppbmRleCA5ZDQwMjgwNjU5YzBmYmJi N2Y2MDVhOTg0NDY4NmIyNjQwZTQ4ZmM0Li5iNTdiNDhkY2JiZDI4MWFhY2UwMzc5OTBhYjA2NjFh OTA3NmNiYzI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJv bHMvbWVkaWFDb250cm9sc2lPUy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh Y29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwpAQCAtMTgwLDcgKzE4MCw3IEBAIENvbnRyb2xs ZXJJT1MucHJvdG90eXBlID0gewogICAgICAgICAgICAgLy8gSGlkZSB0aGUgc2NydWJiZXIgb24g YXVkaW8gdW50aWwgdGhlIHVzZXIgc3RhcnRzIHBsYXlpbmcuCiAgICAgICAgICAgICB0aGlzLmNv bnRyb2xzLnRpbWVsaW5lQm94LmNsYXNzTGlzdC5hZGQodGhpcy5DbGFzc05hbWVzLmhpZGRlbik7 CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBpZiAoQ29udHJvbGxlci5nU2ltdWxhdGVP cHRpbWl6ZWRGdWxsc2NyZWVuQXZhaWxhYmxlIHx8ICgnd2Via2l0U3VwcG9ydHNQcmVzZW50YXRp b25Nb2RlJyBpbiB0aGlzLnZpZGVvICYmIHRoaXMudmlkZW8ud2Via2l0U3VwcG9ydHNQcmVzZW50 YXRpb25Nb2RlKCdvcHRpbWl6ZWQnKSkpCisgICAgICAgICAgICBpZiAoQ29udHJvbGxlci5nU2lt dWxhdGVPcHRpbWl6ZWRGdWxsc2NyZWVuQXZhaWxhYmxlIHx8ICgnd2Via2l0U3VwcG9ydHNQcmVz ZW50YXRpb25Nb2RlJyBpbiB0aGlzLnZpZGVvICYmIHRoaXMudmlkZW8ud2Via2l0U3VwcG9ydHNQ cmVzZW50YXRpb25Nb2RlKCdwaWN0dXJlLWluLXBpY3R1cmUnKSkpCiAgICAgICAgICAgICAgICAg dGhpcy5jb250cm9scy5wYW5lbC5hcHBlbmRDaGlsZCh0aGlzLmNvbnRyb2xzLm9wdGltaXplZEZ1 bGxzY3JlZW5CdXR0b24pOwogICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbC5hcHBlbmRD aGlsZCh0aGlzLmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24pOwogICAgICAgICB9CkBAIC0zOTUs NyArMzk1LDcgQEAgQ29udHJvbGxlcklPUy5wcm90b3R5cGUgPSB7CiAKICAgICBpc0Z1bGxTY3Jl ZW46IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHJldHVybiB0aGlzLnZpZGVvLndlYmtpdERp c3BsYXlpbmdGdWxsc2NyZWVuICYmIHRoaXMucHJlc2VudGF0aW9uTW9kZSgpICE9ICdvcHRpbWl6 ZWQnOworICAgICAgICByZXR1cm4gdGhpcy52aWRlby53ZWJraXREaXNwbGF5aW5nRnVsbHNjcmVl biAmJiB0aGlzLnByZXNlbnRhdGlvbk1vZGUoKSAhPSAncGljdHVyZS1pbi1waWN0dXJlJzsKICAg ICB9LAogCiAgICAgaGFuZGxlRnVsbHNjcmVlbkJ1dHRvbkNsaWNrZWQ6IGZ1bmN0aW9uKGV2ZW50 KSB7CkBAIC00MzUsMTAgKzQzNSwxMCBAQCBDb250cm9sbGVySU9TLnByb3RvdHlwZSA9IHsKICAg ICAgICAgaWYgKCEoJ3dlYmtpdFNldFByZXNlbnRhdGlvbk1vZGUnIGluIHRoaXMudmlkZW8pKQog ICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGlmICh0aGlzLnByZXNlbnRhdGlvbk1vZGUo KSA9PT0gJ29wdGltaXplZCcpCisgICAgICAgIGlmICh0aGlzLnByZXNlbnRhdGlvbk1vZGUoKSA9 PT0gJ3BpY3R1cmUtaW4tcGljdHVyZScpCiAgICAgICAgICAgICB0aGlzLnZpZGVvLndlYmtpdFNl dFByZXNlbnRhdGlvbk1vZGUoJ2lubGluZScpOwogICAgICAgICBlbHNlCi0gICAgICAgICAgICB0 aGlzLnZpZGVvLndlYmtpdFNldFByZXNlbnRhdGlvbk1vZGUoJ29wdGltaXplZCcpOworICAgICAg ICAgICAgdGhpcy52aWRlby53ZWJraXRTZXRQcmVzZW50YXRpb25Nb2RlKCdwaWN0dXJlLWluLXBp Y3R1cmUnKTsKICAgICB9LAogCiAgICAgaGFuZGxlT3B0aW1pemVkRnVsbHNjcmVlblRvdWNoU3Rh cnQ6IGZ1bmN0aW9uKCkgewpAQCAtNTczLDcgKzU3Myw3IEBAIENvbnRyb2xsZXJJT1MucHJvdG90 eXBlID0gewogCiAgICAgICAgICAgICAgICAgdGhpcy5jb250cm9scy5vcHRpbWl6ZWRGdWxsc2Ny ZWVuQnV0dG9uLmNsYXNzTGlzdC5yZW1vdmUodGhpcy5DbGFzc05hbWVzLnJldHVybkZyb21PcHRp bWl6ZWQpOwogICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgY2FzZSAnb3B0aW1p emVkJzoKKyAgICAgICAgICAgIGNhc2UgJ3BpY3R1cmUtaW4tcGljdHVyZSc6CiAgICAgICAgICAg ICAgICAgdmFyIGJhY2tncm91bmRJbWFnZSA9ICJ1cmwoJyIgKyB0aGlzLmhvc3QubWVkaWFVSUlt YWdlRGF0YSgib3B0aW1pemVkLWZ1bGxzY3JlZW4tcGxhY2Vob2xkZXIiKSArICInKSI7CiAgICAg ICAgICAgICAgICAgdGhpcy5jb250cm9scy5pbmxpbmVQbGF5YmFja1BsYWNlaG9sZGVyLnN0eWxl LmJhY2tncm91bmRJbWFnZSA9IGJhY2tncm91bmRJbWFnZTsKICAgICAgICAgICAgICAgICB0aGlz LmNvbnRyb2xzLmlubGluZVBsYXliYWNrUGxhY2Vob2xkZXIuc2V0QXR0cmlidXRlKCdhcmlhLWxh YmVsJywgInZpZGVvIHBsYXliYWNrIHBsYWNlaG9sZGVyIik7CkBAIC02MTEsNyArNjExLDcgQEAg Q29udHJvbGxlcklPUy5wcm90b3R5cGUgPSB7CiAKICAgICBjb250cm9sc0Fsd2F5c1Zpc2libGU6 IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIGlmICh0aGlzLnByZXNlbnRhdGlvbk1vZGUoKSA9 PT0gJ29wdGltaXplZCcpCisgICAgICAgIGlmICh0aGlzLnByZXNlbnRhdGlvbk1vZGUoKSA9PT0g J3BpY3R1cmUtaW4tcGljdHVyZScpCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgICAg ICByZXR1cm4gQ29udHJvbGxlci5wcm90b3R5cGUuY29udHJvbHNBbHdheXNWaXNpYmxlLmNhbGwo dGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlkZW9FbGVtZW50LmNwcAppbmRleCA4YTJm YmI0YTExODlmODlmNDE1Yjg3MmEwN2ZkM2FhODM4ZTQ4ODc3Li4xNzhhNjMzNmIyZGYyMGZkNWE3 MzkxNDM4OTAxOGVlNzEwN2ZkYTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxWaWRlb0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFZpZGVvRWxl bWVudC5jcHAKQEAgLTM1MSwxMCArMzUxLDEwIEBAIHN0YXRpYyBjb25zdCBBdG9taWNTdHJpbmcm IHByZXNlbnRhdGlvbk1vZGVGdWxsc2NyZWVuKCkKICAgICByZXR1cm4gZnVsbHNjcmVlbjsKIH0K IAotc3RhdGljIGNvbnN0IEF0b21pY1N0cmluZyYgcHJlc2VudGF0aW9uTW9kZU9wdGltaXplZCgp CitzdGF0aWMgY29uc3QgQXRvbWljU3RyaW5nJiBwcmVzZW50YXRpb25Nb2RlUGljdHVyZUluUGlj dHVyZSgpCiB7Ci0gICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPEF0b21pY1N0cmluZz4gb3B0aW1p emVkKCJvcHRpbWl6ZWQiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKTsKLSAg ICByZXR1cm4gb3B0aW1pemVkOworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxBdG9taWNTdHJp bmc+IHBpY3R1cmVJblBpY3R1cmUoInBpY3R1cmUtaW4tcGljdHVyZSIsIEF0b21pY1N0cmluZzo6 Q29uc3RydWN0RnJvbUxpdGVyYWwpOworICAgIHJldHVybiBwaWN0dXJlSW5QaWN0dXJlOwogfQog CiBzdGF0aWMgY29uc3QgQXRvbWljU3RyaW5nJiBwcmVzZW50YXRpb25Nb2RlSW5saW5lKCkKQEAg LTM2OCw3ICszNjgsNyBAQCBib29sIEhUTUxWaWRlb0VsZW1lbnQ6OndlYmtpdFN1cHBvcnRzUHJl c2VudGF0aW9uTW9kZShjb25zdCBTdHJpbmcmIG1vZGUpIGNvbnN0CiAgICAgaWYgKG1vZGUgPT0g cHJlc2VudGF0aW9uTW9kZUZ1bGxzY3JlZW4oKSkKICAgICAgICAgcmV0dXJuIG1lZGlhU2Vzc2lv bigpLmZ1bGxzY3JlZW5QZXJtaXR0ZWQoKnRoaXMpICYmIHN1cHBvcnRzRnVsbHNjcmVlbigpOwog Ci0gICAgaWYgKG1vZGUgPT0gcHJlc2VudGF0aW9uTW9kZU9wdGltaXplZCgpKQorICAgIGlmICht b2RlID09IHByZXNlbnRhdGlvbk1vZGVQaWN0dXJlSW5QaWN0dXJlKCkpCiAgICAgICAgIHJldHVy biB3a0lzT3B0aW1pemVkRnVsbHNjcmVlblN1cHBvcnRlZCgpICYmIG1lZGlhU2Vzc2lvbigpLmFs bG93c0FsdGVybmF0ZUZ1bGxzY3JlZW4oKnRoaXMpICYmIHN1cHBvcnRzRnVsbHNjcmVlbigpOwog CiAgICAgaWYgKG1vZGUgPT0gcHJlc2VudGF0aW9uTW9kZUlubGluZSgpKQpAQCAtMzkxLDcgKzM5 MSw3IEBAIHZvaWQgSFRNTFZpZGVvRWxlbWVudDo6d2Via2l0U2V0UHJlc2VudGF0aW9uTW9kZShj b25zdCBTdHJpbmcmIG1vZGUpCiAKICAgICBpZiAobW9kZSA9PSBwcmVzZW50YXRpb25Nb2RlRnVs bHNjcmVlbigpKQogICAgICAgICBlbnRlckZ1bGxzY3JlZW4oVmlkZW9GdWxsc2NyZWVuTW9kZVN0 YW5kYXJkKTsKLSAgICBlbHNlIGlmIChtb2RlID09IHByZXNlbnRhdGlvbk1vZGVPcHRpbWl6ZWQo KSkKKyAgICBlbHNlIGlmIChtb2RlID09IHByZXNlbnRhdGlvbk1vZGVQaWN0dXJlSW5QaWN0dXJl KCkpCiAgICAgICAgIGVudGVyRnVsbHNjcmVlbihWaWRlb0Z1bGxzY3JlZW5Nb2RlT3B0aW1pemVk KTsKIH0KIApAQCAtNDAzLDcgKzQwMyw3IEBAIFN0cmluZyBIVE1MVmlkZW9FbGVtZW50Ojp3ZWJr aXRQcmVzZW50YXRpb25Nb2RlKCkgY29uc3QKICAgICAgICAgcmV0dXJuIHByZXNlbnRhdGlvbk1v ZGVGdWxsc2NyZWVuKCk7CiAKICAgICBpZiAobW9kZSAmIFZpZGVvRnVsbHNjcmVlbk1vZGVPcHRp bWl6ZWQpCi0gICAgICAgIHJldHVybiBwcmVzZW50YXRpb25Nb2RlT3B0aW1pemVkKCk7CisgICAg ICAgIHJldHVybiBwcmVzZW50YXRpb25Nb2RlUGljdHVyZUluUGljdHVyZSgpOwogCiAgICAgaWYg KG1vZGUgPT0gVmlkZW9GdWxsc2NyZWVuTW9kZU5vbmUpCiAgICAgICAgIHJldHVybiBwcmVzZW50 YXRpb25Nb2RlSW5saW5lKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxW aWRlb0VsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlkZW9FbGVtZW50Lmlk bAppbmRleCAyYzU2Y2NjZjMxODA2ZWMxZWQ1ZGE5MWFmZTZlMWU5NDFmNGZjNzU1Li44Y2QwZTRi ZDE1MmJlOWQ3MjdiNjliYjBhMjE4ZTMyYjY3OTA4M2NjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFZpZGVvRWxlbWVudC5pZGwKQEAgLTI0LDcgKzI0LDcgQEAKICAqLwogCiAvLyBGSVhNRTog VGhpcyBzaG91bGQgYmUgQ29uZGl0aW9uYWw9VklERU9fUFJFU0VOVEFUSU9OX01PREUuCi1lbnVt IFZpZGVvUHJlc2VudGF0aW9uTW9kZSB7ICJmdWxsc2NyZWVuIiwgIm9wdGltaXplZCIsICJpbmxp bmUiIH07CitlbnVtIFZpZGVvUHJlc2VudGF0aW9uTW9kZSB7ICJmdWxsc2NyZWVuIiwgInBpY3R1 cmUtaW4tcGljdHVyZSIsICJpbmxpbmUiIH07CiAKIFsKICAgICBDb25kaXRpb25hbD1WSURFTywK