145824 2015-06-09 16:29:54 -0700 MediaControls: Reenable resize of controls on pinch zoom 2015-06-09 17:54:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino oldest_to_newest 1100850 0 dino 2015-06-09 16:29:54 -0700 MediaControls: Reenable resize of controls on pinch zoom 1100851 1 dino 2015-06-09 16:30:12 -0700 <rdar://problem/21212778> 1100854 2 254614 dino 2015-06-09 16:33:14 -0700 Created attachment 254614 Patch 1100861 3 254614 darin 2015-06-09 16:40:47 -0700 Comment on attachment 254614 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254614&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:631 > + if (newScaleFactor) { Early return maybe to not nest this entire thing. > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:640 > + this.controls.panel.style.width = Math.ceil(newScaleFactor * 100) + "%"; Why ceil rather than round? 1100879 4 254614 dino 2015-06-09 17:53:25 -0700 Comment on attachment 254614 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254614&action=review >> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:631 >> + if (newScaleFactor) { > > Early return maybe to not nest this entire thing. Done. >> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:640 >> + this.controls.panel.style.width = Math.ceil(newScaleFactor * 100) + "%"; > > Why ceil rather than round? We got a few complaints about the bar not quite covering the media do to rounding down. But I'm going to go back to round to see what happens. 1100881 5 dino 2015-06-09 17:54:04 -0700 Committed r185397: <http://trac.webkit.org/changeset/185397> 1100882 6 dino 2015-06-09 17:54:19 -0700 Committed r185397: <http://trac.webkit.org/changeset/185397> 254614 2015-06-09 16:33:14 -0700 2015-06-09 16:40:47 -0700 Patch bug-145824-20150609163246.patch text/plain 4902 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmUzNGM0N2FhYmE4N2E3 YjRjMmM4YTIzMzA0MmM1M2U3YmI3NTk0Mi4uM2Y0YzdlOTNjYTBmYzM0MmFhNTQzNTFkYjI5YjNh YjY2NDA5ZmI3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTA2LTA5ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYUNvbnRyb2xzOiBSZWVu YWJsZSByZXNpemUgb2YgY29udHJvbHMgb24gcGluY2ggem9vbQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1ODI0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVpbnN0YXRlIHRoZSBjb2RlIHRoYXQgdXBk YXRlZCB0aGUgc2NhbGluZyBvZiB0aGUKKyAgICAgICAgY29udHJvbHMgaW4gcmVzcG9uc2UgdG8g Y2hhbmdlcyBpbiBwYWdlIHNjYWxlLgorICAgICAgICBUaGlzIHRpbWUgYXJvdW5kIHdlIGhhdmUg dG8gY2hhbmdlIGJvdGggdGhlIGNvbnRyb2xzCisgICAgICAgIHBhbmVsLCBhbmQgaXRzIGJsdXJy eSBiYWNrZ3JvdW5kLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29u dHJvbHNBcHBsZS5qczoKKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBlLnNldCBwYWdlU2Nh bGVGYWN0b3IpOiBEZWxldGVkIGEgY29tbWVudC4KKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29u dHJvbHMvbWVkaWFDb250cm9sc2lPUy5jc3M6CisgICAgICAgICh2aWRlbzo6LXdlYmtpdC1tZWRp YS1jb250cm9scy1wYW5lbC1iYWNrZ3JvdW5kKTogU2V0IHRoZSBiYWNrZ3JvdW5kIHRvIHBpbgor ICAgICAgICB0byB0aGUgYm90dG9tIG9mIGl0cyB2aWV3LgorICAgICAgICAqIE1vZHVsZXMvbWVk aWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzOgorICAgICAgICAoQ29udHJvbGxlcklPUy5w cm90b3R5cGUuZ2V0IHBhZ2VTY2FsZUZhY3Rvcik6IEJhc2ljIGdldHRlciwgY29waWVkIGZyb20g bWVkaWFDb250cm9sc0FwcGxlLgorICAgICAgICAoQ29udHJvbGxlcklPUy5wcm90b3R5cGUuc2V0 IHBhZ2VTY2FsZUZhY3Rvcik6IFRoZSBzZXR0ZXIgdGhhdCByZWFjdHMgdG8gdGhlIHBhZ2Ugc2Nh bGUKKyAgICAgICAgYW5kIGFwcGxpZXMgYW4gaW52ZXJzZSBzY2FsaW5nIG9uIHRoZSBjb250cm9s IHBhbmVsIHVzaW5nIGEgdHJhbnNmb3JtLCBhbmQgYWRqdXN0cyB0aGUKKyAgICAgICAgaGVpZ2h0 IG9uIHRoZSBiYWNrZ3JvdW5kIHNpbWlsYXJseS4KKwogMjAxNS0wNi0wOCAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBFeHBsaWNpdGx5IGRpc21pc3MgY29ycmVj dGlvbiBwYW5lbCB3aGVuIHVzZXIgdHlwZXMgYSBuZXcgY2hhcmFjdGVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpz IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBs ZS5qcwppbmRleCA5ODA2NTM4OWViMDJjMGUyYjg1NWQ3ZTQ0N2U3NDFhYzQ1ZTE3MmI5Li4xNDQ3 ZDRjMzZkZTcwNmU0YWRkY2EwMDZhZGM5Yjg3ODU4YjJjYzUwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUu anMKQEAgLTIwMzQsMTIgKzIwMzQsNiBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgIHJldHVybjsKIAogICAgICAgICB0aGlzLl9wYWdlU2NhbGVGYWN0b3IgPSBuZXdTY2Fs ZUZhY3RvcjsKLQotICAgICAgICAvLyBGSVhNRTogdGhpcyBzaG91bGQgcmVhY3QgdG8gdGhlIHNj YWxlIGNoYW5nZSBieQotICAgICAgICAvLyB1bnNjYWxpbmcgdGhlIGNvbnRyb2xzIHBhbmVsLiBI b3dldmVyLCB0aGlzCi0gICAgICAgIC8vIGhpdHMgYSBidWcgd2l0aCB0aGUgYmFja2Ryb3AgYmx1 ciBsYXllciBnZXR0aW5nCi0gICAgICAgIC8vIHRvbyBiaWcgYW5kIG1vdmluZyB0byBhIHRpbGVk IGxheWVyLgotICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQyMzE3CiAgICAgfSwKIAogICAgIGhhbmRsZVJvb3RSZXNpemU6IGZ1bmN0aW9uKGV2ZW50 KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlh Q29udHJvbHNpT1MuY3NzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNpT1MuY3NzCmluZGV4IGI3OGVkMGUxNjQyZTYxZjkyNWZkNzgxNjlmNWNkYmY0 MTJlYzgyZDkuLjYwMTI1ZDM2NmNlYWVjNDc2MDI5YjBkOWM4OWI3M2QyYWRlNzU1N2EgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xz aU9TLmNzcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFD b250cm9sc2lPUy5jc3MKQEAgLTEyMCw2ICsxMjAsOCBAQCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1j b250cm9scy1wYW5lbC1iYWNrZ3JvdW5kIHsKICAgICB0cmFuc2l0aW9uOiBvcGFjaXR5IDAuMjVz IGxpbmVhcjsKICAgICBvcGFjaXR5OiAwOwogICAgIHBvaW50ZXItZXZlbnRzOiBub25lOworICAg IGJvdHRvbTogMDsKKyAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiB9CiAKIGF1ZGlvOjotd2Via2l0 LW1lZGlhLWNvbnRyb2xzLXBhbmVsLWJhY2tncm91bmQgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwppbmRleCA5 ZDQwMjgwNjU5YzBmYmJiN2Y2MDVhOTg0NDY4NmIyNjQwZTQ4ZmM0Li4xMjg5ZGNhMjIzYzZiNThl MjViMTdiMmMwMDgyMzNiZjNkZmYwNDI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwpAQCAtMjUsNyArMjUs NiBAQCBmdW5jdGlvbiBDb250cm9sbGVySU9TKHJvb3QsIHZpZGVvLCBob3N0KQogLyogRW51bXMg Ki8KIENvbnRyb2xsZXJJT1MuU3RhcnRQbGF5YmFja0NvbnRyb2xzID0gMjsKIAotCiBDb250cm9s bGVySU9TLnByb3RvdHlwZSA9IHsKICAgICAvKiBDb25zdGFudHMgKi8KICAgICBNaW5pbXVtVGlt ZWxpbmVXaWR0aDogMjAwLApAQCAtNjE3LDYgKzYxNiwzOCBAQCBDb250cm9sbGVySU9TLnByb3Rv dHlwZSA9IHsKICAgICAgICAgcmV0dXJuIENvbnRyb2xsZXIucHJvdG90eXBlLmNvbnRyb2xzQWx3 YXlzVmlzaWJsZS5jYWxsKHRoaXMpOwogICAgIH0sCiAKKyAgICBnZXQgcGFnZVNjYWxlRmFjdG9y KCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLl9wYWdlU2NhbGVGYWN0b3I7CisgICAgfSwK KworICAgIHNldCBwYWdlU2NhbGVGYWN0b3IobmV3U2NhbGVGYWN0b3IpCisgICAgeworICAgICAg ICBpZiAodGhpcy5fcGFnZVNjYWxlRmFjdG9yID09PSBuZXdTY2FsZUZhY3RvcikKKyAgICAgICAg ICAgIHJldHVybjsKKworICAgICAgICB0aGlzLl9wYWdlU2NhbGVGYWN0b3IgPSBuZXdTY2FsZUZh Y3RvcjsKKworICAgICAgICBpZiAobmV3U2NhbGVGYWN0b3IpIHsKKyAgICAgICAgICAgIHZhciBz Y2FsZVZhbHVlID0gMSAvIG5ld1NjYWxlRmFjdG9yOworICAgICAgICAgICAgdmFyIHNjYWxlVHJh bnNmb3JtID0gInNjYWxlKCIgKyBzY2FsZVZhbHVlICsgIikiOworICAgICAgICAgICAgaWYgKHRo aXMuY29udHJvbHMuc3RhcnRQbGF5YmFja0J1dHRvbikKKyAgICAgICAgICAgICAgICB0aGlzLmNv bnRyb2xzLnN0YXJ0UGxheWJhY2tCdXR0b24uc3R5bGUud2Via2l0VHJhbnNmb3JtID0gc2NhbGVU cmFuc2Zvcm07CisgICAgICAgICAgICBpZiAodGhpcy5jb250cm9scy5wYW5lbCkgeworICAgICAg ICAgICAgICAgIHZhciBib3R0b21BbGlnbWVudCA9IC0yICogc2NhbGVWYWx1ZTsKKyAgICAgICAg ICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsLnN0eWxlLmJvdHRvbSA9IGJvdHRvbUFsaWdtZW50 ICsgInB4IjsKKyAgICAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsLnN0eWxlLnBhZGRp bmdCb3R0b20gPSAtKG5ld1NjYWxlRmFjdG9yICogYm90dG9tQWxpZ21lbnQpICsgInB4IjsKKyAg ICAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsLnN0eWxlLndpZHRoID0gTWF0aC5jZWls KG5ld1NjYWxlRmFjdG9yICogMTAwKSArICIlIjsKKyAgICAgICAgICAgICAgICB0aGlzLmNvbnRy b2xzLnBhbmVsLnN0eWxlLndlYmtpdFRyYW5zZm9ybSA9IHNjYWxlVHJhbnNmb3JtOworCisgICAg ICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbEJhY2tncm91bmQuc3R5bGUuaGVpZ2h0ID0g KDUwICogc2NhbGVWYWx1ZSkgKyAicHgiOworCisgICAgICAgICAgICAgICAgdGhpcy5zZXROZWVk c1RpbWVsaW5lTWV0cmljc1VwZGF0ZSgpOworICAgICAgICAgICAgICAgIHRoaXMudXBkYXRlUHJv Z3Jlc3MoKTsKKyAgICAgICAgICAgICAgICB0aGlzLnNjaGVkdWxlVXBkYXRlTGF5b3V0Rm9yRGlz cGxheWVkV2lkdGgoKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgIH0sCiAKIH07CiAK