145803 2015-06-09 09:31:16 -0700 [JSC] JSString::getIndex() should avoid reifying substrings. 2015-06-09 11:04:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 312.x Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling commit-queue oldest_to_newest 1100666 0 kling 2015-06-09 09:31:16 -0700 JSString::getIndex() should use StringView. 1100667 1 254573 kling 2015-06-09 09:32:15 -0700 Created attachment 254573 Patch 1100707 2 254573 commit-queue 2015-06-09 11:04:12 -0700 Comment on attachment 254573 Patch Clearing flags on attachment: 254573 Committed r185368: <http://trac.webkit.org/changeset/185368> 1100709 3 commit-queue 2015-06-09 11:04:22 -0700 All reviewed patches have been landed. Closing bug. 254573 2015-06-09 09:32:15 -0700 2015-06-09 11:04:12 -0700 Patch bug-145803.diff text/plain 2803 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDU5ZjI4MmEuLjBkOWY0MGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA2LTA5ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBKU1N0cmluZzo6Z2V0SW5kZXgo KSBzaG91bGQgYXZvaWQgcmVpZnlpbmcgc3Vic3RyaW5ncy4KKyAgICAgICAgPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzE0NTgwMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbXBsZW1lbnQgZ2V0SW5kZXgoKSB1c2luZyBKU1N0cmluZzo6dmlldygpLCB3 aGljaCBjdXRzIGl0IGRvd24gdG8gYSBvbmUtbGluZXIKKyAgICAgICAgYW5kIGFsc28gYXZvaWRz IHJlaWZ5aW5nIHN1YnN0cmluZ3MuCisKKyAgICAgICAgSSBzYXcgMTc4IGtCIG9mIHJlaWZpZWQg c3Vic3RyaW5ncyBiZWxvdyBvcGVyYXRpb25HZXRCeVZhbCAtPiBnZXRJbmRleCgpCisgICAgICAg IG9uIGNuZXQuY29tLCBzbyB0aGlzIHNob3VsZCBoZWxwLgorCisgICAgICAgICogcnVudGltZS9K U1N0cmluZy5jcHA6CisgICAgICAgIChKU0M6OkpTUm9wZVN0cmluZzo6Z2V0SW5kZXhTbG93Q2Fz ZSk6IERlbGV0ZWQuCisgICAgICAgICogcnVudGltZS9KU1N0cmluZy5oOgorICAgICAgICAoSlND OjpKU1N0cmluZzo6Z2V0SW5kZXgpOgorCiAyMDE1LTA2LTA4ICBBbmRyZWFzIEtsaW5nICA8YWts aW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBKU1Byb3BlcnR5TmFtZUVudW1lcmF0b3In cyBwcm9wZXJ0eSBuYW1lIHZlY3RvciBzaG91bGQgYmUgc2l6ZWQtdG8tZml0LgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuY3BwCmluZGV4IDhjN2VjMDguLmViMDQ2ZWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5jcHAKQEAgLTM2NSwx OCArMzY1LDYgQEAgdm9pZCBKU1JvcGVTdHJpbmc6Om91dE9mTWVtb3J5KEV4ZWNTdGF0ZSogZXhl YykgY29uc3QKICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMpOwogfQogCi1KU1N0 cmluZyogSlNSb3BlU3RyaW5nOjpnZXRJbmRleFNsb3dDYXNlKEV4ZWNTdGF0ZSogZXhlYywgdW5z aWduZWQgaSkKLXsKLSAgICBBU1NFUlQoaXNSb3BlKCkpOwotICAgIHJlc29sdmVSb3BlKGV4ZWMp OwotICAgIC8vIFJldHVybiBhIHNhZmUgbm8tdmFsdWUgcmVzdWx0LCB0aGlzIHNob3VsZCBuZXZl ciBiZSB1c2VkLCBzaW5jZSB0aGUgZXhjZXRpb24gd2lsbCBiZSB0aHJvd24uCi0gICAgaWYgKGV4 ZWMtPmV4Y2VwdGlvbigpKQotICAgICAgICByZXR1cm4ganNFbXB0eVN0cmluZyhleGVjKTsKLSAg ICBBU1NFUlQoIWlzUm9wZSgpKTsKLSAgICBSRUxFQVNFX0FTU0VSVChpIDwgbV92YWx1ZS5sZW5n dGgoKSk7Ci0gICAgcmV0dXJuIGpzU2luZ2xlQ2hhcmFjdGVyU3RyaW5nKGV4ZWMsIG1fdmFsdWVb aV0pOwotfQotCiBKU1ZhbHVlIEpTU3RyaW5nOjp0b1ByaW1pdGl2ZShFeGVjU3RhdGUqLCBQcmVm ZXJyZWRQcmltaXRpdmVUeXBlKSBjb25zdAogewogICAgIHJldHVybiBjb25zdF9jYXN0PEpTU3Ry aW5nKj4odGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U1N0cmluZy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuaAppbmRl eCBkNDk2OWRiLi4xNzBjNjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU1N0cmluZy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3Ry aW5nLmgKQEAgLTM3Miw4ICszNzIsNiBAQCBwcml2YXRlOgogICAgIHZvaWQgY2xlYXJGaWJlcnMo KSBjb25zdDsKICAgICBTdHJpbmdWaWV3IHZpZXcoRXhlY1N0YXRlKikgY29uc3Q7CiAKLSAgICBK U19FWFBPUlRfUFJJVkFURSBKU1N0cmluZyogZ2V0SW5kZXhTbG93Q2FzZShFeGVjU3RhdGUqLCB1 bnNpZ25lZCk7Ci0KICAgICBXcml0ZUJhcnJpZXJCYXNlPEpTU3RyaW5nPiYgZmliZXIodW5zaWdu ZWQgaSkgY29uc3QKICAgICB7CiAgICAgICAgIEFTU0VSVCghaXNTdWJzdHJpbmcoKSk7CkBAIC00 OTMsMTAgKzQ5MSw3IEBAIGlubGluZSBjb25zdCBTdHJpbmcmIEpTU3RyaW5nOjp0cnlHZXRWYWx1 ZSgpIGNvbnN0CiBpbmxpbmUgSlNTdHJpbmcqIEpTU3RyaW5nOjpnZXRJbmRleChFeGVjU3RhdGUq IGV4ZWMsIHVuc2lnbmVkIGkpCiB7CiAgICAgQVNTRVJUKGNhbkdldEluZGV4KGkpKTsKLSAgICBp ZiAoaXNSb3BlKCkpCi0gICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxKU1JvcGVTdHJpbmcqPih0 aGlzKS0+Z2V0SW5kZXhTbG93Q2FzZShleGVjLCBpKTsKLSAgICBBU1NFUlQoaSA8IG1fdmFsdWUu bGVuZ3RoKCkpOwotICAgIHJldHVybiBqc1NpbmdsZUNoYXJhY3RlclN0cmluZyhleGVjLCBtX3Zh bHVlW2ldKTsKKyAgICByZXR1cm4ganNTaW5nbGVDaGFyYWN0ZXJTdHJpbmcoZXhlYywgdmlldyhl eGVjKVtpXSk7CiB9CiAKIGlubGluZSBKU1N0cmluZyoganNTdHJpbmcoVk0qIHZtLCBjb25zdCBT dHJpbmcmIHMpCg==