145795 2015-06-09 04:13:27 -0700 [GTK] Inhibit screen saver when playing full screen video 2015-06-16 23:01:21 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bugzilla webkit-unassigned berto cgarcia commit-queue gustavo mcatanzaro mrobinson pnormand oldest_to_newest 1100626 0 bugzilla 2015-06-09 04:13:27 -0700 The cross-desktop API is documented here: http://people.freedesktop.org/~hadess/idle-inhibition-spec/index.html 1101853 1 254860 cgarcia 2015-06-14 03:05:25 -0700 Created attachment 254860 Patch Of course this doesn't work in crappy sites that still use flash for videos and don't implement the fullscreen API. 1101854 2 commit-queue 2015-06-14 03:06:31 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1102257 3 254860 gustavo 2015-06-16 10:29:19 -0700 Comment on attachment 254860 Patch LGTM! 1102489 4 cgarcia 2015-06-16 23:01:21 -0700 Committed r185642: <http://trac.webkit.org/changeset/185642> 254860 2015-06-14 03:05:25 -0700 2015-06-16 10:29:19 -0700 Patch wk2-screensaver.diff text/plain 7036 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvcG8vQ2hhbmdlTG9nCmluZGV4IGI3ODMwYjkuLjBl ZjNiZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL3BvL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDE1LTA2LTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KKworICAgICAgICBbR1RLXSBJbmhpYml0IHNjcmVlbiBzYXZlciB3aGVuIHBsYXlp bmcgZnVsbCBzY3JlZW4gdmlkZW8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NTc5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogUE9URklMRVMuaW46IEFkZCBXZWJLaXRXZWJWaWV3QmFzZS5jcHAuCisK IDIwMTUtMDUtMjIgIEpvcmRpIE1hcyAgPGptYXNAc29mdGNhdGFsYS5vcmc+CiAKICAgICAgICAg W2wxMG5dIEFkZCBDYXRhbGFuIHRyYW5zbGF0aW9uIGZvciBXZWJLaXRHVEsrCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvcG8vUE9URklMRVMuaW4gYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvcG8vUE9URklMRVMuaW4KaW5kZXggYjRiZmZkOC4uZjM5MzRlOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL3BvL1BPVEZJTEVTLmluCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9QT1RGSUxFUy5pbgpAQCAtMTYsNiAr MTYsNyBAQCBMb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcAogLi4vLi4vLi4vV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRVUklSZXNwb25zZS5jcHAKIC4uLy4uLy4uL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViSW5zcGVjdG9yLmNwcAogLi4vLi4vLi4vV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJSZXNvdXJjZS5jcHAKKy4uLy4uLy4uL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCiAuLi8uLi8uLi9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCiAuLi8uLi8uLi9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdpbmRvd1Byb3BlcnRpZXMuY3BwCiAuLi8uLi8uLi9XZWJLaXQy L1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTAz OTY0Yi4uODRiYjMwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA2LTE0ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XSBJbmhpYml0IHNjcmVlbiBzYXZlciB3aGVuIHBsYXlpbmcgZnVsbCBzY3JlZW4gdmlkZW8KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTc5NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBGcmVlZGVz a3RvcC5vcmcgREJ1cyBBUEkgdG8gaW5oaWJpdC91bmhpbmliaXQgdGhlIHNjcmVlbiBzYXZlcgor ICAgICAgICB3aGVuIGVudGVyaW5nL2xlYXZpbmcgZnVsbHNjcmVlbi4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcDoKKyAgICAgICAgKHNjcmVlblNh dmVySW5oaWJpdGVkQ2FsbGJhY2spOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VTZW5kSW5o aWJpdE1lc3NhZ2VUb1NjcmVlblNhdmVyKToKKyAgICAgICAgKHNjcmVlblNhdmVyUHJveHlDcmVh dGVkQ2FsbGJhY2spOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VJbmhpYml0U2NyZWVuU2F2 ZXIpOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VVbmluaGliaXRTY3JlZW5TYXZlcik6Cisg ICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZUVudGVyRnVsbFNjcmVlbik6CisgICAgICAgICh3ZWJr aXRXZWJWaWV3QmFzZUV4aXRGdWxsU2NyZWVuKToKKwogMjAxNS0wNi0xMSAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIEFQSSB0 byBiZSBub3RpZmllZCBhYm91dCBlZGl0b3Igc3RhdGUgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4 IDQ4NzEyOWMuLjJhYzNhMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTYxLDYgKzYxLDcgQEAKICNpbmNs dWRlIDxXZWJDb3JlL1JlZ2lvbi5oPgogI2luY2x1ZGUgPGdkay9nZGsuaD4KICNpbmNsdWRlIDxn ZGsvZ2Rra2V5c3ltcy5oPgorI2luY2x1ZGUgPGdsaWIvZ2kxOG4tbGliLmg+CiAjaW5jbHVkZSA8 bWVtb3J5PgogI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CiAjaW5jbHVkZSA8d3RmL2dvYmplY3Qv R1JlZlB0ci5oPgpAQCAtMTg3LDYgKzE4OCw5IEBAIHN0cnVjdCBfV2ViS2l0V2ViVmlld0Jhc2VQ cml2YXRlIHsKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCiAgICAgYm9vbCBmdWxsU2NyZWVu TW9kZUFjdGl2ZTsKICAgICBXZWJGdWxsU2NyZWVuQ2xpZW50R3RrIGZ1bGxTY3JlZW5DbGllbnQ7 CisgICAgR1JlZlB0cjxHREJ1c1Byb3h5PiBzY3JlZW5TYXZlclByb3h5OworICAgIEdSZWZQdHI8 R0NhbmNlbGxhYmxlPiBzY3JlZW5TYXZlckluaGliaXRDYW5jZWxsYWJsZTsKKyAgICB1bnNpZ25l ZCBzY3JlZW5TYXZlckNvb2tpZTsKICNlbmRpZgogCiAjaWYgVVNFKFJFRElSRUNURURfWENPTVBP U0lURV9XSU5ET1cpCkBAIC0xMjAwLDYgKzEyMDQsNzEgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFz ZUZvcndhcmROZXh0S2V5RXZlbnQoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNl KQogICAgIHdlYmtpdFdlYlZpZXdCYXNlLT5wcml2LT5zaG91bGRGb3J3YXJkTmV4dEtleUV2ZW50 ID0gVFJVRTsKIH0KIAorI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKK3N0YXRpYyB2b2lkIHNj cmVlblNhdmVySW5oaWJpdGVkQ2FsbGJhY2soR0RCdXNQcm94eSogc2NyZWVuU2F2ZXJQcm94eSwg R0FzeW5jUmVzdWx0KiByZXN1bHQsIFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSkKK3sK KyAgICBHUmVmUHRyPEdWYXJpYW50PiByZXR1cm5WYWx1ZSA9IGFkb3B0R1JlZihnX2RidXNfcHJv eHlfY2FsbF9maW5pc2goc2NyZWVuU2F2ZXJQcm94eSwgcmVzdWx0LCBudWxscHRyKSk7CisgICAg aWYgKHJldHVyblZhbHVlKQorICAgICAgICBnX3ZhcmlhbnRfZ2V0KHJldHVyblZhbHVlLmdldCgp LCAiKHUpIiwgJndlYlZpZXdCYXNlLT5wcml2LT5zY3JlZW5TYXZlckNvb2tpZSk7CisgICAgd2Vi Vmlld0Jhc2UtPnByaXYtPnNjcmVlblNhdmVySW5oaWJpdENhbmNlbGxhYmxlID0gbnVsbHB0cjsK K30KKworc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VTZW5kSW5oaWJpdE1lc3NhZ2VUb1Nj cmVlblNhdmVyKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSkKK3sKKyAgICBXZWJLaXRX ZWJWaWV3QmFzZVByaXZhdGUqIHByaXYgPSB3ZWJWaWV3QmFzZS0+cHJpdjsKKyAgICBBU1NFUlQo cHJpdi0+c2NyZWVuU2F2ZXJQcm94eSk7CisgICAgcHJpdi0+c2NyZWVuU2F2ZXJDb29raWUgPSAw OworICAgIGlmICghcHJpdi0+c2NyZWVuU2F2ZXJJbmhpYml0Q2FuY2VsbGFibGUpCisgICAgICAg IHByaXYtPnNjcmVlblNhdmVySW5oaWJpdENhbmNlbGxhYmxlID0gZ19jYW5jZWxsYWJsZV9uZXco KTsKKyAgICBnX2RidXNfcHJveHlfY2FsbChwcml2LT5zY3JlZW5TYXZlclByb3h5LmdldCgpLCAi SW5oaWJpdCIsIGdfdmFyaWFudF9uZXcoIihzcykiLCBnX2dldF9wcmduYW1lKCksIF8oIldlYnNp dGUgcnVubmluZyBpbiBmdWxsc2NyZWVuIG1vZGUiKSksCisgICAgICAgIEdfREJVU19DQUxMX0ZM QUdTX05PTkUsIC0xLCBwcml2LT5zY3JlZW5TYXZlckluaGliaXRDYW5jZWxsYWJsZS5nZXQoKSwg cmVpbnRlcnByZXRfY2FzdDxHQXN5bmNSZWFkeUNhbGxiYWNrPihzY3JlZW5TYXZlckluaGliaXRl ZENhbGxiYWNrKSwgd2ViVmlld0Jhc2UpOworfQorCitzdGF0aWMgdm9pZCBzY3JlZW5TYXZlclBy b3h5Q3JlYXRlZENhbGxiYWNrKEdPYmplY3QqLCBHQXN5bmNSZXN1bHQqIHJlc3VsdCwgV2ViS2l0 V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlKQoreworICAgIFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0 ZSogcHJpdiA9IHdlYlZpZXdCYXNlLT5wcml2OworICAgIHByaXYtPnNjcmVlblNhdmVyUHJveHkg PSBhZG9wdEdSZWYoZ19kYnVzX3Byb3h5X25ld19mb3JfYnVzX2ZpbmlzaChyZXN1bHQsIG51bGxw dHIpKTsKKyAgICBpZiAoIXByaXYtPnNjcmVlblNhdmVyUHJveHkpCisgICAgICAgIHJldHVybjsK KworICAgIHdlYmtpdFdlYlZpZXdCYXNlU2VuZEluaGliaXRNZXNzYWdlVG9TY3JlZW5TYXZlcih3 ZWJWaWV3QmFzZSk7Cit9CisKK3N0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlSW5oaWJpdFNj cmVlblNhdmVyKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSkKK3sKKyAgICBXZWJLaXRX ZWJWaWV3QmFzZVByaXZhdGUqIHByaXYgPSB3ZWJWaWV3QmFzZS0+cHJpdjsKKyAgICBpZiAocHJp di0+c2NyZWVuU2F2ZXJDb29raWUpIHsKKyAgICAgICAgLy8gQWxyZWFkeSBpbmhpYml0ZWQuCisg ICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBpZiAocHJpdi0+c2NyZWVuU2F2ZXJQcm94eSkg eworICAgICAgICB3ZWJraXRXZWJWaWV3QmFzZVNlbmRJbmhpYml0TWVzc2FnZVRvU2NyZWVuU2F2 ZXIod2ViVmlld0Jhc2UpOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgcHJpdi0+c2Ny ZWVuU2F2ZXJJbmhpYml0Q2FuY2VsbGFibGUgPSBnX2NhbmNlbGxhYmxlX25ldygpOworICAgIGdf ZGJ1c19wcm94eV9uZXdfZm9yX2J1cyhHX0JVU19UWVBFX1NFU1NJT04sIHN0YXRpY19jYXN0PEdE QnVzUHJveHlGbGFncz4oR19EQlVTX1BST1hZX0ZMQUdTX0RPX05PVF9MT0FEX1BST1BFUlRJRVMg fCBHX0RCVVNfUFJPWFlfRkxBR1NfRE9fTk9UX0NPTk5FQ1RfU0lHTkFMUyksCisgICAgICAgIG51 bGxwdHIsICJvcmcuZnJlZWRlc2t0b3AuU2NyZWVuU2F2ZXIiLCAiL1NjcmVlblNhdmVyIiwgIm9y Zy5mcmVlZGVza3RvcC5TY3JlZW5TYXZlciIsIHByaXYtPnNjcmVlblNhdmVySW5oaWJpdENhbmNl bGxhYmxlLmdldCgpLAorICAgICAgICByZWludGVycHJldF9jYXN0PEdBc3luY1JlYWR5Q2FsbGJh Y2s+KHNjcmVlblNhdmVyUHJveHlDcmVhdGVkQ2FsbGJhY2spLCB3ZWJWaWV3QmFzZSk7Cit9CisK K3N0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlVW5pbmhpYml0U2NyZWVuU2F2ZXIoV2ViS2l0 V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlKQoreworICAgIFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0 ZSogcHJpdiA9IHdlYlZpZXdCYXNlLT5wcml2OworICAgIGlmICghcHJpdi0+c2NyZWVuU2F2ZXJD b29raWUpIHsKKyAgICAgICAgLy8gTm90IGluaGliaXRlZCBvciBpdCdzIGJlaW5nIGluaGliaXRl ZC4KKyAgICAgICAgZ19jYW5jZWxsYWJsZV9jYW5jZWwocHJpdi0+c2NyZWVuU2F2ZXJJbmhpYml0 Q2FuY2VsbGFibGUuZ2V0KCkpOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgLy8gSWYg d2UgaGF2ZSBhIGNvb2tpZSB3ZSBzaG91bGQgaGF2ZSBhIHByb3h5LgorICAgIEFTU0VSVChwcml2 LT5zY3JlZW5TYXZlclByb3h5KTsKKyAgICBnX2RidXNfcHJveHlfY2FsbChwcml2LT5zY3JlZW5T YXZlclByb3h5LmdldCgpLCAiVW5JbmhpYml0IiwgZ192YXJpYW50X25ldygiKHUpIiwgcHJpdi0+ c2NyZWVuU2F2ZXJDb29raWUpLCBHX0RCVVNfQ0FMTF9GTEFHU19OT05FLCAtMSwgbnVsbHB0ciwg bnVsbHB0ciwgbnVsbHB0cik7CisgICAgcHJpdi0+c2NyZWVuU2F2ZXJDb29raWUgPSAwOworfQor I2VuZGlmCisKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VFbnRlckZ1bGxTY3JlZW4oV2ViS2l0V2Vi Vmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNlKQogewogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQ SSkKQEAgLTEyMTgsNiArMTI4Nyw3IEBAIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VFbnRlckZ1bGxT Y3JlZW4oV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNlKQogICAgICAgICBndGtf d2luZG93X2Z1bGxzY3JlZW4oR1RLX1dJTkRPVyh0b3BMZXZlbFdpbmRvdykpOwogICAgIGZ1bGxT Y3JlZW5NYW5hZ2VyUHJveHktPmRpZEVudGVyRnVsbFNjcmVlbigpOwogICAgIHByaXYtPmZ1bGxT Y3JlZW5Nb2RlQWN0aXZlID0gdHJ1ZTsKKyAgICB3ZWJraXRXZWJWaWV3QmFzZUluaGliaXRTY3Jl ZW5TYXZlcih3ZWJraXRXZWJWaWV3QmFzZSk7CiAjZW5kaWYKIH0KIApAQCAtMTIzOSw2ICsxMzA5 LDcgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUV4aXRGdWxsU2NyZWVuKFdlYktpdFdlYlZpZXdC YXNlKiB3ZWJraXRXZWJWaWV3QmFzZSkKICAgICAgICAgZ3RrX3dpbmRvd191bmZ1bGxzY3JlZW4o R1RLX1dJTkRPVyh0b3BMZXZlbFdpbmRvdykpOwogICAgIGZ1bGxTY3JlZW5NYW5hZ2VyUHJveHkt PmRpZEV4aXRGdWxsU2NyZWVuKCk7CiAgICAgcHJpdi0+ZnVsbFNjcmVlbk1vZGVBY3RpdmUgPSBm YWxzZTsKKyAgICB3ZWJraXRXZWJWaWV3QmFzZVVuaW5oaWJpdFNjcmVlblNhdmVyKHdlYmtpdFdl YlZpZXdCYXNlKTsKICNlbmRpZgogfQogCg==