145790 2015-06-09 00:46:58 -0700 [GTK] Allow to dispatch tasks in WorkQueue with different priorities 2015-11-23 01:18:52 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED LATER Gtk P2 Normal --- 1 cgarcia webkit-unassigned benjamin cmarcelo commit-queue mcatanzaro zan oldest_to_newest 1100595 0 cgarcia 2015-06-09 00:46:58 -0700 In glib we can use different priorities for the sources in the same main loop. I want to use this to give more priority to read tasks in the disk cache IO WorkQueue, but it could be useful for other cases as well. 1100596 1 254554 cgarcia 2015-06-09 00:51:32 -0700 Created attachment 254554 Patch 1100597 2 commit-queue 2015-06-09 00:52:34 -0700 Attachment 254554 did not pass style-queue: ERROR: Source/WTF/wtf/WorkQueue.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:114: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:121: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:126: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:130: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:133: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 7 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1100627 3 mcatanzaro 2015-06-09 05:22:14 -0700 In the test case, why name the nonmember variables with the m_ prefix? 1100628 4 cgarcia 2015-06-09 05:28:29 -0700 (In reply to comment #3) > In the test case, why name the nonmember variables with the m_ prefix? Good question, there's no reason other than I copy-pasted from Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp :-P 1100690 5 cgarcia 2015-06-09 10:13:47 -0700 We are no longer using this for the disk cache, so I guess we don't really need it for now. 1144140 6 zan 2015-11-23 01:11:51 -0800 RESOLVED LATER? 1144141 7 zan 2015-11-23 01:18:52 -0800 RESOLVED LATER. 254554 2015-06-09 00:51:32 -0700 2015-11-23 01:17:09 -0800 Patch wtf-work-queue-dispatch-priority.diff text/plain 5137 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNDUzODQzMy4uNjc1MDg4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxNS0wNi0wOSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dU S10gQWxsb3cgdG8gZGlzcGF0Y2ggdGFza3MgaW4gV29ya1F1ZXVlIHdpdGggZGlmZmVyZW50IHBy aW9yaXRpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0NTc5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluIGdsaWIgd2UgY2FuIHVzZSBkaWZmZXJlbnQgcHJpb3JpdGllcyBmb3IgdGhlIHNvdXJjZXMg aW4gdGhlCisgICAgICAgIHNhbWUgbWFpbiBsb29wLiBXZSB3aWxsIHVzZSB0aGlzIHRvIGdpdmUg bW9yZSBwcmlvcml0eSB0byByZWFkCisgICAgICAgIHRhc2tzIGluIHRoZSBkaXNrIGNhY2hlIElP IFdvcmtRdWV1ZS4KKworICAgICAgICAqIHd0Zi9Xb3JrUXVldWUuaDogQWRkIGRpc3BhdGNoIGZ1 bmN0aW9ucyB0aGF0IHJlY2VpdmUgYSBwcmlvcml0eQorICAgICAgICBhcyBwYXJhbWV0ZXIuCisg ICAgICAgICogd3RmL2dsaWIvV29ya1F1ZXVlR0xpYi5jcHA6CisgICAgICAgIChXVEY6OldvcmtR dWV1ZTo6ZGlzcGF0Y2gpOiBVc2UgdGhlIGdpdmVuIHByaW9yaXR5LgorICAgICAgICAoV1RGOjpX b3JrUXVldWU6OmRpc3BhdGNoQWZ0ZXIpOiBEaXR0by4KKwogMjAxNS0wNi0wNSAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSzJdW2lPU10gTGltaXQgdGhlIG51 bWJlciBvZiB2bm9kZXMgdXNlZCBieSB0aGUgV2ViQ29udGVudCBwcm9jZXNzZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL1dvcmtRdWV1ZS5oIGIvU291cmNlL1dURi93dGYvV29ya1F1ZXVl LmgKaW5kZXggMTVkNzU1Zi4uZmJmZGVkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvV29y a1F1ZXVlLmgKKysrIGIvU291cmNlL1dURi93dGYvV29ya1F1ZXVlLmgKQEAgLTc0LDYgKzc0LDgg QEAgcHVibGljOgogI2lmIE9TKERBUldJTikKICAgICBkaXNwYXRjaF9xdWV1ZV90IGRpc3BhdGNo UXVldWUoKSBjb25zdCB7IHJldHVybiBtX2Rpc3BhdGNoUXVldWU7IH0KICNlbGlmIFBMQVRGT1JN KEdUSykKKyAgICB2b2lkIGRpc3BhdGNoKHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4sIGludCBwcmlv cml0eSk7CisgICAgdm9pZCBkaXNwYXRjaEFmdGVyKHN0ZDo6Y2hyb25vOjpuYW5vc2Vjb25kcywg c3RkOjpmdW5jdGlvbjx2b2lkICgpPiwgaW50IHByaW9yaXR5KTsKICAgICB2b2lkIHJlZ2lzdGVy U29ja2V0RXZlbnRIYW5kbGVyKGludCwgc3RkOjpmdW5jdGlvbjx2b2lkICgpPiwgc3RkOjpmdW5j dGlvbjx2b2lkICgpPik7CiAgICAgdm9pZCB1bnJlZ2lzdGVyU29ja2V0RXZlbnRIYW5kbGVyKGlu dCk7CiAjZWxpZiBQTEFURk9STShFRkwpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9nbGli L1dvcmtRdWV1ZUdMaWIuY3BwIGIvU291cmNlL1dURi93dGYvZ2xpYi9Xb3JrUXVldWVHTGliLmNw cAppbmRleCBlZTFiNjBiLi5lYjIwNzM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9nbGli L1dvcmtRdWV1ZUdMaWIuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvV29ya1F1ZXVlR0xp Yi5jcHAKQEAgLTExMSwxOCArMTExLDI4IEBAIHZvaWQgV29ya1F1ZXVlOjp1bnJlZ2lzdGVyU29j a2V0RXZlbnRIYW5kbGVyKGludCkKICAgICBtX3NvY2tldEV2ZW50U291cmNlLmNhbmNlbCgpOwog fQogCi12b2lkIFdvcmtRdWV1ZTo6ZGlzcGF0Y2goc3RkOjpmdW5jdGlvbjx2b2lkICgpPiBmdW5j dGlvbikKK3ZvaWQgV29ya1F1ZXVlOjpkaXNwYXRjaChzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IGZ1 bmN0aW9uLCBpbnQgcHJpb3JpdHkpCiB7CiAgICAgcmVmKCk7Ci0gICAgR01haW5Mb29wU291cmNl OjpzY2hlZHVsZUFuZERlbGV0ZU9uRGVzdHJveSgiW1dlYktpdF0gV29ya1F1ZXVlOjpkaXNwYXRj aCIsIFdURjo6bW92ZShmdW5jdGlvbiksIEdfUFJJT1JJVFlfREVGQVVMVCwKKyAgICBHTWFpbkxv b3BTb3VyY2U6OnNjaGVkdWxlQW5kRGVsZXRlT25EZXN0cm95KCJbV2ViS2l0XSBXb3JrUXVldWU6 OmRpc3BhdGNoIiwgV1RGOjptb3ZlKGZ1bmN0aW9uKSwgcHJpb3JpdHksCiAgICAgICAgIFt0aGlz XSB7IGRlcmVmKCk7IH0sIG1fZXZlbnRDb250ZXh0LmdldCgpKTsKIH0KIAotdm9pZCBXb3JrUXVl dWU6OmRpc3BhdGNoQWZ0ZXIoc3RkOjpjaHJvbm86Om5hbm9zZWNvbmRzIGR1cmF0aW9uLCBzdGQ6 OmZ1bmN0aW9uPHZvaWQgKCk+IGZ1bmN0aW9uKQordm9pZCBXb3JrUXVldWU6OmRpc3BhdGNoKHN0 ZDo6ZnVuY3Rpb248dm9pZCAoKT4gZnVuY3Rpb24pCit7CisgICAgZGlzcGF0Y2goV1RGOjptb3Zl KGZ1bmN0aW9uKSwgR19QUklPUklUWV9ERUZBVUxUKTsKK30KKwordm9pZCBXb3JrUXVldWU6OmRp c3BhdGNoQWZ0ZXIoc3RkOjpjaHJvbm86Om5hbm9zZWNvbmRzIGR1cmF0aW9uLCBzdGQ6OmZ1bmN0 aW9uPHZvaWQgKCk+IGZ1bmN0aW9uLCBpbnQgcHJpb3JpdHkpCiB7CiAgICAgcmVmKCk7CiAgICAg R01haW5Mb29wU291cmNlOjpzY2hlZHVsZUFmdGVyRGVsYXlBbmREZWxldGVPbkRlc3Ryb3koIltX ZWJLaXRdIFdvcmtRdWV1ZTo6ZGlzcGF0Y2hBZnRlciIsIFdURjo6bW92ZShmdW5jdGlvbiksCi0g ICAgICAgIHN0ZDo6Y2hyb25vOjpkdXJhdGlvbl9jYXN0PHN0ZDo6Y2hyb25vOjptaWxsaXNlY29u ZHM+KGR1cmF0aW9uKSwgR19QUklPUklUWV9ERUZBVUxULCBbdGhpc10geyBkZXJlZigpOyB9LCBt X2V2ZW50Q29udGV4dC5nZXQoKSk7CisgICAgICAgIHN0ZDo6Y2hyb25vOjpkdXJhdGlvbl9jYXN0 PHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHM+KGR1cmF0aW9uKSwgcHJpb3JpdHksIFt0aGlzXSB7 IGRlcmVmKCk7IH0sIG1fZXZlbnRDb250ZXh0LmdldCgpKTsKK30KKwordm9pZCBXb3JrUXVldWU6 OmRpc3BhdGNoQWZ0ZXIoc3RkOjpjaHJvbm86Om5hbm9zZWNvbmRzIGR1cmF0aW9uLCBzdGQ6OmZ1 bmN0aW9uPHZvaWQgKCk+IGZ1bmN0aW9uKQoreworICAgIGRpc3BhdGNoQWZ0ZXIoZHVyYXRpb24s IFdURjo6bW92ZShmdW5jdGlvbiksIEdfUFJJT1JJVFlfREVGQVVMVCk7CiB9CiAKIH0KZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMTdlYzY5Li4y NDMzMzE5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDYtMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFsbG93IHRvIGRpc3BhdGNoIHRhc2tz IGluIFdvcmtRdWV1ZSB3aXRoIGRpZmZlcmVudCBwcmlvcml0aWVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU3OTAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGVzdCBjYXNlIHRvIGNoZWNrIHBy aW9yaXRpZXMuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9nbGliL1dvcmtR dWV1ZUdMaWIuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMTUtMDYt MDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdIEFkZCBlZGl0b3IgbW9kZSB0byBNaW5pQnJvd3NlcgpkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvZ2xpYi9Xb3JrUXVldWVHTGliLmNwcCBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV1RGL2dsaWIvV29ya1F1ZXVlR0xpYi5jcHAKaW5kZXggOTkzMmI0 Ny4uMzUzZjRiYyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvZ2xp Yi9Xb3JrUXVldWVHTGliLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9n bGliL1dvcmtRdWV1ZUdMaWIuY3BwCkBAIC02Niw0ICs2NiwzNCBAQCBURVNUKFdURl9Xb3JrUXVl dWUsIEFzeW5jSU8pCiAgICAgY29udGV4dC5tX3Rlc3RDb21wbGV0ZWQud2FpdChjb250ZXh0Lm1f bG9jayk7CiB9CiAKK1RFU1QoV1RGX1dvcmtRdWV1ZSwgRGlzcGF0Y2hQcmlvcml0eSkKK3sKKyAg ICBib29sIGNhbGxlZERlZmF1bHRQcmlvcml0eVRhc2sgPSBmYWxzZTsKKyAgICBib29sIGNhbGxl ZElkbGVQcmlvcml0eVRhc2sgPSBmYWxzZTsKKworICAgIGF1dG8gcXVldWUgPSBXb3JrUXVldWU6 OmNyZWF0ZSgiY29tLmFwcGxlLldlYktpdC5UZXN0LkRpc3BhdGNoUHJpb3JpdHkiKTsKKworICAg IE11dGV4IG1fbG9jazsKKyAgICBUaHJlYWRDb25kaXRpb24gbV90ZXN0Q29tcGxldGVkOworCisg ICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fbG9jayk7CisgICAgcXVldWUtPmRpc3BhdGNoKFsmXSh2 b2lkKSB7CisgICAgICAgIEVYUEVDVF9UUlVFKGNhbGxlZERlZmF1bHRQcmlvcml0eVRhc2spOwor ICAgICAgICBFWFBFQ1RfRkFMU0UoY2FsbGVkSWRsZVByaW9yaXR5VGFzayk7CisgICAgICAgIGNh bGxlZElkbGVQcmlvcml0eVRhc2sgPSB0cnVlOworICAgICAgICBtX3Rlc3RDb21wbGV0ZWQuc2ln bmFsKCk7CisgICAgfSwgR19QUklPUklUWV9ERUZBVUxUX0lETEUpOworCisgICAgcXVldWUtPmRp c3BhdGNoKFsmXSh2b2lkKSB7CisgICAgICAgIEVYUEVDVF9GQUxTRShjYWxsZWREZWZhdWx0UHJp b3JpdHlUYXNrKTsKKyAgICAgICAgRVhQRUNUX0ZBTFNFKGNhbGxlZElkbGVQcmlvcml0eVRhc2sp OworICAgICAgICBjYWxsZWREZWZhdWx0UHJpb3JpdHlUYXNrID0gdHJ1ZTsKKyAgICB9LCBHX1BS SU9SSVRZX0RFRkFVTFQpOworCisgICAgbV90ZXN0Q29tcGxldGVkLndhaXQobV9sb2NrKTsKKwor ICAgIEVYUEVDVF9UUlVFKGNhbGxlZERlZmF1bHRQcmlvcml0eVRhc2spOworICAgIEVYUEVDVF9U UlVFKGNhbGxlZElkbGVQcmlvcml0eVRhc2spOworfQorCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2Vi S2l0QVBJCg==