<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>145786</bug_id>
          
          <creation_ts>2015-06-08 22:18:48 -0700</creation_ts>
          <short_desc>[JSC] Polymorphic{Get,Put}ByIdList::addAccess() should optimize for size, not speed.</short_desc>
          <delta_ts>2015-06-09 14:23:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Performance</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andreas Kling">kling</reporter>
          <assigned_to name="Andreas Kling">kling</assigned_to>
          <cc>kling</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1100579</commentid>
    <comment_count>0</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-06-08 22:18:48 -0700</bug_when>
    <thetext>These functions clearly want Vector::resizeToFit(), not resize().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1100580</commentid>
    <comment_count>1</comment_count>
      <attachid>254548</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-06-08 22:19:41 -0700</bug_when>
    <thetext>Created attachment 254548
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1100794</commentid>
    <comment_count>2</comment_count>
      <attachid>254548</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-06-09 14:23:33 -0700</bug_when>
    <thetext>Comment on attachment 254548
Patch

Clearing flags on attachment: 254548

Committed r185381: &lt;http://trac.webkit.org/changeset/185381&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1100795</commentid>
    <comment_count>3</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-06-09 14:23:35 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>254548</attachid>
            <date>2015-06-08 22:19:41 -0700</date>
            <delta_ts>2015-06-09 14:23:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-145786.diff</filename>
            <type>text/plain</type>
            <size>2448</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDYzYzhhMjEuLmI2NTFkOGUgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE1LTA2LTA4ICBBbmRyZWFzIEtsaW5n
ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBbSlNDXSBQb2x5bW9ycGhpY3tHZXQsUHV0
fUJ5SWRMaXN0OjphZGRBY2Nlc3MoKSBzaG91bGQgb3B0aW1pemUgZm9yIHNpemUsIG5vdCBzcGVl
ZC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0NTc4Nj4KKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVzZSBmdW5jdGlvbnMgYWxyZWFk
eSBjb250YWluZWQgY29tbWVudHMgc2F5aW5nIHRoZXkgb3B0aW1pemUgZm9yIHNpemUgb3ZlciBz
cGVlZCwKKyAgICAgICAgYnV0IHRoZXkgd2VyZSB1c2luZyBWZWN0b3I6OnJlc2l6ZSgpIHdoaWNo
IGFkZHMgdGhlIHVzdWFsIHNsYWNrIGZvciBmYXN0ZXIgYXBwZW5kKCkuCisKKyAgICAgICAgU3dp
dGNoIHRoZW0gb3ZlciB0byB1c2luZyBWZWN0b3I6OnJlc2l6ZVRvRml0KCkgaW5zdGVhZCwgd2hp
Y2ggbWFrZXMgdGhlIFZlY3RvcgorICAgICAgICBhbGxvY2F0ZSBhIHBlcmZlY3RseSBzaXplZCBi
YWNraW5nIHN0b3JlLgorCisgICAgICAgIFNwb3R0ZWQgNjcwIGtCIG9mIHRoZSBHZXRCeUlkIG9u
ZXMsIGFuZCAxNjUga0Igb2YgUHV0QnlJZCBvbiBjbmV0LmNvbSwgc28gdGhlc2UKKyAgICAgICAg
VmVjdG9ycyBhcmUgZGVmaW5pdGVseSB3b3J0aCBzaHJpbmstd3JhcHBpbmcuCisKKyAgICAgICAg
KiBieXRlY29kZS9Qb2x5bW9ycGhpY0dldEJ5SWRMaXN0LmNwcDoKKyAgICAgICAgKEpTQzo6UG9s
eW1vcnBoaWNHZXRCeUlkTGlzdDo6YWRkQWNjZXNzKToKKyAgICAgICAgKiBieXRlY29kZS9Qb2x5
bW9ycGhpY1B1dEJ5SWRMaXN0LmNwcDoKKyAgICAgICAgKEpTQzo6UG9seW1vcnBoaWNQdXRCeUlk
TGlzdDo6YWRkQWNjZXNzKToKKworMjAxNS0wNi0wOCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0Bh
cHBsZS5jb20+CisKICAgICAgICAgW0pTQ10gU3RyaW5nLnByb3RvdHlwZS5pbmRleE9mKCkgc2hv
dWxkIHVzZSBTdHJpbmdWaWV3LgogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQ1MzUx
PgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUG9seW1vcnBo
aWNHZXRCeUlkTGlzdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUG9seW1v
cnBoaWNHZXRCeUlkTGlzdC5jcHAKaW5kZXggODUwMTFjNi4uYzFlNWU2NyAxMDA2NDQKLS0tIGEv
U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1BvbHltb3JwaGljR2V0QnlJZExpc3QuY3Bw
CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Qb2x5bW9ycGhpY0dldEJ5SWRM
aXN0LmNwcApAQCAtMTE2LDcgKzExNiw3IEBAIHZvaWQgUG9seW1vcnBoaWNHZXRCeUlkTGlzdDo6
YWRkQWNjZXNzKGNvbnN0IEdldEJ5SWRBY2Nlc3MmIGFjY2VzcykKIHsKICAgICBBU1NFUlQoIWlz
RnVsbCgpKTsKICAgICAvLyBNYWtlIHN1cmUgdGhhdCB0aGUgcmVzaXppbmcgb3B0aW1pemVzIGZv
ciBzcGFjZSwgbm90IHRpbWUuCi0gICAgbV9saXN0LnJlc2l6ZShtX2xpc3Quc2l6ZSgpICsgMSk7
CisgICAgbV9saXN0LnJlc2l6ZVRvRml0KG1fbGlzdC5zaXplKCkgKyAxKTsKICAgICBtX2xpc3Qu
bGFzdCgpID0gYWNjZXNzOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
Ynl0ZWNvZGUvUG9seW1vcnBoaWNQdXRCeUlkTGlzdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvYnl0ZWNvZGUvUG9seW1vcnBoaWNQdXRCeUlkTGlzdC5jcHAKaW5kZXggODYwNWE1MC4uOTFi
ODdkNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1BvbHltb3Jw
aGljUHV0QnlJZExpc3QuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Q
b2x5bW9ycGhpY1B1dEJ5SWRMaXN0LmNwcApAQCAtMTM4LDcgKzEzOCw3IEBAIHZvaWQgUG9seW1v
cnBoaWNQdXRCeUlkTGlzdDo6YWRkQWNjZXNzKGNvbnN0IFB1dEJ5SWRBY2Nlc3MmIHB1dEJ5SWRB
Y2Nlc3MpCiB7CiAgICAgQVNTRVJUKCFpc0Z1bGwoKSk7CiAgICAgLy8gTWFrZSBzdXJlIHRoYXQg
dGhlIHJlc2l6aW5nIG9wdGltaXplcyBmb3Igc3BhY2UsIG5vdCB0aW1lLgotICAgIG1fbGlzdC5y
ZXNpemUobV9saXN0LnNpemUoKSArIDEpOworICAgIG1fbGlzdC5yZXNpemVUb0ZpdChtX2xpc3Qu
c2l6ZSgpICsgMSk7CiAgICAgbV9saXN0Lmxhc3QoKSA9IHB1dEJ5SWRBY2Nlc3M7CiB9CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>