145784 2015-06-08 22:10:00 -0700 [JSC] CodeBlock::m_constantRegisters should be sized-to-fit. 2015-06-09 14:26:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling kling oldest_to_newest 1100575 0 kling 2015-06-08 22:10:00 -0700 We should use Vector::resizeToFit() instead of Vector::resize() when we know the final size for something. 1100576 1 254546 kling 2015-06-08 22:10:22 -0700 Created attachment 254546 Patch 1100796 2 254546 kling 2015-06-09 14:26:09 -0700 Comment on attachment 254546 Patch Clearing flags on attachment: 254546 Committed r185382: <http://trac.webkit.org/changeset/185382> 1100797 3 kling 2015-06-09 14:26:13 -0700 All reviewed patches have been landed. Closing bug. 254546 2015-06-08 22:10:22 -0700 2015-06-09 14:26:09 -0700 Patch bug-145784.diff text/plain 6560 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGUwNDQ0NzQuLmU4MDQ3NjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDE1LTA2LTA4ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBbSlNDXSBDb2RlQmxvY2s6Om1fY29uc3Rh bnRSZWdpc3RlcnMgc2hvdWxkIGJlIHNpemVkLXRvLWZpdC4KKyAgICAgICAgPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzE0NTc4ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTcG90dGVkIHRoaXMgVmVjdG9yIGxvb2tpbmcgY2h1YmJ5IG9uIGNuZXQuY29t LCB3aXRoIDEuMjMgTUIgb2YgbWVtb3J5CisgICAgICAgIGFsbG9jYXRlZCBiZWxvdyBDb2RlQmxv Y2s6OnNldENvbnN0YW50UmVnaXN0ZXJzKCkuCisKKyAgICAgICAgVXNlIHJlc2l6ZVRvRml0KCkg aW5zdGVhZCBzaW5jZSB3ZSBrbm93IHRoZSBmaW5hbCBzaXplIHVwIGZyb250LgorICAgICAgICBB bHNvIHJlbW92ZWQgc29tZSB1bnVzZWQgZnVuY3Rpb25zIHRoYXQgb3BlcmF0ZWQgb24gdGhpcyBj b25zdGFudHMgdmVjdG9yCisgICAgICAgIGFuZCB0aGUgY29ycmVzcG9uZGluZyBvbmUgaW4gVW5s aW5rZWRDb2RlQmxvY2suCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAg ICAgICAoSlNDOjpDb2RlQmxvY2s6OmFkZE9yRmluZENvbnN0YW50KTogRGVsZXRlZC4KKyAgICAg ICAgKEpTQzo6Q29kZUJsb2NrOjpmaW5kQ29uc3RhbnQpOiBEZWxldGVkLgorICAgICAgICAqIGJ5 dGVjb2RlL0NvZGVCbG9jay5oOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OnNldENvbnN0YW50 UmVnaXN0ZXJzKToKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpudW1iZXJPZkNvbnN0YW50UmVn aXN0ZXJzKTogRGVsZXRlZC4KKyAgICAgICAgKiBieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5j cHA6CisgICAgICAgIChKU0M6OlVubGlua2VkQ29kZUJsb2NrOjphZGRPckZpbmRDb25zdGFudCk6 IERlbGV0ZWQuCisgICAgICAgICogYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suaDoKKyAgICAg ICAgKEpTQzo6VW5saW5rZWRDb2RlQmxvY2s6Om51bWJlck9mQ29uc3RhbnRSZWdpc3RlcnMpOiBE ZWxldGVkLgorICAgICAgICAoSlNDOjpVbmxpbmtlZENvZGVCbG9jazo6Z2V0Q29uc3RhbnQpOiBE ZWxldGVkLgorCisyMDE1LTA2LTA4ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4K KwogICAgICAgICBbSlNDXSBJbmxpbmVDYWxsRnJhbWU6OmFyZ3VtZW50cyBzaG91bGQgYmUgc2l6 ZWQtdG8tZml0LgogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQ1NzgyPgogCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCmluZGV4IDFjNmIzYTMu LmI0MGY4ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2Rl QmxvY2suY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2su Y3BwCkBAIC0yOTY0LDI3ICsyOTY0LDYgQEAgdm9pZCBDb2RlQmxvY2s6OnNocmlua1RvRml0KFNo cmlua01vZGUgc2hyaW5rTW9kZSkKICAgICB9IC8vIGVsc2UgZG9uJ3Qgc2hyaW5rIHRoZXNlLCBi ZWNhdXNlIHdlIHdvdWxkIGhhdmUgYWxyZWFkeSBwb2ludGVkIHBvaW50ZXJzIGludG8gdGhlc2Ug dGFibGVzLgogfQogCi11bnNpZ25lZCBDb2RlQmxvY2s6OmFkZE9yRmluZENvbnN0YW50KEpTVmFs dWUgdikKLXsKLSAgICB1bnNpZ25lZCByZXN1bHQ7Ci0gICAgaWYgKGZpbmRDb25zdGFudCh2LCBy ZXN1bHQpKQotICAgICAgICByZXR1cm4gcmVzdWx0OwotICAgIHJldHVybiBhZGRDb25zdGFudCh2 KTsKLX0KLQotYm9vbCBDb2RlQmxvY2s6OmZpbmRDb25zdGFudChKU1ZhbHVlIHYsIHVuc2lnbmVk JiBpbmRleCkKLXsKLSAgICB1bnNpZ25lZCBudW1iZXJPZkNvbnN0YW50cyA9IG51bWJlck9mQ29u c3RhbnRSZWdpc3RlcnMoKTsKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbnVtYmVyT2ZD b25zdGFudHM7ICsraSkgewotICAgICAgICBpZiAoZ2V0Q29uc3RhbnQoRmlyc3RDb25zdGFudFJl Z2lzdGVySW5kZXggKyBpKSA9PSB2KSB7Ci0gICAgICAgICAgICBpbmRleCA9IGk7Ci0gICAgICAg ICAgICByZXR1cm4gdHJ1ZTsKLSAgICAgICAgfQotICAgIH0KLSAgICBpbmRleCA9IG51bWJlck9m Q29uc3RhbnRzOwotICAgIHJldHVybiBmYWxzZTsKLX0KLQogI2lmIEVOQUJMRShKSVQpCiB2b2lk IENvZGVCbG9jazo6dW5saW5rQ2FsbHMoKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL0NvZGVCbG9jay5oCmluZGV4IDRiODE1NDMuLjY1ZGFiOTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKQEAgLTU3Miw3ICs1NzIsNiBAQCBwdWJsaWM6 CiAKICAgICBWZWN0b3I8V3JpdGVCYXJyaWVyPFVua25vd24+PiYgY29uc3RhbnRzKCkgeyByZXR1 cm4gbV9jb25zdGFudFJlZ2lzdGVyczsgfQogICAgIFZlY3RvcjxTb3VyY2VDb2RlUmVwcmVzZW50 YXRpb24+JiBjb25zdGFudHNTb3VyY2VDb2RlUmVwcmVzZW50YXRpb24oKSB7IHJldHVybiBtX2Nv bnN0YW50c1NvdXJjZUNvZGVSZXByZXNlbnRhdGlvbjsgfQotICAgIHNpemVfdCBudW1iZXJPZkNv bnN0YW50UmVnaXN0ZXJzKCkgY29uc3QgeyByZXR1cm4gbV9jb25zdGFudFJlZ2lzdGVycy5zaXpl KCk7IH0KICAgICB1bnNpZ25lZCBhZGRDb25zdGFudChKU1ZhbHVlIHYpCiAgICAgewogICAgICAg ICB1bnNpZ25lZCByZXN1bHQgPSBtX2NvbnN0YW50UmVnaXN0ZXJzLnNpemUoKTsKQEAgLTU5MCw4 ICs1ODksNiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogCi0gICAg Ym9vbCBmaW5kQ29uc3RhbnQoSlNWYWx1ZSwgdW5zaWduZWQmIHJlc3VsdCk7Ci0gICAgdW5zaWdu ZWQgYWRkT3JGaW5kQ29uc3RhbnQoSlNWYWx1ZSk7CiAgICAgV3JpdGVCYXJyaWVyPFVua25vd24+ JiBjb25zdGFudFJlZ2lzdGVyKGludCBpbmRleCkgeyByZXR1cm4gbV9jb25zdGFudFJlZ2lzdGVy c1tpbmRleCAtIEZpcnN0Q29uc3RhbnRSZWdpc3RlckluZGV4XTsgfQogICAgIEFMV0FZU19JTkxJ TkUgYm9vbCBpc0NvbnN0YW50UmVnaXN0ZXJJbmRleChpbnQgaW5kZXgpIGNvbnN0IHsgcmV0dXJu IGluZGV4ID49IEZpcnN0Q29uc3RhbnRSZWdpc3RlckluZGV4OyB9CiAgICAgQUxXQVlTX0lOTElO RSBKU1ZhbHVlIGdldENvbnN0YW50KGludCBpbmRleCkgY29uc3QgeyByZXR1cm4gbV9jb25zdGFu dFJlZ2lzdGVyc1tpbmRleCAtIEZpcnN0Q29uc3RhbnRSZWdpc3RlckluZGV4XS5nZXQoKTsgfQpA QCAtOTM0LDcgKzkzMSw3IEBAIHByaXZhdGU6CiAgICAgewogICAgICAgICBBU1NFUlQoY29uc3Rh bnRzLnNpemUoKSA9PSBjb25zdGFudHNTb3VyY2VDb2RlUmVwcmVzZW50YXRpb24uc2l6ZSgpKTsK ICAgICAgICAgc2l6ZV90IGNvdW50ID0gY29uc3RhbnRzLnNpemUoKTsKLSAgICAgICAgbV9jb25z dGFudFJlZ2lzdGVycy5yZXNpemUoY291bnQpOworICAgICAgICBtX2NvbnN0YW50UmVnaXN0ZXJz LnJlc2l6ZVRvRml0KGNvdW50KTsKICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBjb3Vu dDsgaSsrKQogICAgICAgICAgICAgbV9jb25zdGFudFJlZ2lzdGVyc1tpXS5zZXQoKm1fdm0sIG93 bmVyRXhlY3V0YWJsZSgpLCBjb25zdGFudHNbaV0uZ2V0KCkpOwogICAgICAgICBtX2NvbnN0YW50 c1NvdXJjZUNvZGVSZXByZXNlbnRhdGlvbiA9IGNvbnN0YW50c1NvdXJjZUNvZGVSZXByZXNlbnRh dGlvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Vbmxpbmtl ZENvZGVCbG9jay5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRD b2RlQmxvY2suY3BwCmluZGV4IDhhODBhNWMuLmUyNjJiYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmNwcApAQCAtODAsMTYg KzgwLDYgQEAgc3RhdGljIFVubGlua2VkRnVuY3Rpb25Db2RlQmxvY2sqIGdlbmVyYXRlRnVuY3Rp b25Db2RlQmxvY2soCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAotdW5zaWduZWQgVW5saW5rZWRD b2RlQmxvY2s6OmFkZE9yRmluZENvbnN0YW50KEpTVmFsdWUgdikKLXsKLSAgICB1bnNpZ25lZCBu dW1iZXJPZkNvbnN0YW50cyA9IG51bWJlck9mQ29uc3RhbnRSZWdpc3RlcnMoKTsKLSAgICBmb3Ig KHVuc2lnbmVkIGkgPSAwOyBpIDwgbnVtYmVyT2ZDb25zdGFudHM7ICsraSkgewotICAgICAgICBp ZiAoZ2V0Q29uc3RhbnQoRmlyc3RDb25zdGFudFJlZ2lzdGVySW5kZXggKyBpKSA9PSB2KQotICAg ICAgICAgICAgcmV0dXJuIGk7Ci0gICAgfQotICAgIHJldHVybiBhZGRDb25zdGFudCh2KTsKLX0K LQogVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGU6OlVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxl KFZNKiB2bSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJjZSwg UmVmUHRyPFNvdXJjZVByb3ZpZGVyPiYmIHNvdXJjZU92ZXJyaWRlLCBGdW5jdGlvbkJvZHlOb2Rl KiBub2RlLCBVbmxpbmtlZEZ1bmN0aW9uS2luZCBraW5kKQogICAgIDogQmFzZSgqdm0sIHN0cnVj dHVyZSkKICAgICAsIG1fbmFtZShub2RlLT5pZGVudCgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suaAppbmRleCAxOGRhMWY1Li43OTA0 NDI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRD b2RlQmxvY2suaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRD b2RlQmxvY2suaApAQCAtMzE2LDcgKzMxNiw2IEBAIHB1YmxpYzoKICAgICBjb25zdCBJZGVudGlm aWVyJiBpZGVudGlmaWVyKGludCBpbmRleCkgY29uc3QgeyByZXR1cm4gbV9pZGVudGlmaWVyc1tp bmRleF07IH0KICAgICBjb25zdCBWZWN0b3I8SWRlbnRpZmllcj4mIGlkZW50aWZpZXJzKCkgY29u c3QgeyByZXR1cm4gbV9pZGVudGlmaWVyczsgfQogCi0gICAgc2l6ZV90IG51bWJlck9mQ29uc3Rh bnRSZWdpc3RlcnMoKSBjb25zdCB7IHJldHVybiBtX2NvbnN0YW50UmVnaXN0ZXJzLnNpemUoKTsg fQogICAgIHVuc2lnbmVkIGFkZENvbnN0YW50KEpTVmFsdWUgdiwgU291cmNlQ29kZVJlcHJlc2Vu dGF0aW9uIHNvdXJjZUNvZGVSZXByZXNlbnRhdGlvbiA9IFNvdXJjZUNvZGVSZXByZXNlbnRhdGlv bjo6T3RoZXIpCiAgICAgewogICAgICAgICB1bnNpZ25lZCByZXN1bHQgPSBtX2NvbnN0YW50UmVn aXN0ZXJzLnNpemUoKTsKQEAgLTM0MiwxMSArMzQxLDkgQEAgcHVibGljOgogICAgICAgICBBU1NF UlQoaW5kZXggPCBMaW5rVGltZUNvbnN0YW50Q291bnQpOwogICAgICAgICByZXR1cm4gbV9saW5r VGltZUNvbnN0YW50c1tpbmRleF07CiAgICAgfQotICAgIHVuc2lnbmVkIGFkZE9yRmluZENvbnN0 YW50KEpTVmFsdWUpOwogICAgIGNvbnN0IFZlY3RvcjxXcml0ZUJhcnJpZXI8VW5rbm93bj4+JiBj b25zdGFudFJlZ2lzdGVycygpIHsgcmV0dXJuIG1fY29uc3RhbnRSZWdpc3RlcnM7IH0KICAgICBj b25zdCBXcml0ZUJhcnJpZXI8VW5rbm93bj4mIGNvbnN0YW50UmVnaXN0ZXIoaW50IGluZGV4KSBj b25zdCB7IHJldHVybiBtX2NvbnN0YW50UmVnaXN0ZXJzW2luZGV4IC0gRmlyc3RDb25zdGFudFJl Z2lzdGVySW5kZXhdOyB9CiAgICAgQUxXQVlTX0lOTElORSBib29sIGlzQ29uc3RhbnRSZWdpc3Rl ckluZGV4KGludCBpbmRleCkgY29uc3QgeyByZXR1cm4gaW5kZXggPj0gRmlyc3RDb25zdGFudFJl Z2lzdGVySW5kZXg7IH0KLSAgICBBTFdBWVNfSU5MSU5FIEpTVmFsdWUgZ2V0Q29uc3RhbnQoaW50 IGluZGV4KSBjb25zdCB7IHJldHVybiBtX2NvbnN0YW50UmVnaXN0ZXJzW2luZGV4IC0gRmlyc3RD b25zdGFudFJlZ2lzdGVySW5kZXhdLmdldCgpOyB9CiAgICAgY29uc3QgVmVjdG9yPFNvdXJjZUNv ZGVSZXByZXNlbnRhdGlvbj4mIGNvbnN0YW50c1NvdXJjZUNvZGVSZXByZXNlbnRhdGlvbigpIHsg cmV0dXJuIG1fY29uc3RhbnRzU291cmNlQ29kZVJlcHJlc2VudGF0aW9uOyB9CiAKICAgICAvLyBK dW1wcwo=