145779 2015-06-08 17:31:55 -0700 Missing content in UIWebView snapshots sometimes 2015-06-11 11:03:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser koivisto simon.fraser oldest_to_newest 1100527 0 simon.fraser 2015-06-08 17:31:55 -0700 Missing content in UIWebView snapshots sometimes 1100528 1 254528 simon.fraser 2015-06-08 17:34:36 -0700 Created attachment 254528 Patch 1100531 2 254528 darin 2015-06-08 17:44:14 -0700 Comment on attachment 254528 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254528&action=review > Source/WebCore/platform/ios/LegacyTileLayer.mm:35 > +using namespace WebCore; If we are going to add this, then are we going to remove all the other WebCore prefixes in this file? Maybe we should just use WebCore::FloatRect in the one place it matters. > Source/WebCore/platform/ios/LegacyTileLayer.mm:62 > + _tileGrid->tileCache().setOverrideVisibleRect(Optional<FloatRect>(dirtyRect)); I think just FloatRect(dirtyRect) would be better here. > Source/WebCore/platform/ios/LegacyTileLayer.mm:67 > + _tileGrid->tileCache().setOverrideVisibleRect(Optional<FloatRect>()); Nullopt is the normal way to write this. 1101315 3 simon.fraser 2015-06-11 10:29:15 -0700 <rdar://problem/20744708> 1101328 4 simon.fraser 2015-06-11 11:03:02 -0700 https://trac.webkit.org/r185461 254528 2015-06-08 17:34:36 -0700 2015-06-08 17:44:14 -0700 Patch bug-145779-20150608173410.patch text/plain 4257 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI2YTE3ZDA5NGNhNTEz YmVjOTkyYzEyNWFhNTUyOWJiM2I4YmRjMS4uODVhNTk5ZGNjNTg4ZmY2YTNiNDQ0ZjhmMDZiZDM4 ZjQzMGQ4MzMwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA2LTA4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1pc3NpbmcgY29u dGVudCBpbiBVSVdlYlZpZXcgc25hcHNob3RzIHNvbWV0aW1lcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1Nzc5CisgICAgICAgIHJkYXI6Ly9wcm9i bGVtLzIwNzQ0NzA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIAorICAgICAgICBXaGVuIGV4cGFuZGluZyBjb2xsYXBzZWQgcGFydHMgb2YgcXVvdGVkIHRl eHQgb24gaU9TLCBzb21ldGltZXMgdGhlICJjb25jZXJ0aW5hIgorICAgICAgICBpbWFnZXMgd291 bGQgYmUgYmxhbmsuIFRoaXMgaGFwcGVuZWQgYmVjYXVzZSB3ZSdkIGZhaWwgdG8gY3JlYXRlIHRp bGVzIGZvciByZWdpb25zCisgICAgICAgIG91dHNpZGUgdGhlIExlZ2FjeVRpbGVDYWNoZSdzIHZp c2libGVSZWN0LgorICAgICAgICAKKyAgICAgICAgRml4IGJ5IGdpdmluZyBMZWdhY3lUaWxlQ2Fj aGUgYW4gb3B0aW9uYWwgb3ZlcnJpZGUgdmlzaWJsZVJlY3QsIHdoaWNoIGlzIHNldAorICAgICAg ICBhbmQgY2xlYXJlZCBkdXJpbmcgLXJlbmRlckluQ29udGV4dDogdXNpbmcgdGhlIGNvbnRleHQg Y2xpcCByZWN0LgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL0xlZ2FjeVRpbGVDYWNoZS5oOgor ICAgICAgICAqIHBsYXRmb3JtL2lvcy9MZWdhY3lUaWxlQ2FjaGUubW06CisgICAgICAgIChXZWJD b3JlOjpMZWdhY3lUaWxlQ2FjaGU6OnZpc2libGVSZWN0SW5MYXllcik6CisgICAgICAgIChXZWJD b3JlOjpMZWdhY3lUaWxlQ2FjaGU6OnNldE92ZXJyaWRlVmlzaWJsZVJlY3QpOgorICAgICAgICAq IHBsYXRmb3JtL2lvcy9MZWdhY3lUaWxlTGF5ZXIubW06CisgICAgICAgICgtW0xlZ2FjeVRpbGVI b3N0TGF5ZXIgcmVuZGVySW5Db250ZXh0Ol0pOgorCiAyMDE1LTA2LTAzICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxODQ5Njgp OiBtaXNzaW5nIG1lZGlhIHBsYXllciBidXR0b25zIChjb250cm9sIGJhciBleGlzdHMsIGJ1dCBu byBidXR0b25zKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0xlZ2Fj eVRpbGVDYWNoZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0xlZ2FjeVRpbGVDYWNo ZS5oCmluZGV4IGE4YTA3MzM2MDVkY2FkNGJkMjJiMzZjZDJiZGU1MzkyZjRiMjgzNTcuLjQ0YmFi Y2NjNDkwYmY4NDlhZjE5OWJlY2RjNDJiYzRhYjIxYzg1YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2lvcy9MZWdhY3lUaWxlQ2FjaGUuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pb3MvTGVnYWN5VGlsZUNhY2hlLmgKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNs dWRlICJJbnRTaXplLmgiCiAjaW5jbHVkZSAiVGltZXIuaCIKICNpbmNsdWRlIDx3dGYvTm9uY29w eWFibGUuaD4KKyNpbmNsdWRlIDx3dGYvT3B0aW9uYWwuaD4KICNpbmNsdWRlIDx3dGYvUGFzc1Jl ZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SZXRhaW5QdHIuaD4KICNpbmNsdWRlIDx3dGYvVGhyZWFk aW5nLmg+CkBAIC0xMzksNiArMTQwLDcgQEAgcHVibGljOgogICAgIENBTGF5ZXIqIGhvc3RMYXll cigpIGNvbnN0OwogICAgIHVuc2lnbmVkIHRpbGVDYXBhY2l0eUZvckdyaWQoTGVnYWN5VGlsZUdy aWQqKTsKICAgICBDb2xvciBjb2xvckZvckdyaWRUaWxlQm9yZGVyKExlZ2FjeVRpbGVHcmlkKikg Y29uc3Q7CisgICAgdm9pZCBzZXRPdmVycmlkZVZpc2libGVSZWN0KE9wdGlvbmFsPEZsb2F0UmVj dD4pOwogCiAgICAgdm9pZCBkb1BlbmRpbmdSZXBhaW50cygpOwogCkBAIC0xODMsNiArMTg1LDgg QEAgcHJpdmF0ZToKICAgICAvLyBFbnN1cmUgdGhlcmUgYXJlIG5vIGFzeW5jIGNhbGxzIG9uIGEg ZGVhZCB0aWxlIGNhY2hlLgogICAgIFJldGFpblB0cjxMZWdhY3lUaWxlQ2FjaGVUb21ic3RvbmU+ IG1fdG9tYnN0b25lOwogCisgICAgT3B0aW9uYWw8RmxvYXRSZWN0PiBtX292ZXJyaWRlVmlzaWJs ZVJlY3Q7CisKICAgICBUaWxpbmdNb2RlIG1fdGlsaW5nTW9kZTsKICAgICBUaWxpbmdEaXJlY3Rp b24gbV90aWxpbmdEaXJlY3Rpb247CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy9MZWdhY3lUaWxlQ2FjaGUubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mv TGVnYWN5VGlsZUNhY2hlLm1tCmluZGV4IDlkZWNlZTgxNzJiOGE3OTM1MTEwYzg4NjJjMmVlNTUz Y2FkMDIwZGMuLjkyN2U5YThiN2I0MzBlYjIxNzBiMGU5Y2RhYTIwMjg0MWI3YjI4YjIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9MZWdhY3lUaWxlQ2FjaGUubW0KKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0xlZ2FjeVRpbGVDYWNoZS5tbQpAQCAtMTEw LDkgKzExMCwxNyBAQCBDQUxheWVyKiBMZWdhY3lUaWxlQ2FjaGU6Omhvc3RMYXllcigpIGNvbnN0 CiAKIEZsb2F0UmVjdCBMZWdhY3lUaWxlQ2FjaGU6OnZpc2libGVSZWN0SW5MYXllcihDQUxheWVy ICpsYXllcikgY29uc3QKIHsKKyAgICBpZiAobV9vdmVycmlkZVZpc2libGVSZWN0KQorICAgICAg ICByZXR1cm4gW2xheWVyIGNvbnZlcnRSZWN0Om1fb3ZlcnJpZGVWaXNpYmxlUmVjdC52YWx1ZSgp IGZyb21MYXllcjpob3N0TGF5ZXIoKV07CisKICAgICByZXR1cm4gW2xheWVyIGNvbnZlcnRSZWN0 OlttX3dpbmRvdyBleHRlbmRlZFZpc2libGVSZWN0XSBmcm9tTGF5ZXI6aG9zdExheWVyKCldOwog fQogCit2b2lkIExlZ2FjeVRpbGVDYWNoZTo6c2V0T3ZlcnJpZGVWaXNpYmxlUmVjdChPcHRpb25h bDxGbG9hdFJlY3Q+IHJlY3QpCit7CisgICAgbV9vdmVycmlkZVZpc2libGVSZWN0ID0gcmVjdDsK K30KKwogYm9vbCBMZWdhY3lUaWxlQ2FjaGU6OnRpbGVzT3BhcXVlKCkgY29uc3QKIHsKICAgICBy ZXR1cm4gbV90aWxlc09wYXF1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2lvcy9MZWdhY3lUaWxlTGF5ZXIubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvTGVn YWN5VGlsZUxheWVyLm1tCmluZGV4IDg1MDkyMTAxNjA0YzdlOTAzMDI2NjA4Mzg0Yjg2MWE1NDhl N2I3YTMuLjFhNGVkYmYzZmIxNDgwYThjMzFlZTI1MzFiMzE4ZTk3YjRiZTA3ZGUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9MZWdhY3lUaWxlTGF5ZXIubW0KKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0xlZ2FjeVRpbGVMYXllci5tbQpAQCAtMzIsNyAr MzIsMTAgQEAKICNpbmNsdWRlICJMZWdhY3lUaWxlR3JpZC5oIgogI2luY2x1ZGUgIldlYkNvcmVU aHJlYWQuaCIKIAordXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CisKIEBpbXBsZW1lbnRhdGlvbiBM ZWdhY3lUaWxlSG9zdExheWVyCisKIC0gKGlkKWluaXRXaXRoVGlsZUdyaWQ6KFdlYkNvcmU6Okxl Z2FjeVRpbGVHcmlkKil0aWxlR3JpZAogewogICAgIHNlbGYgPSBbc3VwZXIgaW5pdF07CkBAIC01 NCw4ICs1NywxNCBAQCAtICh2b2lkKXJlbmRlckluQ29udGV4dDooQ0dDb250ZXh0UmVmKWNvbnRl eHQKIHsKICAgICBpZiAocHRocmVhZF9tYWluX25wKCkpCiAgICAgICAgIFdlYlRocmVhZExvY2so KTsKKworICAgIENHUmVjdCBkaXJ0eVJlY3QgPSBDR0NvbnRleHRHZXRDbGlwQm91bmRpbmdCb3go Y29udGV4dCk7CisgICAgX3RpbGVHcmlkLT50aWxlQ2FjaGUoKS5zZXRPdmVycmlkZVZpc2libGVS ZWN0KE9wdGlvbmFsPEZsb2F0UmVjdD4oZGlydHlSZWN0KSk7CiAgICAgX3RpbGVHcmlkLT50aWxl Q2FjaGUoKS5kb0xheW91dFRpbGVzKCk7CisKICAgICBbc3VwZXIgcmVuZGVySW5Db250ZXh0OmNv bnRleHRdOworCisgICAgX3RpbGVHcmlkLT50aWxlQ2FjaGUoKS5zZXRPdmVycmlkZVZpc2libGVS ZWN0KE9wdGlvbmFsPEZsb2F0UmVjdD4oKSk7CiB9CiBAZW5kCiAK