145767 2015-06-08 13:26:13 -0700 Web Inspector: Clearing active Timeline recording should stop capturing 2015-06-08 20:03:56 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1100436 0 mattbaker 2015-06-08 13:26:13 -0700 * SUMMARY Clearing active Timeline recording should stop capturing. Clearing the TimelineRecording resets start/end times and the current Rendering Frame index, so we're effectively creating a new Timeline recording anyway. 1100439 1 webkit-bug-importer 2015-06-08 13:26:50 -0700 <rdar://problem/21287839> 1100441 2 254505 mattbaker 2015-06-08 13:30:19 -0700 Created attachment 254505 [Patch] Proposed Fix 1100442 3 mattbaker 2015-06-08 13:37:18 -0700 Before we stop capturing, maybe we should we check that: WebInspector.timelineManager.activeRecording === this._recording I'm fairly certain only the active timeline recording can be cleared, but this would make the change tolerant to future changes such as adding the ability to delete an arbitrary recording. 1100453 4 254507 mattbaker 2015-06-08 14:24:17 -0700 Created attachment 254507 [Patch] Proposed Fix 1100496 5 254507 joepeck 2015-06-08 16:14:56 -0700 Comment on attachment 254507 [Patch] Proposed Fix Sounds good! r=me 1100560 6 254507 commit-queue 2015-06-08 20:03:52 -0700 Comment on attachment 254507 [Patch] Proposed Fix Clearing flags on attachment: 254507 Committed r185349: <http://trac.webkit.org/changeset/185349> 1100561 7 commit-queue 2015-06-08 20:03:56 -0700 All reviewed patches have been landed. Closing bug. 254505 2015-06-08 13:30:19 -0700 2015-06-08 14:24:15 -0700 [Patch] Proposed Fix bug-145767-20150608132953.patch text/plain 1520 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAy NmI1NzczY2VjNzk5ZjNmZmUwMjdjOGZjOTJhYTBiODU4NzdhZjZiLi5mYWY0YjIzOGUwNGQyMTBh OTczNDRlMjM1OWY1YmJkOTUwYTQ1MmQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNS0wNi0wOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xlYXJpbmcgYWN0aXZlIFRpbWVsaW5lIHJlY29y ZGluZyBzaG91bGQgc3RvcCBjYXB0dXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NTc2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGlu Z0NvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5n Q29udGVudFZpZXcucHJvdG90eXBlLl9jbGVhclRpbWVsaW5lKToKKyAgICAgICAgU3RvcCBjYXB0 dXJpbmcgaWYgbmVjZXNzYXJ5LgorCiAyMDE1LTA2LTA3ICBUb2JpYXMgUmVpc3MgIDx0b2JpK3dl YmtpdEBiYXNlY29kZS5kZT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgUHJldHR5UHJp bnRlciBDU1NSdWxlIHRlc3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250 ZW50Vmlldy5qcwppbmRleCA5ZGRmNWY4ZGQ0MjY0OTNlZmMyMGFmOTdiNDBhMDMyYTQxYjdjNjI4 Li43OTViNzJhMzhhNmZlMDE3YmU3OWI0NDYxZDZjZGM2MmZmMDUxMDQzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGlu Z0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKQEAgLTUzMCw2ICs1MzAsOSBA QCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUgPSB7 CiAKICAgICBfY2xlYXJUaW1lbGluZTogZnVuY3Rpb24oZXZlbnQpCiAgICAgeworICAgICAgICBp ZiAoV2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFuYWdlci5pc0NhcHR1cmluZygpKQorICAgICAgICAg ICAgV2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFuYWdlci5zdG9wQ2FwdHVyaW5nKCk7CisKICAgICAg ICAgdGhpcy5fcmVjb3JkaW5nLnJlc2V0KCk7CiAgICAgfSwKIAo= 254507 2015-06-08 14:24:17 -0700 2015-06-08 20:03:52 -0700 [Patch] Proposed Fix bug-145767-20150608142351.patch text/plain 1588 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAy NmI1NzczY2VjNzk5ZjNmZmUwMjdjOGZjOTJhYTBiODU4NzdhZjZiLi5mYWY0YjIzOGUwNGQyMTBh OTczNDRlMjM1OWY1YmJkOTUwYTQ1MmQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNS0wNi0wOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xlYXJpbmcgYWN0aXZlIFRpbWVsaW5lIHJlY29y ZGluZyBzaG91bGQgc3RvcCBjYXB0dXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NTc2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGlu Z0NvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5n Q29udGVudFZpZXcucHJvdG90eXBlLl9jbGVhclRpbWVsaW5lKToKKyAgICAgICAgU3RvcCBjYXB0 dXJpbmcgaWYgbmVjZXNzYXJ5LgorCiAyMDE1LTA2LTA3ICBUb2JpYXMgUmVpc3MgIDx0b2JpK3dl YmtpdEBiYXNlY29kZS5kZT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgUHJldHR5UHJp bnRlciBDU1NSdWxlIHRlc3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250 ZW50Vmlldy5qcwppbmRleCA5ZGRmNWY4ZGQ0MjY0OTNlZmMyMGFmOTdiNDBhMDMyYTQxYjdjNjI4 Li5hYWE5NTg0ZWE3NmY1ODU3MzM5ZjAzZDlhNjVkMWZiMWZlNDBjZTA0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGlu Z0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKQEAgLTUzMCw2ICs1MzAsOSBA QCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUgPSB7 CiAKICAgICBfY2xlYXJUaW1lbGluZTogZnVuY3Rpb24oZXZlbnQpCiAgICAgeworICAgICAgICBp ZiAoV2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFuYWdlci5hY3RpdmVSZWNvcmRpbmcgPT09IHRoaXMu X3JlY29yZGluZyAmJiBXZWJJbnNwZWN0b3IudGltZWxpbmVNYW5hZ2VyLmlzQ2FwdHVyaW5nKCkp CisgICAgICAgICAgICBXZWJJbnNwZWN0b3IudGltZWxpbmVNYW5hZ2VyLnN0b3BDYXB0dXJpbmco KTsKKwogICAgICAgICB0aGlzLl9yZWNvcmRpbmcucmVzZXQoKTsKICAgICB9LAogCg==