145764 2015-06-08 12:48:57 -0700 run-benchmark should either checkout JetStream 1.0.1 or support running the latest version 2015-06-09 12:30:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145762 1 rniwa rniwa barraclough commit-queue dewei_zhu fpizlo glenn oldest_to_newest 1100423 0 rniwa 2015-06-08 12:48:57 -0700 run-benchmark currently hard-codes 1.0.1 in its plan for JetStream and expects the ToT WebKit checkout to produce this version. We need to either download 1.0.1 or support running the latest version. It's probably preferable to download 1.0.1 since we want to able to control when change the benchmark we run. 1100424 1 fpizlo 2015-06-08 12:50:44 -0700 Let's change it to check out 1.0.1. We should only have the perf dashboard rev-up to the latest version of the benchmark when we are ready. We don't want the dashboard to have a meaningless jitter every time someone makes an incremental change to a benchmark. 1100443 2 rniwa 2015-06-08 13:40:35 -0700 Okay, let me write a patch to do that. 1100457 3 254509 rniwa 2015-06-08 14:31:56 -0700 Created attachment 254509 Fixes the bug 1100725 4 254509 darin 2015-06-09 11:40:44 -0700 Comment on attachment 254509 Fixes the bug rs=me 1100742 5 254509 commit-queue 2015-06-09 12:30:03 -0700 Comment on attachment 254509 Fixes the bug Clearing flags on attachment: 254509 Committed r185371: <http://trac.webkit.org/changeset/185371> 1100743 6 commit-queue 2015-06-09 12:30:07 -0700 All reviewed patches have been landed. Closing bug. 254509 2015-06-08 14:31:56 -0700 2015-06-09 12:30:03 -0700 Fixes the bug bug-145764-20150608143129.patch text/plain 6994 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTMyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI1IEBACisyMDE1LTA2LTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIHJ1bi1iZW5jaG1hcmsgc2hvdWxkIGVpdGhlciBjaGVja291dCBKZXRTdHJlYW0g MS4wLjEgb3Igc3VwcG9ydCBydW5uaW5nIHRoZSBsYXRlc3QgdmVyc2lvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NzY0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGhlIHN1cHBvcnQgZm9y IGNoZWNrb3V0IGEgc3VidmVyc2lvbiBkaXJlY3RvcnkgaW4gcnVuLWJlbmNobWFyayBhbmQgdXNl ZCBpbiB0aGUgcGxhbnMgZm9yCisgICAgICAgIEpldFN0cmVhbSBhbmQgU3VuU3BpZGVyLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2JlbmNobWFya19idWls ZGVyL2dlbmVyaWNfYmVuY2htYXJrX2J1aWxkZXIucHk6CisgICAgICAgIChHZW5lcmljQmVuY2ht YXJrQnVpbGRlcik6CisgICAgICAgIChHZW5lcmljQmVuY2htYXJrQnVpbGRlci5wcmVwYXJlKTog SW5zdGVhZCBvZiB0YWtpbmcgZWFjaCBhcmd1bWVudCBmcm9tIGJlbmNobWFyayBwbGFuLCBqdXN0 IGFjY2VwdAorICAgICAgICB0aGUgd2hvbGUgSlNPTiBhcyB0aGUgaW5wdXQuCisgICAgICAgIChH ZW5lcmljQmVuY2htYXJrQnVpbGRlci5fY2hlY2tvdXRXaXRoU3VidmVyaW9uKTogQWRkZWQuCisg ICAgICAgIChHZW5lcmljQmVuY2htYXJrQnVpbGRlci5fYXBwbHlQYXRjaCk6IENoZWNrIHRoZSBl eGlzdGVuY2Ugb2YgYmVuY2htYXJrX3BhdGNoIGluIHByZXBhcmUoKSBpbnN0ZWFkLgorICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9iZW5jaG1hcmtfcnVubmVyLnB5 OgorICAgICAgICAoQmVuY2htYXJrUnVubmVyLmV4ZWN1dGUpOiBSZW1vdmVkIHRoZSBjaGVjayBm b3IgaGF2aW5nIGVpdGhlciAnbG9jYWxfY29weScgb3IgJ3JlbW90ZV9hcmNoaXZlJyBpbgorICAg ICAgICBhIGJlbmNobWFyayBwbGFuIG5vdyB0aGF0IGl0J3MgY2hlY2tlZGkgaW4gR2VuZXJpY0Jl bmNobWFya0J1aWxkZXIucHJlcGFyZS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2JlbmNo bWFya19ydW5uZXIvZGF0YS9wbGFucy9qZXRzdHJlYW0ucGxhbjoKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvZGF0YS9wbGFucy9zdW5zcGlkZXIucGxhbjoKKwog MjAxNS0wNi0wOCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFtHVEtdIEZpeCBwYXJlbnRoZXNlcyB3YXJuaW5nIGluIFRlc3RXZWJLaXRXZWJWaWV3LmNw cApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2JlbmNobWFy a19ydW5uZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1h cmtfcnVubmVyL2JlbmNobWFya19ydW5uZXIucHkJKHJldmlzaW9uIDE4NTMyNykKKysrIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9iZW5jaG1hcmtfcnVubmVyLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC02NCwxMiArNjQsNyBAQCBjbGFzcyBCZW5jaG1hcmtSdW5uZXIob2Jq ZWN0KToKICAgICAgICAgcmVzdWx0cyA9IFtdCiAgICAgICAgIHNlbGYuYmVuY2htYXJrQnVpbGRl ciA9IEJlbmNobWFya0J1aWxkZXJGYWN0b3J5LmNyZWF0ZShbc2VsZi5wbGFuWydiZW5jaG1hcmtf YnVpbGRlciddXSkKIAotICAgICAgICBpZiBub3Qgc2VsZi5wbGFuLmdldCgnbG9jYWxfY29weScp IGFuZCBub3Qgc2VsZi5wbGFuLmdldCgncmVtb3RlX2FyY2hpdmUnKToKLSAgICAgICAgICAgIF9s b2cuZXJyb3IoJ0VpdGhlciBsb2NhbF9jb3B5IG9yIHJlbW90ZV9hcmNoaXZlIG11c3QgYmUgc3Bl Y2lmaWVkIGluIHRoZSBwbGFuJykKLSAgICAgICAgICAgIHN5cy5leGl0KDIpCi0KLSAgICAgICAg d2ViUm9vdCA9IHNlbGYuYmVuY2htYXJrQnVpbGRlci5wcmVwYXJlKHNlbGYucGxhbk5hbWUsIHNl bGYucGxhbi5nZXQoJ2xvY2FsX2NvcHknKSwgc2VsZi5wbGFuLmdldCgncmVtb3RlX2FyY2hpdmUn KSwKLSAgICAgICAgICAgIHNlbGYucGxhbi5nZXQoJ2JlbmNobWFya19wYXRjaCcpLCBzZWxmLnBs YW4uZ2V0KCdjcmVhdGVfc2NyaXB0JykpCisgICAgICAgIHdlYlJvb3QgPSBzZWxmLmJlbmNobWFy a0J1aWxkZXIucHJlcGFyZShzZWxmLnBsYW5OYW1lLCBzZWxmLnBsYW4pCiAgICAgICAgIGZvciB4 IGluIHhyYW5nZShpbnQoc2VsZi5wbGFuWydjb3VudCddKSk6CiAgICAgICAgICAgICBfbG9nLmlu Zm8oJ1N0YXJ0IHRoZSBpdGVyYXRpb24gJWQgb2YgY3VycmVudCBiZW5jaG1hcmsnICUgKHggKyAx KSkKICAgICAgICAgICAgIHNlbGYuaHR0cFNlcnZlckRyaXZlci5zZXJ2ZSh3ZWJSb290KQpJbmRl eDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2JlbmNobWFya19idWls ZGVyL2dlbmVyaWNfYmVuY2htYXJrX2J1aWxkZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2JlbmNobWFya19idWlsZGVyL2dlbmVyaWNf YmVuY2htYXJrX2J1aWxkZXIucHkJKHJldmlzaW9uIDE4NTMyNykKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9iZW5jaG1hcmtfYnVpbGRlci9nZW5lcmljX2JlbmNo bWFya19idWlsZGVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNiwyMSArMTYsMjYgQEAgX2xvZyA9 IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQogCiBjbGFzcyBHZW5lcmljQmVuY2htYXJrQnVp bGRlcihvYmplY3QpOgogCi0gICAgZGVmIHByZXBhcmUoc2VsZiwgbmFtZSwgYmVuY2htYXJrUGF0 aCwgYXJjaGl2ZVVSTCwgcGF0Y2gsIGNyZWF0ZVNjcmlwdCk6CisgICAgZGVmIHByZXBhcmUoc2Vs ZiwgbmFtZSwgcGxhbik6CiAgICAgICAgIHNlbGYubmFtZSA9IG5hbWUKICAgICAgICAgc2VsZi53 ZWJSb290ID0gdGVtcGZpbGUubWtkdGVtcCgpCiAgICAgICAgIHNlbGYuZGVzdCA9IG9zLnBhdGgu am9pbihzZWxmLndlYlJvb3QsIHNlbGYubmFtZSkKLSAgICAgICAgaWYgYmVuY2htYXJrUGF0aDoK LSAgICAgICAgICAgIHNlbGYuX2NvcHlCZW5jaG1hcmtUb1RlbXBEaXIoYmVuY2htYXJrUGF0aCkK KyAgICAgICAgaWYgJ2xvY2FsX2NvcHknIGluIHBsYW46CisgICAgICAgICAgICBzZWxmLl9jb3B5 QmVuY2htYXJrVG9UZW1wRGlyKHBsYW5bJ2xvY2FsX2NvcHknXSkKKyAgICAgICAgZWxpZiAncmVt b3RlX2FyY2hpdmUnIGluIHBsYW46CisgICAgICAgICAgICBzZWxmLl9mZXRjaFJlbW90ZUFyY2hp dmUocGxhblsncmVtb3RlX2FyY2hpdmUnXSkKKyAgICAgICAgZWxpZiAnc3ZuX3NvdXJjZScgaW4g cGxhbjoKKyAgICAgICAgICAgIHNlbGYuX2NoZWNrb3V0V2l0aFN1YnZlcmlvbihwbGFuWydzdm5f c291cmNlJ10pCiAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICBhc3NlcnQoYXJjaGl2ZVVSTCkK LSAgICAgICAgICAgIHNlbGYuX2ZldGNoUmVtb3RlQXJjaGl2ZShhcmNoaXZlVVJMKQorICAgICAg ICAgICAgcmFpc2UgRXhjZXB0aW9uKCdUaGUgYmVuY2htYXJrIGxvY2F0aW9uIHdhcyBub3Qgc3Bl Y2lmaWVkJykKIAogICAgICAgICBfbG9nLmluZm8oJ0NvcGllZCB0aGUgYmVuY2htYXJrIGludG86 ICVzJyAlIHNlbGYuZGVzdCkKICAgICAgICAgdHJ5OgotICAgICAgICAgICAgaWYgY3JlYXRlU2Ny aXB0OgotICAgICAgICAgICAgICAgIHNlbGYuX3J1bkNyZWF0ZVNjcmlwdChjcmVhdGVTY3JpcHQp Ci0gICAgICAgICAgICByZXR1cm4gc2VsZi5fYXBwbHlQYXRjaChwYXRjaCkKKyAgICAgICAgICAg IGlmICdjcmVhdGVfc2NyaXB0JyBpbiBwbGFuOgorICAgICAgICAgICAgICAgIHNlbGYuX3J1bkNy ZWF0ZVNjcmlwdChwbGFuWydjcmVhdGVfc2NyaXB0J10pCisgICAgICAgICAgICBpZiAnYmVuY2ht YXJrX3BhdGNoJyBpbiBwbGFuOgorICAgICAgICAgICAgICAgIHNlbGYuX2FwcGx5UGF0Y2gocGxh blsnYmVuY2htYXJrX3BhdGNoJ10pCisgICAgICAgICAgICByZXR1cm4gc2VsZi53ZWJSb290CiAg ICAgICAgIGV4Y2VwdCBFeGNlcHRpb246CiAgICAgICAgICAgICBzZWxmLmNsZWFuKCkKICAgICAg ICAgICAgIHJhaXNlCkBAIC02MiwxNiArNjcsMTkgQEAgY2xhc3MgR2VuZXJpY0JlbmNobWFya0J1 aWxkZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICBzaHV0aWwubW92ZShmaXJzdEZpbGUsIHNl bGYud2ViUm9vdCkKICAgICAgICAgICAgICAgICBvcy5yZW5hbWUob3MucGF0aC5qb2luKHNlbGYu d2ViUm9vdCwgdW5hcmNoaXZlZEZpbGVzWzBdKSwgc2VsZi5kZXN0KQogCisgICAgZGVmIF9jaGVj a291dFdpdGhTdWJ2ZXJpb24oc2VsZiwgc3VidmVyc2lvblVSTCk6CisgICAgICAgIF9sb2cuaW5m bygnQ2hlY2tpbmcgb3V0ICVzIHRvICVzJyAlIChzdWJ2ZXJzaW9uVVJMLCBzZWxmLmRlc3QpKQor ICAgICAgICBlcnJvckNvZGUgPSBzdWJwcm9jZXNzLmNhbGwoWydzdm4nLCAnY2hlY2tvdXQnLCBz dWJ2ZXJzaW9uVVJMLCBzZWxmLmRlc3RdKQorICAgICAgICBpZiBlcnJvckNvZGU6CisgICAgICAg ICAgICByYWlzZSBFeGNlcHRpb24oJ0Nhbm5vdCBjaGVja291dCB0aGUgYmVuY2htYXJrIC0gRXJy b3I6ICVzJyAlIGVycm9yQ29kZSkKKwogICAgIGRlZiBfYXBwbHlQYXRjaChzZWxmLCBwYXRjaCk6 Ci0gICAgICAgIGlmIG5vdCBwYXRjaDoKLSAgICAgICAgICAgIHJldHVybiBzZWxmLndlYlJvb3QK ICAgICAgICAgb2xkV29ya2luZ0RpcmVjdG9yeSA9IG9zLmdldGN3ZCgpCiAgICAgICAgIG9zLmNo ZGlyKHNlbGYuZGVzdCkKICAgICAgICAgZXJyb3JDb2RlID0gc3VicHJvY2Vzcy5jYWxsKFsncGF0 Y2gnLCAnLXAxJywgJy1mJywgJy1pJywgZ2V0UGF0aEZyb21Qcm9qZWN0Um9vdChwYXRjaCldKQog ICAgICAgICBvcy5jaGRpcihvbGRXb3JraW5nRGlyZWN0b3J5KQogICAgICAgICBpZiBlcnJvckNv ZGU6CiAgICAgICAgICAgICByYWlzZSBFeGNlcHRpb24oJ0Nhbm5vdCBhcHBseSBwYXRjaCwgd2ls bCBza2lwIGN1cnJlbnQgYmVuY2htYXJrUGF0aCAtIEVycm9yOiAlcycgJSBlcnJvckNvZGUpCi0g ICAgICAgIHJldHVybiBzZWxmLndlYlJvb3QKIAogICAgIGRlZiBjbGVhbihzZWxmKToKICAgICAg ICAgX2xvZy5pbmZvKCdDbGVhbmluZyBCZW5jaG1hcmsnKQpJbmRleDogVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2RhdGEvcGxhbnMvamV0c3RyZWFtLnBsYW4KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2RhdGEvcGxh bnMvamV0c3RyZWFtLnBsYW4JKHJldmlzaW9uIDE4NTMyNykKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvYmVuY2htYXJrX3J1bm5lci9kYXRhL3BsYW5zL2pldHN0cmVhbS5wbGFuCSh3b3JraW5n IGNvcHkpCkBAIC0zLDcgKzMsNyBAQAogICAgICJ0aW1lb3V0IiA6IDYwMCwKICAgICAiY291bnQi OiA1LAogICAgICJiZW5jaG1hcmtfYnVpbGRlciI6ICJHZW5lcmljQmVuY2htYXJrQnVpbGRlciIs Ci0gICAgImxvY2FsX2NvcHkiOiAiLi4vLi4vLi4vLi4vUGVyZm9ybWFuY2VUZXN0cy9KZXRTdHJl YW0iLAorICAgICJzdm5fc291cmNlIjogImh0dHBzOi8vc3ZuLndlYmtpdC5vcmcvcmVwb3NpdG9y eS93ZWJraXQvdHJ1bmsvUGVyZm9ybWFuY2VUZXN0cy9KZXRTdHJlYW0vQHIxODMwOTEiLAogICAg ICJiZW5jaG1hcmtfcGF0Y2giOiAiZGF0YS9wYXRjaGVzL0pldFN0cmVhbS5wYXRjaCIsCiAgICAg ImNyZWF0ZV9zY3JpcHQiOiBbInJ1YnkiLCAiY3JlYXRlLnJiIl0sCiAgICAgImVudHJ5X3BvaW50 IjogIkpldFN0cmVhbS0xLjAuMS9pbmRleC5odG1sIiwKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvYmVuY2htYXJrX3J1bm5lci9kYXRhL3BsYW5zL3N1bnNwaWRlci5wbGFuCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9kYXRhL3BsYW5z L3N1bnNwaWRlci5wbGFuCShyZXZpc2lvbiAxODUzMjcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2JlbmNobWFya19ydW5uZXIvZGF0YS9wbGFucy9zdW5zcGlkZXIucGxhbgkod29ya2luZyBj b3B5KQpAQCAtMyw3ICszLDcgQEAKICAgICAidGltZW91dCI6IDMwMCwKICAgICAiY291bnQiOiA1 LAogICAgICJiZW5jaG1hcmtfYnVpbGRlciI6ICJHZW5lcmljQmVuY2htYXJrQnVpbGRlciIsCi0g ICAgImxvY2FsX2NvcHkiOiAiLi4vLi4vLi4vLi4vUGVyZm9ybWFuY2VUZXN0cy9TdW5TcGlkZXIi LAorICAgICJzdm5fc291cmNlIjogImh0dHBzOi8vc3ZuLndlYmtpdC5vcmcvcmVwb3NpdG9yeS93 ZWJraXQvdHJ1bmsvUGVyZm9ybWFuY2VUZXN0cy9TdW5TcGlkZXIvQHIxODIxNzAiLAogICAgICJi ZW5jaG1hcmtfcGF0Y2giOiAiZGF0YS9wYXRjaGVzL1N1blNwaWRlci5wYXRjaCIsCiAgICAgImNy ZWF0ZV9zY3JpcHQiOiBbInBlcmwiLCAibWFrZS1ob3N0ZWQiXSwKICAgICAiZW50cnlfcG9pbnQi OiAiaG9zdGVkL3N1bnNwaWRlci0xLjAuMS9kcml2ZXIuaHRtbCIsCg==