145759 2015-06-08 08:54:45 -0700 [GTK] Fix parentheses warning in TestWebKitWebView.cpp 2015-06-08 09:49:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy cgarcia commit-queue zan oldest_to_newest 1100369 0 ossy 2015-06-08 08:54:45 -0700 clang build log: ----------------- ../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:478:22: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] while (readBytes = g_input_stream_read(test->m_inputStream.get(), &buffer, 512, 0, &error.outPtr())) { ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:478:22: note: place parentheses around the assignment to silence this warning while (readBytes = g_input_stream_read(test->m_inputStream.get(), &buffer, 512, 0, &error.outPtr())) { ^ ( ) ../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:478:22: note: use '==' to turn this assignment into an equality comparison while (readBytes = g_input_stream_read(test->m_inputStream.get(), &buffer, 512, 0, &error.outPtr())) { ^ == 1 warning generated. It isn't a bug, but a valid assignment, so we should use double parentheses to silence this warning. 1100370 1 254494 ossy 2015-06-08 08:55:50 -0700 Created attachment 254494 Patch 1100388 2 254494 commit-queue 2015-06-08 09:48:58 -0700 Comment on attachment 254494 Patch Clearing flags on attachment: 254494 Committed r185321: <http://trac.webkit.org/changeset/185321> 1100389 3 commit-queue 2015-06-08 09:49:02 -0700 All reviewed patches have been landed. Closing bug. 254494 2015-06-08 08:55:50 -0700 2015-06-08 09:48:58 -0700 Patch bug-145759-20150608085524.patch text/plain 1483 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MzE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzE3ZWM2OTE0NTI0YjQzMmYyMWRjYWFiNmM1MTM5MjZi NDQwNWQwOS4uZWE2MGNkNjEyYjAyZmM2NGE5NGRhNDFhYWI3ODBlMTVlZmFlNmJlMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTA2LTA4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0dUS10gRml4IHBhcmVudGhlc2VzIHdhcm5pbmcgaW4gVGVzdFdlYktpdFdlYlZp ZXcuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDU3NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0V2ViS2l0V2ViVmlldy5jcHA6Cisg ICAgICAgICh0ZXN0V2ViVmlld1NhdmUpOgorCiAyMDE1LTA2LTA3ICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgZWRpdG9yIG1v ZGUgdG8gTWluaUJyb3dzZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0Mkd0ay9UZXN0V2ViS2l0V2ViVmlldy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdDJHdGsvVGVzdFdlYktpdFdlYlZpZXcuY3BwCmluZGV4IDU3M2U1NzY2YTIwMTY2 OWE2M2Y3ODA5MTczMjZiNDc3Mzc1MTJhM2EuLjJiNzQyYjRlYTBkMWM1MjA0ZjA3MGFhMzVlOGQ4 NTc4Yjg2ZDQ0ZjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Mkd0ay9UZXN0V2ViS2l0V2ViVmlldy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyR3RrL1Rlc3RXZWJLaXRXZWJWaWV3LmNwcApAQCAtNDc1LDcgKzQ3NSw3IEBAIHN0 YXRpYyB2b2lkIHRlc3RXZWJWaWV3U2F2ZShTYXZlV2ViVmlld1Rlc3QqIHRlc3QsIGdjb25zdHBv aW50ZXIpCiAgICAgZ2NoYXIgYnVmZmVyWzUxMl0gPSB7IDAgfTsKICAgICBnc3NpemUgcmVhZEJ5 dGVzID0gMDsKICAgICBnc3NpemUgdG90YWxCeXRlc0Zyb21TdHJlYW0gPSAwOwotICAgIHdoaWxl IChyZWFkQnl0ZXMgPSBnX2lucHV0X3N0cmVhbV9yZWFkKHRlc3QtPm1faW5wdXRTdHJlYW0uZ2V0 KCksICZidWZmZXIsIDUxMiwgMCwgJmVycm9yLm91dFB0cigpKSkgeworICAgIHdoaWxlICgocmVh ZEJ5dGVzID0gZ19pbnB1dF9zdHJlYW1fcmVhZCh0ZXN0LT5tX2lucHV0U3RyZWFtLmdldCgpLCAm YnVmZmVyLCA1MTIsIDAsICZlcnJvci5vdXRQdHIoKSkpKSB7CiAgICAgICAgIGdfYXNzZXJ0KCFl cnJvcik7CiAgICAgICAgIHRvdGFsQnl0ZXNGcm9tU3RyZWFtICs9IHJlYWRCeXRlczsKICAgICB9 Cg==