145751 2015-06-08 00:07:02 -0700 REGRESSION(r185251): [GTK] webkit_web_context_set_disk_cache_directory() doesn't work when using shared secondary process model after r185251 2015-06-08 08:59:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression, Soup P2 Normal --- 1 cgarcia webkit-unassigned darin gustavo gyuyoung.kim svillar oldest_to_newest 1100314 0 cgarcia 2015-06-08 00:07:02 -0700 In r185251 the CFNetwork cache was disabled in the web process, but it also removed the disk cache directory web process initialization parameter. While we support networking in the web process when shared secondary process model is used, the network cache should still work. We can remove this if we eventually switch to use the network process unconditionally. 1100315 1 254476 cgarcia 2015-06-08 00:10:37 -0700 Created attachment 254476 Patch 1100371 2 cgarcia 2015-06-08 08:59:51 -0700 Committed r185317: <http://trac.webkit.org/changeset/185317> 254476 2015-06-08 00:10:37 -0700 2015-06-08 06:49:44 -0700 Patch wk2-web-process-disk-cache.diff text/plain 6373 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiY2Q5Njc5Li5iNDk4YzFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTUtMDYtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4NTI1MSk6IFtHVEtdIHdlYmtpdF93ZWJfY29udGV4 dF9zZXRfZGlza19jYWNoZV9kaXJlY3RvcnkoKSBkb2Vzbid0IHdvcmsgd2hlbiB1c2luZyBzaGFy ZWQgc2Vjb25kYXJ5IHByb2Nlc3MgbW9kZWwgYWZ0ZXIgcjE4NTI1MQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NzUxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gcjE4NTI1MSB0aGUgQ0ZOZXR3b3Jr IGNhY2hlIHdhcyBkaXNhYmxlZCBpbiB0aGUgd2ViIHByb2Nlc3MsCisgICAgICAgIGJ1dCBpdCBh bHNvIHJlbW92ZWQgdGhlIGRpc2sgY2FjaGUgZGlyZWN0b3J5IHdlYiBwcm9jZXNzCisgICAgICAg IGluaXRpYWxpemF0aW9uIHBhcmFtZXRlci4gV2hpbGUgd2Ugc3VwcG9ydCBuZXR3b3JraW5nIGlu IHRoZSB3ZWIKKyAgICAgICAgcHJvY2VzcyB3aGVuIHNoYXJlZCBzZWNvbmRhcnkgcHJvY2VzcyBt b2RlbCBpcyB1c2VkLCB0aGUgbmV0d29yaworICAgICAgICBjYWNoZSBzaG91bGQgc3RpbGwgd29y ay4gV2UgY2FuIHJlbW92ZSB0aGlzIGlmIHdlIGV2ZW50dWFsbHkKKyAgICAgICAgc3dpdGNoIHRv IHVzZSB0aGUgbmV0d29yayBwcm9jZXNzIHVuY29uZGl0aW9uYWxseS4KKworICAgICAgICAqIFNo YXJlZC9XZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6ZW5jb2RlKTogRW5jb2RlIGRpc2sgY2FjaGUg ZGlyZWN0b3J5LgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJz OjpkZWNvZGUpOiBEZWNvZGUgZGlzayBjYWNoZSBkaXJlY3RvcnkuCisgICAgICAgICogU2hhcmVk L1dlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaDogQnJpbmcgYmFjayBkaXNrIGNhY2hlIGRp cmVjdG9yeSBvbmx5IGZvciBzb3VwLgorICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2ViUHJvY2Vz c1Bvb2xHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6cGxhdGZvcm1J bml0aWFsaXplV2ViUHJvY2Vzcyk6IEluaXRpYWxpemUgZGlzayBjYWNoZSBkaXJlY3RvcnkgcGFy YW1ldGVyLgorICAgICAgICAqIFdlYlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291cC5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3Mp OiBVc2UgdGhlIGRpc2NrIGNhY2hlIGRpcmVjdG9yeSBwYXJhbWV0ZXIgYWdhaW4uCisKIDIwMTUt MDYtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04ocjE4NTI2Mik6IFtHVEtdIHdlYmtpdF93ZWJfY29udGV4dF9zZXRfZGlz a19jYWNoZV9kaXJlY3RvcnkoKSBkb2Vzbid0IHdvcmsgYWZ0ZXIgcjE4NTI2MgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3Bw IGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3Bw CmluZGV4IGE3Mjc3NzQuLjYyNzBkOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9XZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5jcHAKQEAgLTk2LDYgKzk2LDcgQEAg dm9pZCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOjplbmNvZGUoSVBDOjpBcmd1bWVudEVu Y29kZXImIGVuY29kZXIpIGNvbnN0CiAjZW5kaWYKICAgICBlbmNvZGVyIDw8IHVybFNjaGVtZXNS ZWdpc3RlcmVkRm9yQ3VzdG9tUHJvdG9jb2xzOwogI2lmIFVTRShTT1VQKQorICAgIGVuY29kZXIg PDwgZGlza0NhY2hlRGlyZWN0b3J5OwogICAgIGVuY29kZXIgPDwgY29va2llUGVyc2lzdGVudFN0 b3JhZ2VQYXRoOwogICAgIGVuY29kZXIgPDwgY29va2llUGVyc2lzdGVudFN0b3JhZ2VUeXBlOwog ICAgIGVuY29kZXIuZW5jb2RlRW51bShjb29raWVBY2NlcHRQb2xpY3kpOwpAQCAtMjE3LDYgKzIx OCw4IEBAIGJvb2wgV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6ZGVjb2RlKElQQzo6QXJn dW1lbnREZWNvZGVyJiBkZWNvZGVyLCBXZWJQcm9jCiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShw YXJhbWV0ZXJzLnVybFNjaGVtZXNSZWdpc3RlcmVkRm9yQ3VzdG9tUHJvdG9jb2xzKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogI2lmIFVTRShTT1VQKQorICAgIGlmICghZGVjb2Rlci5kZWNvZGUo cGFyYW1ldGVycy5kaXNrQ2FjaGVEaXJlY3RvcnkpKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgaWYgKCFkZWNvZGVyLmRlY29kZShwYXJhbWV0ZXJzLmNvb2tpZVBlcnNpc3RlbnRTdG9yYWdl UGF0aCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHBh cmFtZXRlcnMuY29va2llUGVyc2lzdGVudFN0b3JhZ2VUeXBlKSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmggYi9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5oCmluZGV4IGIwYzBi MzIuLmU3YjE4YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcm9jZXNz Q3JlYXRpb25QYXJhbWV0ZXJzLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByb2Nl c3NDcmVhdGlvblBhcmFtZXRlcnMuaApAQCAtMTAxLDYgKzEwMSw3IEBAIHN0cnVjdCBXZWJQcm9j ZXNzQ3JlYXRpb25QYXJhbWV0ZXJzIHsKICNlbmRpZgogICAgIFZlY3RvcjxTdHJpbmc+IHVybFNj aGVtZXNSZWdpc3RlcmVkRm9yQ3VzdG9tUHJvdG9jb2xzOwogI2lmIFVTRShTT1VQKQorICAgIFN0 cmluZyBkaXNrQ2FjaGVEaXJlY3Rvcnk7CiAgICAgU3RyaW5nIGNvb2tpZVBlcnNpc3RlbnRTdG9y YWdlUGF0aDsKICAgICB1aW50MzJfdCBjb29raWVQZXJzaXN0ZW50U3RvcmFnZVR5cGU7CiAgICAg SFRUUENvb2tpZUFjY2VwdFBvbGljeSBjb29raWVBY2NlcHRQb2xpY3k7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByb2Nlc3NQb29sR3RrLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViUHJvY2Vzc1Bvb2xHdGsuY3BwCmluZGV4IDM0Mjc4 ODAuLmY0MGMzMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2Vi UHJvY2Vzc1Bvb2xHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2Vi UHJvY2Vzc1Bvb2xHdGsuY3BwCkBAIC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgi CiAjaW5jbHVkZSAiV2ViUHJvY2Vzc1Bvb2wuaCIKIAorI2luY2x1ZGUgIkFQSVByb2Nlc3NQb29s Q29uZmlndXJhdGlvbi5oIgogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlICJXZWJDb29r aWVNYW5hZ2VyUHJveHkuaCIKICNpbmNsdWRlICJXZWJJbnNwZWN0b3JTZXJ2ZXIuaCIKQEAgLTEw NSw2ICsxMDYsNyBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQ cm9jZXNzKFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmCiAgICAgICAgIHBhcmFtZXRlcnMu Y29va2llQWNjZXB0UG9saWN5ID0gbV9pbml0aWFsSFRUUENvb2tpZUFjY2VwdFBvbGljeTsKIAog ICAgICAgICBwYXJhbWV0ZXJzLmlnbm9yZVRMU0Vycm9ycyA9IG1faWdub3JlVExTRXJyb3JzOwor ICAgICAgICBwYXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeSA9IG1fY29uZmlndXJhdGlvbi0+ ZGlza0NhY2hlRGlyZWN0b3J5KCk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1NvdXAuY3BwIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NTb3VwLmNwcAppbmRleCA0NjIxMmRiLi4wN2M5YThm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1Nv dXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291 cC5jcHAKQEAgLTMxLDcgKzMxLDYgQEAKICNpbmNsdWRlICJTZWNjb21wRmlsdGVyc1dlYlByb2Nl c3NFZmwuaCIKICNlbmRpZgogCi0jaW5jbHVkZSAiQVBJUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9u LmgiCiAjaW5jbHVkZSAiQ2VydGlmaWNhdGVJbmZvLmgiCiAjaW5jbHVkZSAiV2ViQ29va2llTWFu YWdlci5oIgogI2luY2x1ZGUgIldlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaCIKQEAgLTEz NiwxNiArMTM1LDIwIEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJv Y2VzcyhXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiYgcGFyCiAgICAgaWYgKHVzZXNOZXR3 b3JrUHJvY2VzcygpKQogICAgICAgICByZXR1cm47CiAKLSAgICBhdXRvIGNvbmZpZ3VyYXRpb24g PSBBUEk6OlByb2Nlc3NQb29sQ29uZmlndXJhdGlvbjo6Y3JlYXRlV2l0aExlZ2FjeU9wdGlvbnMo KTsKLQotICAgIEFTU0VSVCghY29uZmlndXJhdGlvbi0+ZGlza0NhY2hlRGlyZWN0b3J5KCkuaXNF bXB0eSgpKTsKKyAgICBBU1NFUlQoIXBhcmFtZXRlcnMuZGlza0NhY2hlRGlyZWN0b3J5LmlzRW1w dHkoKSk7CiAKICAgICAvLyBXZSB1c2VkIHRvIHVzZSB0aGUgZ2l2ZW4gY2FjaGUgZGlyZWN0b3J5 IGZvciB0aGUgc291cCBjYWNoZSwgYnV0IG5vdyB3ZSB1c2UgYSBzdWJkaXJlY3RvcnkgdG8gYXZv aWQKICAgICAvLyBjb25mbGljdHMgd2l0aCBvdGhlciBjYWNoZSBmaWxlcyBpbiB0aGUgc2FtZSBk aXJlY3RvcnkuIFJlbW92ZSB0aGUgb2xkIGNhY2hlIGZpbGVzIGlmIHRoZXkgc3RpbGwgZXhpc3Qu Ci0gICAgV2ViQ29yZTo6U291cE5ldHdvcmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLmNsZWFy Q2FjaGUoY29uZmlndXJhdGlvbi0+ZGlza0NhY2hlRGlyZWN0b3J5KCkpOworICAgIFdlYkNvcmU6 OlNvdXBOZXR3b3JrU2Vzc2lvbjo6ZGVmYXVsdFNlc3Npb24oKS5jbGVhckNhY2hlKFdlYkNvcmU6 OmRpcmVjdG9yeU5hbWUocGFyYW1ldGVycy5kaXNrQ2FjaGVEaXJlY3RvcnkpKTsKKworI2lmIEVO QUJMRShORVRXT1JLX0NBQ0hFKQorICAgIC8vIFdoZW4gbmV0d29yayBjYWNoZSBpcyBlbmFibGVk LCB0aGUgZGlzayBjYWNoZSBkaXJlY3RvcnkgaXMgdGhlIG5ldHdvcmsgcHJvY2VzcyBvbmUuCisg ICAgQ1N0cmluZyBkaXNrQ2FjaGVQYXRoID0gV2ViQ29yZTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9u ZW50KFdlYkNvcmU6OmRpcmVjdG9yeU5hbWUocGFyYW1ldGVycy5kaXNrQ2FjaGVEaXJlY3Rvcnkp LCAid2Via2l0IikudXRmOCgpOworI2Vsc2UKKyAgICBDU3RyaW5nIGRpc2tDYWNoZVBhdGggPSBw YXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeS51dGY4KCk7CisjZW5kaWYKIAotICAgIFN0cmlu ZyBkaXNrQ2FjaGVQYXRoID0gV2ViQ29yZTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KGNvbmZp Z3VyYXRpb24tPmRpc2tDYWNoZURpcmVjdG9yeSgpLCAid2Via2l0Iik7Ci0gICAgR1JlZlB0cjxT b3VwQ2FjaGU+IHNvdXBDYWNoZSA9IGFkb3B0R1JlZihzb3VwX2NhY2hlX25ldyhkaXNrQ2FjaGVQ YXRoLnV0ZjgoKS5kYXRhKCksIFNPVVBfQ0FDSEVfU0lOR0xFX1VTRVIpKTsKKyAgICBHUmVmUHRy PFNvdXBDYWNoZT4gc291cENhY2hlID0gYWRvcHRHUmVmKHNvdXBfY2FjaGVfbmV3KGRpc2tDYWNo ZVBhdGguZGF0YSgpLCBTT1VQX0NBQ0hFX1NJTkdMRV9VU0VSKSk7CiAgICAgV2ViQ29yZTo6U291 cE5ldHdvcmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLnNldENhY2hlKHNvdXBDYWNoZS5nZXQo KSk7CiAgICAgLy8gU2V0IGFuIGluaXRpYWwgaHVnZSBtYXhfc2l6ZSBmb3IgdGhlIFNvdXBDYWNo ZSBzbyB0aGUgY2FsbCB0byBzb3VwX2NhY2hlX2xvYWQoKSB3b24ndCBldmljdCBhbnkgY2FjaGVk CiAgICAgLy8gcmVzb3VyY2UuIFRoZSBmaW5hbCBzaXplIG9mIHRoZSBjYWNoZSB3aWxsIGJlIHNl dCBieSBOZXR3b3JrUHJvY2Vzczo6cGxhdGZvcm1TZXRDYWNoZU1vZGVsKCkuCg==