145735 2015-06-07 03:45:49 -0700 REGRESSION(r185262): [GTK] webkit_web_context_set_disk_cache_directory() doesn't work after r185262 2015-06-07 23:36:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression, Soup P2 Normal --- 1 cgarcia webkit-unassigned andersca berto commit-queue gustavo gyuyoung.kim koivisto mcatanzaro mrobinson svillar oldest_to_newest 1100172 0 cgarcia 2015-06-07 03:45:49 -0700 We need way to change the web process pool configuration, and also move to the UI process the disk cache subdirectory handling. This is an API break, because webkit_web_context_set_disk_cache_directory() does nothing now. 1100173 1 254435 cgarcia 2015-06-07 03:51:44 -0700 Created attachment 254435 Patch The shared secondary process model is still broken, but because of r185251. 1100174 2 commit-queue 2015-06-07 03:52:38 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1100310 3 cgarcia 2015-06-07 23:36:08 -0700 Committed r185311: <http://trac.webkit.org/changeset/185311> 254435 2015-06-07 03:51:44 -0700 2015-06-07 17:47:10 -0700 Patch wk2-disk-cache-directory.diff text/plain 7394 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzNDlhODgwLi44MDExMmQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTUtMDYtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4NTI2Mik6IFtHVEtdIHdlYmtpdF93ZWJfY29udGV4 dF9zZXRfZGlza19jYWNoZV9kaXJlY3RvcnkoKSBkb2Vzbid0IHdvcmsgYWZ0ZXIgcjE4NTI2Mgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NzM1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3Jr UHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5l dHdvcmtQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVOZXR3b3JrUHJvY2Vzcyk6IFVzZQorICAg ICAgICB0aGUgZGlyZWN0b3J5IG5hbWUgdG8gY2xlYXIgdGhlIG9sZCBjYWNoZSwgc2luY2UgdGhl IGRpc2sgY2FjaGUKKyAgICAgICAgc3ViZGlyZWN0b3J5IGlzIG5vdyBhZGRlZCBpbiB0aGUgVUkg cHJvY2Vzcy4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNw cDoKKyAgICAgICAgKHdlYmtpdF93ZWJfY29udGV4dF9zZXRfZGlza19jYWNoZV9kaXJlY3Rvcnkp OiBVcGRhdGUgdGhlCisgICAgICAgIFdlYlByb2Nlc3NQb29sIGNvbmZpZ3VyYXRpb24gdG8gb3Zl cnJpZGUgdGhlIGRpc2sgY2FjaGUgZGlyZWN0b3J5LgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQ cm9jZXNzUG9vbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjplbnN1cmVO ZXR3b3JrUHJvY2Vzcyk6IFVzZSB0aGUKKyAgICAgICAgY29uZmlndXJhdGlvbiB0byBnZXQgdGhl IGRpc2sgY2FjaGUgZGlyZWN0b3J5LgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6 V2ViUHJvY2Vzc1Bvb2wpOiBSZW1vdmUKKyAgICAgICAgbV9kaXNrQ2FjaGVEaXJlY3RvcnkgbWVt YmVyIGluaXRpYWxpemF0aW9uLgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5o OiBSZW1vdmUgbV9kaXNrQ2FjaGVEaXJlY3RvcnkgbWVtYmVyLgorICAgICAgICAqIFVJUHJvY2Vz cy9ndGsvV2ViUHJvY2Vzc1Bvb2xHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNz UG9vbDo6bGVnYWN5UGxhdGZvcm1EZWZhdWx0TmV0d29ya0NhY2hlRGlyZWN0b3J5KToKKyAgICAg ICAgQXBwZW5kIHRoZSBkaXNrIGNhY2hlIHN1YmRpcmVjdG9yeS4KKwogMjAxNS0wNi0wNyAgR3l1 eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF1bR1RL XSBGaXggYnVpbGQgIGJyZWFrIHNpbmNlIHIxODUyNjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcAppbmRleCAy NDVlOTUxLi5iYTUxODgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz cy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwCkBAIC03MiwxNiArNzIsMTUgQEAg dm9pZCBOZXR3b3JrUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplTmV0d29ya1Byb2Nlc3MoY29u c3QgTmV0d29ya1Byb2Nlc3NDcmVhdGkKIAogI2lmIEVOQUJMRShORVRXT1JLX0NBQ0hFKQogICAg IC8vIENsZWFyIHRoZSBvbGQgc291cCBjYWNoZSBpZiBpdCBleGlzdHMuCi0gICAgU291cE5ldHdv cmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLmNsZWFyQ2FjaGUobV9kaXNrQ2FjaGVEaXJlY3Rv cnkpOworICAgIFNvdXBOZXR3b3JrU2Vzc2lvbjo6ZGVmYXVsdFNlc3Npb24oKS5jbGVhckNhY2hl KFdlYkNvcmU6OmRpcmVjdG9yeU5hbWUobV9kaXNrQ2FjaGVEaXJlY3RvcnkpKTsKIAogICAgIE5l dHdvcmtDYWNoZTo6c2luZ2xldG9uKCkuaW5pdGlhbGl6ZShtX2Rpc2tDYWNoZURpcmVjdG9yeSwg cGFyYW1ldGVycy5zaG91bGRFbmFibGVOZXR3b3JrQ2FjaGVFZmZpY2FjeUxvZ2dpbmcpOwogI2Vs c2UKICAgICAvLyBXZSB1c2VkIHRvIHVzZSB0aGUgZ2l2ZW4gY2FjaGUgZGlyZWN0b3J5IGZvciB0 aGUgc291cCBjYWNoZSwgYnV0IG5vdyB3ZSB1c2UgYSBzdWJkaXJlY3RvcnkgdG8gYXZvaWQKICAg ICAvLyBjb25mbGljdHMgd2l0aCBvdGhlciBjYWNoZSBmaWxlcyBpbiB0aGUgc2FtZSBkaXJlY3Rv cnkuIFJlbW92ZSB0aGUgb2xkIGNhY2hlIGZpbGVzIGlmIHRoZXkgc3RpbGwgZXhpc3QuCi0gICAg U291cE5ldHdvcmtTZXNzaW9uOjpkZWZhdWx0U2Vzc2lvbigpLmNsZWFyQ2FjaGUocGFyYW1ldGVy cy5kaXNrQ2FjaGVEaXJlY3RvcnkpOworICAgIFNvdXBOZXR3b3JrU2Vzc2lvbjo6ZGVmYXVsdFNl c3Npb24oKS5jbGVhckNhY2hlKFdlYkNvcmU6OmRpcmVjdG9yeU5hbWUobV9kaXNrQ2FjaGVEaXJl Y3RvcnkpKTsKIAotICAgIFN0cmluZyBkaXNrQ2FjaGVQYXRoID0gV2ViQ29yZTo6cGF0aEJ5QXBw ZW5kaW5nQ29tcG9uZW50KHBhcmFtZXRlcnMuZGlza0NhY2hlRGlyZWN0b3J5LCAid2Via2l0Iik7 Ci0gICAgR1JlZlB0cjxTb3VwQ2FjaGU+IHNvdXBDYWNoZSA9IGFkb3B0R1JlZihzb3VwX2NhY2hl X25ldyhkaXNrQ2FjaGVQYXRoLnV0ZjgoKS5kYXRhKCksIFNPVVBfQ0FDSEVfU0lOR0xFX1VTRVIp KTsKKyAgICBHUmVmUHRyPFNvdXBDYWNoZT4gc291cENhY2hlID0gYWRvcHRHUmVmKHNvdXBfY2Fj aGVfbmV3KG1fZGlza0NhY2hlRGlyZWN0b3J5LnV0ZjgoKS5kYXRhKCksIFNPVVBfQ0FDSEVfU0lO R0xFX1VTRVIpKTsKICAgICBTb3VwTmV0d29ya1Nlc3Npb246OmRlZmF1bHRTZXNzaW9uKCkuc2V0 Q2FjaGUoc291cENhY2hlLmdldCgpKTsKICAgICAvLyBTZXQgYW4gaW5pdGlhbCBodWdlIG1heF9z aXplIGZvciB0aGUgU291cENhY2hlIHNvIHRoZSBjYWxsIHRvIHNvdXBfY2FjaGVfbG9hZCgpIHdv bid0IGV2aWN0IGFueSBjYWNoZWQKICAgICAvLyByZXNvdXJjZS4gVGhlIGZpbmFsIHNpemUgb2Yg dGhlIGNhY2hlIHdpbGwgYmUgc2V0IGJ5IE5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybVNldENhY2hl TW9kZWwoKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFdlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0V2ViQ29udGV4dC5jcHAKaW5kZXggOGU3OTQ5MS4uMjZhNTkwNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHAKQEAg LTEwMjUsMTIgKzEwMjUsMTcgQEAgdm9pZCB3ZWJraXRfd2ViX2NvbnRleHRfc2V0X3dlYl9leHRl bnNpb25zX2luaXRpYWxpemF0aW9uX3VzZXJfZGF0YShXZWJLaXRXZWJDb24KICAqIFRoaXMgbWV0 aG9kIG11c3QgYmUgY2FsbGVkIGJlZm9yZSBsb2FkaW5nIGFueXRoaW5nIGluIHRoaXMgY29udGV4 dCwgb3RoZXJ3aXNlCiAgKiBpdCB3aWxsIG5vdCBoYXZlIGFueSBlZmZlY3QuCiAgKi8KLXZvaWQg d2Via2l0X3dlYl9jb250ZXh0X3NldF9kaXNrX2NhY2hlX2RpcmVjdG9yeShXZWJLaXRXZWJDb250 ZXh0KiwgY29uc3QgY2hhciogZGlyZWN0b3J5KQordm9pZCB3ZWJraXRfd2ViX2NvbnRleHRfc2V0 X2Rpc2tfY2FjaGVfZGlyZWN0b3J5KFdlYktpdFdlYkNvbnRleHQqIGNvbnRleHQsIGNvbnN0IGNo YXIqIGRpcmVjdG9yeSkKIHsKKyAgICBnX3JldHVybl9pZl9mYWlsKFdFQktJVF9JU19XRUJfQ09O VEVYVChjb250ZXh0KSk7CiAgICAgZ19yZXR1cm5faWZfZmFpbChkaXJlY3RvcnkpOwogCi0gICAg YXV0byBjb25maWd1cmF0aW9uID0gQVBJOjpQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb246OmNyZWF0 ZVdpdGhMZWdhY3lPcHRpb25zKCk7Ci0gICAgY29uZmlndXJhdGlvbi0+c2V0RGlza0NhY2hlRGly ZWN0b3J5KFdlYkNvcmU6OmZpbGVuYW1lVG9TdHJpbmcoZGlyZWN0b3J5KSk7CisjaWYgRU5BQkxF KE5FVFdPUktfQ0FDSEUpCisgICAgc3RhdGljIGNvbnN0IGNoYXIgbmV0d29ya0NhY2hlU3ViZGly ZWN0b3J5W10gPSAiV2ViS2l0Q2FjaGUiOworI2Vsc2UKKyAgICBzdGF0aWMgY29uc3QgY2hhciBu ZXR3b3JrQ2FjaGVTdWJkaXJlY3RvcnlbXSA9ICJ3ZWJraXQiOworI2VuZGlmCisgICAgY29udGV4 dC0+cHJpdi0+Y29udGV4dC0+Y29uZmlndXJhdGlvbigpLnNldERpc2tDYWNoZURpcmVjdG9yeShX ZWJDb3JlOjpwYXRoQnlBcHBlbmRpbmdDb21wb25lbnQoV2ViQ29yZTo6ZmlsZW5hbWVUb1N0cmlu ZyhkaXJlY3RvcnkpLCBuZXR3b3JrQ2FjaGVTdWJkaXJlY3RvcnkpKTsKIH0KIAogLyoqCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcAppbmRleCBmNjk1YmY3Li5i YjUzYWE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bv b2wuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAK QEAgLTE2Nyw3ICsxNjcsNiBAQCBXZWJQcm9jZXNzUG9vbDo6V2ViUHJvY2Vzc1Bvb2woQVBJOjpQ cm9jZXNzUG9vbENvbmZpZ3VyYXRpb24mIGNvbmZpZ3VyYXRpb24pCiAgICAgLCBtX2luaXRpYWxI VFRQQ29va2llQWNjZXB0UG9saWN5KEhUVFBDb29raWVBY2NlcHRQb2xpY3lPbmx5RnJvbU1haW5E b2N1bWVudERvbWFpbikKICNlbmRpZgogICAgICwgbV9hcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5 KGNvbmZpZ3VyYXRpb24uYXBwbGljYXRpb25DYWNoZURpcmVjdG9yeSgpKQotICAgICwgbV9kaXNr Q2FjaGVEaXJlY3RvcnkoY29uZmlndXJhdGlvbi5kaXNrQ2FjaGVEaXJlY3RvcnkoKSkKICAgICAs IG1faW5kZXhlZERCRGF0YWJhc2VEaXJlY3RvcnkoY29uZmlndXJhdGlvbi5pbmRleGVkREJEYXRh YmFzZURpcmVjdG9yeSgpKQogICAgICwgbV9tZWRpYUtleXNTdG9yYWdlRGlyZWN0b3J5KGNvbmZp Z3VyYXRpb24ubWVkaWFLZXlzU3RvcmFnZURpcmVjdG9yeSgpKQogICAgICwgbV93ZWJTUUxEYXRh YmFzZURpcmVjdG9yeShjb25maWd1cmF0aW9uLndlYlNRTERhdGFiYXNlRGlyZWN0b3J5KCkpCkBA IC00MTgsNyArNDE3LDcgQEAgTmV0d29ya1Byb2Nlc3NQcm94eSYgV2ViUHJvY2Vzc1Bvb2w6OmVu c3VyZU5ldHdvcmtQcm9jZXNzKCkKICAgICBwYXJhbWV0ZXJzLmRpc2tDYWNoZVNpemVPdmVycmlk ZSA9IG1fZGlza0NhY2hlU2l6ZU92ZXJyaWRlOwogICAgIHBhcmFtZXRlcnMuY2FuSGFuZGxlSFRU UFNTZXJ2ZXJUcnVzdEV2YWx1YXRpb24gPSBtX2NhbkhhbmRsZUhUVFBTU2VydmVyVHJ1c3RFdmFs dWF0aW9uOwogCi0gICAgcGFyYW1ldGVycy5kaXNrQ2FjaGVEaXJlY3RvcnkgPSBtX2Rpc2tDYWNo ZURpcmVjdG9yeTsKKyAgICBwYXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeSA9IG1fY29uZmln dXJhdGlvbi0+ZGlza0NhY2hlRGlyZWN0b3J5KCk7CiAgICAgaWYgKCFwYXJhbWV0ZXJzLmRpc2tD YWNoZURpcmVjdG9yeS5pc0VtcHR5KCkpCiAgICAgICAgIFNhbmRib3hFeHRlbnNpb246OmNyZWF0 ZUhhbmRsZUZvclJlYWRXcml0ZURpcmVjdG9yeShwYXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9y eSwgcGFyYW1ldGVycy5kaXNrQ2FjaGVEaXJlY3RvcnlFeHRlbnNpb25IYW5kbGUpOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuaCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5oCmluZGV4IGZmYTQzOWIuLjI1ZGM5 M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5o CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5oCkBAIC01MDYs NyArNTA2LDYgQEAgcHJpdmF0ZToKICAgICBTdHJpbmcgbV9vdmVycmlkZUNvb2tpZVN0b3JhZ2VE aXJlY3Rvcnk7CiAKICAgICBTdHJpbmcgbV9hcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5OwotICAg IFN0cmluZyBtX2Rpc2tDYWNoZURpcmVjdG9yeTsKICAgICBTdHJpbmcgbV9pbmRleGVkREJEYXRh YmFzZURpcmVjdG9yeTsKICAgICBTdHJpbmcgbV9tZWRpYUtleXNTdG9yYWdlRGlyZWN0b3J5Owog ICAgIFN0cmluZyBtX3dlYlNRTERhdGFiYXNlRGlyZWN0b3J5OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJQcm9jZXNzUG9vbEd0ay5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByb2Nlc3NQb29sR3RrLmNwcAppbmRleCAxNGEzYTVjLi4z NDI3ODgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByb2Nl c3NQb29sR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByb2Nl c3NQb29sR3RrLmNwcApAQCAtMTQ0LDcgKzE0NCwxMiBAQCBTdHJpbmcgV2ViUHJvY2Vzc1Bvb2w6 OmxlZ2FjeVBsYXRmb3JtRGVmYXVsdE1lZGlhS2V5c1N0b3JhZ2VEaXJlY3RvcnkoKQogCiBTdHJp bmcgV2ViUHJvY2Vzc1Bvb2w6OmxlZ2FjeVBsYXRmb3JtRGVmYXVsdE5ldHdvcmtDYWNoZURpcmVj dG9yeSgpCiB7Ci0gICAgR1VuaXF1ZVB0cjxjaGFyPiBkaXNrQ2FjaGVEaXJlY3RvcnkoZ19idWls ZF9maWxlbmFtZShnX2dldF91c2VyX2NhY2hlX2RpcigpLCBnX2dldF9wcmduYW1lKCksIG51bGxw dHIpKTsKKyNpZiBFTkFCTEUoTkVUV09SS19DQUNIRSkKKyAgICBzdGF0aWMgY29uc3QgY2hhciBu ZXR3b3JrQ2FjaGVTdWJkaXJlY3RvcnlbXSA9ICJXZWJLaXRDYWNoZSI7CisjZWxzZQorICAgIHN0 YXRpYyBjb25zdCBjaGFyIG5ldHdvcmtDYWNoZVN1YmRpcmVjdG9yeVtdID0gIndlYmtpdCI7Cisj ZW5kaWYKKyAgICBHVW5pcXVlUHRyPGNoYXI+IGRpc2tDYWNoZURpcmVjdG9yeShnX2J1aWxkX2Zp bGVuYW1lKGdfZ2V0X3VzZXJfY2FjaGVfZGlyKCksIGdfZ2V0X3ByZ25hbWUoKSwgbmV0d29ya0Nh Y2hlU3ViZGlyZWN0b3J5LCBudWxscHRyKSk7CiAgICAgcmV0dXJuIFdlYkNvcmU6OmZpbGVuYW1l VG9TdHJpbmcoZGlza0NhY2hlRGlyZWN0b3J5LmdldCgpKTsKIH0KIAo=