145725 2015-06-06 02:21:04 -0700 [EFL] Execute Javascript method in mini browser address bar 2015-06-10 00:30:12 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyungwook.lee hyungwook.lee commit-queue lucas.de.marchi oldest_to_newest 1100082 0 hyungwook.lee 2015-06-06 02:21:04 -0700 Many browser able to execute JavaScript method from browser address bar as below. javascript:{alert("ok");} We also need to support this functionality for same user experience what they expected in address bar. 1100167 1 254433 hyungwook.lee 2015-06-07 00:56:01 -0700 Created attachment 254433 Patch 1100271 2 254433 darin 2015-06-07 17:48:09 -0700 Comment on attachment 254433 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254433&action=review > Source/WebKit2/ChangeLog:9 > + Many browser able to execute JavaScript contents in browser address bar using 'javascript:' scheme. > + WebKit EFL port also need to support this functionality for same user experience. Interesting choice. Safari choses to not include this feature by default, and only enables it for developers who turn it on, to improve security for typical web browser users who have no need to do this, and could be tricked into doing it by social engineering. 1100294 3 254433 hyungwook.lee 2015-06-07 20:26:40 -0700 Comment on attachment 254433 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254433&action=review >> Source/WebKit2/ChangeLog:9 >> + WebKit EFL port also need to support this functionality for same user experience. > > Interesting choice. > > Safari choses to not include this feature by default, and only enables it for developers who turn it on, to improve security for typical web browser users who have no need to do this, and could be tricked into doing it by social engineering. In my investigation, Chrome, Firefox, Opera, Internet Explorer supports this functionality in default. I also agreed with your opinion. How about turn it on only WebKit EFL mini browser as same as WebKit GTK Port? 1100558 4 254433 ryuan.choi 2015-06-08 19:35:50 -0700 Comment on attachment 254433 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254433&action=review >>> Source/WebKit2/ChangeLog:9 >>> + WebKit EFL port also need to support this functionality for same user experience. >> >> Interesting choice. >> >> Safari choses to not include this feature by default, and only enables it for developers who turn it on, to improve security for typical web browser users who have no need to do this, and could be tricked into doing it by social engineering. > > In my investigation, Chrome, Firefox, Opera, Internet Explorer supports this functionality in default. > I also agreed with your opinion. > How about turn it on only WebKit EFL mini browser as same as WebKit GTK Port? Sorry about late answer. But, I think that it looks not good. We should not assume whether the browser want javascript scheme or not, so we should consider both use cases. With your patch, browser can't disable javascript scheme. 1100587 5 254433 hyungwook.lee 2015-06-09 00:09:38 -0700 Comment on attachment 254433 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254433&action=review >>>> Source/WebKit2/ChangeLog:9 >>>> + WebKit EFL port also need to support this functionality for same user experience. >>> >>> Interesting choice. >>> >>> Safari choses to not include this feature by default, and only enables it for developers who turn it on, to improve security for typical web browser users who have no need to do this, and could be tricked into doing it by social engineering. >> >> In my investigation, Chrome, Firefox, Opera, Internet Explorer supports this functionality in default. >> I also agreed with your opinion. >> How about turn it on only WebKit EFL mini browser as same as WebKit GTK Port? > > Sorry about late answer. > > But, I think that it looks not good. > We should not assume whether the browser want javascript scheme or not, so we should consider both use cases. > With your patch, browser can't disable javascript scheme. I will re-implement this only for efl mini browser. 1100640 6 254563 hyungwook.lee 2015-06-09 06:32:22 -0700 Created attachment 254563 Patch 1100884 7 254563 gyuyoung.kim 2015-06-09 17:56:38 -0700 Comment on attachment 254563 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254563&action=review > Tools/MiniBrowser/efl/main.c:1064 > +load_url_from_user_input(Evas_Object* ewk_view, const char* url) - Wrong * place. - url_load_from_user_input() looks more like efl function name style. 1100888 8 254563 hyungwook.lee 2015-06-09 18:20:05 -0700 Comment on attachment 254563 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254563&action=review >> Tools/MiniBrowser/efl/main.c:1064 >> +load_url_from_user_input(Evas_Object* ewk_view, const char* url) > > - Wrong * place. > > - url_load_from_user_input() looks more like efl function name style. I referenced url_from_user_input() looks simulator function name in this case. Could you suggest new one for me? 1100903 9 254563 gyuyoung.kim 2015-06-09 20:18:36 -0700 Comment on attachment 254563 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254563&action=review >>> Tools/MiniBrowser/efl/main.c:1064 >>> +load_url_from_user_input(Evas_Object* ewk_view, const char* url) >> >> - Wrong * place. >> >> - url_load_from_user_input() looks more like efl function name style. > > I referenced url_from_user_input() looks simulator function name in this case. > Could you suggest new one for me? > - url_load_from_user_input() looks more like efl function name style. I already did ;) 1100906 10 254623 hyungwook.lee 2015-06-09 20:39:06 -0700 Created attachment 254623 Patch 1100926 11 254623 gyuyoung.kim 2015-06-09 23:14:47 -0700 Comment on attachment 254623 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254623&action=review > Tools/MiniBrowser/efl/main.c:1064 > +url_load_from_user_input(Evas_Object* ewk_view, const char* url) Though I pointed out, it is not fixed yet. Wrong * place. 1100929 12 254630 hyungwook.lee 2015-06-09 23:31:08 -0700 Created attachment 254630 Patch 1100934 13 254630 commit-queue 2015-06-10 00:30:09 -0700 Comment on attachment 254630 Patch Clearing flags on attachment: 254630 Committed r185405: <http://trac.webkit.org/changeset/185405> 1100935 14 commit-queue 2015-06-10 00:30:12 -0700 All reviewed patches have been landed. Closing bug. 254433 2015-06-07 00:56:01 -0700 2015-06-09 06:32:15 -0700 Patch bug-145725-20150607165536.patch text/plain 4094 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTI5OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA2LTA3ICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIEV4 ZWN1dGUgSmF2YXNjcmlwdCBtZXRob2QgZnJvbSBicm93c2VyIGFkZHJlc3MgYmFyLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NzI1LgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hbnkgYnJvd3NlciBh YmxlIHRvIGV4ZWN1dGUgSmF2YVNjcmlwdCBjb250ZW50cyBpbiBicm93c2VyIGFkZHJlc3MgYmFy IHVzaW5nICdqYXZhc2NyaXB0Oicgc2NoZW1lLgorICAgICAgICBXZWJLaXQgRUZMIHBvcnQgYWxz byBuZWVkIHRvIHN1cHBvcnQgdGhpcyBmdW5jdGlvbmFsaXR5IGZvciBzYW1lIHVzZXIgZXhwZXJp ZW5jZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAg ICAgKHRvRXdrVmlld0NoZWNrZWQpOgorICAgICAgICAoZXdrX3ZpZXdfdXJsX3NldCk6CisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwOgorICAgICAg ICAoVEVTVF9GKToKKwogMjAxNS0wNi0wNiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29t PgogCiAgICAgICAgIERvbuKAmXQgZW5hYmxlIG1hbnVhbCBzYW5kYm94aW5nIGluIHRoZSBpT1Mg U2ltdWxhdG9yLiBUaGlzIHNob3VsZCBmaXggYWxsIHRoZSB0ZXN0cyB0aW1pbmcgb3V0LgpJbmRl eDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAkocmV2 aXNpb24gMTg1MjQ1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3Zp ZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OSw2ICs0OSw4IEBACiAKIHVzaW5nIG5hbWVzcGFj ZSBXZWJLaXQ7CiAKK3N0YXRpYyBjb25zdCBjaGFyIGphdmFzY3JpcHRQcmVmaXhbXSA9ICJqYXZh c2NyaXB0OiI7CisKIHN0YXRpYyBpbmxpbmUgRXdrVmlldyogdG9Fd2tWaWV3Q2hlY2tlZChjb25z dCBFdmFzX09iamVjdCogZXZhc09iamVjdCkKIHsKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JF VFVSTl9WQUwoZXZhc09iamVjdCwgbnVsbHB0cik7CkBAIC0xNDUsNiArMTQ3LDkgQEAgRWluYV9C b29sIGV3a192aWV3X3VybF9zZXQoRXZhc19PYmplY3QqCiAgICAgRVdLX1ZJRVdfSU1QTF9HRVRf T1JfUkVUVVJOKGV3a1ZpZXcsIGltcGwsIGZhbHNlKTsKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxM X1JFVFVSTl9WQUwodXJsLCBmYWxzZSk7CiAKKyAgICBpZiAoZWluYV9zdHJfaGFzX3ByZWZpeCh1 cmwsIGphdmFzY3JpcHRQcmVmaXgpKQorICAgICAgICByZXR1cm4gZXdrX3ZpZXdfc2NyaXB0X2V4 ZWN1dGUoZXdrVmlldywgc3Ryc3RyKHVybCwgamF2YXNjcmlwdFByZWZpeCksIG51bGxwdHIsIG51 bGxwdHIpOworCiAgICAgV0tSZXRhaW5QdHI8V0tVUkxSZWY+IHdrVXJsID0gYWRvcHRXSyhXS1VS TENyZWF0ZVdpdGhVVEY4Q1N0cmluZyh1cmwpKTsKICAgICBXS1BhZ2VMb2FkVVJMKGltcGwtPndr UGFnZSgpLCB3a1VybC5nZXQoKSk7CiAgICAgaW1wbC0+aW5mb3JtVVJMQ2hhbmdlKCk7CkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMv dGVzdF9ld2syX3ZpZXcuY3BwCShyZXZpc2lvbiAxODUyNDUpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTI2NSw2ICsyNjUsMTMgQEAgVEVTVF9GKEVXSzJWaWV3VGVzdCwgZXdrX3ZpZXdfYWRkKQog ICAgIGV2YXNfb2JqZWN0X2RlbCh2aWV3KTsKIH0KIAorVEVTVF9GKEVXSzJWaWV3VGVzdCwgZXdr X3ZpZXdfdXJsX3NldCkKK3sKKyAgICBld2tfdmlld191cmxfc2V0KHdlYlZpZXcoKSwgImphdmFz Y3JpcHQ6eyBkb2N1bWVudC50aXRsZSA9ICdIZWxsbycgfSIpOworICAgIEVYUEVDVF9UUlVFKHdh aXRVbnRpbFRpdGxlQ2hhbmdlZFRvKCJIZWxsbyIpKTsKKyAgICBFWFBFQ1RfU1RSRVEoIkhlbGxv IiwgZXdrX3ZpZXdfdGl0bGVfZ2V0KHdlYlZpZXcoKSkpOworfQorCiBURVNUX0YoRVdLMlZpZXdU ZXN0LCBld2tfdmlld191cmxfZ2V0KQogewogICAgIEFTU0VSVF9UUlVFKGxvYWRVcmxTeW5jKGVu dmlyb25tZW50LT5kZWZhdWx0VGVzdFBhZ2VVcmwoKSkpOwpJbmRleDogVG9vbHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1Mjk5KQorKysgVG9v bHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMDYtMDcg IEh5dW5nd29vayBMZWUgIDxoeXVuZ3dvb2subGVlQG5hdmVyY29ycC5jb20+CisKKyAgICAgICAg W0VGTF0gRXhlY3V0ZSBKYXZhc2NyaXB0IG1ldGhvZCBmcm9tIGJyb3dzZXIgYWRkcmVzcyBiYXIu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU3MjUu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFueSBi cm93c2VyIGFibGUgdG8gZXhlY3V0ZSBKYXZhU2NyaXB0IGNvbnRlbnRzIGluIGJyb3dzZXIgYWRk cmVzcyBiYXIgdXNpbmcgJ2phdmFzY3JpcHQ6JyBzY2hlbWUuCisgICAgICAgIFdlYktpdCBFRkwg cG9ydCBhbHNvIG5lZWQgdG8gc3VwcG9ydCB0aGlzIGZ1bmN0aW9uYWxpdHkgZm9yIHNhbWUgdXNl ciBleHBlcmllbmNlLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAg ICAgKHVybF9mcm9tX3VzZXJfaW5wdXQpOgorCiAyMDE1LTA2LTA1ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgRnJvbSByMTg1MjczIG9uIFdURjo6UmVmQ291bnRl ciBleHBvc2VzIHRoZSBhY3R1YWwgcmVmY291bnQgaW5zdGVhZCBvZiBhIGJvb2xlYW4gdmFsdWUu CkluZGV4OiBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L01pbmlCcm93c2VyL2VmbC9tYWluLmMJKHJldmlzaW9uIDE4NTI0NSkKKysrIFRvb2xzL01pbmlC cm93c2VyL2VmbC9tYWluLmMJKHdvcmtpbmcgY29weSkKQEAgLTEwMzgsNyArMTAzOCw3IEBAIHN0 YXRpYyBjaGFyICoKIHVybF9mcm9tX3VzZXJfaW5wdXQoY29uc3QgY2hhciAqYXJnKQogewogICAg IC8qIElmIGl0IGlzIGFscmVhZHkgYSBVUkwsIHJldHVybiB0aGUgYXJndW1lbnQgYXMgaXMuICov Ci0gICAgaWYgKGhhc19zY2hlbWUoYXJnKSB8fCAhc3RyY2FzZWNtcChhcmcsICJhYm91dDpibGFu ayIpKQorICAgIGlmIChoYXNfc2NoZW1lKGFyZykgfHwgZWluYV9zdHJfaGFzX3ByZWZpeChhcmcs ICJqYXZhc2NyaXB0OiIpIHx8ICFzdHJjYXNlY21wKGFyZywgImFib3V0OmJsYW5rIikpCiAgICAg ICAgIHJldHVybiBzdHJkdXAoYXJnKTsKIAogICAgIEVpbmFfU3RyYnVmICpidWYgPSBlaW5hX3N0 cmJ1Zl9tYW5hZ2VfbmV3KGVpbmFfZmlsZV9wYXRoX3Nhbml0aXplKGFyZykpOwo= 254563 2015-06-09 06:32:22 -0700 2015-06-09 20:39:00 -0700 Patch bug-145725-20150609223155.patch text/plain 2573 hyungwook.lee SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTM2MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE1LTA2LTA5ICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZl cmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIEV4ZWN1dGUgSmF2YXNjcmlwdCBtZXRob2QgaW4g bWluaSBicm93c2VyIGFkZHJlc3MgYmFyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NzI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU3VwcG9ydCAnamF2YXNjcmlwdDonIHNjaGVtZSBpbiBXZWJLaXQg RUZMIE1pbmkgQnJvd3Nlci4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6Cisg ICAgICAgICh1cmxfZnJvbV91c2VyX2lucHV0KToKKyAgICAgICAgKGxvYWRfdXJsX2Zyb21fdXNl cl9pbnB1dCk6CisgICAgICAgIChvbl91cmxfYmFyX2FjdGl2YXRlZCk6CisgICAgICAgIChlbG1f bWFpbik6CisKIDIwMTUtMDYtMDkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJlbW92ZSBld3N0b29sIHNjcmlwdHMgdXNlZCBieSBjaHJvbWl1bSBw b3J0CkluZGV4OiBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMJKHJldmlzaW9uIDE4NTM1NSkKKysrIFRvb2xzL01p bmlCcm93c2VyL2VmbC9tYWluLmMJKHdvcmtpbmcgY29weSkKQEAgLTEwMzgsNyArMTAzOCw3IEBA IHN0YXRpYyBjaGFyICoKIHVybF9mcm9tX3VzZXJfaW5wdXQoY29uc3QgY2hhciAqYXJnKQogewog ICAgIC8qIElmIGl0IGlzIGFscmVhZHkgYSBVUkwsIHJldHVybiB0aGUgYXJndW1lbnQgYXMgaXMu ICovCi0gICAgaWYgKGhhc19zY2hlbWUoYXJnKSB8fCAhc3RyY2FzZWNtcChhcmcsICJhYm91dDpi bGFuayIpKQorICAgIGlmIChoYXNfc2NoZW1lKGFyZykgfHwgZWluYV9zdHJfaGFzX3ByZWZpeChh cmcsICJqYXZhc2NyaXB0OiIpIHx8ICFzdHJjYXNlY21wKGFyZywgImFib3V0OmJsYW5rIikpCiAg ICAgICAgIHJldHVybiBzdHJkdXAoYXJnKTsKIAogICAgIEVpbmFfU3RyYnVmICpidWYgPSBlaW5h X3N0cmJ1Zl9tYW5hZ2VfbmV3KGVpbmFfZmlsZV9wYXRoX3Nhbml0aXplKGFyZykpOwpAQCAtMTA2 MCw2ICsxMDYwLDE4IEBAIHVybF9mcm9tX3VzZXJfaW5wdXQoY29uc3QgY2hhciAqYXJnKQogICAg IHJldHVybiB1cmw7CiB9CiAKK3N0YXRpYyBFaW5hX0Jvb2wKK2xvYWRfdXJsX2Zyb21fdXNlcl9p bnB1dChFdmFzX09iamVjdCogZXdrX3ZpZXcsIGNvbnN0IGNoYXIqIHVybCkKK3sKKyAgICBpZiAo IWV3a192aWV3IHx8ICF1cmwpCisgICAgICAgIHJldHVybiBFSU5BX0ZBTFNFOworCisgICAgaWYg KGVpbmFfc3RyX2hhc19wcmVmaXgodXJsLCAiamF2YXNjcmlwdDoiKSkKKyAgICAgICAgcmV0dXJu IGV3a192aWV3X3NjcmlwdF9leGVjdXRlKGV3a192aWV3LCBzdHJzdHIodXJsLCAiamF2YXNjcmlw dDoiKSwgMCwgMCk7CisKKyAgICByZXR1cm4gZXdrX3ZpZXdfdXJsX3NldChld2tfdmlldywgdXJs KTsKK30KKwogc3RhdGljIHZvaWQKIG9uX3VybF9iYXJfYWN0aXZhdGVkKHZvaWQgKnVzZXJfZGF0 YSwgRXZhc19PYmplY3QgKnVybF9iYXIsIHZvaWQgKmV2ZW50X2luZm8pCiB7CkBAIC0xMDY4LDcg KzEwODAsNyBAQCBvbl91cmxfYmFyX2FjdGl2YXRlZCh2b2lkICp1c2VyX2RhdGEsIEV2CiAgICAg Y29uc3QgY2hhciAqbWFya3VwX3VybCA9IGVsbV9lbnRyeV9lbnRyeV9nZXQodXJsX2Jhcik7CiAg ICAgY2hhciAqdXNlcl91cmwgPSBlbG1fZW50cnlfbWFya3VwX3RvX3V0ZjgobWFya3VwX3VybCk7 CiAgICAgY2hhciAqdXJsID0gdXJsX2Zyb21fdXNlcl9pbnB1dCh1c2VyX3VybCk7Ci0gICAgZXdr X3ZpZXdfdXJsX3NldCh3aW5kb3ctPmV3a192aWV3LCB1cmwpOworICAgIGxvYWRfdXJsX2Zyb21f dXNlcl9pbnB1dCh3aW5kb3ctPmV3a192aWV3LCB1cmwpOwogCiAgICAgZnJlZSh1c2VyX3VybCk7 CiAgICAgZnJlZSh1cmwpOwpAQCAtMjQ2MSw3ICsyNDczLDcgQEAgZWxtX21haW4oaW50IGFyZ2Ms IGNoYXIgKmFyZ3ZbXSkKIAogICAgIGlmIChhcmdzIDwgYXJnYykgewogICAgICAgICBjaGFyICp1 cmwgPSB1cmxfZnJvbV91c2VyX2lucHV0KGFyZ3ZbYXJnc10pOwotICAgICAgICBld2tfdmlld191 cmxfc2V0KHdpbmRvdy0+ZXdrX3ZpZXcsIHVybCk7CisgICAgICAgIGxvYWRfdXJsX2Zyb21fdXNl cl9pbnB1dCh3aW5kb3ctPmV3a192aWV3LCB1cmwpOwogICAgICAgICBmcmVlKHVybCk7CiAgICAg fSBlbHNlCiAgICAgICAgIGV3a192aWV3X3VybF9zZXQod2luZG93LT5ld2tfdmlldywgREVGQVVM VF9VUkwpOwo= 254623 2015-06-09 20:39:06 -0700 2015-06-09 23:31:00 -0700 Patch bug-145725-20150610123838.patch text/plain 2612 hyungwook.lee SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTM5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE1LTA2LTA5ICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZl cmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIEV4ZWN1dGUgSmF2YXNjcmlwdCBtZXRob2QgaW4g bWluaSBicm93c2VyIGFkZHJlc3MgYmFyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NzI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU3VwcG9ydCAnamF2YXNjcmlwdDonIHNjaGVtZSBpbiBXZWJLaXQg RUZMIE1pbmkgQnJvd3Nlci4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6Cisg ICAgICAgICh1cmxfZnJvbV91c2VyX2lucHV0KToKKyAgICAgICAgKHVybF9sb2FkX2Zyb21fdXNl cl9pbnB1dCk6CisgICAgICAgIChvbl91cmxfYmFyX2FjdGl2YXRlZCk6CisgICAgICAgIChlbG1f bWFpbik6CisKIDIwMTUtMDYtMDkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgcnVuLWJlbmNobWFyayBzaG91bGQgZWl0aGVyIGNoZWNrb3V0IEpldFN0cmVhbSAx LjAuMSBvciBzdXBwb3J0IHJ1bm5pbmcgdGhlIGxhdGVzdCB2ZXJzaW9uCkluZGV4OiBUb29scy9N aW5pQnJvd3Nlci9lZmwvbWFpbi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL2Vm bC9tYWluLmMJKHJldmlzaW9uIDE4NTM5OSkKKysrIFRvb2xzL01pbmlCcm93c2VyL2VmbC9tYWlu LmMJKHdvcmtpbmcgY29weSkKQEAgLTEwMzgsNyArMTAzOCw3IEBAIHN0YXRpYyBjaGFyICoKIHVy bF9mcm9tX3VzZXJfaW5wdXQoY29uc3QgY2hhciAqYXJnKQogewogICAgIC8qIElmIGl0IGlzIGFs cmVhZHkgYSBVUkwsIHJldHVybiB0aGUgYXJndW1lbnQgYXMgaXMuICovCi0gICAgaWYgKGhhc19z Y2hlbWUoYXJnKSB8fCAhc3RyY2FzZWNtcChhcmcsICJhYm91dDpibGFuayIpKQorICAgIGlmICho YXNfc2NoZW1lKGFyZykgfHwgZWluYV9zdHJfaGFzX3ByZWZpeChhcmcsICJqYXZhc2NyaXB0OiIp IHx8ICFzdHJjYXNlY21wKGFyZywgImFib3V0OmJsYW5rIikpCiAgICAgICAgIHJldHVybiBzdHJk dXAoYXJnKTsKIAogICAgIEVpbmFfU3RyYnVmICpidWYgPSBlaW5hX3N0cmJ1Zl9tYW5hZ2VfbmV3 KGVpbmFfZmlsZV9wYXRoX3Nhbml0aXplKGFyZykpOwpAQCAtMTA2MCw2ICsxMDYwLDE4IEBAIHVy bF9mcm9tX3VzZXJfaW5wdXQoY29uc3QgY2hhciAqYXJnKQogICAgIHJldHVybiB1cmw7CiB9CiAK K3N0YXRpYyBFaW5hX0Jvb2wKK3VybF9sb2FkX2Zyb21fdXNlcl9pbnB1dChFdmFzX09iamVjdCog ZXdrX3ZpZXcsIGNvbnN0IGNoYXIqIHVybCkKK3sKKyAgICBpZiAoIWV3a192aWV3IHx8ICF1cmwp CisgICAgICAgIHJldHVybiBFSU5BX0ZBTFNFOworCisgICAgaWYgKGVpbmFfc3RyX2hhc19wcmVm aXgodXJsLCAiamF2YXNjcmlwdDoiKSkKKyAgICAgICAgcmV0dXJuIGV3a192aWV3X3NjcmlwdF9l eGVjdXRlKGV3a192aWV3LCBzdHJzdHIodXJsLCAiamF2YXNjcmlwdDoiKSwgMCwgMCk7CisKKyAg ICByZXR1cm4gZXdrX3ZpZXdfdXJsX3NldChld2tfdmlldywgdXJsKTsKK30KKwogc3RhdGljIHZv aWQKIG9uX3VybF9iYXJfYWN0aXZhdGVkKHZvaWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKnVy bF9iYXIsIHZvaWQgKmV2ZW50X2luZm8pCiB7CkBAIC0xMDY4LDcgKzEwODAsNyBAQCBvbl91cmxf YmFyX2FjdGl2YXRlZCh2b2lkICp1c2VyX2RhdGEsIEV2CiAgICAgY29uc3QgY2hhciAqbWFya3Vw X3VybCA9IGVsbV9lbnRyeV9lbnRyeV9nZXQodXJsX2Jhcik7CiAgICAgY2hhciAqdXNlcl91cmwg PSBlbG1fZW50cnlfbWFya3VwX3RvX3V0ZjgobWFya3VwX3VybCk7CiAgICAgY2hhciAqdXJsID0g dXJsX2Zyb21fdXNlcl9pbnB1dCh1c2VyX3VybCk7Ci0gICAgZXdrX3ZpZXdfdXJsX3NldCh3aW5k b3ctPmV3a192aWV3LCB1cmwpOworICAgIHVybF9sb2FkX2Zyb21fdXNlcl9pbnB1dCh3aW5kb3ct PmV3a192aWV3LCB1cmwpOwogCiAgICAgZnJlZSh1c2VyX3VybCk7CiAgICAgZnJlZSh1cmwpOwpA QCAtMjQ2MSw3ICsyNDczLDcgQEAgZWxtX21haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAog ICAgIGlmIChhcmdzIDwgYXJnYykgewogICAgICAgICBjaGFyICp1cmwgPSB1cmxfZnJvbV91c2Vy X2lucHV0KGFyZ3ZbYXJnc10pOwotICAgICAgICBld2tfdmlld191cmxfc2V0KHdpbmRvdy0+ZXdr X3ZpZXcsIHVybCk7CisgICAgICAgIHVybF9sb2FkX2Zyb21fdXNlcl9pbnB1dCh3aW5kb3ctPmV3 a192aWV3LCB1cmwpOwogICAgICAgICBmcmVlKHVybCk7CiAgICAgfSBlbHNlCiAgICAgICAgIGV3 a192aWV3X3VybF9zZXQod2luZG93LT5ld2tfdmlldywgREVGQVVMVF9VUkwpOwo= 254630 2015-06-09 23:31:08 -0700 2015-06-10 00:30:09 -0700 Patch bug-145725-20150610153039.patch text/plain 2604 hyungwook.lee SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NTQwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE1LTA2LTA5ICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZl cmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIEV4ZWN1dGUgSmF2YXNjcmlwdCBtZXRob2QgaW4g bWluaSBicm93c2VyIGFkZHJlc3MgYmFyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NzI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU3VwcG9ydCAnamF2YXNjcmlwdDonIHNjaGVtZSBpbiBXZWJLaXQg RUZMIE1pbmkgQnJvd3Nlci4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6Cisg ICAgICAgICh1cmxfZnJvbV91c2VyX2lucHV0KToKKyAgICAgICAgKHVybF9sb2FkX2Zyb21fdXNl cl9pbnB1dCk6CisgICAgICAgIChvbl91cmxfYmFyX2FjdGl2YXRlZCk6CisgICAgICAgIChlbG1f bWFpbik6CisKIDIwMTUtMDYtMDkgIEh5dW5nd29vayBMZWUgIDxoeXVuZ3dvb2subGVlQG5hdmVy Y29ycC5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IGR1bXBQcm9ncmVzc0ZpbmlzaGVkQ2FsbGJh Y2soKSBmb3IgV2luIGxheW91dFRlc3RDb250cm9sbGVyLgpJbmRleDogVG9vbHMvTWluaUJyb3dz ZXIvZWZsL21haW4uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5j CShyZXZpc2lvbiAxODU0MDMpCisrKyBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMDM4LDcgKzEwMzgsNyBAQCBzdGF0aWMgY2hhciAqCiB1cmxfZnJvbV91 c2VyX2lucHV0KGNvbnN0IGNoYXIgKmFyZykKIHsKICAgICAvKiBJZiBpdCBpcyBhbHJlYWR5IGEg VVJMLCByZXR1cm4gdGhlIGFyZ3VtZW50IGFzIGlzLiAqLwotICAgIGlmIChoYXNfc2NoZW1lKGFy ZykgfHwgIXN0cmNhc2VjbXAoYXJnLCAiYWJvdXQ6YmxhbmsiKSkKKyAgICBpZiAoaGFzX3NjaGVt ZShhcmcpIHx8IGVpbmFfc3RyX2hhc19wcmVmaXgoYXJnLCAiamF2YXNjcmlwdDoiKSB8fCAhc3Ry Y2FzZWNtcChhcmcsICJhYm91dDpibGFuayIpKQogICAgICAgICByZXR1cm4gc3RyZHVwKGFyZyk7 CiAKICAgICBFaW5hX1N0cmJ1ZiAqYnVmID0gZWluYV9zdHJidWZfbWFuYWdlX25ldyhlaW5hX2Zp bGVfcGF0aF9zYW5pdGl6ZShhcmcpKTsKQEAgLTEwNjAsNiArMTA2MCwxOCBAQCB1cmxfZnJvbV91 c2VyX2lucHV0KGNvbnN0IGNoYXIgKmFyZykKICAgICByZXR1cm4gdXJsOwogfQogCitzdGF0aWMg RWluYV9Cb29sCit1cmxfbG9hZF9mcm9tX3VzZXJfaW5wdXQoRXZhc19PYmplY3QgKmV3a192aWV3 LCBjb25zdCBjaGFyICp1cmwpCit7CisgICAgaWYgKCFld2tfdmlldyB8fCAhdXJsKQorICAgICAg ICByZXR1cm4gRUlOQV9GQUxTRTsKKworICAgIGlmIChlaW5hX3N0cl9oYXNfcHJlZml4KHVybCwg ImphdmFzY3JpcHQ6IikpCisgICAgICAgIHJldHVybiBld2tfdmlld19zY3JpcHRfZXhlY3V0ZShl d2tfdmlldywgc3Ryc3RyKHVybCwgImphdmFzY3JpcHQ6IiksIDAsIDApOworCisgICAgcmV0dXJu IGV3a192aWV3X3VybF9zZXQoZXdrX3ZpZXcsIHVybCk7Cit9CisKIHN0YXRpYyB2b2lkCiBvbl91 cmxfYmFyX2FjdGl2YXRlZCh2b2lkICp1c2VyX2RhdGEsIEV2YXNfT2JqZWN0ICp1cmxfYmFyLCB2 b2lkICpldmVudF9pbmZvKQogewpAQCAtMTA2OCw3ICsxMDgwLDcgQEAgb25fdXJsX2Jhcl9hY3Rp dmF0ZWQodm9pZCAqdXNlcl9kYXRhLCBFdgogICAgIGNvbnN0IGNoYXIgKm1hcmt1cF91cmwgPSBl bG1fZW50cnlfZW50cnlfZ2V0KHVybF9iYXIpOwogICAgIGNoYXIgKnVzZXJfdXJsID0gZWxtX2Vu dHJ5X21hcmt1cF90b191dGY4KG1hcmt1cF91cmwpOwogICAgIGNoYXIgKnVybCA9IHVybF9mcm9t X3VzZXJfaW5wdXQodXNlcl91cmwpOwotICAgIGV3a192aWV3X3VybF9zZXQod2luZG93LT5ld2tf dmlldywgdXJsKTsKKyAgICB1cmxfbG9hZF9mcm9tX3VzZXJfaW5wdXQod2luZG93LT5ld2tfdmll dywgdXJsKTsKIAogICAgIGZyZWUodXNlcl91cmwpOwogICAgIGZyZWUodXJsKTsKQEAgLTI0NjEs NyArMjQ3Myw3IEBAIGVsbV9tYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAKICAgICBpZiAo YXJncyA8IGFyZ2MpIHsKICAgICAgICAgY2hhciAqdXJsID0gdXJsX2Zyb21fdXNlcl9pbnB1dChh cmd2W2FyZ3NdKTsKLSAgICAgICAgZXdrX3ZpZXdfdXJsX3NldCh3aW5kb3ctPmV3a192aWV3LCB1 cmwpOworICAgICAgICB1cmxfbG9hZF9mcm9tX3VzZXJfaW5wdXQod2luZG93LT5ld2tfdmlldywg dXJsKTsKICAgICAgICAgZnJlZSh1cmwpOwogICAgIH0gZWxzZQogICAgICAgICBld2tfdmlld191 cmxfc2V0KHdpbmRvdy0+ZXdrX3ZpZXcsIERFRkFVTFRfVVJMKTsK