145720 2015-06-05 18:06:39 -0700 Returned Exception* values need to be initialized to nullptr when no exceptions are thrown. 2015-06-06 00:55:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam ap commit-queue oldest_to_newest 1100034 0 mark.lam 2015-06-05 18:06:39 -0700 For example, see https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r185259%20(52263)/results.html. The relevant failures are: Tests that crashed: +inspector-protocol/debugger/didSampleProbe-multiple-probes.html +inspector-protocol/debugger/hit-breakpoint-from-console.html +inspector-protocol/debugger/setBreakpoint-condition.html Tests that failed text/pixel/audio diff: inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html inspector-protocol/debugger/setBreakpoint-actions.html inspector-protocol/debugger/setBreakpoint-column.html inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html These failures only seem to manifest on the Windows Release build test bots. They don't manifest on the Debug build test bots nor Mac bots. 1100043 1 mark.lam 2015-06-05 18:26:29 -0700 I skipped these tests for now in r185283: <http://trac.webkit.org/r185283>. It turns out, that the inspector-protocol/debugger tests were already skipped for platform/mac and inspector-protocol is skipped entirely for Debug build on platform/win. That may be why we don't see the failures on those bots. 1100065 2 mark.lam 2015-06-05 23:45:11 -0700 Found the culprit: an un-initialized variable. This makes me re-consider introducing an opaque type for encapsulating an Exception*. But for now, I'll do the minimum fix. 1100066 3 254407 mark.lam 2015-06-05 23:49:03 -0700 Created attachment 254407 the patch. 1100071 4 254407 commit-queue 2015-06-06 00:55:49 -0700 Comment on attachment 254407 the patch. Clearing flags on attachment: 254407 Committed r185286: <http://trac.webkit.org/changeset/185286> 1100072 5 commit-queue 2015-06-06 00:55:54 -0700 All reviewed patches have been landed. Closing bug. 254407 2015-06-05 23:49:03 -0700 2015-06-06 00:55:49 -0700 the patch. bug-145720.patch text/plain 4708 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1Mjg1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTA2LTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXR1cm5lZCBFeGNlcHRpb24qIHZhbHVlcyBuZWVkIHRvIGJlIGluaXRpYWxpemVkIHRvIG51bGxw dHIgd2hlbiBubyBleGNlcHRpb25zIGFyZSB0aHJvd24uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU3MjAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyQ2FsbEZyYW1lLmNw cDoKKyAgICAgICAgKEpTQzo6RGVidWdnZXJDYWxsRnJhbWU6OmV2YWx1YXRlKToKKwogMjAxNS0w Ni0wNSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgU3ViY2xhc3Nl cyBvZiBKU05vbkZpbmFsT2JqZWN0IHdpdGggZ2MnYWJsZSBjaGlsZHJlbiBuZWVkIHRvIGltcGxl bWVudCB2aXNpdENoaWxkcmVuKCkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdn ZXIvRGVidWdnZXJDYWxsRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlckNhbGxGcmFtZS5jcHAJKHJldmlzaW9uIDE4NTI4MSkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlckNhbGxGcmFtZS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE4MCw2ICsxODAsNyBAQCBKU1ZhbHVlIERlYnVnZ2VyQ2FsbEZyYW1l Ojp0aGlzVmFsdWUoKSBjCiBKU1ZhbHVlIERlYnVnZ2VyQ2FsbEZyYW1lOjpldmFsdWF0ZShjb25z dCBTdHJpbmcmIHNjcmlwdCwgRXhjZXB0aW9uKiYgZXhjZXB0aW9uKQogewogICAgIEFTU0VSVChp c1ZhbGlkKCkpOworICAgIGV4Y2VwdGlvbiA9IG51bGxwdHI7CiAgICAgQ2FsbEZyYW1lKiBjYWxs RnJhbWUgPSBtX2NhbGxGcmFtZTsKICAgICBpZiAoIWNhbGxGcmFtZSkKICAgICAgICAgcmV0dXJu IGpzTnVsbCgpOwpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1Mjg1KQorKysgU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDYt MDUgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJldHVybmVkIEV4 Y2VwdGlvbiogdmFsdWVzIG5lZWQgdG8gYmUgaW5pdGlhbGl6ZWQgdG8gbnVsbHB0ciB3aGVuIG5v IGV4Y2VwdGlvbnMgYXJlIHRocm93bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NTcyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoaXMgaXNzdWUgaXMgYWxyZWFk eSBjb3ZlcmVkIGJ5IHRoZSBleGlzdGluZyBpbnNwZWN0b3ItcHJvdG9jb2wgdGVzdHMuCisKKyAg ICAgICAgKiBiaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OldvcmtlclNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlKToKKwogMjAxNS0wNi0w NSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gRG9u J3QgZm9yY2UgY29tcG9zaXRpbmcgbGF5ZXJzIGZvciBuby1vcCAzRCB0cmFuc2Zvcm1zIG9uIGxv dy1tZW1vcnkgZGV2aWNlcy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dvcmtl clNjcmlwdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxODUyODEpCisrKyBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTA5LDYgKzEwOSw3IEBAIHZvaWQgV29ya2VyU2NyaXB0Q29udHJvbGxl cjo6ZXZhbHVhdGUoY28KIAogdm9pZCBXb3JrZXJTY3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZShj b25zdCBTY3JpcHRTb3VyY2VDb2RlJiBzb3VyY2VDb2RlLCBKU0M6OkV4Y2VwdGlvbiomIHJldHVy bmVkRXhjZXB0aW9uKQogeworICAgIHJldHVybmVkRXhjZXB0aW9uID0gbnVsbHB0cjsKICAgICBp ZiAoaXNFeGVjdXRpb25Gb3JiaWRkZW4oKSkKICAgICAgICAgcmV0dXJuOwogCkluZGV4OiBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShy ZXZpc2lvbiAxODUyODUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxMyBAQAorMjAxNS0wNi0wNSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5j b20+CisKKyAgICAgICAgUmV0dXJuZWQgRXhjZXB0aW9uKiB2YWx1ZXMgbmVlZCB0byBiZSBpbml0 aWFsaXplZCB0byBudWxscHRyIHdoZW4gbm8gZXhjZXB0aW9ucyBhcmUgdGhyb3duLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NzIwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4v VGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgLSBVbmRvaW5nIHNraXBwZWQgdGVzdHMuCisKIDIw MTUtMDYtMDUgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEdhcmRl bmluZzogc2tpcCBzb21lIGluc3BlY3Rvci1wcm90b2NvbCB0ZXN0cyB3aGlsZSB0aGUgaXNzdWUg aXMgYmVpbmcgaW52ZXN0aWdhdGVkLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rl c3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rl c3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDE4NTI4MykKKysrIExheW91dFRlc3RzL3BsYXRmb3Jt L3dpbi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0yMzY5LDE0ICsyMzY5LDYg QEAgd2Via2l0Lm9yZy9iLzEyODk3OSBbIFJlbGVhc2UgXSBpbnNwZWN0bwogaW5zcGVjdG9yLXBy b3RvY29sL2RlYnVnZ2VyL3JlbW92ZUJyZWFrcG9pbnQuaHRtbCBbIFNraXAgXSAjIENyYXNoaW5n CiBpbnNwZWN0b3ItcHJvdG9jb2wvZGVidWdnZXIvc2VhcmNoSW5Db250ZW50LWxpbmVicmVha3Mu aHRtbCBbIFBhc3MgQ3Jhc2ggXSAjIEZsYWt5CiAKLXdlYmtpdC5vcmcvYi8xNDU3MjAgWyBSZWxl YXNlIF0gaW5zcGVjdG9yLXByb3RvY29sL2RlYnVnZ2VyL2RpZFNhbXBsZVByb2JlLW11bHRpcGxl LXByb2Jlcy5odG1sIFsgU2tpcCBdCi13ZWJraXQub3JnL2IvMTQ1NzIwIFsgUmVsZWFzZSBdIGlu c3BlY3Rvci1wcm90b2NvbC9kZWJ1Z2dlci9oaXQtYnJlYWtwb2ludC1mcm9tLWNvbnNvbGUuaHRt bCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzE0NTcyMCBbIFJlbGVhc2UgXSBpbnNwZWN0b3ItcHJv dG9jb2wvZGVidWdnZXIvc2V0QnJlYWtwb2ludC1jb25kaXRpb24uaHRtbCBbIFNraXAgXQotd2Vi a2l0Lm9yZy9iLzE0NTcyMCBbIFJlbGVhc2UgXSBpbnNwZWN0b3ItcHJvdG9jb2wvZGVidWdnZXIv YnJlYWtwb2ludC1pbnNpZGUtY29uZGl0b25zLWFuZC1hY3Rpb25zLmh0bWwgWyBGYWlsdXJlIF0K LXdlYmtpdC5vcmcvYi8xNDU3MjAgWyBSZWxlYXNlIF0gaW5zcGVjdG9yLXByb3RvY29sL2RlYnVn Z2VyL3NldEJyZWFrcG9pbnQtYWN0aW9ucy5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2Iv MTQ1NzIwIFsgUmVsZWFzZSBdIGluc3BlY3Rvci1wcm90b2NvbC9kZWJ1Z2dlci9zZXRCcmVha3Bv aW50LWNvbHVtbi5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTQ1NzIwIFsgUmVsZWFz ZSBdIGluc3BlY3Rvci1wcm90b2NvbC9kZWJ1Z2dlci9zZXRCcmVha3BvaW50QnlVcmwtc291cmNl VVJMLmh0bWwgWyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE0MzU0OCBpbnNwZWN0b3IvY29u c29sZS9jb25zb2xlLWFwaS5odG1sIFsgU2tpcCBdICMgVGltZW91dAogIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMKICMjIyMjIyMjIyMjIyMjIyMjICAgICAgICBFbmQgSW5zcGVjdG9yIElzc3VlcyAg ICAgICAgICAgICAgICMjIyMjIyMjIyMjIyMjIyMjIyMjCg==