145719 2015-06-05 16:58:24 -0700 [iOS] Don't force compositing layers for no-op 3D transforms on low-memory devices. 2015-06-06 09:58:20 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified REOPENED InRadar, Performance P2 Normal --- 145723 1 kling kling commit-queue esprehn+autocc ggaren glenn kling kondapallykalyan simon.fraser oldest_to_newest 1100018 0 kling 2015-06-05 16:58:24 -0700 <rdar://problem/19973042> 1100019 1 254398 kling 2015-06-05 16:59:45 -0700 Created attachment 254398 Patch 1100020 2 commit-queue 2015-06-05 17:01:46 -0700 Attachment 254398 did not pass style-queue: ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:66: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1100021 3 254398 ggaren 2015-06-05 17:15:54 -0700 Comment on attachment 254398 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254398&action=review r=me > Source/WebCore/rendering/RenderLayerCompositor.cpp:2476 > + static uint64_t memSize = ramSize() / 1024 / 1024; Please call this ramSizeInMB. > Source/WebCore/rendering/RenderLayerCompositor.cpp:2478 > + // Special policy for low-memory devices: Don't require compositing just because there's a no-op 3D transform. I really really really wish we did this all the time. 1100045 4 kling 2015-06-05 19:22:20 -0700 (In reply to comment #3) > > Source/WebCore/rendering/RenderLayerCompositor.cpp:2478 > > + // Special policy for low-memory devices: Don't require compositing just because there's a no-op 3D transform. > > I really really really wish we did this all the time. Me too, really x3. 1100048 5 kling 2015-06-05 20:12:11 -0700 Committed r185284: <http://trac.webkit.org/changeset/185284> 1100076 6 commit-queue 2015-06-06 01:39:47 -0700 Re-opened since this is blocked by bug 145723 1100100 7 254398 darin 2015-06-06 09:58:20 -0700 Comment on attachment 254398 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254398&action=review >> Source/WebCore/rendering/RenderLayerCompositor.cpp:2476 >> + static uint64_t memSize = ramSize() / 1024 / 1024; > > Please call this ramSizeInMB. If we are going to precompute and cache something, I suggest caching the boolean that indicates whether we should do the special policy. Not as good to instead cache a 64-bit number and keep comparing it against 512 over and over again. 254398 2015-06-05 16:59:45 -0700 2015-06-05 17:15:54 -0700 Patch bug-145719.diff text/plain 2701 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZjlmYmI0Li4zZDIxZWY3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDE1LTA2LTA1ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAg ICAgICBbaU9TXSBEb24ndCBmb3JjZSBjb21wb3NpdGluZyBsYXllcnMgZm9yIG5vLW9wIDNEIHRy YW5zZm9ybXMgb24gbG93LW1lbW9yeSBkZXZpY2VzLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQu b3JnL2IvMTQ1NzE5PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTk5NzMwNDI+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgcHV0IGVsZW1lbnRz IHdpdGggM0QgaWRlbnRpdHkgdHJhbnNmb3JtcyBvbnRvIGNvbXBvc2l0aW5nIGxheWVycyBiZWNh dXNlCisgICAgICAgIHdlIGFudGljaXBhdGUgdGhhdCB0aGV5IHdpbGwgc29tZWhvdyBhbmltYXRl IGluIHRoZSBmdXR1cmUuCisKKyAgICAgICAgVGhpcyBjYW4gZ2V0IGV4dHJlbWVseSBleHBlbnNp dmUsIGVzcGVjaWFsbHkgb24gbG93LW1lbW9yeSBkZXZpY2VzLgorICAgICAgICBUaGlzIHBhdGNo IG1ha2VzIFdlYktpdCBzdG9wIGhhbmRpbmcgb3V0IGNvbXBvc2l0aW5nIGxheWVycyBmb3IgdGhp cyBraW5kYSB0aGluZzoKKworICAgICAgICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0 ZTNkKDAsMCwwKQorCisgICAgICAgIC4ub24gZGV2aWNlcyB3aXRoIDUxMk1CIG9yIGxlc3MuIFRo aXMgZHJhbWF0aWNhbGx5IGltcHJvdmVzIHN0YWJpbGl0eSBvbiBzb21lCisgICAgICAgIHdlYiBw YWdlcy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0 aW5nRm9yVHJhbnNmb3JtKToKKwogMjAxNS0wNi0wNSAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVy ZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBbV2F5bGFuZF0gVGhlIE1p bmlCcm93c2VyIGNyYXNoZXMgaW5zaWRlIFdlc3Rvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggZjIxN2U3OS4uNjE2ZDU1 ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKQEAgLTYzLDYgKzYzLDcgQEAKICNpbmNsdWRlICJUcmFuc2Zvcm1TdGF0ZS5oIgog I2luY2x1ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgogI2luY2x1ZGUgPHd0Zi9UZW1wb3JhcnlDaGFu Z2UuaD4KKyNpbmNsdWRlIDx3dGYvUkFNU2l6ZS5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJp bmcuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+CiAKQEAgLTI0NjUsNyAr MjQ2NiwyNSBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVxdWlyZXNDb21wb3NpdGlu Z0ZvclRyYW5zZm9ybShSZW5kZXJMYXllck1vZGVsT2JqZQogCiAgICAgLy8gTm90ZSB0aGF0IHdl IGFzayB0aGUgcmVuZGVyZXIgaWYgaXQgaGFzIGEgdHJhbnNmb3JtLCBiZWNhdXNlIHRoZSBzdHls ZSBtYXkgaGF2ZSB0cmFuc2Zvcm1zLAogICAgIC8vIGJ1dCB0aGUgcmVuZGVyZXIgbWF5IGJlIGFu IGlubGluZSB0aGF0IGRvZXNuJ3Qgc3VwcHBvcnQgdGhlbS4KLSAgICByZXR1cm4gcmVuZGVyZXIu aGFzVHJhbnNmb3JtKCkgJiYgcmVuZGVyZXIuc3R5bGUoKS50cmFuc2Zvcm0oKS5oYXMzRE9wZXJh dGlvbigpOworICAgIGlmICghcmVuZGVyZXIuaGFzVHJhbnNmb3JtKCkpCisgICAgICAgIHJldHVy biBmYWxzZTsKKworICAgIGlmICghcmVuZGVyZXIuc3R5bGUoKS50cmFuc2Zvcm0oKS5oYXMzRE9w ZXJhdGlvbigpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyNpZiBQTEFURk9STShJT1MpCisg ICAgc3RhdGljIHVpbnQ2NF90IG1lbVNpemUgPSByYW1TaXplKCkgLyAxMDI0IC8gMTAyNDsKKyAg ICBpZiAobWVtU2l6ZSA8PSA1MTIpIHsKKyAgICAgICAgLy8gU3BlY2lhbCBwb2xpY3kgZm9yIGxv dy1tZW1vcnkgZGV2aWNlczogRG9uJ3QgcmVxdWlyZSBjb21wb3NpdGluZyBqdXN0IGJlY2F1c2Ug dGhlcmUncyBhIG5vLW9wIDNEIHRyYW5zZm9ybS4KKyAgICAgICAgZm9yIChhdXRvJiB0cmFuc2Zv cm0gOiByZW5kZXJlci5zdHlsZSgpLnRyYW5zZm9ybSgpLm9wZXJhdGlvbnMoKSkgeworICAgICAg ICAgICAgaWYgKCF0cmFuc2Zvcm0tPmlzSWRlbnRpdHkoKSkKKyAgICAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKKyAgICAgICAgfQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorI2VuZGlm CisKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogYm9vbCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJl cXVpcmVzQ29tcG9zaXRpbmdGb3JCYWNrZmFjZVZpc2liaWxpdHkoUmVuZGVyTGF5ZXJNb2RlbE9i amVjdCYgcmVuZGVyZXIpIGNvbnN0Cg==