145712 2015-06-05 14:14:48 -0700 Web Inspector: "Other" time in the framerate table is often negative 2015-06-05 18:07:01 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1099936 0 mattbaker 2015-06-05 14:14:48 -0700 * SUMMARY "Other" time in the framerate table is often negative. 1099938 1 mattbaker 2015-06-05 14:15:22 -0700 <rdar://problem/21223666> 1099987 2 254393 mattbaker 2015-06-05 15:28:40 -0700 Created attachment 254393 [Patch] Proposed Fix 1099992 3 254393 simon.fraser 2015-06-05 15:34:48 -0700 Comment on attachment 254393 [Patch] Proposed Fix Can this be tested? 1099999 4 mattbaker 2015-06-05 15:58:41 -0700 I'm not sure what type of layout test could cover this. I performed some ad hoc testing by scrolling while recording frames on sites that previously generated negative Other time. 1100022 5 254393 timothy 2015-06-05 17:18:18 -0700 Comment on attachment 254393 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=254393&action=review > Source/WebCore/inspector/InspectorTimelineAgent.cpp:676 > + // Nested paint records are an implementation detail and add no information not already contained in the parent. Can they be nested more than one level deep? Will this block more than one level nesting? 1100035 6 254393 commit-queue 2015-06-05 18:06:57 -0700 Comment on attachment 254393 [Patch] Proposed Fix Clearing flags on attachment: 254393 Committed r185278: <http://trac.webkit.org/changeset/185278> 1100036 7 commit-queue 2015-06-05 18:07:01 -0700 All reviewed patches have been landed. Closing bug. 254393 2015-06-05 15:28:40 -0700 2015-06-05 18:06:57 -0700 [Patch] Proposed Fix bug-145712-20150605152817.patch text/plain 2046 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhhZGQ1NzcxMTJkODE1 MzNlMjIzZjY5NDZkMzFlYjI1OWQ4ZTMyNS4uMTIzNTU3MzUwZGI2ZDQzMjMxZGZiMzQ3NzQzY2My OWFkMjgzYzc0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA2LTA1ICBNYXR0 IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiAi T3RoZXIiIHRpbWUgaW4gdGhlIGZyYW1lcmF0ZSB0YWJsZSBpcyBvZnRlbiBuZWdhdGl2ZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NzEyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIEluc3BlY3Rv ciBmcm9udGVuZCBmbGF0dGVucyB0aGUgdGltZWxpbmUgZXZlbnQgdHJlZSBpdCByZWNlaXZlcyBm cm9tIHRoZSBiYWNrZW5kLCB3aGljaCBjYW4gY29udGFpbiBuZXN0ZWQKKyAgICAgICAgcGFpbnQg cmVjb3Jkcy4gVGhlIG5lc3RlZCByZWNvcmRzIHJlcHJlc2VudCBhIHNpbmdsZSBwYWludCBldmVu dCwgYnV0IHdlcmUgYmVpbmcgaW50ZXJwcmV0ZWQgYXMgdHdvIHNlcGFyYXRlCisgICAgICAgIGV2 ZW50cyBmb3IgcHVycG9zZXMgb2YgY2FsY3VsYXRpbmcgdG90YWwgbGF5b3V0IHRpbWUuIFRoaXMg Y2F1c2VkIHRoZSBjYWxjdWxhdGVkICJvdGhlciIgdGltZSB0byBiZSBsZXNzIHRoYW4KKyAgICAg ICAgaXQgc2hvdWxkIGJlIChhbmQgaW4gc29tZSBjYXNlcyBuZWdhdGl2ZSkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxpbmVBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpJbnNwZWN0b3JUaW1lbGluZUFnZW50OjphZGRSZWNvcmRUb1RpbWVsaW5lKToKKyAgICAgICAg UGFpbnQgcmVjb3JkcyBhcmUgbm8gbG9uZ2VyIG5lc3RlZCwgd2Ugc2ltcGx5IGRyb3AgdGhlIGNo aWxkIHBhaW50IGV2ZW50LgorCiAyMDE1LTA2LTA1ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhm aWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gRW1vamkgb3ZlcmxhcCBwcmVjZWVkaW5n IGxpbmVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yVGlt ZWxpbmVBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxp bmVBZ2VudC5jcHAKaW5kZXggZjc4OGVkMzU4MTBjNjM3MjI5OTgwNzJlOTJjNDhiMzJmZTBjNTJh OC4uYThkMzc5ZGUyYjdiOTE1ODgzNDRjYTU5NWJiMGIxOGRiNjFmOTM0NyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFnZW50LmNwcApAQCAt NjczLDYgKzY3MywxMCBAQCB2b2lkIEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6OmFkZFJlY29yZFRv VGltZWxpbmUoUmVmUHRyPEluc3BlY3Rvck9iamVjdD4mJiByZWNvcgogICAgICAgICBzZW5kRXZl bnQoV1RGOjptb3ZlKHJlY29yZE9iamVjdCkpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIGNvbnN0 IFRpbWVsaW5lUmVjb3JkRW50cnkmIHBhcmVudCA9IG1fcmVjb3JkU3RhY2subGFzdCgpOworICAg ICAgICAvLyBOZXN0ZWQgcGFpbnQgcmVjb3JkcyBhcmUgYW4gaW1wbGVtZW50YXRpb24gZGV0YWls IGFuZCBhZGQgbm8gaW5mb3JtYXRpb24gbm90IGFscmVhZHkgY29udGFpbmVkIGluIHRoZSBwYXJl bnQuCisgICAgICAgIGlmICh0eXBlID09IFRpbWVsaW5lUmVjb3JkVHlwZTo6UGFpbnQgJiYgcGFy ZW50LnR5cGUgPT0gdHlwZSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBwYXJlbnQu Y2hpbGRyZW4tPnB1c2hPYmplY3QoV1RGOjptb3ZlKHJlY29yZCkpOwogICAgIH0KIH0K