145695 2015-06-05 09:27:14 -0700 REGRESSION (r185213): TypeError: undefined is not an object (evaluating 'WebInspector.clearLogOnReload.value') 2015-06-05 15:59:49 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 145090 1 mark.lam joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy tobi+webkit webkit-bug-importer oldest_to_newest 1099820 0 mark.lam 2015-06-05 09:27:14 -0700 This error started showing up after r185213: <http://trac.webkit.org/changeset/185213>. The complete error message says: Uncaught exception in inspector page: TypeError: undefined is not an object (evaluating 'WebInspector.clearLogOnReload.value') [file:///.../OpenSource/WebKitBuild/Debug/WebInspectorUI.framework/Resources/Controllers/LogManager.js:77] I see that WebInspector.clearLogOnReload is initialized by WebInspector.loaded() in Main.js. Are we guaranteed that WebInspector.loaded will be called before the first use of WebInspector.clearLogOnReload? I'm seeing the above error while trying to run new inspector tests I'm writing to test exception breakpoints. 1099821 1 webkit-bug-importer 2015-06-05 09:27:34 -0700 <rdar://problem/21260137> 1099898 2 mark.lam 2015-06-05 12:04:29 -0700 To reproduce this issue: 1. Comment out the asserts in InspectorTimelineAgent.cpp if the fix for https://bugs.webkit.org/show_bug.cgi?id=145090 is not yet landed. 2. Run the following inspector tests (landed in r185259): OpenSource$ ./Tools/Scripts/run-webkit-tests -1 --debug inspector/debugger/break-on-* That should run a set of 20 tests. The issue will manifest intermittently on a subset of those tests, and result in failures due to text diffs. 1099926 3 joepeck 2015-06-05 13:42:52 -0700 (In reply to comment #0) > This error started showing up after r185213: > <http://trac.webkit.org/changeset/185213>. The complete error message says: > > Uncaught exception in inspector page: TypeError: undefined is not an object > (evaluating 'WebInspector.clearLogOnReload.value') > [file:///.../OpenSource/WebKitBuild/Debug/WebInspectorUI.framework/Resources/ > Controllers/LogManager.js:77] It sounds like you reproduced this running tests. I suspect this is a Tests only issue. We just need to add a fake WebInspector.clearLogOnReload WebInspector.Setting to Test.js. Or, move it to LogManager like I suggested. I'll take a quick look. 1099971 4 254389 joepeck 2015-06-05 14:44:56 -0700 Created attachment 254389 [PATCH] Proposed Fix 1099974 5 254389 mark.lam 2015-06-05 14:48:52 -0700 Comment on attachment 254389 [PATCH] Proposed Fix r=me 1100000 6 254389 commit-queue 2015-06-05 15:59:44 -0700 Comment on attachment 254389 [PATCH] Proposed Fix Clearing flags on attachment: 254389 Committed r185271: <http://trac.webkit.org/changeset/185271> 1100001 7 commit-queue 2015-06-05 15:59:49 -0700 All reviewed patches have been landed. Closing bug. 254389 2015-06-05 14:44:56 -0700 2015-06-05 15:59:44 -0700 [PATCH] Proposed Fix clear-on-reload.patch text/plain 4905 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM3MDQyZjkuLjllZGQ4YzQ5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxNS0wNi0wNSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxODUyMTMp OiBUeXBlRXJyb3I6IHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdXZWJJ bnNwZWN0b3IuY2xlYXJMb2dPblJlbG9hZC52YWx1ZScpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU2OTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIGFuZCByZW5hbWUgdGhlIGNsZWFyIGxvZyBv biByZWxvYWQgc2V0dGluZyBwcm9wZXJ0eSBmcm9tCisgICAgICAgIFdlYkluc3BlY3RvciAoTWFp bi5qcykgdG8gTG9nTWFuYWdlciAoc2hhcmVkIHdpdGggdGVzdHMpLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IubG9hZGVkKTog RGVsZXRlZC4KKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0xvZ01hbmFnZXIu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTG9nTWFuYWdlcik6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuTG9nTWFuYWdlci5wcm90b3R5cGUuX2RlbGF5ZWRNZXNzYWdlc0NsZWFyZWQpOgorICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlLl9zZXNzaW9uU3RhcnRlZCk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlLl9oYW5kbGVDb250 ZXh0TWVudUV2ZW50KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Mb2dDb250ZW50Vmlldy5wcm90 b3R5cGUuX3RvZ2dsZUNsZWFyTG9nT25SZWxvYWRTZXR0aW5nKToKKwogMjAxNS0wNi0wNSAgTWF0 dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog U3dpdGNoIHRvIGRvdWdobnV0IGNoYXJ0IGFuZCByZW1vdmUgaWRsZSB0aW1lIGluIHRoZSBSZW5k ZXJpbmcgRnJhbWVzIHRpbWVsaW5lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggNmMyZTM0YS4uODFiZWE5MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMTUxLDcg KzE1MSw2IEBAIFdlYkluc3BlY3Rvci5sb2FkZWQgPSBmdW5jdGlvbigpCiAKICAgICB0aGlzLnNo b3dTaGFkb3dET01TZXR0aW5nID0gbmV3IFdlYkluc3BlY3Rvci5TZXR0aW5nKCJzaG93LXNoYWRv dy1kb20iLCBmYWxzZSk7CiAgICAgdGhpcy5zaG93UmVwbGF5SW50ZXJmYWNlU2V0dGluZyA9IG5l dyBXZWJJbnNwZWN0b3IuU2V0dGluZygic2hvdy13ZWItcmVwbGF5IiwgZmFsc2UpOwotICAgIHRo aXMuY2xlYXJMb2dPblJlbG9hZCA9IG5ldyBXZWJJbnNwZWN0b3IuU2V0dGluZygiY2xlYXItbG9n LW9uLXJlbG9hZCIsIHRydWUpOwogCiAgICAgdGhpcy5zaG93SmF2YVNjcmlwdFR5cGVJbmZvcm1h dGlvblNldHRpbmcgPSBuZXcgV2ViSW5zcGVjdG9yLlNldHRpbmcoInNob3ctamF2YXNjcmlwdC10 eXBlLWluZm9ybWF0aW9uIiwgZmFsc2UpOwogICAgIGlmICh0aGlzLnNob3dKYXZhU2NyaXB0VHlw ZUluZm9ybWF0aW9uU2V0dGluZy52YWx1ZSAmJiB3aW5kb3cuUnVudGltZUFnZW50ICYmIFJ1bnRp bWVBZ2VudC5lbmFibGVUeXBlUHJvZmlsZXIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Mb2dNYW5hZ2VyLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvTG9nTWFuYWdlci5qcwppbmRl eCA4YTEwMTAyLi44Y2I4YjUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9Mb2dNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0xvZ01hbmFnZXIuanMKQEAgLTMzLDYg KzMzLDggQEAgV2ViSW5zcGVjdG9yLkxvZ01hbmFnZXIgPSBjbGFzcyBMb2dNYW5hZ2VyIGV4dGVu ZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAgICB0aGlzLl9jbGVhck1lc3NhZ2VzUmVxdWVz dGVkID0gZmFsc2U7CiAgICAgICAgIHRoaXMuX2lzUGFnZVJlbG9hZCA9IGZhbHNlOwogCisgICAg ICAgIHRoaXMuY2xlYXJMb2dPblJlbG9hZFNldHRpbmcgPSBuZXcgV2ViSW5zcGVjdG9yLlNldHRp bmcoImNsZWFyLWxvZy1vbi1yZWxvYWQiLCB0cnVlKTsKKwogICAgICAgICBXZWJJbnNwZWN0b3Iu RnJhbWUuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRnJhbWUuRXZlbnQuTWFpblJlc291 cmNlRGlkQ2hhbmdlLCB0aGlzLl9tYWluUmVzb3VyY2VEaWRDaGFuZ2UsIHRoaXMpOwogICAgIH0K IApAQCAtNzQsNyArNzYsNyBAQCBXZWJJbnNwZWN0b3IuTG9nTWFuYWdlciA9IGNsYXNzIExvZ01h bmFnZXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAgewogICAgICAgICBpZiAodGhp cy5faXNQYWdlUmVsb2FkKSB7CiAgICAgICAgICAgICB0aGlzLl9pc1BhZ2VSZWxvYWQgPSBmYWxz ZTsKLSAgICAgICAgICAgIGlmIChXZWJJbnNwZWN0b3IuY2xlYXJMb2dPblJlbG9hZC52YWx1ZSkK KyAgICAgICAgICAgIGlmICh0aGlzLmNsZWFyTG9nT25SZWxvYWRTZXR0aW5nLnZhbHVlKQogICAg ICAgICAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5M b2dNYW5hZ2VyLkV2ZW50LkNsZWFyZWQpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAg Ly8gQSBmcmFtZSBuYXZpZ2F0ZWQsIGNvbnNvbGUuY2xlYXIoKSBvciBjb21tYW5kIGxpbmUgY2xl YXIoKSBoYXBwZW5lZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMKaW5kZXggYjcyMmFlYi4uMDYwMjg2 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TG9nQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvTG9nQ29udGVudFZpZXcuanMKQEAgLTMxMCw3ICszMTAsNyBAQCBXZWJJbnNwZWN0 b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlID0gewogCiAgICAgX3Nlc3Npb25TdGFydGVkOiBm dW5jdGlvbihldmVudCkKICAgICB7Ci0gICAgICAgIGlmIChXZWJJbnNwZWN0b3IuY2xlYXJMb2dP blJlbG9hZC52YWx1ZSkgeworICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLmxvZ01hbmFnZXIuY2xl YXJMb2dPblJlbG9hZFNldHRpbmcudmFsdWUpIHsKICAgICAgICAgICAgIHRoaXMuX3JlYXBwZW5k UHJvdmlzaW9uYWxNZXNzYWdlcygpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CkBA IC0zNTEsNyArMzUxLDcgQEAgV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZSA9 IHsKICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmco IkNsZWFyIExvZyIpLCB0aGlzLl9jbGVhckxvZy5iaW5kKHRoaXMpKTsKICAgICAgICAgY29udGV4 dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7CiAKLSAgICAgICAgdmFyIGNsZWFyTG9nT25SZWxvYWRV SVN0cmluZyA9IFdlYkluc3BlY3Rvci5jbGVhckxvZ09uUmVsb2FkLnZhbHVlID8gV2ViSW5zcGVj dG9yLlVJU3RyaW5nKCJLZWVwIExvZyBvbiBSZWxvYWQiKSA6IFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiQ2xlYXIgTG9nIG9uIFJlbG9hZCIpOworICAgICAgICB2YXIgY2xlYXJMb2dPblJlbG9hZFVJ U3RyaW5nID0gV2ViSW5zcGVjdG9yLmxvZ01hbmFnZXIuY2xlYXJMb2dPblJlbG9hZFNldHRpbmcu dmFsdWUgPyBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIktlZXAgTG9nIG9uIFJlbG9hZCIpIDogV2Vi SW5zcGVjdG9yLlVJU3RyaW5nKCJDbGVhciBMb2cgb24gUmVsb2FkIik7CiAKICAgICAgICAgY29u dGV4dE1lbnUuYXBwZW5kSXRlbShjbGVhckxvZ09uUmVsb2FkVUlTdHJpbmcsIHRoaXMuX3RvZ2ds ZUNsZWFyTG9nT25SZWxvYWRTZXR0aW5nLmJpbmQodGhpcykpOwogCkBAIC02NDMsNyArNjQzLDcg QEAgV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKIAogICAgIF90b2dn bGVDbGVhckxvZ09uUmVsb2FkU2V0dGluZzogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgV2Vi SW5zcGVjdG9yLmNsZWFyTG9nT25SZWxvYWQudmFsdWUgPSAhV2ViSW5zcGVjdG9yLmNsZWFyTG9n T25SZWxvYWQudmFsdWU7CisgICAgICAgIFdlYkluc3BlY3Rvci5sb2dNYW5hZ2VyLmNsZWFyTG9n T25SZWxvYWRTZXR0aW5nLnZhbHVlID0gIVdlYkluc3BlY3Rvci5sb2dNYW5hZ2VyLmNsZWFyTG9n T25SZWxvYWRTZXR0aW5nLnZhbHVlOwogICAgIH0sCiAKICAgICBfY2xlYXJMb2c6IGZ1bmN0aW9u KCkK