145689 2015-06-05 00:42:14 -0700 FunctionExecutable::isCompiling() is weird and wrong. 2015-06-09 14:20:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling ggaren kling oldest_to_newest 1099776 0 kling 2015-06-05 00:42:14 -0700 FunctionExecutable::isCompiling() will effectively always return false. It was probably correct back in the day when there was only the interpreter and the baseline JIT. 1099777 1 254345 kling 2015-06-05 00:50:50 -0700 Created attachment 254345 Patch 1099841 2 254345 ggaren 2015-06-05 10:15:27 -0700 Comment on attachment 254345 Patch r=me 1100787 3 254345 kling 2015-06-09 14:20:37 -0700 Comment on attachment 254345 Patch Clearing flags on attachment: 254345 Committed r185379: <http://trac.webkit.org/changeset/185379> 1100788 4 kling 2015-06-09 14:20:40 -0700 All reviewed patches have been landed. Closing bug. 254345 2015-06-05 00:50:50 -0700 2015-06-09 14:20:37 -0700 Patch bug-145689.diff text/plain 6580 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBkNGQzMTcuLmQ4ZTdhOTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE1LTA2LTA1ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBGdW5jdGlvbkV4ZWN1dGFibGU6OmlzQ29t cGlsaW5nKCkgaXMgd2VpcmQgYW5kIHdyb25nLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3Jn L2IvMTQ1Njg5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZSBGdW5jdGlvbkV4ZWN1dGFibGU6OmlzQ29tcGlsaW5nKCkgYW5kIHRoZSBjbGVh ckNvZGVJZk5vdENvbXBpbGluZygpIHN0eWxlCisgICAgICAgIGZ1bmN0aW9ucyB0aGF0IGNhbGxl ZCBpdCBiZWZvcmUgdGhyb3dpbmcgYXdheSBjb2RlLgorCisgICAgICAgIGlzQ29tcGlsaW5nKCkg d291bGQgY29uc2lkZXIgdGhlIGV4ZWN1dGFibGUgdG8gYmUgImNvbXBpbGluZyIgaWYgaXQgaGFk IGEgQ29kZUJsb2NrCisgICAgICAgIGJ1dCBubyBKSVRDb2RlLiBJbiBwcmFjdGljZSwgZXZlcnkg ZXhlY3V0YWJsZSBnZXRzIGEgSklUQ29kZSBhdCB0aGUgc2FtZSB0aW1lIGFzIGl0CisgICAgICAg IGdldHMgYSBDb2RlQmxvY2ssIGJ5IHdheSBvZiBwcmVwYXJlRm9yRXhlY3V0aW9uSW1wbCgpLgor CisgICAgICAgICogZGVidWdnZXIvRGVidWdnZXIuY3BwOgorICAgICAgICAqIGhlYXAvSGVhcC5j cHA6CisgICAgICAgIChKU0M6OkhlYXA6OmRlbGV0ZUFsbENvbXBpbGVkQ29kZSk6CisgICAgICAg IChKU0M6OkhlYXA6OmRlbGV0ZUFsbFVubGlua2VkRnVuY3Rpb25Db2RlKToKKyAgICAgICAgKiBp bnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclJ1bnRpbWVBZ2VudC5jcHA6CisgICAgICAgIChJbnNw ZWN0b3I6OlR5cGVSZWNvbXBpbGVyOjp2aXNpdCk6CisgICAgICAgICogcnVudGltZS9FeGVjdXRh YmxlLmNwcDoKKyAgICAgICAgKEpTQzo6RnVuY3Rpb25FeGVjdXRhYmxlOjpjbGVhclVubGlua2Vk Q29kZUZvclJlY29tcGlsYXRpb24pOgorICAgICAgICAoSlNDOjpGdW5jdGlvbkV4ZWN1dGFibGU6 OmNsZWFyQ29kZUlmTm90Q29tcGlsaW5nKTogRGVsZXRlZC4KKyAgICAgICAgKEpTQzo6RnVuY3Rp b25FeGVjdXRhYmxlOjpjbGVhclVubGlua2VkQ29kZUZvclJlY29tcGlsYXRpb25JZk5vdENvbXBp bGluZyk6IERlbGV0ZWQuCisgICAgICAgICogcnVudGltZS9FeGVjdXRhYmxlLmg6CisgICAgICAg ICogcnVudGltZS9WTS5jcHA6CisgICAgICAgIChKU0M6OlN0YWNrUHJlc2VydmluZ1JlY29tcGls ZXI6OnZpc2l0KToKKwogMjAxNS0wNi0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsYXNzIGNvbnN0cnVjdG9yIGFwcGVh cmluZyBhcyBPYmplY3QgVHJlZSBwcm9wZXJ0eSBkb2VzIG5vdCBpbmNsdWRlIHBhcmFtZXRlcnMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3BwCmluZGV4IDE0N2E3 ZTYuLjQ2MzBkNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9E ZWJ1Z2dlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2Vy LmNwcApAQCAtODgsOCArODgsOCBAQCBpbmxpbmUgdm9pZCBSZWNvbXBpbGVyOjp2aXNpdChKU0Nl bGwqIGNlbGwpCiAgICAgICAgIHJldHVybjsKIAogICAgIEV4ZWNTdGF0ZSogZXhlYyA9IGZ1bmN0 aW9uLT5zY29wZSgpLT5nbG9iYWxPYmplY3QoKS0+SlNHbG9iYWxPYmplY3Q6Omdsb2JhbEV4ZWMo KTsKLSAgICBleGVjdXRhYmxlLT5jbGVhckNvZGVJZk5vdENvbXBpbGluZygpOwotICAgIGV4ZWN1 dGFibGUtPmNsZWFyVW5saW5rZWRDb2RlRm9yUmVjb21waWxhdGlvbklmTm90Q29tcGlsaW5nKCk7 CisgICAgZXhlY3V0YWJsZS0+Y2xlYXJDb2RlKCk7CisgICAgZXhlY3V0YWJsZS0+Y2xlYXJVbmxp bmtlZENvZGVGb3JSZWNvbXBpbGF0aW9uKCk7CiAgICAgaWYgKG1fZGVidWdnZXIgPT0gZnVuY3Rp b24tPnNjb3BlKCktPmdsb2JhbE9iamVjdCgpLT5kZWJ1Z2dlcigpKQogICAgICAgICBtX3NvdXJj ZVByb3ZpZGVycy5hZGQoZXhlY3V0YWJsZS0+c291cmNlKCkucHJvdmlkZXIoKSwgZXhlYyk7CiB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCmluZGV4IDFjMzkyNGYuLmQ1MmY1MzcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCkBAIC05MjYsNyArOTI2LDcgQEAgdm9pZCBI ZWFwOjpkZWxldGVBbGxDb21waWxlZENvZGUoKQogICAgIGZvciAoRXhlY3V0YWJsZUJhc2UqIGN1 cnJlbnQgOiBtX2NvbXBpbGVkQ29kZSkgewogICAgICAgICBpZiAoIWN1cnJlbnQtPmlzRnVuY3Rp b25FeGVjdXRhYmxlKCkpCiAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgc3RhdGljX2Nh c3Q8RnVuY3Rpb25FeGVjdXRhYmxlKj4oY3VycmVudCktPmNsZWFyQ29kZUlmTm90Q29tcGlsaW5n KCk7CisgICAgICAgIHN0YXRpY19jYXN0PEZ1bmN0aW9uRXhlY3V0YWJsZSo+KGN1cnJlbnQpLT5j bGVhckNvZGUoKTsKICAgICB9CiAKICAgICBBU1NFUlQobV9vcGVyYXRpb25JblByb2dyZXNzID09 IEZ1bGxDb2xsZWN0aW9uIHx8IG1fb3BlcmF0aW9uSW5Qcm9ncmVzcyA9PSBOb09wZXJhdGlvbik7 CkBAIC05MzksNyArOTM5LDcgQEAgdm9pZCBIZWFwOjpkZWxldGVBbGxVbmxpbmtlZEZ1bmN0aW9u Q29kZSgpCiAgICAgZm9yIChFeGVjdXRhYmxlQmFzZSogY3VycmVudCA6IG1fY29tcGlsZWRDb2Rl KSB7CiAgICAgICAgIGlmICghY3VycmVudC0+aXNGdW5jdGlvbkV4ZWN1dGFibGUoKSkKICAgICAg ICAgICAgIGNvbnRpbnVlOwotICAgICAgICBzdGF0aWNfY2FzdDxGdW5jdGlvbkV4ZWN1dGFibGUq PihjdXJyZW50KS0+Y2xlYXJVbmxpbmtlZENvZGVGb3JSZWNvbXBpbGF0aW9uSWZOb3RDb21waWxp bmcoKTsKKyAgICAgICAgc3RhdGljX2Nhc3Q8RnVuY3Rpb25FeGVjdXRhYmxlKj4oY3VycmVudCkt PmNsZWFyVW5saW5rZWRDb2RlRm9yUmVjb21waWxhdGlvbigpOwogICAgIH0KIH0KIApkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yUnVu dGltZUFnZW50LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0lu c3BlY3RvclJ1bnRpbWVBZ2VudC5jcHAKaW5kZXggZGNmYWRkNi4uZmFhMmRkYiAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yUnVudGlt ZUFnZW50LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9J bnNwZWN0b3JSdW50aW1lQWdlbnQuY3BwCkBAIC0zMTUsOCArMzE1LDggQEAgcHVibGljOgogICAg ICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIEZ1bmN0aW9uRXhlY3V0YWJsZSogZXhlY3V0YWJs ZSA9IGpzQ2FzdDxGdW5jdGlvbkV4ZWN1dGFibGUqPihjZWxsKTsKLSAgICAgICAgZXhlY3V0YWJs ZS0+Y2xlYXJDb2RlSWZOb3RDb21waWxpbmcoKTsKLSAgICAgICAgZXhlY3V0YWJsZS0+Y2xlYXJV bmxpbmtlZENvZGVGb3JSZWNvbXBpbGF0aW9uSWZOb3RDb21waWxpbmcoKTsKKyAgICAgICAgZXhl Y3V0YWJsZS0+Y2xlYXJDb2RlKCk7CisgICAgICAgIGV4ZWN1dGFibGUtPmNsZWFyVW5saW5rZWRD b2RlRm9yUmVjb21waWxhdGlvbigpOwogICAgIH0KICAgICBpbmxpbmUgSXRlcmF0aW9uU3RhdHVz IG9wZXJhdG9yKCkoSlNDZWxsKiBjZWxsKQogICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvRXhlY3V0YWJsZS5jcHAKaW5kZXggMzUwOTJjYy4uNGMyMjVlNSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5jcHAKQEAgLTU4MCwxNyArNTgw LDggQEAgU3ltYm9sVGFibGUqIEZ1bmN0aW9uRXhlY3V0YWJsZTo6c3ltYm9sVGFibGUoQ29kZVNw ZWNpYWxpemF0aW9uS2luZCBraW5kKQogICAgIHJldHVybiBjb2RlQmxvY2tGb3Ioa2luZCktPnN5 bWJvbFRhYmxlKCk7CiB9CiAKLXZvaWQgRnVuY3Rpb25FeGVjdXRhYmxlOjpjbGVhckNvZGVJZk5v dENvbXBpbGluZygpCit2b2lkIEZ1bmN0aW9uRXhlY3V0YWJsZTo6Y2xlYXJVbmxpbmtlZENvZGVG b3JSZWNvbXBpbGF0aW9uKCkKIHsKLSAgICBpZiAoaXNDb21waWxpbmcoKSkKLSAgICAgICAgcmV0 dXJuOwotICAgIGNsZWFyQ29kZSgpOwotfQotCi12b2lkIEZ1bmN0aW9uRXhlY3V0YWJsZTo6Y2xl YXJVbmxpbmtlZENvZGVGb3JSZWNvbXBpbGF0aW9uSWZOb3RDb21waWxpbmcoKQotewotICAgIGlm IChpc0NvbXBpbGluZygpKQotICAgICAgICByZXR1cm47CiAgICAgbV91bmxpbmtlZEV4ZWN1dGFi bGUtPmNsZWFyQ29kZUZvclJlY29tcGlsYXRpb24oKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5oCmluZGV4IGU2NDQwYTAuLmJkODNhY2QgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuaAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmgKQEAgLTYzNyw4ICs2MzcsNyBA QCBwdWJsaWM6CiAgICAgc2l6ZV90IHBhcmFtZXRlckNvdW50KCkgY29uc3QgeyByZXR1cm4gbV91 bmxpbmtlZEV4ZWN1dGFibGUtPnBhcmFtZXRlckNvdW50KCk7IH0gLy8gRXhjbHVkaW5nICd0aGlz JyEKICAgICBTeW1ib2xUYWJsZSogc3ltYm9sVGFibGUoQ29kZVNwZWNpYWxpemF0aW9uS2luZCk7 CiAKLSAgICB2b2lkIGNsZWFyQ29kZUlmTm90Q29tcGlsaW5nKCk7Ci0gICAgdm9pZCBjbGVhclVu bGlua2VkQ29kZUZvclJlY29tcGlsYXRpb25JZk5vdENvbXBpbGluZygpOworICAgIHZvaWQgY2xl YXJVbmxpbmtlZENvZGVGb3JSZWNvbXBpbGF0aW9uKCk7CiAgICAgc3RhdGljIHZvaWQgdmlzaXRD aGlsZHJlbihKU0NlbGwqLCBTbG90VmlzaXRvciYpOwogICAgIHN0YXRpYyBTdHJ1Y3R1cmUqIGNy ZWF0ZVN0cnVjdHVyZShWTSYgdm0sIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEpTVmFs dWUgcHJvdG8pCiAgICAgewpAQCAtNjY5LDE3ICs2NjgsNiBAQCBwcml2YXRlOgogICAgIAogICAg IHZvaWQgZmluaXNoQ3JlYXRpb24oVk0mKTsKIAotICAgIGJvb2wgaXNDb21waWxpbmcoKQotICAg IHsKLSNpZiBFTkFCTEUoSklUKQotICAgICAgICBpZiAoIW1faml0Q29kZUZvckNhbGwgJiYgbV9j b2RlQmxvY2tGb3JDYWxsKQotICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgIGlmICgh bV9qaXRDb2RlRm9yQ29uc3RydWN0ICYmIG1fY29kZUJsb2NrRm9yQ29uc3RydWN0KQotICAgICAg ICAgICAgcmV0dXJuIHRydWU7Ci0jZW5kaWYKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0K LQogICAgIGZyaWVuZCBjbGFzcyBTY3JpcHRFeGVjdXRhYmxlOwogICAgIAogICAgIFdyaXRlQmFy cmllcjxVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZT4gbV91bmxpbmtlZEV4ZWN1dGFibGU7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAKaW5kZXggNzEyNmU4MC4uODk1YWZhZSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcApAQCAtNTAyLDcgKzUwMiw3IEBAIHN0cnVj dCBTdGFja1ByZXNlcnZpbmdSZWNvbXBpbGVyIDogcHVibGljIE1hcmtlZEJsb2NrOjpWb2lkRnVu Y3RvciB7CiAgICAgICAgIEZ1bmN0aW9uRXhlY3V0YWJsZSogZXhlY3V0YWJsZSA9IGpzQ2FzdDxG dW5jdGlvbkV4ZWN1dGFibGUqPihjZWxsKTsKICAgICAgICAgaWYgKGN1cnJlbnRseUV4ZWN1dGlu Z0Z1bmN0aW9ucy5jb250YWlucyhleGVjdXRhYmxlKSkKICAgICAgICAgICAgIHJldHVybjsKLSAg ICAgICAgZXhlY3V0YWJsZS0+Y2xlYXJDb2RlSWZOb3RDb21waWxpbmcoKTsKKyAgICAgICAgZXhl Y3V0YWJsZS0+Y2xlYXJDb2RlKCk7CiAgICAgfQogICAgIEl0ZXJhdGlvblN0YXR1cyBvcGVyYXRv cigpKEpTQ2VsbCogY2VsbCkKICAgICB7Cg==