145687 2015-06-04 23:42:19 -0700 Ignore radio buttons with different associated forms on keydown when the form element is descendants of main form. 2019-02-06 22:06:50 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 kumar.rohit webkit-unassigned cdumez jonlee rniwa wenson_hsieh oldest_to_newest 1099772 0 kumar.rohit 2015-06-04 23:42:19 -0700 Currently if a new form is encountered on key down in a radio group, the pressing keydown does not jump to another next radio button in the group. We should just ignore radio buttons with different associated forms. The associated form element of a control may have a form element as one of its descendants. It can happen in case of mixing buttons from different form control groups and other elements. Webkit should handleccomplicated cases Like, mixing buttons from different groups and other elements. <input type=radio name=foo> <input type=radio name=bar> <div><input type=radio name=foo></div> And attaching form elements to form elements <form name=alpha> <input type=radio name=foo> <input type=radio name=foo> </form> <form name=beta> <input type=radio name=foo> </form> <script> document.alpha.appendChild(document.beta); </script> 1099779 1 254347 kumar.rohit 2015-06-05 02:02:42 -0700 Created attachment 254347 Patch 1100153 2 254347 darin 2015-06-06 22:45:23 -0700 Comment on attachment 254347 Patch Change seems OK. One small problem is that we’ll now always traverse the entire document once we are past the last radio button. That could take a long time. 1100337 3 kumar.rohit 2015-06-08 04:05:01 -0700 Thanks Darin. I am working on a patch that will cycle the radio button in a group on "downArrow"/"upArrow" keydown event when we reach the last/first radio button in a group. That should solve the entire document traversal issue. I will raise the bug and submit it soon. 1503237 4 lforschler 2019-02-06 09:18:44 -0800 Mass move bugs into the DOM component. 1503638 5 254347 rniwa 2019-02-06 22:06:50 -0800 Comment on attachment 254347 Patch This 3.5 year old patch is probably not going to land properly. 254347 2015-06-05 02:02:42 -0700 2019-02-06 22:06:50 -0800 Patch bug-145687-20150605143447.patch text/plain 6599 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDgwOWFkNGQ4MTY0YjY3 ZjYyOTIzNTQwOGZkMjg0ZWRmYzQyOTU5NC4uYTVkZGRkZmE2MDM5YjIyNGZjZDZlOWJiNDcwNmE0 NTAwNDAzY2UxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA2LTA1ICBSb2hp dCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgorCisgICAgICAgIElnbm9yZSByYWRp byBidXR0b25zIHdpdGggZGlmZmVyZW50IGFzc29jaWF0ZWQgZm9ybXMgb24ga2V5ZG93biB3aGVu IHRoZSBmb3JtIGVsZW1lbnQgaXMgZGVzY2VuZGFudHMgb2YgbWFpbiBmb3JtLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1Njg3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9y YWRpby9yYWRpby1ncm91cC1pZ25vcmUtZGVzY2VuZGFudC1mb3JtLW9uLWtleWRvd24uaHRtbAor CisgICAgICAgICogaHRtbC9SYWRpb0lucHV0VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS YWRpb0lucHV0VHlwZTo6aGFuZGxlS2V5ZG93bkV2ZW50KToKKwogMjAxNS0wNi0wMyAgQ2FybG9z IEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RL XSBbV2F5bGFuZF0gQnVpbGQgaXMgYnJva2VuIG9uIHRydW5rCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL1JhZGlvSW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvUmFk aW9JbnB1dFR5cGUuY3BwCmluZGV4IDhmMjc2ZTc4NjkxNjQ4YzE3YzRkOWZjMjFiOTBkN2I1Zjdj MjIwNzcuLjcwYTQ1YmI3NGVkZjc4YmJiYTU2NGQyMDQ5MDFiMWE4ZjY4NWIyMTcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvUmFkaW9JbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvUmFkaW9JbnB1dFR5cGUuY3BwCkBAIC04MCwxNiArODAsMTEgQEAgdm9pZCBS YWRpb0lucHV0VHlwZTo6aGFuZGxlS2V5ZG93bkV2ZW50KEtleWJvYXJkRXZlbnQqIGV2ZW50KQog ICAgIC8vIG9mIG1hbGZvcm1lZCBIVE1MLgogICAgIE5vZGUqIG5vZGUgPSAmZWxlbWVudCgpOwog ICAgIHdoaWxlICgobm9kZSA9IChmb3J3YXJkID8gTm9kZVRyYXZlcnNhbDo6bmV4dCgqbm9kZSkg OiBOb2RlVHJhdmVyc2FsOjpwcmV2aW91cygqbm9kZSkpKSkgewotICAgICAgICAvLyBPbmNlIHdl IGVuY291bnRlciBhIGZvcm0gZWxlbWVudCwgd2Uga25vdyB3ZSdyZSB0aHJvdWdoLgotICAgICAg ICBpZiAoaXM8SFRNTEZvcm1FbGVtZW50Pigqbm9kZSkpCi0gICAgICAgICAgICBicmVhazsKICAg ICAgICAgLy8gTG9vayBmb3IgbW9yZSByYWRpbyBidXR0b25zLgogICAgICAgICBpZiAoIWlzPEhU TUxJbnB1dEVsZW1lbnQ+KCpub2RlKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBS ZWZQdHI8SFRNTElucHV0RWxlbWVudD4gaW5wdXRFbGVtZW50ID0gZG93bmNhc3Q8SFRNTElucHV0 RWxlbWVudD4obm9kZSk7Ci0gICAgICAgIGlmIChpbnB1dEVsZW1lbnQtPmZvcm0oKSAhPSBlbGVt ZW50KCkuZm9ybSgpKQotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGlmIChpbnB1dEVsZW1l bnQtPmlzUmFkaW9CdXR0b24oKSAmJiBpbnB1dEVsZW1lbnQtPm5hbWUoKSA9PSBlbGVtZW50KCku bmFtZSgpICYmIGlucHV0RWxlbWVudC0+aXNGb2N1c2FibGUoKSkgeworICAgICAgICBpZiAoaW5w dXRFbGVtZW50LT5mb3JtKCkgPT0gZWxlbWVudCgpLmZvcm0oKSAmJiBpbnB1dEVsZW1lbnQtPmlz UmFkaW9CdXR0b24oKSAmJiBpbnB1dEVsZW1lbnQtPm5hbWUoKSA9PSBlbGVtZW50KCkubmFtZSgp ICYmIGlucHV0RWxlbWVudC0+aXNGb2N1c2FibGUoKSkgewogICAgICAgICAgICAgZWxlbWVudCgp LmRvY3VtZW50KCkuc2V0Rm9jdXNlZEVsZW1lbnQoaW5wdXRFbGVtZW50KTsKICAgICAgICAgICAg IGlucHV0RWxlbWVudC0+ZGlzcGF0Y2hTaW11bGF0ZWRDbGljayhldmVudCwgU2VuZE5vRXZlbnRz LCBEb05vdFNob3dQcmVzc2VkTG9vayk7CiAgICAgICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhh bmRsZWQoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwppbmRleCA3YTFhNWI0YmNjNzBiYjdlZmI3NGI1ZjVmZTY1Y2Q2NmQ2YWMxZTA0 Li5hMzk0ZmYyMjE2ZWY0NmVhZmUxOWM2ODBmYmEwNzIzZDdkYmMzNzg0IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTUtMDYtMDUgIFJvaGl0IEt1bWFyICA8a3VtYXIucm9oaXRAc2Ftc3VuZy5j b20+CisKKyAgICAgICAgSWdub3JlIHJhZGlvIGJ1dHRvbnMgd2l0aCBkaWZmZXJlbnQgYXNzb2Np YXRlZCBmb3JtcyBvbiBrZXlkb3duIHdoZW4gdGhlIGZvcm0gZWxlbWVudCBpcyBkZXNjZW5kYW50 cyBvZiBtYWluIGZvcm0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDU2ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGZhc3QvZm9ybXMvcmFkaW8vcmFkaW8tZ3JvdXAtaWdub3JlLWRlc2NlbmRhbnQt Zm9ybS1vbi1rZXlkb3duLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jt cy9yYWRpby9yYWRpby1ncm91cC1pZ25vcmUtZGVzY2VuZGFudC1mb3JtLW9uLWtleWRvd24uaHRt bDogQWRkZWQuCisKIDIwMTUtMDYtMDQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4K IAogICAgICAgICBjc3MzL2ZpbHRlcnMvYmFja2Ryb3AvYmFja2Ryb3AtZmlsdGVyLXdpdGgtbWFz ay5odG1sIGlzIG1pc3NpbmcgdGhlIG1hc2sgbGF5ZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL3JhZGlvL3JhZGlvLWdyb3VwLWlnbm9yZS1kZXNjZW5kYW50LWZvcm0tb24t a2V5ZG93bi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JhZGlvL3JhZGlv LWdyb3VwLWlnbm9yZS1kZXNjZW5kYW50LWZvcm0tb24ta2V5ZG93bi1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uMDNiMTNiMjhlZjhhMzhkMGU4ZWQ1YmY5OWM4ZTk3MzQ2YjRlMGYwNAotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFkaW8vcmFkaW8tZ3JvdXAtaWdu b3JlLWRlc2NlbmRhbnQtZm9ybS1vbi1rZXlkb3duLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIz IEBACitUZXN0cyBhZnRlciBzZWxlY3RpbmcgcmFkaW8gYnV0dG9uLCBvbiBwcmVzc2luZyBkb3du a2V5IG9yIHVwa2V5IGl0IGlnbm9yZXMgZGVzY2VuZGFudCBhc3NvY2lhdGVkIGZvcm0gYW5kIHNl bGVjdCBzYW1lIGZvcm0gcmFkaW8gYnV0dG9uCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBh IHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4K KworCitQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJiYW5hbmEiKS5jaGVja2VkIGlzIHRy dWUKK1BBU1MgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNoZXJyeSIpLmNoZWNrZWQgaXMgdHJ1 ZQorUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYmFuYW5hIikuY2hlY2tlZCBpcyB0cnVl CitQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkZWx0YSIpLmNoZWNrZWQgaXMgdHJ1ZQor UEFTUyBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY3VjdW1iZXIiKS5jaGVja2VkIGlzIHRydWUK K1BBU1MgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRlbHRhIikuY2hlY2tlZCBpcyB0cnVlCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKworCisKKwor CisKKworCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFkaW8vcmFkaW8t Z3JvdXAtaWdub3JlLWRlc2NlbmRhbnQtZm9ybS1vbi1rZXlkb3duLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL3JhZGlvL3JhZGlvLWdyb3VwLWlnbm9yZS1kZXNjZW5kYW50LWZvcm0tb24t a2V5ZG93bi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjU2ZWQwN2RjNmQ2NjRmMTI1YzQyZDlkMjVlM2Q1NDcz NjY4MWUzZmIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JhZGlv L3JhZGlvLWdyb3VwLWlnbm9yZS1kZXNjZW5kYW50LWZvcm0tb24ta2V5ZG93bi5odG1sCkBAIC0w LDAgKzEsNTEgQEAKKzwhRE9DVFlQRSBodG1sPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgCis8Ym9keT4gICAgCis8c2NyaXB0IHNyYz0iLi4vcmVzb3Vy Y2VzL2NvbW1vbi5qcyI+PC9zY3JpcHQ+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAorPHNjcmlwdCBzcmM9 Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+ICAKKworPGZvcm0g bmFtZT1hbHBoYT4KKzxpbnB1dCB0eXBlPSJyYWRpbyIgbmFtZT0iZnJ1aXQiIGlkPSJhcHBsZSI+ PGJyPgorPGlucHV0IHR5cGU9InJhZGlvIiBuYW1lPSJmcnVpdCIgaWQ9ImJhbmFuYSI+PGJyPgor PGlucHV0IHR5cGU9InJhZGlvIiBuYW1lPSJmcnVpdCIgaWQ9ImNoZXJyeSI+PGJyPgorPGlucHV0 IHR5cGU9InJhZGlvIiBuYW1lPSJmcnVpdCIgZm9ybT1iZXRhIGlkPSJ0b21hdG8iPjxicj4KKzxp bnB1dCB0eXBlPSJyYWRpbyIgbmFtZT0iZnJ1aXQiIGZvcm09YmV0YSBpZD0iZGVsdGEiPjxicj4K KzxpbnB1dCB0eXBlPSJjaGVja2JveCIgbmFtZT0idmVoaWNsZSIgdmFsdWU9IkJpa2UiIGlkPSJj aGVja2JveC0xIj48YnI+Cis8L2Zvcm0+Cis8Zm9ybSBuYW1lPWJldGE+CisgICAgPGlucHV0IHR5 cGU9InJhZGlvIiBuYW1lPSJmcnVpdCIgaWQ9InB1bXBraW4iPjxicj4KKzwvZm9ybT4KKzxpbnB1 dCB0eXBlPSJyYWRpbyIgbmFtZT0iZnJ1aXQiIGZvcm09YWxwaGEgaWQ9ImN1Y3VtYmVyIj48YnI+ CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAorPHNjcmlwdD4gCitkb2N1 bWVudC5hbHBoYS5pbnNlcnRCZWZvcmUoZG9jdW1lbnQuYmV0YSwgZG9jdW1lbnQuYWxwaGEuZnJ1 aXRbMl0pOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCitkZXNjcmlwdGlvbign VGVzdHMgYWZ0ZXIgc2VsZWN0aW5nIHJhZGlvIGJ1dHRvbiwgb24gcHJlc3NpbmcgZG93bmtleSBv ciB1cGtleSBpdCBpZ25vcmVzIGRlc2NlbmRhbnQgYXNzb2NpYXRlZCBmb3JtIGFuZCBzZWxlY3Qg c2FtZSBmb3JtIHJhZGlvIGJ1dHRvbicpOworCitjbGlja0VsZW1lbnQoZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ2JhbmFuYScpKTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCitz aG91bGRCZVRydWUoJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJiYW5hbmEiKS5jaGVja2VkJyk7 CisgICAgICAgICAgICAgICAgIAorLy9ldmVudFNlbmRlci5rZXlEb3duKCdcdCcpOworZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoImJhbmFuYSIpLmZvY3VzKCk7CitldmVudFNlbmRlci5rZXlEb3du KCdkb3duQXJyb3cnKTsgICAgICAgCitzaG91bGRCZVRydWUoJ2RvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJjaGVycnkiKS5jaGVja2VkJyk7CisKK2V2ZW50U2VuZGVyLmtleURvd24oJ3VwQXJyb3cn KTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCitz aG91bGRCZVRydWUoJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJiYW5hbmEiKS5jaGVja2VkJyk7 CisKK2NsaWNrRWxlbWVudChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZGVsdGEnKSk7CitzaG91 bGRCZVRydWUoJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkZWx0YSIpLmNoZWNrZWQnKTsKKwor ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRlbHRhIikuZm9jdXMoKTsKK2V2ZW50U2VuZGVyLmtl eURvd24oJ2Rvd25BcnJvdycpOworc2hvdWxkQmVUcnVlKCdkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgiY3VjdW1iZXIiKS5jaGVja2VkJyk7CisKK2V2ZW50U2VuZGVyLmtleURvd24oJ3VwQXJyb3cn KTsKK3Nob3VsZEJlVHJ1ZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRlbHRhIikuY2hlY2tl ZCcpOworCis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PiAKKzwvYm9keT4KKzwvaHRtbD4KKwo=