145682 2015-06-04 20:26:08 -0700 [CMake] Error when gst-plugins-base is missing is too confusing 2015-06-30 00:19:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 1 mcatanzaro webkit-unassigned cgarcia clopez mcatanzaro mrobinson pnormand oldest_to_newest 1099737 0 mcatanzaro 2015-06-04 20:26:08 -0700 If gstreamer is installed but gst-plugins-base is not, we get a horrible build error. We should do better than this. CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: GSTREAMER_APP_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore GSTREAMER_AUDIO_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore GSTREAMER_FFT_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore GSTREAMER_PBUTILS_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore GSTREAMER_TAG_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore GSTREAMER_VIDEO_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore -- Configuring incomplete, errors occurred! See also "/home/mcatanzaro/WebKit/WebKitBuild/Release/CMakeFiles/CMakeOutput.log". See also "/home/mcatanzaro/WebKit/WebKitBuild/Release/CMakeFiles/CMakeError.log". 1101358 1 mcatanzaro 2015-06-11 12:37:08 -0700 *** Bug 145887 has been marked as a duplicate of this bug. *** 1102910 2 pnormand 2015-06-18 07:26:37 -0700 CMake should error out early if, for instance, the gstreamer-video-1.0 pkgconfig file isn't found. 1102915 3 pnormand 2015-06-18 07:39:38 -0700 I'm starting to work on a small (I hope) patch for this. 1102920 4 255116 pnormand 2015-06-18 08:29:10 -0700 Created attachment 255116 patch 1102929 5 mcatanzaro 2015-06-18 09:20:36 -0700 Patch LGTM. 1105357 6 pnormand 2015-06-29 00:52:33 -0700 Hi Carlos, can you please have a look at this patch? 1105641 7 pnormand 2015-06-30 00:19:08 -0700 Committed r186110: <http://trac.webkit.org/changeset/186110> 255116 2015-06-18 08:29:10 -0700 2015-06-29 01:29:42 -0700 patch patch.patch text/plain 2763 pnormand RnJvbSBjMGVmNzk5MjA4OWQ4ZGY5MmI5ZTQwNjU0ZjRjMmM0ZjVjNTJkYTJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDE4IEp1biAyMDE1IDE3OjI4OjExICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgfCAxMCArKysrKysrKysr CiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSB8IDE5ICsrKysrKysrKysrKysrKysrLS0K IDIgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNWRlMjJmNi4uOTU5MTNmNiAxMDA2 NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1 LTA2LTE4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAg ICBbQ01ha2VdIEVycm9yIHdoZW4gZ3N0LXBsdWdpbnMtYmFzZSBpcyBtaXNzaW5nIGlzIHRvbyBj b25mdXNpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0NTY4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6IEVycm9yIG91dCBpZiB0aGUgcmVxdWly ZWQKKyAgICAgICAgR1N0cmVhbWVyIGxpYnJhcmllcyBhcmUgbm90IGZvdW5kIG9uIHRoZSBob3N0 LgorCiAyMDE1LTA2LTE2ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgog CiAgICAgICAgIFtFRkxdIFJlbW92ZSBkdXBsaWNhdGVkIFBVQkxJQyBhcmd1bWVudCBpbiBPcHRp b25zRWZsLmNtYWtlCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBi L1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGMzZmFiNjguLmE1MDk1MjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFr ZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0zNTIsMTggKzM1MiwzMSBAQCBlbmRpZiAoKQogCiBpZiAo RU5BQkxFX1ZJREVPIE9SIEVOQUJMRV9XRUJfQVVESU8pCiAgICAgc2V0KEdTVFJFQU1FUl9DT01Q T05FTlRTIGFwcCBwYnV0aWxzKQotICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9HU1RS RUFNRVIgVFJVRSkKKwogICAgIGlmIChFTkFCTEVfVklERU8pCiAgICAgICAgIGxpc3QoQVBQRU5E IEdTVFJFQU1FUl9DT01QT05FTlRTIHZpZGVvIG1wZWd0cyB0YWcgZ2wpCiAgICAgZW5kaWYgKCkK IAogICAgIGlmIChFTkFCTEVfV0VCX0FVRElPKQogICAgICAgICBsaXN0KEFQUEVORCBHU1RSRUFN RVJfQ09NUE9ORU5UUyBhdWRpbyBmZnQpCi0gICAgICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxE KFVTRV9XRUJBVURJT19HU1RSRUFNRVIgVFJVRSkKICAgICBlbmRpZiAoKQogCiAgICAgZmluZF9w YWNrYWdlKEdTdHJlYW1lciAxLjAuMyBSRVFVSVJFRCBDT01QT05FTlRTICR7R1NUUkVBTUVSX0NP TVBPTkVOVFN9KQogCisgICAgaWYgKEVOQUJMRV9XRUJfQVVESU8pCisgICAgICAgIGlmIChOT1Qg UENfR1NUUkVBTUVSX0FVRElPX0ZPVU5EIE9SIE5PVCBQQ19HU1RSRUFNRVJfRkZUX0ZPVU5EKQor ICAgICAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiV2ViQXVkaW8gcmVxdWlyZXMgdGhlIGF1 ZGlvIGFuZCBmZnQgR1N0cmVhbWVyIGxpYnJhcmllcy4gUGxlYXNlIGNoZWNrIHlvdXIgZ3N0LXBs dWdpbnMtYmFzZSBpbnN0YWxsYXRpb24uIikKKyAgICAgICAgZWxzZSAoKQorICAgICAgICAgICAg U0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX1dFQkFVRElPX0dTVFJFQU1FUiBUUlVFKQorICAg ICAgICBlbmRpZiAoKQorICAgIGVuZGlmICgpCisKKyAgICBpZiAoRU5BQkxFX1ZJREVPKQorICAg ICAgICBpZiAoTk9UIFBDX0dTVFJFQU1FUl9BUFBfRk9VTkQgT1IgTk9UIFBDX0dTVFJFQU1FUl9Q QlVUSUxTX0ZPVU5EIE9SIE5PVCBQQ19HU1RSRUFNRVJfVEFHX0ZPVU5EIE9SIE5PVCBQQ19HU1RS RUFNRVJfVklERU9fRk9VTkQpCisgICAgICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJWaWRl byBwbGF5YmFjayByZXF1aXJlcyB0aGUgZm9sbG93aW5nIEdTdHJlYW1lciBsaWJyYXJpZXM6IGFw cCwgcGJ1dGlscywgdGFnLCB2aWRlby4gUGxlYXNlIGNoZWNrIHlvdXIgZ3N0LXBsdWdpbnMtYmFz ZSBpbnN0YWxsYXRpb24uIikKKyAgICAgICAgZW5kaWYgKCkKKyAgICBlbmRpZiAoKQorCiAgICAg aWYgKFVTRV9HU1RSRUFNRVJfTVBFR1RTKQogICAgICAgICBpZiAoTk9UIFBDX0dTVFJFQU1FUl9N UEVHVFNfRk9VTkQpCiAgICAgICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJHU3RyZWFtZXIg TVBFRy1UUyBpcyBuZWVkZWQgZm9yIFVTRV9HU1RSRUFNRVJfTVBFR1RTLiIpCkBAIC0zNzUsNiAr Mzg4LDggQEAgaWYgKEVOQUJMRV9WSURFTyBPUiBFTkFCTEVfV0VCX0FVRElPKQogICAgICAgICAg ICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiR1N0cmVhbWVyR0wgaXMgbmVlZGVkIGZvciBVU0VfR1NU UkVBTUVSX0dMLiIpCiAgICAgICAgIGVuZGlmICgpCiAgICAgZW5kaWYgKCkKKworICAgIFNFVF9B TkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9HU1RSRUFNRVIgVFJVRSkKIGVuZGlmICgpCiAKIGlmIChF TkFCTEVfWDExX1RBUkdFVCkKLS0gCjIuMS40