145680 2015-06-04 18:52:52 -0700 check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code 2015-06-05 04:08:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez aestes bfulgham commit-queue ddkilzer fpizlo glenn ysuzuki oldest_to_newest 1099723 0 clopez 2015-06-04 18:52:52 -0700 We should recommend using nullptr instead of 0 or null in C++ code per http://www.webkit.org/coding/coding-style.html#zero-null 1099726 1 254330 clopez 2015-06-04 19:03:07 -0700 Created attachment 254330 Patch 1099771 2 254330 bfulgham 2015-06-04 23:22:45 -0700 Comment on attachment 254330 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254330&action=review R=me. > Tools/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=145680 This code seems to handle null -> nullptr, but does it really suggest nullptr instead of 0? 1099788 3 clopez 2015-06-05 03:46:18 -0700 (In reply to comment #2) > This code seems to handle null -> nullptr, but does it really suggest > nullptr instead of 0? Good point. It only suggest using nullptr instead of NULL (the previous code was suggesting to use 0 instead of NULL) 1099789 4 clopez 2015-06-05 03:59:58 -0700 Now is clearer. 1099790 5 clopez 2015-06-05 04:07:23 -0700 Committed r185245: <http://trac.webkit.org/changeset/185245> 254330 2015-06-04 19:03:07 -0700 2015-06-05 04:08:36 -0700 Patch bug-145680-20150605040245.patch text/plain 5232 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MTk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmYxZWUxYjMyMWUyYWJjMTJmOTI5OTBiOGUwY2M1ODcz ZGIzZTMxNS4uZDk5ZmVhYTFlMzZkM2UzM2VmZTBhZTYwNTAxMTc5NGNkYjgzZmNkNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTA2LTA0ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBzaG91bGQgcmVjb21tZW5kIHVz aW5nIG51bGxwdHIgaW5zdGVhZCBvZiAwIG9yIG51bGwgaW4gQysrIGNvZGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTY4MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19mb3JfbnVsbCk6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6CisgICAg ICAgIChXZWJLaXRTdHlsZVRlc3QudGVzdF9udWxsX2ZhbHNlX3plcm8pOgorCiAyMDE1LTA2LTAz ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIEZpeCBv cHRpb25zIGluIGJ1aWxkLWpzYyBmb3IgQ01ha2UgYnVpbGRzCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IDAxNTQyMjVmZjU0Yzc5ZWEyYmVhMzli ZjEwMzA1NDJhZDJhOTcwZTIuLmE3NTY5ZWMzZmJmYTdhMDZmMDEyZDZkZjI0NzdlYjBiYjJjNmFh MWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBA IC0yNzIyLDcgKzI3MjIsNyBAQCBkZWYgY2hlY2tfZm9yX251bGwoY2xlYW5fbGluZXMsIGxpbmVf bnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcik6CiAgICAgaWYgc2VhcmNoKHInXGJOVUxMXGInLCBs aW5lKToKICAgICAgICAgIyBGSVhNRTogV2Ugc2hvdWxkIHJlY29tbWVuZCB1c2luZyBudWxscHRy IGluc3RlYWQgb2YgTlVMTCBpbiBDKysgY29kZSBwZXIKICAgICAgICAgIyA8aHR0cDovL3d3dy53 ZWJraXQub3JnL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbCN6ZXJvLW51bGw+LgotICAgICAgICBl cnJvcihsaW5lX251bWJlciwgJ3JlYWRhYmlsaXR5L251bGwnLCA1LCAnVXNlIDAgaW5zdGVhZCBv ZiBOVUxMLicpCisgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvbnVsbCcs IDUsICdVc2UgbnVsbHB0ciBpbnN0ZWFkIG9mIE5VTEwuJykKICAgICAgICAgcmV0dXJuCiAKICAg ICBsaW5lID0gY2xlYW5fbGluZXMucmF3X2xpbmVzW2xpbmVfbnVtYmVyXQpAQCAtMjczMCw5ICsy NzMwLDcgQEAgZGVmIGNoZWNrX2Zvcl9udWxsKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmls ZV9zdGF0ZSwgZXJyb3IpOgogICAgICMgbWF0Y2hlcywgdGhlbiBkbyB0aGUgY2hlY2sgd2l0aCBz dHJpbmdzIGNvbGxhcHNlZCB0byBhdm9pZCBnaXZpbmcgZXJyb3JzIGZvcgogICAgICMgTlVMTHMg b2NjdXJyaW5nIGluIHN0cmluZ3MuCiAgICAgaWYgc2VhcmNoKHInXGJOVUxMXGInLCBsaW5lKSBh bmQgc2VhcmNoKHInXGJOVUxMXGInLCBDbGVhbnNlZExpbmVzLmNvbGxhcHNlX3N0cmluZ3MobGlu ZSkpOgotICAgICAgICAjIEZJWE1FOiBXZSBzaG91bGQgcmVjb21tZW5kIHVzaW5nIG51bGxwdHIg aW5zdGVhZCBvZiAwIG9yIG51bGwgaW4gQysrIGNvZGUgcGVyCi0gICAgICAgICMgPGh0dHA6Ly93 d3cud2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwjemVyby1udWxsPi4KLSAgICAg ICAgZXJyb3IobGluZV9udW1iZXIsICdyZWFkYWJpbGl0eS9udWxsJywgNCwgJ1VzZSAwIG9yIG51 bGwgaW5zdGVhZCBvZiBOVUxMIChldmVuIGluICpjb21tZW50cyopLicpCisgICAgICAgIGVycm9y KGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvbnVsbCcsIDQsICdVc2UgbnVsbHB0ciBpbnN0ZWFk IG9mIE5VTEwgKGV2ZW4gaW4gKmNvbW1lbnRzKikuJykKIAogZGVmIGdldF9saW5lX3dpZHRoKGxp bmUpOgogICAgICIiIkRldGVybWluZXMgdGhlIHdpZHRoIG9mIHRoZSBsaW5lIGluIGNvbHVtbiBw b3NpdGlvbnMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDIwMmFjZDM5Mjk0NTMyM2M5NDZmNGMyYzZlZjQzZjMx NzczODk4Y2QuLjdhMTY4YTI3OWVjZmQ3ZjJhODY2MzI5ZGVkZTVmNWYxZjZiMDU3ZGQgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0 LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0 ZXN0LnB5CkBAIC00NTk5LDIzICs0NTk5LDIzIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBT dHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICcnKQogCiAgICAgZGVmIHRlc3RfbnVsbF9mYWxz ZV96ZXJvKHNlbGYpOgotICAgICAgICAjIDEuIEluIEMrKywgdGhlIG51bGwgcG9pbnRlciB2YWx1 ZSBzaG91bGQgYmUgd3JpdHRlbiBhcyAwLiBJbiBDLAorICAgICAgICAjIDEuIEluIEMrKywgdGhl IG51bGwgcG9pbnRlciB2YWx1ZSBzaG91bGQgYmUgd3JpdHRlbiBhcyBudWxscHRyLiBJbiBDLAog ICAgICAgICAjICAgIGl0IHNob3VsZCBiZSB3cml0dGVuIGFzIE5VTEwuIEluIE9iamVjdGl2ZS1D IGFuZCBPYmplY3RpdmUtQysrLAogICAgICAgICAjICAgIGZvbGxvdyB0aGUgZ3VpZGVsaW5lIGZv ciBDIG9yIEMrKywgcmVzcGVjdGl2ZWx5LCBidXQgdXNlIG5pbCB0bwogICAgICAgICAjICAgIHJl cHJlc2VudCBhIG51bGwgT2JqZWN0aXZlLUMgb2JqZWN0LgogICAgICAgICBzZWxmLmFzc2VydF9s aW50KAogICAgICAgICAgICAgJ2Z1bmN0aW9uQ2FsbChOVUxMKScsCi0gICAgICAgICAgICAnVXNl IDAgaW5zdGVhZCBvZiBOVUxMLicKKyAgICAgICAgICAgICdVc2UgbnVsbHB0ciBpbnN0ZWFkIG9m IE5VTEwuJwogICAgICAgICAgICAgJyAgW3JlYWRhYmlsaXR5L251bGxdIFs1XScsCiAgICAgICAg ICAgICAnZm9vLmNwcCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAgICAgICAi Ly8gRG9uJ3QgdXNlIE5VTEwgaW4gY29tbWVudHMgc2luY2UgaXQgaXNuJ3QgaW4gY29kZS4iLAot ICAgICAgICAgICAgJ1VzZSAwIG9yIG51bGwgaW5zdGVhZCBvZiBOVUxMIChldmVuIGluICpjb21t ZW50cyopLicKKyAgICAgICAgICAgICdVc2UgbnVsbHB0ciBpbnN0ZWFkIG9mIE5VTEwgKGV2ZW4g aW4gKmNvbW1lbnRzKikuJwogICAgICAgICAgICAgJyAgW3JlYWRhYmlsaXR5L251bGxdIFs0XScs CiAgICAgICAgICAgICAnZm9vLmNwcCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAg ICAgICAgICAnIkEgc3RyaW5nIHdpdGggTlVMTCIgLy8gYW5kIGEgY29tbWVudCB3aXRoIE5VTEwg aXMgdHJpY2t5IHRvIGZsYWcgY29ycmVjdGx5IGluIGNwcF9zdHlsZS4nLAotICAgICAgICAgICAg J1VzZSAwIG9yIG51bGwgaW5zdGVhZCBvZiBOVUxMIChldmVuIGluICpjb21tZW50cyopLicKKyAg ICAgICAgICAgICdVc2UgbnVsbHB0ciBpbnN0ZWFkIG9mIE5VTEwgKGV2ZW4gaW4gKmNvbW1lbnRz KikuJwogICAgICAgICAgICAgJyAgW3JlYWRhYmlsaXR5L251bGxdIFs0XScsCiAgICAgICAgICAg ICAnZm9vLmNwcCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCkBAIC00NzI2LDExICs0NzI2 LDExIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAg ICAgICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAogICAgICAgICAgICAgJ2d0a193aWRn ZXRfc3R5bGVfZ2V0X3Byb3BlcnR5KHN0eWxlLCBOVUxMLCBOVUxMKTsnLAotICAgICAgICAgICAg J1VzZSAwIGluc3RlYWQgb2YgTlVMTC4gIFtyZWFkYWJpbGl0eS9udWxsXSBbNV0nLAorICAgICAg ICAgICAgJ1VzZSBudWxscHRyIGluc3RlYWQgb2YgTlVMTC4gIFtyZWFkYWJpbGl0eS9udWxsXSBb NV0nLAogICAgICAgICAgICAgJ2Zvby5jcHAnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAog ICAgICAgICAgICAgJ2d0a193aWRnZXRfc3R5bGVfZ2V0X3ZhbGlzdChzdHlsZSwgTlVMTCwgTlVM TCk7JywKLSAgICAgICAgICAgICdVc2UgMCBpbnN0ZWFkIG9mIE5VTEwuICBbcmVhZGFiaWxpdHkv bnVsbF0gWzVdJywKKyAgICAgICAgICAgICdVc2UgbnVsbHB0ciBpbnN0ZWFkIG9mIE5VTEwuICBb cmVhZGFiaWxpdHkvbnVsbF0gWzVdJywKICAgICAgICAgICAgICdmb28uY3BwJykKIAogICAgICAg ICAjIDIuIEMrKyBhbmQgQyBib29sIHZhbHVlcyBzaG91bGQgYmUgd3JpdHRlbiBhcyB0cnVlIGFu ZApAQCAtNDc5MSwxMCArNDc5MSwxMCBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVU ZXN0QmFzZSk6CiAgICAgICAgICAgICAnJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKICAg ICAgICAgICAgICdpZiAoTElLRUxZKGZvbyA9PSBOVUxMKSknLAotICAgICAgICAgICAgJ1VzZSAw IGluc3RlYWQgb2YgTlVMTC4gIFtyZWFkYWJpbGl0eS9udWxsXSBbNV0nKQorICAgICAgICAgICAg J1VzZSBudWxscHRyIGluc3RlYWQgb2YgTlVMTC4gIFtyZWFkYWJpbGl0eS9udWxsXSBbNV0nKQog ICAgICAgICBzZWxmLmFzc2VydF9saW50KAogICAgICAgICAgICAgJ2lmIChVTkxJS0VMWShmb28g PT0gTlVMTCkpJywKLSAgICAgICAgICAgICdVc2UgMCBpbnN0ZWFkIG9mIE5VTEwuICBbcmVhZGFi aWxpdHkvbnVsbF0gWzVdJykKKyAgICAgICAgICAgICdVc2UgbnVsbHB0ciBpbnN0ZWFkIG9mIE5V TEwuICBbcmVhZGFiaWxpdHkvbnVsbF0gWzVdJykKIAogICAgIGRlZiB0ZXN0X2RpcmVjdGl2ZV9p bmRlbnRhdGlvbihzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgK