145675 2015-06-04 17:04:36 -0700 Layout tests fullscreen/video-controls-drag.html and media/video-fullscreeen-only-controls.html fail on WK1 and WK2 2015-06-05 11:39:42 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sabouhallawa eric.carlson ap commit-queue dino eric.carlson oldest_to_newest 1099679 0 sabouhallawa 2015-06-04 17:04:36 -0700 These tests began to fail after https://trac.webkit.org/changeset/185207 https://trac.webkit.org/changeset/185220 1099844 1 254360 eric.carlson 2015-06-05 10:17:06 -0700 Created attachment 254360 Proposed patch. 1099856 2 254360 ap 2015-06-05 10:53:17 -0700 Comment on attachment 254360 Proposed patch. Please update test expectations too. 1099858 3 ap 2015-06-05 10:53:55 -0700 Sorry, I didn't notice that you did, was looking for that at the bottom of the patch for some reason. 1099884 4 254360 commit-queue 2015-06-05 11:39:37 -0700 Comment on attachment 254360 Proposed patch. Clearing flags on attachment: 254360 Committed r185258: <http://trac.webkit.org/changeset/185258> 1099885 5 commit-queue 2015-06-05 11:39:42 -0700 All reviewed patches have been landed. Closing bug. 254360 2015-06-05 10:17:06 -0700 2015-06-05 11:39:37 -0700 Proposed patch. fix_broken_tests_patch.txt text/plain 5089 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NTI0NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA2LTA1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCB0ZXN0cyBm dWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLWRyYWcuaHRtbCBhbmQgbWVkaWEvdmlkZW8tZnVsbHNj cmVlZW4tb25seS1jb250cm9scy5odG1sCisgICAgICAgIGZhaWwgb24gV0sxIGFuZCBXSzIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTY3NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgY2hhbmdlcyBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogTW9kdWxl cy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qczoKKyAgICAgICAgKENvbnRyb2xs ZXIucHJvdG90eXBlLnVwZGF0ZUNvbnRyb2xzKTogVXNlIHNob3VsZEhhdmVDb250cm9scygpIHRv IHRlc3QgaWYgY29udHJvbHMgc2hvdWxkCisgICAgICAgICAgYmUgdmlzaWJsZS4KKyAgICAgICAg KENvbnRyb2xsZXIucHJvdG90eXBlLmhhbmRsZVdyYXBwZXJNb3VzZU1vdmUpOiBEb24ndCByZXR1 cm4gZWFybHkgd2hlbiBpbiBmdWxsc2NyZWVuLgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5 cGUudXBkYXRlRnVsbHNjcmVlbkJ1dHRvbnMpOiBEcml2ZS1ieSBmaXg6IGFsd2F5cyBzaG93IHRo ZSAoZXhpdCkgZnVsbHNjcmVlbgorICAgICAgICAgIGJ1dHRvbiB3aGVuIGluIGZ1bGxzY3JlZW4u CisgICAgICAgICAgCisKIDIwMTUtMDYtMDUgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdv QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NTUyBHcmlkIExheW91dF0gU3VwcG9ydCBkb3RzIHNl cXVlbmNlcyBpbiBncmlkLXRlbXBsYXRlLWFyZWFzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJ KHJldmlzaW9uIDE4NTI0NSkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9s cy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTYxMiw3ICs2MTIsNyBA QCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy51cGRhdGVMYXlvdXRGb3JE aXNwbGF5ZWRXaWR0aCgpOwogICAgICAgICB0aGlzLnNldE5lZWRzVGltZWxpbmVNZXRyaWNzVXBk YXRlKCk7CiAKLSAgICAgICAgaWYgKHRoaXMudmlkZW8uY29udHJvbHMgfHwgdGhpcy5pc0Z1bGxT Y3JlZW4oKSkgeworICAgICAgICBpZiAodGhpcy5zaG91bGRIYXZlQ29udHJvbHMoKSkgewogICAg ICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbC5jbGFzc0xpc3QuYWRkKHRoaXMuQ2xhc3NOYW1l cy5zaG93KTsKICAgICAgICAgICAgIHRoaXMuY29udHJvbHMucGFuZWwuY2xhc3NMaXN0LnJlbW92 ZSh0aGlzLkNsYXNzTmFtZXMuaGlkZGVuKTsKICAgICAgICAgICAgIHRoaXMucmVzZXRIaWRlQ29u dHJvbHNUaW1lcigpOwpAQCAtNzg4LDcgKzc4OCw3IEBAIENvbnRyb2xsZXIucHJvdG90eXBlID0g ewogCiAgICAgaGFuZGxlV3JhcHBlck1vdXNlTW92ZTogZnVuY3Rpb24oZXZlbnQpCiAgICAgewot ICAgICAgICBpZiAoIXRoaXMudmlkZW8uY29udHJvbHMpCisgICAgICAgIGlmICghdGhpcy52aWRl by5jb250cm9scyAmJiAhdGhpcy5pc0Z1bGxTY3JlZW4oKSkKICAgICAgICAgICAgIHJldHVybjsK IAogICAgICAgICBpZiAodGhpcy5jb250cm9sc0FyZUhpZGRlbigpKQpAQCAtMTAyNCw3ICsxMDI0 LDcgQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAgdXBkYXRlRnVsbHNjcmVlbkJ1dHRv bnM6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHZhciBzaG91bGRCZUhpZGRlbiA9ICF0aGlz LnZpZGVvLndlYmtpdFN1cHBvcnRzRnVsbHNjcmVlbiB8fCAhdGhpcy5oYXNWaWRlbygpOwotICAg ICAgICB0aGlzLmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24uY2xhc3NMaXN0LnRvZ2dsZSh0aGlz LkNsYXNzTmFtZXMuaGlkZGVuLCBzaG91bGRCZUhpZGRlbik7CisgICAgICAgIHRoaXMuY29udHJv bHMuZnVsbHNjcmVlbkJ1dHRvbi5jbGFzc0xpc3QudG9nZ2xlKHRoaXMuQ2xhc3NOYW1lcy5oaWRk ZW4sIHNob3VsZEJlSGlkZGVuICYmICF0aGlzLmlzRnVsbFNjcmVlbigpKTsKICAgICAgICAgdGhp cy5jb250cm9scy5vcHRpbWl6ZWRGdWxsc2NyZWVuQnV0dG9uLmNsYXNzTGlzdC50b2dnbGUodGhp cy5DbGFzc05hbWVzLmhpZGRlbiwgc2hvdWxkQmVIaWRkZW4pOwogICAgICAgICB0aGlzLnNldE5l ZWRzVXBkYXRlRm9yRGlzcGxheWVkV2lkdGgoKTsKICAgICAgICAgdGhpcy51cGRhdGVMYXlvdXRG b3JEaXNwbGF5ZWRXaWR0aCgpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTg1MjQ3KQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDYt MDUgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5 b3V0IHRlc3RzIGZ1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtZHJhZy5odG1sIGFuZCBtZWRpYS92 aWRlby1mdWxsc2NyZWVlbi1vbmx5LWNvbnRyb2xzLmh0bWwKKyAgICAgICAgZmFpbCBvbiBXSzEg YW5kIFdLMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ1Njc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBUZXN0RXhwZWN0YXRpb25zOiBVbnNraXAgdGVzdHMuCisgICAgICAgICogZnVsbHNjcmVlbi92 aWRlby1jb250cm9scy1kcmFnLmh0bWw6IE1pbm9yIGNsZWFudXAsIGZvcmNlIGxheW91dCBiZWZv cmUgdGVzdGluZyBjb250cm9sIGxvY2F0aW9uLgorCiAyMDE1LTA2LTA1ICBCcmVudCBGdWxnaGFt ICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBXSzEgdmVyc2lvbnMgb2YgdGVz dHMgZnJvbSBCdWdzIDE0NTYzNyBhbmQgMTQ1NjQyCkluZGV4OiBMYXlvdXRUZXN0cy9UZXN0RXhw ZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMJKHJl dmlzaW9uIDE4NTI0NSkKKysrIExheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcg Y29weSkKQEAgLTUyNSw2ICs1MjUsMyBAQCB3ZWJraXQub3JnL2IvMTQ0NTQwIGZhc3QvZnJhbWVz L2ZsYXR0ZW5pCiB3ZWJraXQub3JnL2IvMTQ1MDA3IGpzL3JlZ3Jlc3MtMTQxMDk4Lmh0bWwgWyBT a2lwIF0KIAogd2Via2l0Lm9yZy9iLzE0NTM5MCBzdG9yYWdlL2luZGV4ZWRkYi9kZWxldGVJbmRl eC1idWcxMTA3OTIuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCi0KLXdlYmtpdC5vcmcvYi8xNDU2NzUg ZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1kcmFnLmh0bWwgWyBTa2lwIF0KLXdlYmtpdC5vcmcv Yi8xNDU2NzUgbWVkaWEvdmlkZW8tZnVsbHNjcmVlZW4tb25seS1jb250cm9scy5odG1sIFsgU2tp cCBdCkluZGV4OiBMYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLWRyYWcuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLWRy YWcuaHRtbAkocmV2aXNpb24gMTg1MjQ1KQorKysgTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRl by1jb250cm9scy1kcmFnLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTUsMTggKzUsMTcgQEAKICAg ICA8c2NyaXB0IHNyYz0iLi4vbWVkaWEvbWVkaWEtY29udHJvbHMuanMiPjwvc2NyaXB0PgogICAg IDxzY3JpcHQ+CiAgICAgICAgIHZhciB2aWRlbyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd2 aWRlbycpOwotICAgICAgICB2YXIgc2hhZG93Um9vdDsKICAgICAgICAgdmFyIHBhbmVsOwogICAg ICAgICB2YXIgc3RhcnRCb3g7CiAgICAgICAgIHZhciBlbmRCb3g7CiAKLSAgICAgICAgdmFyIGZ1 bGxzY3JlZW5DaGFuZ2VkID0gZnVuY3Rpb24oZXZlbnQpCi0gICAgICAgIHsKLSAgICAgICAgICAg IGlmIChjYWxsYmFjaykKLSAgICAgICAgICAgICAgICBjYWxsYmFjayhldmVudCkKLSAgICAgICAg fTsKICAgICAgICAgd2FpdEZvckV2ZW50KGRvY3VtZW50LCAnd2Via2l0ZnVsbHNjcmVlbmNoYW5n ZScsIGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpIHsKKwor ICAgICAgICAgICAgICAgIC8vIEZvcmNlIGEgcmVsYXlvdXQgdG8gZW5zdXJlIHRoYXQgdGhlIGNv bnRyb2xzIGluIHRoZSBzaGFkb3cgRE9NIGhhdmUgYmVlbiAKKyAgICAgICAgICAgICAgICAvLyBw b3NpdGlvbmVkIGNvcnJlY3RseS4KKyAgICAgICAgICAgICAgICBkb2N1bWVudC5ib2R5Lm9mZnNl dFRvcDsKKwogICAgICAgICAgICAgICAgIHBhbmVsID0gbWVkaWFDb250cm9sc0VsZW1lbnQoaW50 ZXJuYWxzLnNoYWRvd1Jvb3QodmlkZW8pLmZpcnN0Q2hpbGQsICctd2Via2l0LW1lZGlhLWNvbnRy b2xzLXBhbmVsJyk7CiAgICAgICAgICAgICAgICAgc3RhcnRCb3ggPSBpbnRlcm5hbHMuYm91bmRp bmdCb3gocGFuZWwpOwogCg==