145656 2015-06-04 14:09:02 -0700 Web Inspector: Close and open tabs on mouseup, not mousedown 2015-06-04 21:31:49 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1099607 0 nvasilyev 2015-06-04 14:09:02 -0700 In Safari, tabs close and open on mouse down. In Web Inspector, however, tabs close and open on mouse up. It should match Safari’s behavior. 1099609 1 webkit-bug-importer 2015-06-04 14:09:28 -0700 <rdar://problem/21248005> 1099672 2 254314 nvasilyev 2015-06-04 16:30:21 -0700 Created attachment 254314 Patch 1099753 3 254314 commit-queue 2015-06-04 21:31:45 -0700 Comment on attachment 254314 Patch Clearing flags on attachment: 254314 Committed r185236: <http://trac.webkit.org/changeset/185236> 1099754 4 commit-queue 2015-06-04 21:31:49 -0700 All reviewed patches have been landed. Closing bug. 254314 2015-06-04 16:30:21 -0700 2015-06-04 21:31:45 -0700 Patch patch.txt text/plain 5337 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYyODczZWIuLjZkNmEyYTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTA2LTA0ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsb3Nl IGFuZCBvcGVuIHRhYnMgb24gbW91c2V1cCwgbm90IG1vdXNlZG93bgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NjU2CisKKyAgICAgICAgTWF0Y2gg U2FmYXJpJ3MgYmVoYXZpb3VyLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXIuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuVGFiQmFyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJCYXIucHJvdG90 eXBlLnNldCBuZXdUYWJJdGVtKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJCYXIucHJvdG90 eXBlLl9oYW5kbGVNb3VzZURvd24pOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYkJhci5wcm90 b3R5cGUuX2hhbmRsZUNsaWNrKTogQWRkZWQuCisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiQmFy LnByb3RvdHlwZS5faGFuZGxlTW91c2VVcCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGFiQmFy LnByb3RvdHlwZS5faGFuZGxlTmV3VGFiQ2xpY2spOiBBZGRlZC4KKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5UYWJCYXIucHJvdG90eXBlLl9oYW5kbGVNb3VzZU1vdmVkKToKKworMjAxNS0wNi0wNCAg TmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5z cGVjdG9yOiBEZWNyZWFzZSB0YWJzIGhlaWdodCB0byBtYXRjaCBTYWZhcmkncyB0YWJzIGhlaWdo dAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NjQ3 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RhYkJhci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Rh YkJhci5qcwppbmRleCBjZjgzMWZlLi4wNjE3OWIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXIuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFyLmpzCkBAIC0zOCw2ICszOCw3IEBA IFdlYkluc3BlY3Rvci5UYWJCYXIgPSBjbGFzcyBUYWJCYXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3Iu T2JqZWN0CiAgICAgICAgIHRoaXMuX2VsZW1lbnQuYXBwZW5kQ2hpbGQodG9wQm9yZGVyRWxlbWVu dCk7CiAKICAgICAgICAgdGhpcy5fZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZWRvd24i LCB0aGlzLl9oYW5kbGVNb3VzZURvd24uYmluZCh0aGlzKSk7CisgICAgICAgIHRoaXMuX2VsZW1l bnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9oYW5kbGVDbGljay5iaW5kKHRoaXMp KTsKICAgICAgICAgdGhpcy5fZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZWxlYXZlIiwg dGhpcy5faGFuZGxlTW91c2VMZWF2ZS5iaW5kKHRoaXMpKTsKIAogICAgICAgICB0aGlzLl90YWJC YXJJdGVtcyA9IFtdOwpAQCAtNTcsMTcgKzU4LDIyIEBAIFdlYkluc3BlY3Rvci5UYWJCYXIgPSBj bGFzcyBUYWJCYXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAKICAgICBzZXQgbmV3VGFi SXRlbShuZXdUYWJJdGVtKQogICAgIHsKKyAgICAgICAgaWYgKCF0aGlzLl9oYW5kbGVOZXdUYWJD bGlja0xpc3RlbmVyKQorICAgICAgICAgICAgdGhpcy5faGFuZGxlTmV3VGFiQ2xpY2tMaXN0ZW5l ciA9IHRoaXMuX2hhbmRsZU5ld1RhYkNsaWNrLmJpbmQodGhpcyk7CisKICAgICAgICAgaWYgKCF0 aGlzLl9oYW5kbGVOZXdUYWJNb3VzZUVudGVyTGlzdGVuZXIpCiAgICAgICAgICAgICB0aGlzLl9o YW5kbGVOZXdUYWJNb3VzZUVudGVyTGlzdGVuZXIgPSB0aGlzLl9oYW5kbGVOZXdUYWJNb3VzZUVu dGVyLmJpbmQodGhpcyk7CiAKICAgICAgICAgaWYgKHRoaXMuX25ld1RhYkl0ZW0pIHsKICAgICAg ICAgICAgIHRoaXMuX25ld1RhYkl0ZW0uZWxlbWVudC5jbGFzc0xpc3QucmVtb3ZlKCJuZXctdGFi LWJ1dHRvbiIpOworICAgICAgICAgICAgdGhpcy5fbmV3VGFiSXRlbS5lbGVtZW50LnJlbW92ZUV2 ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5faGFuZGxlTmV3VGFiQ2xpY2tMaXN0ZW5lcik7CiAg ICAgICAgICAgICB0aGlzLl9uZXdUYWJJdGVtLmVsZW1lbnQucmVtb3ZlRXZlbnRMaXN0ZW5lcigi bW91c2VlbnRlciIsIHRoaXMuX2hhbmRsZU5ld1RhYk1vdXNlRW50ZXJMaXN0ZW5lcik7CiAgICAg ICAgICAgICB0aGlzLnJlbW92ZVRhYkJhckl0ZW0odGhpcy5fbmV3VGFiSXRlbSwgdHJ1ZSk7CiAg ICAgICAgIH0KIAogICAgICAgICBpZiAobmV3VGFiSXRlbSkgewogICAgICAgICAgICAgbmV3VGFi SXRlbS5lbGVtZW50LmNsYXNzTGlzdC5hZGQoIm5ldy10YWItYnV0dG9uIik7CisgICAgICAgICAg ICBuZXdUYWJJdGVtLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9oYW5k bGVOZXdUYWJDbGlja0xpc3RlbmVyKTsKICAgICAgICAgICAgIG5ld1RhYkl0ZW0uZWxlbWVudC5h ZGRFdmVudExpc3RlbmVyKCJtb3VzZWVudGVyIiwgdGhpcy5faGFuZGxlTmV3VGFiTW91c2VFbnRl ckxpc3RlbmVyKTsKICAgICAgICAgICAgIHRoaXMuYWRkVGFiQmFySXRlbShuZXdUYWJJdGVtLCB0 cnVlKTsKICAgICAgICAgfQpAQCAtNTUyLDE2ICs1NTgsMTIgQEAgV2ViSW5zcGVjdG9yLlRhYkJh ciA9IGNsYXNzIFRhYkJhciBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgaWYg KHRhYkJhckl0ZW0uZGlzYWJsZWQpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYg KHRhYkJhckl0ZW0gPT09IHRoaXMuX25ld1RhYkl0ZW0pIHsKLSAgICAgICAgICAgIHRoaXMuZGlz cGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5UYWJCYXIuRXZlbnQuTmV3VGFiSXRl bUNsaWNrZWQpOworICAgICAgICBpZiAodGFiQmFySXRlbSA9PT0gdGhpcy5fbmV3VGFiSXRlbSkK ICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQogCiAgICAgICAgIHZhciBjbG9zZUJ1dHRv bkVsZW1lbnQgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhDbGFzcyhXZWJJ bnNwZWN0b3IuVGFiQmFySXRlbS5DbG9zZUJ1dHRvblN0eWxlQ2xhc3NOYW1lKTsKLSAgICAgICAg aWYgKGNsb3NlQnV0dG9uRWxlbWVudCkgewotICAgICAgICAgICAgdGhpcy5yZW1vdmVUYWJCYXJJ dGVtKHRhYkJhckl0ZW0sIGZhbHNlLCB0cnVlKTsKKyAgICAgICAgaWYgKGNsb3NlQnV0dG9uRWxl bWVudCkKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQogCiAgICAgICAgIHRoaXMuc2Vs ZWN0ZWRUYWJCYXJJdGVtID0gdGFiQmFySXRlbTsKIApAQCAtNTg5LDYgKzU5MSwyNCBAQCBXZWJJ bnNwZWN0b3IuVGFiQmFyID0gY2xhc3MgVGFiQmFyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVj dAogICAgICAgICBldmVudC5zdG9wUHJvcGFnYXRpb24oKTsKICAgICB9CiAKKyAgICBfaGFuZGxl Q2xpY2soZXZlbnQpCisgICAgeworICAgICAgICB2YXIgaXRlbUVsZW1lbnQgPSBldmVudC50YXJn ZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhDbGFzcyhXZWJJbnNwZWN0b3IuVGFiQmFySXRlbS5T dHlsZUNsYXNzTmFtZSk7CisgICAgICAgIGlmICghaXRlbUVsZW1lbnQpCisgICAgICAgICAgICBy ZXR1cm47CisKKyAgICAgICAgdmFyIHRhYkJhckl0ZW0gPSBpdGVtRWxlbWVudFtXZWJJbnNwZWN0 b3IuVGFiQmFySXRlbS5FbGVtZW50UmVmZXJlbmNlU3ltYm9sXTsKKyAgICAgICAgaWYgKCF0YWJC YXJJdGVtKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGlmICh0YWJCYXJJdGVtLmRp c2FibGVkKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHZhciBjbG9zZUJ1dHRvbkVs ZW1lbnQgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhDbGFzcyhXZWJJbnNw ZWN0b3IuVGFiQmFySXRlbS5DbG9zZUJ1dHRvblN0eWxlQ2xhc3NOYW1lKTsKKyAgICAgICAgaWYg KGNsb3NlQnV0dG9uRWxlbWVudCkKKyAgICAgICAgICAgIHRoaXMucmVtb3ZlVGFiQmFySXRlbSh0 YWJCYXJJdGVtLCBmYWxzZSwgdHJ1ZSk7CisgICAgfQorCiAgICAgX2hhbmRsZU1vdXNlTW92ZWQo ZXZlbnQpCiAgICAgewogICAgICAgICBjb25zb2xlLmFzc2VydChldmVudC5idXR0b24gPT09IDAp OwpAQCAtNjY5LDcgKzY4OSw3IEBAIFdlYkluc3BlY3Rvci5UYWJCYXIgPSBjbGFzcyBUYWJCYXIg ZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NM aXN0LnJlbW92ZSgiZHJhZ2dpbmctdGFiIik7CiAKICAgICAgICAgaWYgKCF0aGlzLl90YWJBbmlt YXRlZENsb3NlZFNpbmNlTW91c2VFbnRlcikgewotICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5j bGFzc0xpc3QucmVtb3ZlKCJzdGF0aWMtbGF5b3V0IikKKyAgICAgICAgICAgIHRoaXMuX2VsZW1l bnQuY2xhc3NMaXN0LnJlbW92ZSgic3RhdGljLWxheW91dCIpOwogICAgICAgICAgICAgdGhpcy5f Y2xlYXJUYWJCYXJJdGVtU2l6ZXNBbmRQb3NpdGlvbnMoKTsKICAgICAgICAgfSBlbHNlIHsKICAg ICAgICAgICAgIHZhciBsZWZ0ID0gMDsKQEAgLTcxMSw2ICs3MzEsMTAgQEAgV2ViSW5zcGVjdG9y LlRhYkJhciA9IGNsYXNzIFRhYkJhciBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAg ICAgdGhpcy5fZmluaXNoRXhwYW5kaW5nVGFic0FmdGVyQ2xvc2UoKTsKICAgICB9CiAKKyAgICBf aGFuZGxlTmV3VGFiQ2xpY2soZXZlbnQpIHsKKyAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9M aXN0ZW5lcnMoV2ViSW5zcGVjdG9yLlRhYkJhci5FdmVudC5OZXdUYWJJdGVtQ2xpY2tlZCk7Cisg ICAgfQorCiAgICAgX2hhbmRsZU5ld1RhYk1vdXNlRW50ZXIoZXZlbnQpCiAgICAgewogICAgICAg ICBpZiAoIXRoaXMuX3RhYkFuaW1hdGVkQ2xvc2VkU2luY2VNb3VzZUVudGVyIHx8ICF0aGlzLl9l bGVtZW50LmNsYXNzTGlzdC5jb250YWlucygic3RhdGljLWxheW91dCIpIHx8IHRoaXMuX2VsZW1l bnQuY2xhc3NMaXN0LmNvbnRhaW5zKCJhbmltYXRpbmciKSkK