145636 2015-06-03 23:18:09 -0700 Fix options in build-jsc for CMake builds 2015-06-03 23:59:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145516 1 ysuzuki ysuzuki benjamin commit-queue darin gyuyoung.kim oldest_to_newest 1099415 0 ysuzuki 2015-06-03 23:18:09 -0700 Fix options in build-jsc for CMake builds 1099418 1 254250 ysuzuki 2015-06-03 23:20:54 -0700 Created attachment 254250 Patch 1099434 2 254250 gyuyoung.kim 2015-06-03 23:41:20 -0700 Comment on attachment 254250 Patch I can't find why did r185110 also modify cmake port on bug 145516. https://bugs.webkit.org/show_bug.cgi?id=145516 AFAIK, cmake port needs to use ON/OFF. If we set nothing, it is set to false. http://www.cmake.org/cmake/help/v3.0/command/option.html 1099439 3 254250 commit-queue 2015-06-03 23:49:53 -0700 Comment on attachment 254250 Patch Clearing flags on attachment: 254250 Committed r185194: <http://trac.webkit.org/changeset/185194> 1099440 4 commit-queue 2015-06-03 23:49:58 -0700 All reviewed patches have been landed. Closing bug. 1099443 5 gyuyoung.kim 2015-06-03 23:59:05 -0700 One more thing, if we don't set value for passing arguments, cmake generates build error as below, ~/WebKit$ Tools/Scripts/build-webkit --efl --cmakeargs="-DENABLE_INDEXED_DATABASE_IN_WORKERS" Not searching for unused variables given on the command line. Parse error in command line argument: -DENABLE_INDEXED_DATABASE_IN_WORKERS Should be: VAR:type=value CMake Error: No cmake script provided. CMake Error: Problem processing arguments. Aborting. 254250 2015-06-03 23:20:54 -0700 2015-06-03 23:49:53 -0700 Patch bug-145636-20150604152032.patch text/plain 1422 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MTkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTZiZmY0NTI2ZDI3ODBiNTM2YTY4Zjc1ZjYzYWY3M2E4 NTEyZWQ0MS4uNjhmMjU1ZmZkZWNiNWE3M2Y2YTU1N2Y2YzllMDRkYWQyMmU4MmU2ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTA2LTAzICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgor CisgICAgICAgIEZpeCBvcHRpb25zIGluIGJ1aWxkLWpzYyBmb3IgQ01ha2UgYnVpbGRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDU2MzYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDTWFrZSBvbmx5IGFj Y2VwdHMgLURYWFg9WVlZIHN0eWxlIG9wdGlvbnMuCisgICAgICAgIEFuZCBlbnN1cmVkIHRoYXQg RU5BQkxFX0pJVD1PRkYgd2hlbiBzcGVjaWZ5aW5nIGAtLWNsb29wYC4KKworICAgICAgICAqIFNj cmlwdHMvYnVpbGQtanNjOgorCiAyMDE1LTA2LTAzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciBEcm9tYWVvLgpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MgYi9Ub29scy9TY3JpcHRzL2J1aWxkLWpz YwppbmRleCBiMGE1ZDIyNDkyMmZiOTA5Mjc4M2Q2ODhkN2Y5NzA4Nzk0YmUyNTM3Li44NWZhNTYw NmNjMGMxMDg4NzY1MDE4Mjc0ZmE4NjUxMGIyY2I0ZjU5IDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL2J1aWxkLWpzYworKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYwpAQCAtOTUsOCArOTUs OCBAQCBpZiAoJGZvcmNlQ0xvb3ApIHsKIH0KIAogaWYgKGNtYWtlQmFzZWRQb3J0TmFtZSgpKSB7 Ci0gICAgJGNtYWtlQXJncyAuPSAkZm9yY2VDTG9vcCA/ICIgLURFTkFCTEVfSklUPTAiIDogIiAt REVOQUJMRV9KSVQiOwotICAgICRjbWFrZUFyZ3MgLj0gJGZ0bEpJVCA/ICIgLURFTkFCTEVfRlRM X0pJVCIgOiAiIC1ERU5BQkxFX0ZUTF9KSVQ9MCI7CisgICAgJGNtYWtlQXJncyAuPSAkZm9yY2VD TG9vcCA/ICIgLURFTkFCTEVfSklUPU9GRiIgOiAiIC1ERU5BQkxFX0pJVD1PTiI7CisgICAgJGNt YWtlQXJncyAuPSAkZnRsSklUID8gIiAtREVOQUJMRV9GVExfSklUPU9OIiA6ICIgLURFTkFCTEVf RlRMX0pJVD1PRkYiOwogICAgICMgQnkgZGVmYXVsdCB3ZSBidWlsZCB1c2luZyBhbGwgb2YgdGhl IGF2YWlsYWJsZSBDUFVzCiAgICAgJG1ha2VBcmdzIC49ICgkbWFrZUFyZ3MgPyAiICIgOiAiIikg LiAiLWoiIC4gbnVtYmVyT2ZDUFVzKCkgaWYgJG1ha2VBcmdzICF+IC8talxzKlxkKy87CiAK