145635 2015-06-03 23:05:48 -0700 [EFL] API test has been broken since r184357 2015-06-05 18:20:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145018 1 gyuyoung.kim gyuyoung.kim commit-queue lucas.de.marchi mcatanzaro mrobinson ossy oldest_to_newest 1099411 0 gyuyoung.kim 2015-06-03 23:05:48 -0700 EFL API tests is broken now though, unfortunately it is hard to track what revision broke it because EFL buildbot was broken too. So now I can guess the EFL API test was broken between r184346 ~ r184367. We need to fix it ASAP. 1099445 1 gyuyoung.kim 2015-06-04 00:12:57 -0700 Need to check below range. - Begin : https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21905 - End : https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21921 1099458 2 gyuyoung.kim 2015-06-04 01:23:05 -0700 Oops... EFL API tests work on xvfb.... 1099764 3 gyuyoung.kim 2015-06-04 22:47:37 -0700 I find what revision break EFL API test. r184357 did it because suppress build warning related with cmake. https://bugs.webkit.org/show_bug.cgi?id=145018#c0 However it looks TARGET_FILE property isn't supported by cmake 2.8.12 correctly yet. 1099766 4 254342 gyuyoung.kim 2015-06-04 22:50:29 -0700 Created attachment 254342 Patch 1099767 5 gyuyoung.kim 2015-06-04 22:52:07 -0700 CC'ing Michael and Martin, I would like to revert r184357 at the moment. However if you guys know better fix, please let me know. 1099801 6 mrobinson 2015-06-05 07:06:47 -0700 Yes, I think it is fine to revert for the moment. It's better to have test coverage. 1099806 7 mcatanzaro 2015-06-05 07:53:52 -0700 Yes, go ahead and revert, although I wish we knew what was wrong. I did check to make sure we could use TARGET_FILE with cmake 2.8.12. 1100039 8 254342 commit-queue 2015-06-05 18:20:04 -0700 Comment on attachment 254342 Patch Clearing flags on attachment: 254342 Committed r185281: <http://trac.webkit.org/changeset/185281> 1100040 9 commit-queue 2015-06-05 18:20:09 -0700 All reviewed patches have been landed. Closing bug. 254342 2015-06-04 22:50:29 -0700 2015-06-05 18:20:04 -0700 Patch bug-145635-20150605145008.patch text/plain 1723 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MTkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTZiZmY0NTI2ZDI3ODBiNTM2YTY4Zjc1ZjYzYWY3M2E4 NTEyZWQ0MS4uM2VjYjFhZDEzN2M3M2ZlYmE3MDg1ZjNkNTQ1MjcyOWU5NGNkMTJlZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTA2LTA0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBbRUZMXSBBUEkgdGVzdCBoYXMgYmVlbiBicm9rZW4gc2luY2UgcjE4NDM1Nwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NjM1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjE4NDM1NyBz dXBwcmVzcyBjbWFrZSBidWlsZCB3YXJuaW5nIHVzaW5nIFRBUkdFVF9GSUxFIHByb3BlcnR5LiBI b3dldmVyCisgICAgICAgIG1hbnkgRUZMIEFQSSB0ZXN0IGNhc2VzIGhhdmUgYmVlbiBicm9rZW4g YWZ0ZXIgYXBwbHlpbmcgaXQuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL0NNYWtlTGlzdHMu dHh0OgorCiAyMDE1LTA2LTAzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciBEcm9tYWVvLgpkaWZmIC0tZ2l0IGEvVG9v bHMvVGVzdFdlYktpdEFQSS9DTWFrZUxpc3RzLnR4dCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ01h a2VMaXN0cy50eHQKaW5kZXggMDcwNDI0ZjA1ZmJlODEwYTEyM2ZmM2JlOTMyZjFlNDYyN2M1NTZi OS4uYzVkZmEyZmRlYTNhYjM3MjdlYmYyMjI4NjM4ZDQ1MjM0NWVlMmU5ZiAxMDA2NDQKLS0tIGEv VG9vbHMvVGVzdFdlYktpdEFQSS9DTWFrZUxpc3RzLnR4dAorKysgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL0NNYWtlTGlzdHMudHh0CkBAIC0xMzAsOSArMTMwLDExIEBAIGFkZF9saWJyYXJ5KFRlc3RX ZWJLaXRBUElJbmplY3RlZEJ1bmRsZSBTSEFSRUQKIHRhcmdldF9saW5rX2xpYnJhcmllcyhUZXN0 V2ViS2l0QVBJSW5qZWN0ZWRCdW5kbGUgJHtUZXN0V2ViS2l0QVBJX0xJQlJBUklFU30pCiBhZGRf ZGVwZW5kZW5jaWVzKFRlc3RXZWJLaXRBUElJbmplY3RlZEJ1bmRsZSAke0ZvcndhcmRpbmdIZWFk ZXJzRm9yVGVzdFdlYktpdEFQSV9OQU1FfSkKIAorZ2V0X3Byb3BlcnR5KFRlc3RXZWJLaXRBUElJ bmplY3RlZEJ1bmRsZV9QQVRIIFRBUkdFVCBUZXN0V2ViS2l0QVBJSW5qZWN0ZWRCdW5kbGUgUFJP UEVSVFkgTE9DQVRJT04pCisKIGFkZF9kZWZpbml0aW9ucygtREdURVNUX0xJTktFRF9BU19TSEFS RURfTElCUkFSWT0xIC1ER1RFU1RfSEFTX1JUVEk9MAogICAgIC1EVEVTVF9XRUJLSVQyX1JFU09V UkNFU19ESVI9XCIke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyXCIKLSAgICAtRFRF U1RfSU5KRUNURURfQlVORExFX1BBVEg9XCIkPFRBUkdFVF9GSUxFX0RJUjpUZXN0V2ViS2l0QVBJ SW5qZWN0ZWRCdW5kbGU+XCIKKyAgICAtRFRFU1RfSU5KRUNURURfQlVORExFX1BBVEg9XCIke1Rl c3RXZWJLaXRBUElJbmplY3RlZEJ1bmRsZV9QQVRIfVwiCiApCiAKICMgRklYTUU6IFRoaXMgd29y a3MgYXJvdW5kIGNvbXBhdGliaWxpdHkgcHJvYmxlbXMgaW4gdGhlIG9sZCB2ZXJzaW9uIG9mIHRo ZSB0aGlyZC1wYXJ5Cg==