145624 2015-06-03 17:57:35 -0700 sourceCodeLocation assert in WebInspector.CallFrame.constructor is wrong 2015-06-26 19:10:30 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED WORKSFORME InRadar P2 Normal --- 1 mark.lam webkit-unassigned graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1099342 0 mark.lam 2015-06-03 17:57:35 -0700 Currently, the assertion in WebInspector.CallFrame.constructor expects the sourceCodeLocation to be falsy or be an instance of WebInspector.SourceCodeLocation. Turns out it can also be an instance of WebInspector.LazySourceCodeLocation. The assertion is in error. 1099344 1 webkit-bug-importer 2015-06-03 17:58:07 -0700 <rdar://problem/21234075> 1099506 2 nvasilyev 2015-06-04 10:28:11 -0700 class LazySourceCodeLocation extends WebInspector.SourceCodeLocation So, it should be fine. When does the assertion fail? 1099509 3 mark.lam 2015-06-04 10:30:42 -0700 (In reply to comment #2) > class LazySourceCodeLocation extends WebInspector.SourceCodeLocation > > So, it should be fine. > > When does the assertion fail? I reproduced it by running LayoutTests/inspector/debugger/break-on-exceptions.html which is being introduced in bug 145525. 1105127 4 nvasilyev 2015-06-26 19:10:30 -0700 I tried running tests on r185858 and they all passed. Please let me know if I'm doing something wrong, I don't know much about the tests. ⮀ Tools/Scripts/run-webkit-tests LayoutTests/inspector/debugger/ Using port 'mac-elcapitan-wk2' Test configuration: <elcapitan, x86_64, release> Placing test results in /Users/nv/Code/Apple/OpenSource/WebKitBuild/Release/layout-test-results Baseline search path: mac-wk2 -> wk2 -> mac -> generic Using Release build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /Users/nv/Code/Apple/OpenSource/WebKitBuild/Release/WebKitTestRunner - Found 28 tests; running 28, skipping 0. Running 1 WebKitTestRunner. All 28 tests ran as expected.